Re: [OE-core][PATCH] runqemu: decouple bios and kernel options

2021-08-04 Thread Michael Opdenacker

On 8/4/21 10:53 AM, Matthias Klein wrote:
> This will allow the use of a bios (e.g. U-Boot) in combination with
> a WIC file (from which U-Boot loads the kernel).
>
> Signed-off-by: Matthias Klein 
> ---
>  scripts/runqemu | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 9c92eec030..0976273eb0 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -1443,12 +1443,14 @@ class BaseConfig(object):
>  kernel_opts = "-kernel %s -append '%s %s %s %s'" % (self.kernel, 
> self.kernel_cmdline,
>  
> self.kernel_cmdline_script, self.get('QB_KERNEL_CMDLINE_APPEND'),
>  
> self.bootparams)
> -if self.bios:
> -kernel_opts += " -bios %s" % self.bios
>  if self.dtb:
>  kernel_opts += " -dtb %s" % self.dtb
>  else:
>  kernel_opts = ""
> +
> +if self.bios:
> +self.qemu_opt += " -bios %s" % self.bios
> +
>  cmd = "%s %s" % (self.qemu_opt, kernel_opts)
>  cmds = shlex.split(cmd)
>  logger.info('Running %s\n' % cmd)


Reviewed-by: Michael Opdenacker 
Thanks!

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154421): 
https://lists.openembedded.org/g/openembedded-core/message/154421
Mute This Topic: https://lists.openembedded.org/mt/84657880/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] runqemu: decouple bios and kernel options

2021-08-04 Thread Matthias Klein
This will allow the use of a bios (e.g. U-Boot) in combination with
a WIC file (from which U-Boot loads the kernel).

Signed-off-by: Matthias Klein 
---
 scripts/runqemu | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index 9c92eec030..0976273eb0 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -1443,12 +1443,14 @@ class BaseConfig(object):
 kernel_opts = "-kernel %s -append '%s %s %s %s'" % (self.kernel, 
self.kernel_cmdline,
 
self.kernel_cmdline_script, self.get('QB_KERNEL_CMDLINE_APPEND'),
 
self.bootparams)
-if self.bios:
-kernel_opts += " -bios %s" % self.bios
 if self.dtb:
 kernel_opts += " -dtb %s" % self.dtb
 else:
 kernel_opts = ""
+
+if self.bios:
+self.qemu_opt += " -bios %s" % self.bios
+
 cmd = "%s %s" % (self.qemu_opt, kernel_opts)
 cmds = shlex.split(cmd)
 logger.info('Running %s\n' % cmd)
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154416): 
https://lists.openembedded.org/g/openembedded-core/message/154416
Mute This Topic: https://lists.openembedded.org/mt/84657880/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-