Re: [OE-core] [OE-Core][PATCH] systemd: Upgrade 243.2 -> 243.4-latest
On Mon, Feb 3, 2020 at 8:51 PM Alexander Kanavin wrote:
>
> Since move to 243 latest needs further work, how about moving straight to 244?
>
> Alex
>
Having realised it was local to OE-Core, it was easy to find the problem.
The upstream change that I guessed at before is what's caused the
behaviour change:
commit 53d8feeb2334c396dcfa7106c78ce1791fb5d0c4
Author: Michal Suchanek
Date: Mon Nov 4 21:23:15 2019 +0100
libblkid: open device in nonblock mode.
When autoclose is set (kernel default but many distributions reverse the
setting) opening a CD-rom device causes the tray to close.
The function of blkid is to report the current state of the device and
not to change it. Hence it should use O_NONBLOCK when opening the
device to avoid closing a CD-rom tray.
blkid is used liberally in scripts so it can potentially interfere with
the user operating the CD-rom hardware.
Which causes a blizzard of "ide-cd: hdc: tray open" when you have our
local changes:
commit 90dcf2574daca8e7bf35074c46a2729a82acfe8b (HEAD -> devtool, tag:
devtool-patched, devtool-no-overrides)
Author: Chen Qi
Date: Thu Feb 21 16:38:38 2019 +0800
rules: watch metadata changes in ide devices
Formatting IDE storage does not trigger "change" uevents. As a result
clients using udev API don't get any updates afterwards and get outdated
information about the device.
...
root@qemux86-64:~# mkfs.ext4 -F /dev/hda1
Creating filesystem with 262144 4k blocks and 65536 inodes
Filesystem UUID: 98791eb2-2bf3-47ad-b4d8-4cf7e914eee2
root@qemux86-64:~# ls /dev/disk/by-uuid/98791eb2-2bf3-47ad-b4d8-4cf7e914eee2
ls: cannot access
'/dev/disk/by-uuid/98791eb2-2bf3-47ad-b4d8-4cf7e914eee2': No such file
or directory
...
Include hd* in a match for watch option assignment.
Upstream-Status: Denied
qemu by default emulates IDE and the linux-yocto kernel(s) use
CONFIG_IDE instead of the more modern libsata, so disks appear as
/dev/hd*. A similar patch rejected by upstream because CONFIG_IDE
is deprecated.
Signed-off-by: Hongxu Jia
[rebased for systemd 241]
Signed-off-by: Chen Qi
[rebased for systemd 243]
Signed-off-by: Scott Murray
%% original patch: 0005-rules-watch-metadata-changes-in-ide-devices.patch
commit 2c49075af99308c25fbfd17ce4f28243cba3e4ec
Author: Chen Qi
Date: Thu Feb 21 16:28:21 2019 +0800
rules: whitelist hd* devices
qemu by default emulates IDE and the linux-yocto kernel(s) use
CONFIG_IDE instead of the more modern libsata, so disks appear as
/dev/hd*. Patch rejected upstream because CONFIG_IDE is deprecated.
Upstream-Status: Denied [https://github.com/systemd/systemd/pull/1276]
Signed-off-by: Patrick Ohly
Signed-off-by: Khem Raj
[rebased for systemd 241]
Signed-off-by: Chen Qi
[rebased for systemd 243]
Signed-off-by: Scott Murray
%% original patch: 0004-rules-whitelist-hd-devices.patch
Short of dropping the the local changes, which (from reading the
commit messages) seem to be mostly there to fix up issues with qemu,
I'm not sure what else to do. I can't see upstream wanting to change
the commit they merged as they already rejected these ones.
Reading backwards we seem to have been carrying these two local changes since:
commit 5702a19f1c91f9d091a15ad30e73f946c5f9fd31
Author: Patrick Ohly
Date: Mon Sep 21 16:30:10 2015 +0200
systemd: apply persistent storage udev rules also for /dev/hd*
This fixes booting with initramfs and root=UUID on machines with IDE
disks, like "runqemu hdddirect", and kernels which still use the
deprecated CONFIG_IDE.
v2: Rebased against current master-next.
(From OE-Core rev: 3d27dfb7e78b8e17b76fcc1d8f8e2b29ca26b0df)
> > On 3 Feb 2020, at 21.26, Alex Kiernan wrote:
> >
> >> On Mon, Feb 3, 2020 at 7:55 PM Alex Kiernan wrote:
> >>
> >> Hi Richard
> >>
> >>> On Mon, Feb 3, 2020 at 2:13 PM Alex Kiernan
> >>> wrote:
> >>>
> >>> On Mon, Feb 3, 2020 at 10:26 AM Richard Purdie
> >>> wrote:
>
> > On Mon, 2020-01-27 at 23:13 +, Alex Kiernan wrote:
> > Update to latest on the 243 stable branch. This includes (amongst other
> > fixes) seccomp filter changes which fix failures with glibc 2.31, e.g.
> >
> > systemd-journald[543]: Assertion
> > 'clock_gettime(map_clock_id(clock_id), ) == 0' failed at
> > src/basic/time-util.c:55, function now(). Aborting.
> >
> > Rebase 0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch
> >
> > Drop 0001-unit-file.c-consider-symlink-on-filesystems-like-NFS.patch,
> > fixed in 5c0224c7bf3c ("Handle d_type == DT_UNKNOWN correctly").
> >
> > Drop 0001-seccomp-more-comprehensive-protection-against-libsec.patch,
> > fixed in 70e8c1978a9a ("seccomp: real syscall numbers are >= 0").
>
> Unfortunately something in this causes:
>
>
Re: [OE-core] [OE-Core][PATCH] systemd: Upgrade 243.2 -> 243.4-latest
Since move to 243 latest needs further work, how about moving straight to 244?
Alex
> On 3 Feb 2020, at 21.26, Alex Kiernan wrote:
>
>> On Mon, Feb 3, 2020 at 7:55 PM Alex Kiernan wrote:
>>
>> Hi Richard
>>
>>> On Mon, Feb 3, 2020 at 2:13 PM Alex Kiernan wrote:
>>>
>>> On Mon, Feb 3, 2020 at 10:26 AM Richard Purdie
>>> wrote:
> On Mon, 2020-01-27 at 23:13 +, Alex Kiernan wrote:
> Update to latest on the 243 stable branch. This includes (amongst other
> fixes) seccomp filter changes which fix failures with glibc 2.31, e.g.
>
> systemd-journald[543]: Assertion 'clock_gettime(map_clock_id(clock_id),
> ) == 0' failed at src/basic/time-util.c:55, function now(). Aborting.
>
> Rebase 0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch
>
> Drop 0001-unit-file.c-consider-symlink-on-filesystems-like-NFS.patch,
> fixed in 5c0224c7bf3c ("Handle d_type == DT_UNKNOWN correctly").
>
> Drop 0001-seccomp-more-comprehensive-protection-against-libsec.patch,
> fixed in 70e8c1978a9a ("seccomp: real syscall numbers are >= 0").
Unfortunately something in this causes:
https://autobuilder.yoctoproject.org/typhoon/#/builders/109/builds/412
https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/413
https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/1545
>>>
>>> That's disappointing...
>>>
>>
>> I'm failing to reproduce this - am I right in thinking the error I
>> should be looking for is this one:
>>
>> [ 3.997360] ide-cd: hdc: tray open
>> [ 3.999321] print_req_error: I/O error, dev hdc, sector 8388592 flags 80700
>>
>> or some variation on it?
>>
>> I've got testimage running across a number of the images I think are
>> the ones that are being run and I can't get any of them to fail.
>>
>
> Scratch that... it looks like one of the local changes is necessary to
> cause this - I'd foolishly reused an external source tree rather than
> just letting devtool deal with it.
>
> --
> Alex Kiernan
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [OE-Core][PATCH] systemd: Upgrade 243.2 -> 243.4-latest
On Mon, Feb 3, 2020 at 7:55 PM Alex Kiernan wrote:
>
> Hi Richard
>
> On Mon, Feb 3, 2020 at 2:13 PM Alex Kiernan wrote:
> >
> > On Mon, Feb 3, 2020 at 10:26 AM Richard Purdie
> > wrote:
> > >
> > > On Mon, 2020-01-27 at 23:13 +, Alex Kiernan wrote:
> > > > Update to latest on the 243 stable branch. This includes (amongst other
> > > > fixes) seccomp filter changes which fix failures with glibc 2.31, e.g.
> > > >
> > > > systemd-journald[543]: Assertion
> > > > 'clock_gettime(map_clock_id(clock_id), ) == 0' failed at
> > > > src/basic/time-util.c:55, function now(). Aborting.
> > > >
> > > > Rebase 0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch
> > > >
> > > > Drop 0001-unit-file.c-consider-symlink-on-filesystems-like-NFS.patch,
> > > > fixed in 5c0224c7bf3c ("Handle d_type == DT_UNKNOWN correctly").
> > > >
> > > > Drop 0001-seccomp-more-comprehensive-protection-against-libsec.patch,
> > > > fixed in 70e8c1978a9a ("seccomp: real syscall numbers are >= 0").
> > >
> > > Unfortunately something in this causes:
> > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/109/builds/412
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/413
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/1545
> > >
> >
> > That's disappointing...
> >
>
> I'm failing to reproduce this - am I right in thinking the error I
> should be looking for is this one:
>
> [ 3.997360] ide-cd: hdc: tray open
> [ 3.999321] print_req_error: I/O error, dev hdc, sector 8388592 flags 80700
>
> or some variation on it?
>
> I've got testimage running across a number of the images I think are
> the ones that are being run and I can't get any of them to fail.
>
Scratch that... it looks like one of the local changes is necessary to
cause this - I'd foolishly reused an external source tree rather than
just letting devtool deal with it.
--
Alex Kiernan
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [OE-Core][PATCH] systemd: Upgrade 243.2 -> 243.4-latest
Hi Richard
On Mon, Feb 3, 2020 at 2:13 PM Alex Kiernan wrote:
>
> On Mon, Feb 3, 2020 at 10:26 AM Richard Purdie
> wrote:
> >
> > On Mon, 2020-01-27 at 23:13 +, Alex Kiernan wrote:
> > > Update to latest on the 243 stable branch. This includes (amongst other
> > > fixes) seccomp filter changes which fix failures with glibc 2.31, e.g.
> > >
> > > systemd-journald[543]: Assertion 'clock_gettime(map_clock_id(clock_id),
> > > ) == 0' failed at src/basic/time-util.c:55, function now(). Aborting.
> > >
> > > Rebase 0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch
> > >
> > > Drop 0001-unit-file.c-consider-symlink-on-filesystems-like-NFS.patch,
> > > fixed in 5c0224c7bf3c ("Handle d_type == DT_UNKNOWN correctly").
> > >
> > > Drop 0001-seccomp-more-comprehensive-protection-against-libsec.patch,
> > > fixed in 70e8c1978a9a ("seccomp: real syscall numbers are >= 0").
> >
> > Unfortunately something in this causes:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/109/builds/412
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/413
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/1545
> >
>
> That's disappointing...
>
I'm failing to reproduce this - am I right in thinking the error I
should be looking for is this one:
[ 3.997360] ide-cd: hdc: tray open
[ 3.999321] print_req_error: I/O error, dev hdc, sector 8388592 flags 80700
or some variation on it?
I've got testimage running across a number of the images I think are
the ones that are being run and I can't get any of them to fail.
I did notice that a couple of the failures were on CentOS, I'm running
on an Ubuntu box - I'm assuming that shouldn't make any difference?
--
Alex Kiernan
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [OE-Core][PATCH] systemd: Upgrade 243.2 -> 243.4-latest
On Mon, Feb 3, 2020 at 10:26 AM Richard Purdie
wrote:
>
> On Mon, 2020-01-27 at 23:13 +, Alex Kiernan wrote:
> > Update to latest on the 243 stable branch. This includes (amongst other
> > fixes) seccomp filter changes which fix failures with glibc 2.31, e.g.
> >
> > systemd-journald[543]: Assertion 'clock_gettime(map_clock_id(clock_id),
> > ) == 0' failed at src/basic/time-util.c:55, function now(). Aborting.
> >
> > Rebase 0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch
> >
> > Drop 0001-unit-file.c-consider-symlink-on-filesystems-like-NFS.patch,
> > fixed in 5c0224c7bf3c ("Handle d_type == DT_UNKNOWN correctly").
> >
> > Drop 0001-seccomp-more-comprehensive-protection-against-libsec.patch,
> > fixed in 70e8c1978a9a ("seccomp: real syscall numbers are >= 0").
>
> Unfortunately something in this causes:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/109/builds/412
> https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/413
> https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/1545
>
That's disappointing...
> I've been blaming Trevor's patches until now but its this one (sorry
> Trevor!).
>
I'll start bisecting it out, though this looks like a likely candidate:
commit 53d8feeb2334c396dcfa7106c78ce1791fb5d0c4
Author: Michal Suchanek
Date: Mon Nov 4 21:23:15 2019 +0100
libblkid: open device in nonblock mode.
When autoclose is set (kernel default but many distributions reverse the
setting) opening a CD-rom device causes the tray to close.
The function of blkid is to report the current state of the device and
not to change it. Hence it should use O_NONBLOCK when opening the
device to avoid closing a CD-rom tray.
blkid is used liberally in scripts so it can potentially interfere with
the user operating the CD-rom hardware.
--
Alex Kiernan
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [OE-Core][PATCH] systemd: Upgrade 243.2 -> 243.4-latest
On Mon, 2020-01-27 at 23:13 +, Alex Kiernan wrote:
> Update to latest on the 243 stable branch. This includes (amongst other
> fixes) seccomp filter changes which fix failures with glibc 2.31, e.g.
>
> systemd-journald[543]: Assertion 'clock_gettime(map_clock_id(clock_id),
> ) == 0' failed at src/basic/time-util.c:55, function now(). Aborting.
>
> Rebase 0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch
>
> Drop 0001-unit-file.c-consider-symlink-on-filesystems-like-NFS.patch,
> fixed in 5c0224c7bf3c ("Handle d_type == DT_UNKNOWN correctly").
>
> Drop 0001-seccomp-more-comprehensive-protection-against-libsec.patch,
> fixed in 70e8c1978a9a ("seccomp: real syscall numbers are >= 0").
Unfortunately something in this causes:
https://autobuilder.yoctoproject.org/typhoon/#/builders/109/builds/412
https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/413
https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/1545
I've been blaming Trevor's patches until now but its this one (sorry
Trevor!).
Cheers,
Richard
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [OE-Core][PATCH] systemd: Upgrade 243.2 -> 243.4-latest
Update to latest on the 243 stable branch. This includes (amongst other
fixes) seccomp filter changes which fix failures with glibc 2.31, e.g.
systemd-journald[543]: Assertion 'clock_gettime(map_clock_id(clock_id), )
== 0' failed at src/basic/time-util.c:55, function now(). Aborting.
Rebase 0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch
Drop 0001-unit-file.c-consider-symlink-on-filesystems-like-NFS.patch,
fixed in 5c0224c7bf3c ("Handle d_type == DT_UNKNOWN correctly").
Drop 0001-seccomp-more-comprehensive-protection-against-libsec.patch,
fixed in 70e8c1978a9a ("seccomp: real syscall numbers are >= 0").
Commits from v243-stable:
70e8c1978a9a seccomp: real syscall numbers are >= 0
a0a1977d9a5d seccomp: more comprehensive protection against libseccomp's
__NR_xyz namespace invasion
7f936c60d597 network: set ipv6 mtu after link-up or device mtu change
b59d88cc62a4 man: fix typo in net-naming-scheme man page
c5e5ac095821 man: fix typos (#14304)
9a2f26564d5a ipv4ll: do not reset conflict counter on restart
bc9e1ebfdd3b Fix typo (duplicate "or")
c6cb71b7e741 network: if /sys is rw, then udev should be around
67dcdfd95629 nspawn: do not fail if udev is not running
a7938a1bc6d3 Create parent directories when creating systemd-private subdirs
53aa44f8738a network: do not return error but return UINT64_MAX if speed
meter is disabled
65abf126744f core: swap priority can be negative
b1cf452ff5f6 systemctl: enhance message about kexec missing kernel
07a0e5b42523 man: use mkswap@ instead of makeswap@
57dc017c6bac journald: don't ask for the machine ID if we don't need it
ac392a57c08c journalctl: pager_close() calls fflush(stdout) anyway as first
thing
ee7dfadc8237 journald: remove unused field
471073f1b52b journalctl: return EOPNOTSUPP if pcre is not enabled
002ededb61a0 man: drop reference to machined, add one for journald instead
fd3bd4be3bff pid1: make TimeoutAbortSec settable for transient units
eb2ef4d6643e pid1: fix setting of DefaultTimeoutAbortSec
1d75e29b2378 shared/ask-password-api: modify keyctl break value
a16b1ee7e565 cryptsetup: reduce the chance that we will be OOM killed
4836fb010ae8 core: write out correct field name when creating transient
service units
3e2c547f6d3c udevd: don't use monitor after manager_exit()
d42f7d45a8e2 Revert "udevd: fix crash when workers time out after exit is
signal caught"
c9a287eee8fd man/systemd.link: Add missing verb *be*
a67a3ae04b89 man: document all pager variables for systemctl and systemd
3a8fce3f38b6 core.timer: fix "systemd-analyze dump" and docs syntax
inconsistencies wrt OnTimezoneChange=
fdffd284b682 core/service: downgrade "scheduling restart" message to debug
733e7f19d3cf travis: add missing closing quote sign
0d7b7817fc34 systemd-tmpfiles: don't install timer when service isn't
installed either
0e7f83cd2b31 pam_systemd: prolong method call timeout when allocating session
e51d9bf9e5ac man: add entry about SpeedMeter=
aa1fc791c7a1 udev: silence warning about PROGRAM+= or IMPORT+= rules
b9a619bb6738 udevadm: ignore EROFS and return earlier
1ec5b9f80cb5 basic: add vmware hypervisor detection from device-tree
7fa7080248aa umount: be happy if /proc/swaps doesn't exist
71ccd774bb33 shutdown: make logging more useful if NULL swap/mount table
files are specified
38453c6d42e4 man: share description of $SYSTEMD_COLORS in other tools
b50ca0152681 core: do not propagate polkit error to caller
99b72a66ca55 ask-password: don't hit assert() when we query pw which the user
C-d and caching is enabled
288edd686911 man: mention $RUNTIME_DIRECTORY & friends in environment list
37aeadd433d3 cryptsetup-generator: guess whether the keyfile argument is two
items or one
a87e8fdc72d7 verify: fix segmentation fault
3aea728cd2d2 timedated: it might be that tzinfo files are just not installed
cc103c72abc1 timedated: handle UTC specially, when generating /etc/localtime
f5a4caa5418b time-util: treat /etc/localtime missing as UTC
2139d58652bb bpf: fix off-by-one in class whitelisting
cb7693595db9 bpf: fix device type filter
56e1ba304b00 core: constify bpf program arrays
b06b7ace92c1 run: propagate return code/status from the child
5db454b8031c udevd: fix crash when workers time out after exit is signal
caught
b774282a855e udev: ignore error caused by device disconnection
8d88a2ecd7ce udev: fix error code in the log message
c41484a2f3d7 udev: ignore ENOENT when chmod_and_chown() device node
f218b65b3246 udev: do not append newline when write attributes
ce4d17ddbc16 time-util: uniquify timezone list, in case UTC is listed in
timezone1970.tab, too
28f0b34c57bc time-util: always accept UTC as valid timezone
8b888d236007 seccomp: add all *time64 syscalls
53d8feeb2334 libblkid: open device in nonblock mode.
b9478046b03d man: describe ordering in case of Conflicts=
fa3e5bd2bbb4 man: put description of Wants= above Requires=
bdebd2c325fc
