Re: [OE-core] [PATCH] cross-localedef-native_2.20.bb: fix for gcc5
Burton, Ross ross.bur...@intel.com writes: On 7 July 2015 at 03:54, Richard Tollerton rich.toller...@ni.com wrote: The build of cross-localedef-native is observed to fail under gcc5 hosts with multiple definition errors, e.g.: Is this patch intended for fido? Master doesn't have 2.20 anymore (2.21) and I believe that works with gcc5 hosts. It was nominally written for dizzy. It looks like Khem already added -fgnu89-inline in his initial commit of cross-localedef-native_2.21.bb, so that's why this works in fido (and master). -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cross-localedef-native_2.20.bb: fix for gcc5
On 7 July 2015 at 03:54, Richard Tollerton rich.toller...@ni.com wrote: The build of cross-localedef-native is observed to fail under gcc5 hosts with multiple definition errors, e.g.: Is this patch intended for fido? Master doesn't have 2.20 anymore (2.21) and I believe that works with gcc5 hosts. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cross-localedef-native_2.20.bb: fix for gcc5
On Tue, Jul 7, 2015 at 5:29 AM, Burton, Ross ross.bur...@intel.com wrote: On 7 July 2015 at 03:54, Richard Tollerton rich.toller...@ni.com wrote: The build of cross-localedef-native is observed to fail under gcc5 hosts with multiple definition errors, e.g.: Is this patch intended for fido? Master doesn't have 2.20 anymore (2.21) and I believe that works with gcc5 hosts. I would prefer to upgrade to 2.21, if this is tthe case. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] cross-localedef-native_2.20.bb: fix for gcc5
Message-ID: 87wpycy88v@weregild.amer.corp.natinst.com
MIME-Version: 1.0
Content-Type: text/plain
--text follows this line--
The build of cross-localedef-native is observed to fail under gcc5 hosts
with multiple definition errors, e.g.:
argp-help.o: In function `argp_fmtstream_write':
argp-help.c:(.text+0x1da0): multiple definition of `argp_fmtstream_write'
argp-fmtstream.o:argp-fmtstream.c:(.text+0x7a0): first defined here
The problem is the change of the default C standard from gnu89 to gnu11
which changes the semantics of 'inline'. The issue is described in the
Porting guide at https://gcc.gnu.org/gcc-5/porting_to.html. Adding the
'-fgnu89-inline' option fixes the issue.
(This fix, including the above explanation, was shamelessly copied from
http://git.vahanus.net/?p=csc/ptxdist-kp.git;a=commit;h=2f04a3587bd33c74ccc9be6e115a8b1fde620841.)
Signed-off-by: Richard Tollerton rich.toller...@ni.com
---
meta/recipes-core/glibc/cross-localedef-native_2.20.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/glibc/cross-localedef-native_2.20.bb
b/meta/recipes-core/glibc/cross-localedef-native_2.20.bb
index ccf56a9..38f2af4 100644
--- a/meta/recipes-core/glibc/cross-localedef-native_2.20.bb
+++ b/meta/recipes-core/glibc/cross-localedef-native_2.20.bb
@@ -39,7 +39,7 @@ SRCREV_localedef = c833367348d39dad7ba018990bfdaffaec8e9ed3
S = ${WORKDIR}/git
EXTRA_OECONF = --with-glibc=${S}
-CFLAGS += -DNOT_IN_libc=1
+CFLAGS += -DNOT_IN_libc=1 -fgnu89-inline
do_configure () {
${S}/localedef/configure ${EXTRA_OECONF}
--
2.4.4
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
