Re: [OE-core] [PATCH] file: specify c std as c99 or greater required

2016-09-06 Thread Jack Mitchell 



On 06/09/16 19:36, Khem Raj wrote:

On Sep 6, 2016, at 6:25 AM, Jack Mitchell  wrote:

From: Jack Mitchell 

when using a toolchain not shipped by OE core such as linaro we
can't be sure what the std will be set to. Ensure file is compiled
as c99 or greater as required.

comment does not match the code, its using gnu11, secondly is gnu11 needed or 
can it live with
c11


Comment says it needs 'c99 or greater' so I set it to gnu11 which is the 
default we use for gcc6, no? The minimum it can compile with is c99, 
would that be a better option to set?


Cheers,




Signed-off-by: Jack Mitchell 
---
meta/recipes-devtools/file/file_5.28.bb | 2 ++
1 file changed, 2 insertions(+)

diff --git a/meta/recipes-devtools/file/file_5.28.bb 
b/meta/recipes-devtools/file/file_5.28.bb
index 516c8c5..94848db 100644
--- a/meta/recipes-devtools/file/file_5.28.bb
+++ b/meta/recipes-devtools/file/file_5.28.bb
@@ -27,6 +27,8 @@ inherit autotools
EXTRA_OEMAKE_append_class-target = "-e 
FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
EXTRA_OEMAKE_append_class-nativesdk = "-e 
FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"

+CFLAGS_append = " -std=gnu11"
+
FILES_${PN} += "${datadir}/misc/*.mgc"

do_install_append_class-native() {
--
2.9.3

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] file: specify c std as c99 or greater required

2016-09-06 Thread Khem Raj 

> On Sep 6, 2016, at 6:25 AM, Jack Mitchell  wrote:
> 
> From: Jack Mitchell 
> 
> when using a toolchain not shipped by OE core such as linaro we
> can't be sure what the std will be set to. Ensure file is compiled
> as c99 or greater as required.

comment does not match the code, its using gnu11, secondly is gnu11 needed or 
can it live with
c11

> 
> Signed-off-by: Jack Mitchell 
> ---
> meta/recipes-devtools/file/file_5.28.bb | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-devtools/file/file_5.28.bb 
> b/meta/recipes-devtools/file/file_5.28.bb
> index 516c8c5..94848db 100644
> --- a/meta/recipes-devtools/file/file_5.28.bb
> +++ b/meta/recipes-devtools/file/file_5.28.bb
> @@ -27,6 +27,8 @@ inherit autotools
> EXTRA_OEMAKE_append_class-target = "-e 
> FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
> EXTRA_OEMAKE_append_class-nativesdk = "-e 
> FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
> 
> +CFLAGS_append = " -std=gnu11"
> +
> FILES_${PN} += "${datadir}/misc/*.mgc"
> 
> do_install_append_class-native() {
> --
> 2.9.3
> 
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



signature.asc
Description: Message signed with OpenPGP using GPGMail
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] file: specify c std as c99 or greater required

2016-09-06 Thread Jack Mitchell 
From: Jack Mitchell 

when using a toolchain not shipped by OE core such as linaro we
can't be sure what the std will be set to. Ensure file is compiled
as c99 or greater as required.

Signed-off-by: Jack Mitchell 
---
 meta/recipes-devtools/file/file_5.28.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-devtools/file/file_5.28.bb 
b/meta/recipes-devtools/file/file_5.28.bb
index 516c8c5..94848db 100644
--- a/meta/recipes-devtools/file/file_5.28.bb
+++ b/meta/recipes-devtools/file/file_5.28.bb
@@ -27,6 +27,8 @@ inherit autotools
 EXTRA_OEMAKE_append_class-target = "-e 
FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
 EXTRA_OEMAKE_append_class-nativesdk = "-e 
FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
 
+CFLAGS_append = " -std=gnu11"
+
 FILES_${PN} += "${datadir}/misc/*.mgc"
 
 do_install_append_class-native() {
-- 
2.9.3

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core