Re: [OE-core] [PATCH] kernel-fitimage: Allow DTB file relocation at boot time

2018-06-15 Thread Mihai Serban 
On Fri, Jun 15, 2018 at 8:58 PM Alex Kiernan  wrote:
>
> On Fri, Jun 15, 2018 at 5:19 PM Mihai Serban  wrote:
> >
> > Use UBOOT_DTB_LOADADDRESS and UBOOT_DTB_ENTRYPOINT variables to instruct
> > U-Boot where to place the selected DTB file when booting the system.
> > Without these settings U-Boot uses the relative offset where DTB resides
> > inside the loading address of the FIT image.
> >
> > Signed-off-by: Mihai Serban 
>
> I've a similar patch I've been sitting on for a while, which also
> deals with the case where you want DTB overlays, but I don't have the
> entry line - what's the use for that in a DTB inside a FIT image?

Thanks for pointing this out. Entry is not used for DTB, I'll send v2.

>
> I'll get what I've got posted up.
>
> > ---
> >  meta/classes/kernel-fitimage.bbclass | 11 +++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/meta/classes/kernel-fitimage.bbclass 
> > b/meta/classes/kernel-fitimage.bbclass
> > index 50a91e199069..981d11f19f8d 100644
> > --- a/meta/classes/kernel-fitimage.bbclass
> > +++ b/meta/classes/kernel-fitimage.bbclass
> > @@ -134,6 +134,15 @@ EOF
> >  fitimage_emit_section_dtb() {
> >
> > dtb_csum="sha1"
> > +   dtb_loadline=""
> > +   dtb_entryline=""
> > +
> > +   if [ -n "${UBOOT_DTB_LOADADDRESS}" ]; then
> > +   dtb_loadline="load = <${UBOOT_DTB_LOADADDRESS}>;"
> > +   fi
> > +   if [ -n "${UBOOT_DTB_ENTRYPOINT}" ]; then
> > +   dtb_entryline="entry = <${UBOOT_DTB_ENTRYPOINT}>;"
> > +   fi
> >
> > cat << EOF >> ${1}
> >  fdt@${2} {
> > @@ -142,6 +151,8 @@ fitimage_emit_section_dtb() {
> >  type = "flat_dt";
> >  arch = "${UBOOT_ARCH}";
> >  compression = "none";
> > +${dtb_loadline}
> > +${dtb_entryline}
> >  hash@1 {
> >  algo = "${dtb_csum}";
> >  };
> > --
> > 2.17.1
> >
> > --
> > ___
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
> --
> Alex Kiernan
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] kernel-fitimage: Allow DTB file relocation at boot time

2018-06-15 Thread Alex Kiernan 
On Fri, Jun 15, 2018 at 5:19 PM Mihai Serban  wrote:
>
> Use UBOOT_DTB_LOADADDRESS and UBOOT_DTB_ENTRYPOINT variables to instruct
> U-Boot where to place the selected DTB file when booting the system.
> Without these settings U-Boot uses the relative offset where DTB resides
> inside the loading address of the FIT image.
>
> Signed-off-by: Mihai Serban 

I've a similar patch I've been sitting on for a while, which also
deals with the case where you want DTB overlays, but I don't have the
entry line - what's the use for that in a DTB inside a FIT image?

I'll get what I've got posted up.

> ---
>  meta/classes/kernel-fitimage.bbclass | 11 +++
>  1 file changed, 11 insertions(+)
>
> diff --git a/meta/classes/kernel-fitimage.bbclass 
> b/meta/classes/kernel-fitimage.bbclass
> index 50a91e199069..981d11f19f8d 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -134,6 +134,15 @@ EOF
>  fitimage_emit_section_dtb() {
>
> dtb_csum="sha1"
> +   dtb_loadline=""
> +   dtb_entryline=""
> +
> +   if [ -n "${UBOOT_DTB_LOADADDRESS}" ]; then
> +   dtb_loadline="load = <${UBOOT_DTB_LOADADDRESS}>;"
> +   fi
> +   if [ -n "${UBOOT_DTB_ENTRYPOINT}" ]; then
> +   dtb_entryline="entry = <${UBOOT_DTB_ENTRYPOINT}>;"
> +   fi
>
> cat << EOF >> ${1}
>  fdt@${2} {
> @@ -142,6 +151,8 @@ fitimage_emit_section_dtb() {
>  type = "flat_dt";
>  arch = "${UBOOT_ARCH}";
>  compression = "none";
> +${dtb_loadline}
> +${dtb_entryline}
>  hash@1 {
>  algo = "${dtb_csum}";
>  };
> --
> 2.17.1
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
Alex Kiernan
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] kernel-fitimage: Allow DTB file relocation at boot time

2018-06-15 Thread Mihai Serban 
Use UBOOT_DTB_LOADADDRESS and UBOOT_DTB_ENTRYPOINT variables to instruct
U-Boot where to place the selected DTB file when booting the system.
Without these settings U-Boot uses the relative offset where DTB resides
inside the loading address of the FIT image.

Signed-off-by: Mihai Serban 
---
 meta/classes/kernel-fitimage.bbclass | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/meta/classes/kernel-fitimage.bbclass 
b/meta/classes/kernel-fitimage.bbclass
index 50a91e199069..981d11f19f8d 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -134,6 +134,15 @@ EOF
 fitimage_emit_section_dtb() {
 
dtb_csum="sha1"
+   dtb_loadline=""
+   dtb_entryline=""
+
+   if [ -n "${UBOOT_DTB_LOADADDRESS}" ]; then
+   dtb_loadline="load = <${UBOOT_DTB_LOADADDRESS}>;"
+   fi
+   if [ -n "${UBOOT_DTB_ENTRYPOINT}" ]; then
+   dtb_entryline="entry = <${UBOOT_DTB_ENTRYPOINT}>;"
+   fi
 
cat << EOF >> ${1}
 fdt@${2} {
@@ -142,6 +151,8 @@ fitimage_emit_section_dtb() {
 type = "flat_dt";
 arch = "${UBOOT_ARCH}";
 compression = "none";
+${dtb_loadline}
+${dtb_entryline}
 hash@1 {
 algo = "${dtb_csum}";
 };
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core