Re: [OE-core] [PATCH] libcomps & librepo: fix buildpaths qa warnings
On 2019/1/15 下午6:01, Burton, Ross wrote: On Tue, 15 Jan 2019 at 06:46, wrote: Add preprocess option '-fmacro-prefix-map' to TARGET_CPPFLAGS to fix buildpaths qa warnings of libcomps and librepo. This is something we should be doing globally, not in a specific recipe. We pass -fdebug-prefix-map already in bitbake.conf (remap debug paths), and macro-prefix-map is the same but for __FILE__. This is good, because we've a few patches to remove __FILE__ already and this means we can drop it. Digging further reveals that there's also -ffile-prefix-map, which sets debug-prefix-map and macro-prefix-map at once. We should just change bitbake.conf to use that instead of debug-prefix-map. OK. --Kai Ross -- Kai Kang -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] libcomps & librepo: fix buildpaths qa warnings
On 2019/1/15 下午5:57, Alexander Kanavin wrote: On Tue, 15 Jan 2019 at 07:46, wrote: Add preprocess option '-fmacro-prefix-map' to TARGET_CPPFLAGS to fix buildpaths qa warnings of libcomps and librepo. These warnings are not happening on the AB or on my local setup. Could they be happening due to something in your local config? Hi Alex, I just enabled buildpaths check in local.conf: WARN_QA_append = " buildpaths" Regards, Kai Can you try with plain poky master please? Alex -- Kai Kang -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] libcomps & librepo: fix buildpaths qa warnings
On Tue, 15 Jan 2019 at 06:46, wrote: > Add preprocess option '-fmacro-prefix-map' to TARGET_CPPFLAGS to fix > buildpaths qa warnings of libcomps and librepo. This is something we should be doing globally, not in a specific recipe. We pass -fdebug-prefix-map already in bitbake.conf (remap debug paths), and macro-prefix-map is the same but for __FILE__. This is good, because we've a few patches to remove __FILE__ already and this means we can drop it. Digging further reveals that there's also -ffile-prefix-map, which sets debug-prefix-map and macro-prefix-map at once. We should just change bitbake.conf to use that instead of debug-prefix-map. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] libcomps & librepo: fix buildpaths qa warnings
On Tue, 15 Jan 2019 at 07:46, wrote: > Add preprocess option '-fmacro-prefix-map' to TARGET_CPPFLAGS to fix > buildpaths qa warnings of libcomps and librepo. These warnings are not happening on the AB or on my local setup. Could they be happening due to something in your local config? Can you try with plain poky master please? Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] libcomps & librepo: fix buildpaths qa warnings
From: Kai Kang
Add preprocess option '-fmacro-prefix-map' to TARGET_CPPFLAGS to fix
buildpaths qa warnings of libcomps and librepo.
Signed-off-by: Kai Kang
---
meta/recipes-devtools/libcomps/libcomps_git.bb | 2 ++
meta/recipes-devtools/librepo/librepo_1.9.3.bb | 2 ++
2 files changed, 4 insertions(+)
diff --git a/meta/recipes-devtools/libcomps/libcomps_git.bb
b/meta/recipes-devtools/libcomps/libcomps_git.bb
index 500d412340..421b8173bb 100644
--- a/meta/recipes-devtools/libcomps/libcomps_git.bb
+++ b/meta/recipes-devtools/libcomps/libcomps_git.bb
@@ -18,6 +18,8 @@ inherit cmake distutils3-base
DEPENDS += "libxml2 expat libcheck"
+TARGET_CPPFLAGS +=
"-fmacro-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}"
+
EXTRA_OECMAKE = " -DPYTHON_INSTALL_DIR=${PYTHON_SITEPACKAGES_DIR}
-DPYTHON_DESIRED=3"
OECMAKE_SOURCEPATH = "${S}/libcomps"
diff --git a/meta/recipes-devtools/librepo/librepo_1.9.3.bb
b/meta/recipes-devtools/librepo/librepo_1.9.3.bb
index abfed798f3..4f468b198a 100644
--- a/meta/recipes-devtools/librepo/librepo_1.9.3.bb
+++ b/meta/recipes-devtools/librepo/librepo_1.9.3.bb
@@ -15,6 +15,8 @@ DEPENDS = "curl glib-2.0 openssl attr gpgme libxml2"
inherit cmake distutils3-base pkgconfig
+TARGET_CPPFLAGS +=
"-fmacro-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}"
+
EXTRA_OECMAKE = " -DPYTHON_INSTALL_DIR=${PYTHON_SITEPACKAGES_DIR}
-DPYTHON_DESIRED=3 -DENABLE_TESTS=OFF -DENABLE_DOCS=OFF -DWITH_ZCHUNK=OFF"
BBCLASSEXTEND = "native nativesdk"
--
2.20.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
