[OE-core] [PATCH] libtool-cross/native: Force usage of bash due to sstate inconsistencies

2014-01-23 Thread Richard Purdie 
Scenario:
a) libtool script is built on system with bash as /bin/sh
b) machine B installs sstate from build a)
c) machine B has dash as /bin/sh

In this scenario, the script fails to work properly since its expecting
/bin/sh to have bash like syntax and it no longer does have it.

This patch forces the configure process to use /bin/bash, not /bin/sh
and hence allows the scripts to work correctly when used from sstate.

(From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org
---
diff --git a/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb 
b/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb
index 34aae0b..72fad37 100644
--- a/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb
+++ b/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb
@@ -39,3 +39,5 @@ libtoolcross_sysroot_preprocess () {
 }
 
 SSTATE_SCAN_FILES += libtoolize *-libtool
+
+export CONFIG_SHELL=/bin/bash
diff --git a/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb 
b/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb
index df73f08..f1051d8 100644
--- a/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb
+++ b/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb
@@ -22,3 +22,4 @@ do_install () {
install -m 0755 ${HOST_SYS}-libtool ${D}${bindir}/${HOST_SYS}-libtool
 }
 
+export CONFIG_SHELL=/bin/bash


___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] libtool-cross/native: Force usage of bash due to sstate inconsistencies

2014-01-23 Thread Otavio Salvador 
On Thu, Jan 23, 2014 at 10:19 AM, Richard Purdie
richard.pur...@linuxfoundation.org wrote:
 Scenario:
 a) libtool script is built on system with bash as /bin/sh
 b) machine B installs sstate from build a)
 c) machine B has dash as /bin/sh

 In this scenario, the script fails to work properly since its expecting
 /bin/sh to have bash like syntax and it no longer does have it.

 This patch forces the configure process to use /bin/bash, not /bin/sh
 and hence allows the scripts to work correctly when used from sstate.

 (From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

 Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org

Does this work for Fedora, using bash in /usr/bin/bash?

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] libtool-cross/native: Force usage of bash due to sstate inconsistencies

2014-01-23 Thread Robert Yang 



On 01/23/2014 08:37 PM, Otavio Salvador wrote:

On Thu, Jan 23, 2014 at 10:19 AM, Richard Purdie
richard.pur...@linuxfoundation.org wrote:

Scenario:
a) libtool script is built on system with bash as /bin/sh
b) machine B installs sstate from build a)
c) machine B has dash as /bin/sh

In this scenario, the script fails to work properly since its expecting
/bin/sh to have bash like syntax and it no longer does have it.

This patch forces the configure process to use /bin/bash, not /bin/sh
and hence allows the scripts to work correctly when used from sstate.

(From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org


Does this work for Fedora, using bash in /usr/bin/bash?



Yes, I think so, on Fedora:

$ readlink -f /bin/
/usr/bin


/bin is a symlink which points to /usr/bin.

// Robert
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] libtool-cross/native: Force usage of bash due to sstate inconsistencies

2014-01-23 Thread Otavio Salvador 
On Thu, Jan 23, 2014 at 10:42 AM, Robert Yang liezhi.y...@windriver.com wrote:


 On 01/23/2014 08:37 PM, Otavio Salvador wrote:

 On Thu, Jan 23, 2014 at 10:19 AM, Richard Purdie
 richard.pur...@linuxfoundation.org wrote:

 Scenario:
 a) libtool script is built on system with bash as /bin/sh
 b) machine B installs sstate from build a)
 c) machine B has dash as /bin/sh

 In this scenario, the script fails to work properly since its expecting
 /bin/sh to have bash like syntax and it no longer does have it.

 This patch forces the configure process to use /bin/bash, not /bin/sh
 and hence allows the scripts to work correctly when used from sstate.

 (From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

 Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org


 Does this work for Fedora, using bash in /usr/bin/bash?


 Yes, I think so, on Fedora:

 $ readlink -f /bin/
 /usr/bin


 /bin is a symlink which points to /usr/bin.

Thanks for checking.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] libtool-cross/native: Force usage of bash due to sstate inconsistencies

2014-01-23 Thread Martin Jansa 
On Thu, Jan 23, 2014 at 12:19:26PM +, Richard Purdie wrote:
 Scenario:
 a) libtool script is built on system with bash as /bin/sh
 b) machine B installs sstate from build a)
 c) machine B has dash as /bin/sh
 
 In this scenario, the script fails to work properly since its expecting
 /bin/sh to have bash like syntax and it no longer does have it.
 
 This patch forces the configure process to use /bin/bash, not /bin/sh
 and hence allows the scripts to work correctly when used from sstate.

Shouldn't oe-core commit 367a19aaf31bcf997f10d045e7954cc800189052 fix
that already? I don't see this issue on our builders since
367a19aaf31bcf997f10d045e7954cc800189052 was merged.

 (From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

This is sent from poky repo, right?

 Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org
 ---
 diff --git a/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb 
 b/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb
 index 34aae0b..72fad37 100644
 --- a/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb
 +++ b/meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb
 @@ -39,3 +39,5 @@ libtoolcross_sysroot_preprocess () {
  }
  
  SSTATE_SCAN_FILES += libtoolize *-libtool
 +
 +export CONFIG_SHELL=/bin/bash
 diff --git a/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb 
 b/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb
 index df73f08..f1051d8 100644
 --- a/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb
 +++ b/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb
 @@ -22,3 +22,4 @@ do_install () {
   install -m 0755 ${HOST_SYS}-libtool ${D}${bindir}/${HOST_SYS}-libtool
  }
  
 +export CONFIG_SHELL=/bin/bash
 
 
 ___
 Openembedded-core mailing list
 Openembedded-core@lists.openembedded.org
 http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com


signature.asc
Description: Digital signature
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core