Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On Wed, 2014-04-02 at 10:35 +0800, Kang Kai wrote:
On 2014年03月31日 22:20, Kai Kang wrote:
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion
to avoid to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
Signed-off-by: Kai Kang kai.k...@windriver.com
---
meta/recipes-support/nss/nss.inc | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc
b/meta/recipes-support/nss/nss.inc
index 404decc..f24da68 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -26,6 +26,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS_append_class-target += virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -37,12 +38,24 @@ TARGET_CC_ARCH += ${LDFLAGS}
do_compile_prepend_class-native() {
export NSPR_INCLUDE_DIR=${STAGING_INCDIR_NATIVE}
export NSPR_LIB_DIR=${STAGING_LIBDIR_NATIVE}
+export OS_RELEASE=`uname -r`
}
do_compile_prepend_class-nativesdk() {
export LDFLAGS=
}
+do_compile_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
+
+do_install_prepend_class-native() {
+export OS_RELEASE=`uname -r`
+}
+
+do_install_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
do_compile() {
export CROSS_COMPILE=1
export NATIVE_CC=gcc
@@ -57,7 +70,6 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
How about use var LINUXLIBCVERSION:
export OS_RELEASE=${@d.getVar('LINUXLIBCVERSION', True)}
it should be the same value with kernel version, right?
As others have replied, that is usually much more recent than the oldest
kernel we support. What does nss do with this value? Is it about the
header versions? Would something run on an older kernel with a newer
value for OS_RELEASE?
We also have the OLDEST_KERNEL variable (currently at 2.6.16) FWIW.
Cheers,
Richard
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On Thursday 03 April 2014 13:00:09 Richard Purdie wrote:
On Wed, 2014-04-02 at 10:35 +0800, Kang Kai wrote:
On 2014年03月31日 22:20, Kai Kang wrote:
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel
version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion to avoid to use the hardcode
kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
Signed-off-by: Kai Kang kai.k...@windriver.com
---
meta/recipes-support/nss/nss.inc | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc
b/meta/recipes-support/nss/nss.inc index 404decc..f24da68 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -26,6 +26,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS_append_class-target += virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -37,12 +38,24 @@ TARGET_CC_ARCH += ${LDFLAGS}
do_compile_prepend_class-native() {
export NSPR_INCLUDE_DIR=${STAGING_INCDIR_NATIVE}
export NSPR_LIB_DIR=${STAGING_LIBDIR_NATIVE}
+export OS_RELEASE=`uname -r`
}
do_compile_prepend_class-nativesdk() {
export LDFLAGS=
}
+do_compile_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'` +}
+
+do_install_prepend_class-native() {
+export OS_RELEASE=`uname -r`
+}
+
+do_install_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'` +}
do_compile() {
export CROSS_COMPILE=1
export NATIVE_CC=gcc
@@ -57,7 +70,6 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
How about use var LINUXLIBCVERSION:
export OS_RELEASE=${@d.getVar('LINUXLIBCVERSION', True)}
it should be the same value with kernel version, right?
As others have replied, that is usually much more recent than the oldest
kernel we support. What does nss do with this value? Is it about the
header versions? Would something run on an older kernel with a newer
value for OS_RELEASE?
We also have the OLDEST_KERNEL variable (currently at 2.6.16) FWIW.
Incidentally, I think maybe for 1.7 it's time we bumped OLDEST_KERNEL. What a
sensible minimum would be though I'm not sure. The minimum version for udev
182 would be one choice, but I believe there are people still using older
kernels even than that.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On Thu, 2014-04-03 at 14:13 +0100, Paul Eggleton wrote: Incidentally, I think maybe for 1.7 it's time we bumped OLDEST_KERNEL. What a sensible minimum would be though I'm not sure. The minimum version for udev 182 would be one choice, but I believe there are people still using older kernels even than that. What would be the advantages of bumping it up? p. -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On Thursday 03 April 2014 14:49:05 Phil Blundell wrote: On Thu, 2014-04-03 at 14:13 +0100, Paul Eggleton wrote: Incidentally, I think maybe for 1.7 it's time we bumped OLDEST_KERNEL. What a sensible minimum would be though I'm not sure. The minimum version for udev 182 would be one choice, but I believe there are people still using older kernels even than that. What would be the advantages of bumping it up? I could be wrong, but my understanding was that EGLIBC functionality specific to a particular kernel version or later is enabled / disabled based upon this value. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On 2014年04月03日 20:00, Richard Purdie wrote:
On Wed, 2014-04-02 at 10:35 +0800, Kang Kai wrote:
On 2014年03月31日 22:20, Kai Kang wrote:
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion
to avoid to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
Signed-off-by: Kai Kang kai.k...@windriver.com
---
meta/recipes-support/nss/nss.inc | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc b/meta/recipes-support/nss/nss.inc
index 404decc..f24da68 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -26,6 +26,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS_append_class-target += virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -37,12 +38,24 @@ TARGET_CC_ARCH += ${LDFLAGS}
do_compile_prepend_class-native() {
export NSPR_INCLUDE_DIR=${STAGING_INCDIR_NATIVE}
export NSPR_LIB_DIR=${STAGING_LIBDIR_NATIVE}
+export OS_RELEASE=`uname -r`
}
do_compile_prepend_class-nativesdk() {
export LDFLAGS=
}
+do_compile_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
+
+do_install_prepend_class-native() {
+export OS_RELEASE=`uname -r`
+}
+
+do_install_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
do_compile() {
export CROSS_COMPILE=1
export NATIVE_CC=gcc
@@ -57,7 +70,6 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
How about use var LINUXLIBCVERSION:
export OS_RELEASE=${@d.getVar('LINUXLIBCVERSION', True)}
it should be the same value with kernel version, right?
As others have replied, that is usually much more recent than the oldest
kernel we support. What does nss do with this value? Is it about the
header versions? Would something run on an older kernel with a newer
value for OS_RELEASE?
I misunderstanding the usage of LINUXLIBCVERSION. What nss needs is just
current kernel version to export for build:
-export OS_RELEASE=3.4
Currently it is a fix string, and I think it is a problem.
Regards,
Kai
We also have the OLDEST_KERNEL variable (currently at 2.6.16) FWIW.
Cheers,
Richard
--
Regards,
Neil | Kai Kang
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On 2014年03月31日 22:20, Kai Kang wrote:
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion
to avoid to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
Signed-off-by: Kai Kang kai.k...@windriver.com
---
meta/recipes-support/nss/nss.inc | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc b/meta/recipes-support/nss/nss.inc
index 404decc..f24da68 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -26,6 +26,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS_append_class-target += virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -37,12 +38,24 @@ TARGET_CC_ARCH += ${LDFLAGS}
do_compile_prepend_class-native() {
export NSPR_INCLUDE_DIR=${STAGING_INCDIR_NATIVE}
export NSPR_LIB_DIR=${STAGING_LIBDIR_NATIVE}
+export OS_RELEASE=`uname -r`
}
do_compile_prepend_class-nativesdk() {
export LDFLAGS=
}
+do_compile_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
+
+do_install_prepend_class-native() {
+export OS_RELEASE=`uname -r`
+}
+
+do_install_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
do_compile() {
export CROSS_COMPILE=1
export NATIVE_CC=gcc
@@ -57,7 +70,6 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
How about use var LINUXLIBCVERSION:
export OS_RELEASE=${@d.getVar('LINUXLIBCVERSION', True)}
it should be the same value with kernel version, right?
--Kai
export OS_TARGET=Linux
export OS_ARCH=Linux
@@ -97,7 +109,6 @@ do_install() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
export OS_TARGET=Linux
export OS_ARCH=Linux
--
Regards,
Neil | Kai Kang
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On Tuesday, April 1, 2014, Kang Kai kai.k...@windriver.com wrote:
On 2014年03月31日 22:20, Kai Kang wrote:
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion
to avoid to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
Signed-off-by: Kai Kang kai.k...@windriver.com
---
meta/recipes-support/nss/nss.inc | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc b/meta/recipes-support/nss/
nss.inc
index 404decc..f24da68 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -26,6 +26,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS_append_class-target += virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -37,12 +38,24 @@ TARGET_CC_ARCH += ${LDFLAGS}
do_compile_prepend_class-native() {
export NSPR_INCLUDE_DIR=${STAGING_INCDIR_NATIVE}
export NSPR_LIB_DIR=${STAGING_LIBDIR_NATIVE}
+export OS_RELEASE=`uname -r`
}
do_compile_prepend_class-nativesdk() {
export LDFLAGS=
}
+do_compile_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
+
+do_install_prepend_class-native() {
+export OS_RELEASE=`uname -r`
+}
+
+do_install_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
do_compile() {
export CROSS_COMPILE=1
export NATIVE_CC=gcc
@@ -57,7 +70,6 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
How about use var LINUXLIBCVERSION:
export OS_RELEASE=${@d.getVar('LINUXLIBCVERSION', True)}
it should be the same value with kernel version, right?
No, that's the kernel headers version, if the dependency is on kernel
proper then it won't be the right thing to do since many bsps use different
kernel
--Kai
export OS_TARGET=Linux
export OS_ARCH=Linux
@@ -97,7 +109,6 @@ do_install() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
export OS_TARGET=Linux
export OS_ARCH=Linux
--
Regards,
Neil | Kai Kang
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] nss: avoid to use the hardcode kernel version
Hi Richard, I don't quite understand what you mean this makes nss machine specific. After update way for nss-native, I send this new version for review. Thanks. Roy Li (1): nss: avoid to use the hardcode kernel version meta/recipes-support/nss/nss.inc | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) -- 1.8.1.2 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] nss: avoid to use the hardcode kernel version
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion
to avoid to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
Signed-off-by: Kai Kang kai.k...@windriver.com
---
meta/recipes-support/nss/nss.inc | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc b/meta/recipes-support/nss/nss.inc
index 404decc..f24da68 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -26,6 +26,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS_append_class-target += virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -37,12 +38,24 @@ TARGET_CC_ARCH += ${LDFLAGS}
do_compile_prepend_class-native() {
export NSPR_INCLUDE_DIR=${STAGING_INCDIR_NATIVE}
export NSPR_LIB_DIR=${STAGING_LIBDIR_NATIVE}
+export OS_RELEASE=`uname -r`
}
do_compile_prepend_class-nativesdk() {
export LDFLAGS=
}
+do_compile_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
+
+do_install_prepend_class-native() {
+export OS_RELEASE=`uname -r`
+}
+
+do_install_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
do_compile() {
export CROSS_COMPILE=1
export NATIVE_CC=gcc
@@ -57,7 +70,6 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
export OS_TARGET=Linux
export OS_ARCH=Linux
@@ -97,7 +109,6 @@ do_install() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
export OS_TARGET=Linux
export OS_ARCH=Linux
--
1.8.1.2
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On Mon, Mar 31, 2014 at 11:20 AM, Kai Kang kai.k...@windriver.com wrote:
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion
to avoid to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
Signed-off-by: Kai Kang kai.k...@windriver.com
This makes it depends on virtual/kernel and it vary from one machine to another.
Am I missing anything here?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On Mon, Mar 31, 2014 at 10:20:49PM +0800, Kai Kang wrote:
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion
to avoid to use the hardcode kernel version.
Doesn't it make nss MACHINE_ARCH like most virtual/kernel providers are?
Signed-off-by: Roy Li rongqing...@windriver.com
Signed-off-by: Kai Kang kai.k...@windriver.com
---
meta/recipes-support/nss/nss.inc | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc
b/meta/recipes-support/nss/nss.inc
index 404decc..f24da68 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -26,6 +26,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS_append_class-target += virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -37,12 +38,24 @@ TARGET_CC_ARCH += ${LDFLAGS}
do_compile_prepend_class-native() {
export NSPR_INCLUDE_DIR=${STAGING_INCDIR_NATIVE}
export NSPR_LIB_DIR=${STAGING_LIBDIR_NATIVE}
+export OS_RELEASE=`uname -r`
}
do_compile_prepend_class-nativesdk() {
export LDFLAGS=
}
+do_compile_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
+
+do_install_prepend_class-native() {
+export OS_RELEASE=`uname -r`
+}
+
+do_install_prepend_class-target() {
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
+}
do_compile() {
export CROSS_COMPILE=1
export NATIVE_CC=gcc
@@ -57,7 +70,6 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
export OS_TARGET=Linux
export OS_ARCH=Linux
@@ -97,7 +109,6 @@ do_install() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
export OS_TARGET=Linux
export OS_ARCH=Linux
--
1.8.1.2
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com
signature.asc
Description: Digital signature
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On Mon, Mar 31, 2014 at 12:10 PM, Martin Jansa martin.ja...@gmail.com wrote:
On Mon, Mar 31, 2014 at 10:20:49PM +0800, Kai Kang wrote:
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion
to avoid to use the hardcode kernel version.
Doesn't it make nss MACHINE_ARCH like most virtual/kernel providers are?
Yes.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On 2014年04月01日 00:32, Richard Purdie wrote:
On Mon, 2014-03-31 at 17:10 +0200, Martin Jansa wrote:
On Mon, Mar 31, 2014 at 10:20:49PM +0800, Kai Kang wrote:
From: Roy Li rongqing...@windriver.com
When native package is built, use the uname to return the kernel version.
When target is built, read kernel version from
${STAGING_KERNEL_DIR}/kernel-abiversion
to avoid to use the hardcode kernel version.
Doesn't it make nss MACHINE_ARCH like most virtual/kernel providers are?
Agreed. I rejected this patch a while ago due to this and I'll reject it
again.
Got it. Thanks for all of your comments.
--Kai
Cheers,
Richard
--
Regards,
Neil | Kai Kang
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On 2014-02-13 04:48, rongqing...@windriver.com wrote:
From: Roy Li rongqing...@windriver.com
Read kernel version from ${STAGING_KERNEL_DIR}/kernel-abiversion, to avoid
to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
---
meta/recipes-support/nss/nss.inc |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc b/meta/recipes-support/nss/nss.inc
index a6aeed8..3ad12cc 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -23,7 +23,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
-DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS = sqlite3 nspr zlib nss-native virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -55,7 +55,7 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
So if native or nativesdk versions compile before virtual/kernel
${STAGING_KERNEL_DIR}/kernel-abiversion is available ?
What will happen then ?
export OS_TARGET=Linux
export OS_ARCH=Linux
@@ -95,7 +95,7 @@ do_install() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
export OS_TARGET=Linux
export OS_ARCH=Linux
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
On Thu, 2014-02-13 at 11:48 +0800, rongqing...@windriver.com wrote:
From: Roy Li rongqing...@windriver.com
Read kernel version from ${STAGING_KERNEL_DIR}/kernel-abiversion, to avoid
to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
---
meta/recipes-support/nss/nss.inc |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
I've just realised this makes nss machine specific. We do not want to do
that.
Cheers,
Richard
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] nss: avoid to use the hardcode kernel version
From: Roy Li rongqing...@windriver.com
Read kernel version from ${STAGING_KERNEL_DIR}/kernel-abiversion, to avoid
to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
---
meta/recipes-support/nss/nss.inc |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc b/meta/recipes-support/nss/nss.inc
index a6aeed8..3ad12cc 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -23,7 +23,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
-DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS = sqlite3 nspr zlib nss-native virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -55,7 +55,7 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
export OS_TARGET=Linux
export OS_ARCH=Linux
@@ -95,7 +95,7 @@ do_install() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion|sed
's/-.*//'`
export OS_TARGET=Linux
export OS_ARCH=Linux
--
1.7.10.4
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] nss: avoid to use the hardcode kernel version
From: Roy Li rongqing...@windriver.com
Read kernel version from ${STAGING_KERNEL_DIR}/kernel-abiversion, to avoid
to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
---
meta/recipes-support/nss/nss.inc |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc b/meta/recipes-support/nss/nss.inc
index a6aeed8..bd7352d 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -23,7 +23,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
-DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS = sqlite3 nspr zlib nss-native virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -55,7 +55,7 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion`
export OS_TARGET=Linux
export OS_ARCH=Linux
@@ -95,7 +95,7 @@ do_install() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion`
export OS_TARGET=Linux
export OS_ARCH=Linux
--
1.7.10.4
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] nss: avoid to use the hardcode kernel version
please drop this one
-Roy
On 02/13/2014 11:34 AM, rongqing...@windriver.com wrote:
From: Roy Li rongqing...@windriver.com
Read kernel version from ${STAGING_KERNEL_DIR}/kernel-abiversion, to avoid
to use the hardcode kernel version.
Signed-off-by: Roy Li rongqing...@windriver.com
---
meta/recipes-support/nss/nss.inc |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-support/nss/nss.inc b/meta/recipes-support/nss/nss.inc
index a6aeed8..bd7352d 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -23,7 +23,7 @@ SRC_URI_append_class-target = \
inherit siteinfo
PR = r0
-DEPENDS = sqlite3 nspr zlib nss-native
+DEPENDS = sqlite3 nspr zlib nss-native virtual/kernel
DEPENDS_class-native = sqlite3-native nspr-native zlib-native
RDEPENDS_${PN} = perl
@@ -55,7 +55,7 @@ do_compile() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion`
export OS_TARGET=Linux
export OS_ARCH=Linux
@@ -95,7 +95,7 @@ do_install() {
export NSS_USE_SYSTEM_SQLITE=1
export NSS_ENABLE_ECC=1
-export OS_RELEASE=3.4
+export OS_RELEASE=`cat ${STAGING_KERNEL_DIR}/kernel-abiversion`
export OS_TARGET=Linux
export OS_ARCH=Linux
--
Best Reagrds,
Roy | RongQing Li
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
