Re: [OE-core] [PATCH] parted_1.8.6.bb: add parted that not GPLv3
On Fri, Jul 10, 2015 at 3:31 PM, Burton, Ross ross.bur...@intel.com wrote: On 9 July 2015 at 12:38, Otavio Salvador ota...@ossystems.com.br wrote: Parted 1.8 is very old and not supported at all. The number of fixes after it is such huge which makes Parted mostly useless in new storage and disk formats. I see NO benefit in having it and a serious maintenance burden. I wasn't aware the situation with the old parted was that bad... maybe this should be in meta-oe (if anywhere) after all? GPLv3 was released in June 2007 and most GNU packages transitioned to it fairly quickly, so by definition, the pre-GPLv3 version of any GNU package is now very old and unsupported. We do have a precedent for keeping pre-GPLv3 versions alive though (a good thing for those of us who need them!). What makes parted different from the other pre-GPLv3 packages which are already in oe-core? Looking at the parted changelog, there have certainly been a lot of bug fixes since 1.8.7 (the last GPLv2 version) but it's difficult to tell how many are for functionality which would be relevant to a typical embedded system. http://git.savannah.gnu.org/cgit/parted.git/tree/NEWS RHEL 5 seems to have been maintaining it's version of parted 1.8.1 up until Jan 2013. RHEL's 33 patches might be a good source of fixes for parted 1.8.7. http://vault.centos.org/5.11/os/SRPMS/parted-1.8.1-30.el5.src.rpm As someone has volunteered to maintain the pre-GPLv3 parted recipe (and I'll volunteer as a secondary maintainer, if that helps) hopefully there would not be a serious maintenance burden on anyone who doesn't have an interest in the older version. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] parted_1.8.6.bb: add parted that not GPLv3
On 9 July 2015 at 12:38, Otavio Salvador ota...@ossystems.com.br wrote: Parted 1.8 is very old and not supported at all. The number of fixes after it is such huge which makes Parted mostly useless in new storage and disk formats. I see NO benefit in having it and a serious maintenance burden. I wasn't aware the situation with the old parted was that bad... maybe this should be in meta-oe (if anywhere) after all? Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] parted_1.8.6.bb: add parted that not GPLv3
Hi Alex
+do_install_append() {
+ /bin/rm -rf ${D}/${libdir}/*.la
+ /bin/rm -rf ${D}/usr/share/info/dir
+ /bin/rm -fr ${D}/usr/bin
+}
Reference to fedora and Ubuntu, I delete these files.
Cheers
Lei
-Original Message-
From: alexander.kana...@linux.intel.com
[mailto:alexander.kana...@linux.intel.com]
Sent: Thursday, July 09, 2015 7:33 PM
To: Lei, Maohui
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] parted_1.8.6.bb: add parted that not GPLv3
Add parted-1.8.6 which is not GPLv3.
I have to say, I still can't support having this in oe-core. Providing
alternatives to GPLv3
software is fine, but not when the 'alternative' is a very old, unsupported
version of the
same software, which inevitably brings issues in functionality and
maintenance.
But if Ross and/or Richard disagree, then I'll have to accept it.
+Upstream-Status: Pending
Inappropriate is a better reason here, with clarification that the patches
are to make an
old version work and upstream won't be interested in them.
+do_install_append() {
+ /bin/rm -rf ${D}/${libdir}/*.la
+ /bin/rm -rf ${D}/usr/share/info/dir
+ /bin/rm -fr ${D}/usr/bin
+}
What are you deleting here and why?
Alex
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] parted_1.8.6.bb: add parted that not GPLv3
Add parted-1.8.6 which is not GPLv3.
Signed-off-by: Lei Maohui leimao...@cn.fujitsu.com
---
.../parted-1.8.6/1000parted-1.8.6-warnings1.patch | 17 ++
.../1001parted-1.8.6-notransname1.patch| 45
.../1002parted-1.8.6-off-by-one1.patch | 31 +++
.../1003parted-1.8.6-primary-boundary1.patch | 18 +++
.../parted-1.8.6/1004parted-1.8.6-xvd1.patch | 56
.../1005parted-1.8.6-devmapper-header1.patch | 19 +++
.../parted/parted-1.8.6/ui.c-fix-build-error.patch | 29 ++
meta/recipes-extended/parted/parted_1.8.6.bb | 61 ++
8 files changed, 276 insertions(+)
create mode 100644
meta/recipes-extended/parted/parted-1.8.6/1000parted-1.8.6-warnings1.patch
create mode 100644
meta/recipes-extended/parted/parted-1.8.6/1001parted-1.8.6-notransname1.patch
create mode 100644
meta/recipes-extended/parted/parted-1.8.6/1002parted-1.8.6-off-by-one1.patch
create mode 100644
meta/recipes-extended/parted/parted-1.8.6/1003parted-1.8.6-primary-boundary1.patch
create mode 100644
meta/recipes-extended/parted/parted-1.8.6/1004parted-1.8.6-xvd1.patch
create mode 100644
meta/recipes-extended/parted/parted-1.8.6/1005parted-1.8.6-devmapper-header1.patch
create mode 100644
meta/recipes-extended/parted/parted-1.8.6/ui.c-fix-build-error.patch
create mode 100644 meta/recipes-extended/parted/parted_1.8.6.bb
diff --git
a/meta/recipes-extended/parted/parted-1.8.6/1000parted-1.8.6-warnings1.patch
b/meta/recipes-extended/parted/parted-1.8.6/1000parted-1.8.6-warnings1.patch
new file mode 100644
index 000..83455ee
--- /dev/null
+++ b/meta/recipes-extended/parted/parted-1.8.6/1000parted-1.8.6-warnings1.patch
@@ -0,0 +1,17 @@
+This patch comes from:
http://pkgs.fedoraproject.org/cgit/parted.git/commit/?id=ce690b23703eb5295d116cdb972a04260ef5ddec
+
+Upstream-Status: Pending
+
+Signed-off-by: Signed-off-by: Lei Maohui leimao...@cn.fujitsu.com
+
+--- parted-1.8.6/libparted/fs/linux_swap/linux_swap.c.warnings 2007-03-20
13:22:36.0 -0400
parted-1.8.6/libparted/fs/linux_swap/linux_swap.c 2007-03-20
13:59:11.0 -0400
+@@ -123,7 +123,7 @@
+
+ error_close_fs:
+ swap_close (fs);
+-error:
++
+ return 0;
+ }
+ #endif /* !DISCOVER_ONLY */
diff --git
a/meta/recipes-extended/parted/parted-1.8.6/1001parted-1.8.6-notransname1.patch
b/meta/recipes-extended/parted/parted-1.8.6/1001parted-1.8.6-notransname1.patch
new file mode 100644
index 000..7fbfde7
--- /dev/null
+++
b/meta/recipes-extended/parted/parted-1.8.6/1001parted-1.8.6-notransname1.patch
@@ -0,0 +1,45 @@
+This patch comes from:
http://pkgs.fedoraproject.org/cgit/parted.git/commit/?id=e13022c01a2cd944e28c61827c96b0a37f4eecf0
+
+Upstream-Status: Pending
+
+Signed-off-by: Signed-off-by: Lei Maohui leimao...@cn.fujitsu.com
+
+--- parted-1.8.6/parted/parted.c.notransname 2007-03-13 13:01:09.0
-0400
parted-1.8.6/parted/parted.c 2007-03-21 10:50:35.0 -0400
+@@ -1429,7 +1429,7 @@
+ part-fs_type-name : );
+
+ if (has_name) {
+-name = _(ped_partition_get_name (part));
++name = ped_partition_get_name (part);
+ str_list_append (row, name);
+ }
+
+--- parted-1.8.6/parted/table.c.notransname2007-03-13 13:01:09.0
-0400
parted-1.8.6/parted/table.c2007-03-21 10:51:31.0 -0400
+@@ -191,7 +191,8 @@
+ len += wcslen(COLSUFFIX);
+
+ newsize = (wcslen(*s) + len + 1) * sizeof(wchar_t);
+-*s = realloc (*s, newsize);
++*s = (wchar_t *) realloc (*s, newsize);
++assert(*s != NULL);
+
+ for (i = 0; i ncols; ++i)
+ {
+@@ -199,6 +200,7 @@
+ int nspaces = max(t-widths[i] - wcswidth(row[i], MAX_WIDTH),
+ 0);
+ wchar_t* pad = malloc ( (nspaces + 1) * sizeof(wchar_t) );
++assert(pad != NULL);
+
+ for (j = 0; j nspaces; ++j)
+pad[j] = L' ';
+@@ -211,6 +213,7 @@
+ wcscat (*s, DELIMITER);
+
+ free (pad);
++pad = NULL;
+ }
+
+ wcscat (*s, COLSUFFIX);
diff --git
a/meta/recipes-extended/parted/parted-1.8.6/1002parted-1.8.6-off-by-one1.patch
b/meta/recipes-extended/parted/parted-1.8.6/1002parted-1.8.6-off-by-one1.patch
new file mode 100644
index 000..dde5c29
--- /dev/null
+++
b/meta/recipes-extended/parted/parted-1.8.6/1002parted-1.8.6-off-by-one1.patch
@@ -0,0 +1,31 @@
+This patch comes from:
http://pkgs.fedoraproject.org/cgit/parted.git/commit/?id=cb95a1496c040be5e9de8f674224619fd47648c3
+
+Upstream-Status: Pending
+
+Signed-off-by: Signed-off-by: Lei Maohui leimao...@cn.fujitsu.com
+
+---
Re: [OE-core] [PATCH] parted_1.8.6.bb: add parted that not GPLv3
On Thu, Jul 9, 2015 at 8:33 AM, alexander.kana...@linux.intel.com wrote: Add parted-1.8.6 which is not GPLv3. I have to say, I still can't support having this in oe-core. Providing alternatives to GPLv3 software is fine, but not when the 'alternative' is a very old, unsupported version of the same software, which inevitably brings issues in functionality and maintenance. Parted 1.8 is very old and not supported at all. The number of fixes after it is such huge which makes Parted mostly useless in new storage and disk formats. I see NO benefit in having it and a serious maintenance burden. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] parted_1.8.6.bb: add parted that not GPLv3
Add parted-1.8.6 which is not GPLv3.
I have to say, I still can't support having this in oe-core. Providing
alternatives to GPLv3 software is fine, but not when the 'alternative' is
a very old, unsupported version of the same software, which inevitably
brings issues in functionality and maintenance.
But if Ross and/or Richard disagree, then I'll have to accept it.
+Upstream-Status: Pending
Inappropriate is a better reason here, with clarification that the
patches are to make an old version work and upstream won't be interested
in them.
+do_install_append() {
+ /bin/rm -rf ${D}/${libdir}/*.la
+ /bin/rm -rf ${D}/usr/share/info/dir
+ /bin/rm -fr ${D}/usr/bin
+}
What are you deleting here and why?
Alex
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
