Re: [OE-core] [PATCH] qemu: Install the default qemu emulation rpm
On Thu, 2023-06-29 at 10:01 +0800, Yu, Mingli wrote: > Please ignore this patch and use the patch "qemu: Add qemu-common > package" instead. > > And the patch "qemu: Add qemu-common package" fix the backward > compatibility as > https://patchwork.yoctoproject.org/project/oe-core/patch/20230627105627.2583973-1-mingli...@eng.windriver.com/. How about we simply add: RRECOMMENDS:${PN} += "${PN}-system-all ${PN}-user-all" I think that solves the issues in a neater way and preserves the useful -all packages? Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#183619): https://lists.openembedded.org/g/openembedded-core/message/183619 Mute This Topic: https://lists.openembedded.org/mt/99544571/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] qemu: Install the default qemu emulation rpm
Please ignore this patch and use the patch "qemu: Add qemu-common package" instead. And the patch "qemu: Add qemu-common package" fix the backward compatibility as https://patchwork.yoctoproject.org/project/oe-core/patch/20230627105627.2583973-1-mingli...@eng.windriver.com/. Thanks, On 6/15/23 16:17, Yu, Mingli wrote: From: Mingli Yu The qemu rpm can be split or not via customize PACKAGESPLITFUNCS and there is no specific qemu emulation rpm installed when we choose split the qemu rpms now. To gurantee the basic usage, install the qemu emulation rpm which corresponding to the target arch by default when split the qemu rpm. Signed-off-by: Mingli Yu --- meta/recipes-devtools/qemu/qemu.inc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc index 7d39f0a25d..c9df43a5a2 100644 --- a/meta/recipes-devtools/qemu/qemu.inc +++ b/meta/recipes-devtools/qemu/qemu.inc @@ -248,6 +248,9 @@ python split_qemu_packages () { mipspackage = d.getVar('PN') + "-user-mips" if mipspackage in ' '.join(userpackages): d.appendVar('RDEPENDS:' + mipspackage, ' ' + d.getVar("MLPREFIX") + 'bash') + +targetarch = "${@'i386' if d.getVar('TARGET_ARCH') in ['x86', 'i486', 'i586', 'i686'] else d.getVar('TARGET_ARCH').replace('_', '-')}" +d.appendVar('RRECOMMENDS:' + d.getVar('PN'), ' ' + d.getVar('PN') + '-user-' + targetarch + ' ' + d.getVar('PN') + '-system-' + targetarch) } # Put the guest agent in a separate package -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#183604): https://lists.openembedded.org/g/openembedded-core/message/183604 Mute This Topic: https://lists.openembedded.org/mt/99544571/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] qemu: Install the default qemu emulation rpm
On Thu, 2023-06-15 at 16:17 +0800, Yu, Mingli wrote: > From: Mingli Yu > > The qemu rpm can be split or not via customize PACKAGESPLITFUNCS and > there is no specific qemu emulation rpm installed when we choose split > the qemu rpms now. > > To gurantee the basic usage, install the qemu emulation rpm which > corresponding to the target arch by default when split the qemu rpm. > > Signed-off-by: Mingli Yu > --- > meta/recipes-devtools/qemu/qemu.inc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/recipes-devtools/qemu/qemu.inc > b/meta/recipes-devtools/qemu/qemu.inc > index 7d39f0a25d..c9df43a5a2 100644 > --- a/meta/recipes-devtools/qemu/qemu.inc > +++ b/meta/recipes-devtools/qemu/qemu.inc > @@ -248,6 +248,9 @@ python split_qemu_packages () { > mipspackage = d.getVar('PN') + "-user-mips" > if mipspackage in ' '.join(userpackages): > d.appendVar('RDEPENDS:' + mipspackage, ' ' + d.getVar("MLPREFIX") + > 'bash') > + > +targetarch = "${@'i386' if d.getVar('TARGET_ARCH') in ['x86', 'i486', > 'i586', 'i686'] else d.getVar('TARGET_ARCH').replace('_', '-')}" > +d.appendVar('RRECOMMENDS:' + d.getVar('PN'), ' ' + d.getVar('PN') + > '-user-' + targetarch + ' ' + d.getVar('PN') + '-system-' + targetarch) > } > > # Put the guest agent in a separate package I did originally say that I thought the qemu package should pull in all of the sub packages to maintain compatibility. I'm not sure having it pick the host architecture like this is a great idea and certainly it changes the default behaviour again. I'd much rather than picked a design then implementing it than keeping changing behaviour like this :(. I'm not seeing many other opinions though. Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#183410): https://lists.openembedded.org/g/openembedded-core/message/183410 Mute This Topic: https://lists.openembedded.org/mt/99544571/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] qemu: Install the default qemu emulation rpm
Ping. Thanks, On 6/15/23 16:17, Yu, Mingli wrote: From: Mingli Yu The qemu rpm can be split or not via customize PACKAGESPLITFUNCS and there is no specific qemu emulation rpm installed when we choose split the qemu rpms now. To gurantee the basic usage, install the qemu emulation rpm which corresponding to the target arch by default when split the qemu rpm. Signed-off-by: Mingli Yu --- meta/recipes-devtools/qemu/qemu.inc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc index 7d39f0a25d..c9df43a5a2 100644 --- a/meta/recipes-devtools/qemu/qemu.inc +++ b/meta/recipes-devtools/qemu/qemu.inc @@ -248,6 +248,9 @@ python split_qemu_packages () { mipspackage = d.getVar('PN') + "-user-mips" if mipspackage in ' '.join(userpackages): d.appendVar('RDEPENDS:' + mipspackage, ' ' + d.getVar("MLPREFIX") + 'bash') + +targetarch = "${@'i386' if d.getVar('TARGET_ARCH') in ['x86', 'i486', 'i586', 'i686'] else d.getVar('TARGET_ARCH').replace('_', '-')}" +d.appendVar('RRECOMMENDS:' + d.getVar('PN'), ' ' + d.getVar('PN') + '-user-' + targetarch + ' ' + d.getVar('PN') + '-system-' + targetarch) } # Put the guest agent in a separate package -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#183404): https://lists.openembedded.org/g/openembedded-core/message/183404 Mute This Topic: https://lists.openembedded.org/mt/99544571/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] qemu: Install the default qemu emulation rpm
From: Mingli Yu The qemu rpm can be split or not via customize PACKAGESPLITFUNCS and there is no specific qemu emulation rpm installed when we choose split the qemu rpms now. To gurantee the basic usage, install the qemu emulation rpm which corresponding to the target arch by default when split the qemu rpm. Signed-off-by: Mingli Yu --- meta/recipes-devtools/qemu/qemu.inc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc index 7d39f0a25d..c9df43a5a2 100644 --- a/meta/recipes-devtools/qemu/qemu.inc +++ b/meta/recipes-devtools/qemu/qemu.inc @@ -248,6 +248,9 @@ python split_qemu_packages () { mipspackage = d.getVar('PN') + "-user-mips" if mipspackage in ' '.join(userpackages): d.appendVar('RDEPENDS:' + mipspackage, ' ' + d.getVar("MLPREFIX") + 'bash') + +targetarch = "${@'i386' if d.getVar('TARGET_ARCH') in ['x86', 'i486', 'i586', 'i686'] else d.getVar('TARGET_ARCH').replace('_', '-')}" +d.appendVar('RRECOMMENDS:' + d.getVar('PN'), ' ' + d.getVar('PN') + '-user-' + targetarch + ' ' + d.getVar('PN') + '-system-' + targetarch) } # Put the guest agent in a separate package -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#182837): https://lists.openembedded.org/g/openembedded-core/message/182837 Mute This Topic: https://lists.openembedded.org/mt/99544571/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-