Re: [OE-core] [PATCH] runtime package management: ipk/opk

2013-11-02 Thread Trevor Woerner 
Hi Saul,

On 1 November 2013 12:35, Saul Wold s...@linux.intel.com wrote:
 This says what you are doing, but the question is why is the change needed?
 It might be obvious to you, but not to others.  The base-feeds.conf file is
 provided via the a distro configuration, so it's not guarenteed to be there
 for every distro, so I am not sure this change is correct.

 Also for future referece the commit message should follow the commit
 guidelines:

You're right, this patch is messed up.

Thank you for the feedback :-)
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] runtime package management: ipk/opk

2013-11-01 Thread Saul Wold 

On 10/31/2013 09:45 AM, Trevor Woerner wrote:

Place the on-target feed configuration into the base-feeds.conf file instead
of the opkg.conf file.

This says what you are doing, but the question is why is the change 
needed?  It might be obvious to you, but not to others.  The 
base-feeds.conf file is provided via the a distro configuration, so it's 
not guarenteed to be there for every distro, so I am not sure this 
change is correct.


Also for future referece the commit message should follow the commit 
guidelines:


http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Thanks

Sau!


Signed-off-by: Trevor Woerner trevor.woer...@linaro.org
---
  meta/classes/rootfs_ipk.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
index b0805dc..1537af4 100644
--- a/meta/classes/rootfs_ipk.bbclass
+++ b/meta/classes/rootfs_ipk.bbclass
@@ -159,7 +159,7 @@ ipk_insert_feed_uris () {
echo Added $feed_name feed with URL $feed_uri

# insert new feed-sources
-   echo src/gz $feed_name $feed_uri  ${IPKGCONF_TARGET}
+   echo src/gz $feed_name $feed_uri  
${IMAGE_ROOTFS}/${sysconfdir}/opkg/base-feeds.conf
done

# Allow to use package deploy directory contents as quick devel-testing


___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] runtime package management: ipk/opk

2013-10-31 Thread Trevor Woerner 
Place the on-target feed configuration into the base-feeds.conf file instead
of the opkg.conf file.

Signed-off-by: Trevor Woerner trevor.woer...@linaro.org
---
 meta/classes/rootfs_ipk.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
index b0805dc..1537af4 100644
--- a/meta/classes/rootfs_ipk.bbclass
+++ b/meta/classes/rootfs_ipk.bbclass
@@ -159,7 +159,7 @@ ipk_insert_feed_uris () {
echo Added $feed_name feed with URL $feed_uri
 
# insert new feed-sources
-   echo src/gz $feed_name $feed_uri  ${IPKGCONF_TARGET}
+   echo src/gz $feed_name $feed_uri  
${IMAGE_ROOTFS}/${sysconfdir}/opkg/base-feeds.conf
done
 
# Allow to use package deploy directory contents as quick devel-testing
-- 
1.8.1.2

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core