On Thu, Jan 23, 2020 at 3:03 PM Jaewon Lee wrote:
>
> Without the proper default tune in TUNE_FEATURES, certain variables
> won't expand correctly. MACHINEOVERRIDES won't add cortexa72-cortexa53:
> TUNE_CCARGS won't add -mtune=cortexa72.cortexa-53, generating the toolchain
> incorrectly.
> Adding missing 'cortexa72-cortexa53' to both
> TUNE_FEATURES_tune-cortexa72-cortexa53 and
> TUNE_FEATURES_tune-cortexa72-cortexa53-crypto
I can confirm that this patch is required to correctly generate the
tunes for cortexa72-cortexa53... did it get missed for being merged?
>
> Signed-off-by: Jaewon Lee
> Signed-off-by: Alejandro Enedino Hernandez Samaniego
> ---
> meta/conf/machine/include/tune-cortexa72-cortexa53.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> index 0d43531..f208b98 100644
> --- a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> +++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> @@ -14,8 +14,8 @@ TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES",
> "cortexa72-cortexa53", " -
> AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
> ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"
> ARMPKGARCH_tune-cortexa72-cortexa53-crypto = "cortexa72-cortexa53"
> -TUNE_FEATURES_tune-cortexa72-cortexa53 =
> "${TUNE_FEATURES_tune-armv8a-crc}"
> -TUNE_FEATURES_tune-cortexa72-cortexa53-crypto=
> "${TUNE_FEATURES_tune-armv8a-crc-crypto}"
> +TUNE_FEATURES_tune-cortexa72-cortexa53 =
> "${TUNE_FEATURES_tune-armv8a-crc} cortexa72-cortexa53"
> +TUNE_FEATURES_tune-cortexa72-cortexa53-crypto=
> "${TUNE_FEATURES_tune-armv8a-crc-crypto} cortexa72-cortexa53"
> PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 =
> "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc}cortexa72-cortexa53"
> PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto =
> "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72-cortexa53
> cortexa72-cortexa53-crypto"
> BASE_LIB_tune-cortexa72-cortexa53= "lib64"
> --
> 2.7.4
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
