Re: [OE-core] [PATCH] u-boot-fw-utils: Fix cross and target builds

[Otavio Salvador]

On Tue, Sep 19, 2017 at 9:39 AM, Tom Rini  wrote:
> On Tue, Sep 19, 2017 at 08:53:38AM -0300, Otavio Salvador wrote:
>> Em 19 de set de 2017 8:26 AM, "Tom Rini"  escreveu:
>>
>> On Tue, Sep 19, 2017 at 02:40:58AM -0300, Otavio Salvador wrote:
>> >  - The environment tools target has change to envtools;
>> >  - The HOSTCC variable must be used to set CC for cross;
>> >  - The ARCH variable must be set for cross;
>> >
>> > Signed-off-by: Otavio Salvador 
>> > ---
>> >
>> >  meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb | 6 +++---
>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
>> b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
>> > index c2e8f0fb84..21ab5b3e6d 100644
>> > --- a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
>> > +++ b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
>> > @@ -5,13 +5,13 @@ DEPENDS = "mtd-utils"
>> >
>> >  INSANE_SKIP_${PN} = "already-stripped"
>> >  EXTRA_OEMAKE_class-target = 'CROSS_COMPILE=${TARGET_PREFIX} CC="${CC}
>> ${CFLAGS} ${LDFLAGS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}"
>> V=1'
>> > -EXTRA_OEMAKE_class-cross = 'ARCH=${TARGET_ARCH} CC="${CC} ${CFLAGS}
>> ${LDFLAGS}" V=1'
>> > +EXTRA_OEMAKE_class-cross = 'ARCH=${ARCH} HOSTCC="${CC} ${CFLAGS}
>> ${LDFLAGS}" V=0'
>>
>> Since we're messing with this, U-Boot's build system doesn't take ARCH.
>> It's one of the variables that you pick in Kconfig, not set so that
>> arch/$(ARCH)/Kconfig is sourced.  We should drop that.
>>
>>
>> You can't. Try dropping it...
>
> I've never ever built U-Boot with ARCH=, so, what's going on in OE land?

Drop works; it was set wrong. v3 is on the way !!! Thanks to spot it ...


-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] u-boot-fw-utils: Fix cross and target builds

[Tom Rini]

On Tue, Sep 19, 2017 at 08:53:38AM -0300, Otavio Salvador wrote:
> Em 19 de set de 2017 8:26 AM, "Tom Rini"  escreveu:
> 
> On Tue, Sep 19, 2017 at 02:40:58AM -0300, Otavio Salvador wrote:
> >  - The environment tools target has change to envtools;
> >  - The HOSTCC variable must be used to set CC for cross;
> >  - The ARCH variable must be set for cross;
> >
> > Signed-off-by: Otavio Salvador 
> > ---
> >
> >  meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> > index c2e8f0fb84..21ab5b3e6d 100644
> > --- a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> > +++ b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> > @@ -5,13 +5,13 @@ DEPENDS = "mtd-utils"
> >
> >  INSANE_SKIP_${PN} = "already-stripped"
> >  EXTRA_OEMAKE_class-target = 'CROSS_COMPILE=${TARGET_PREFIX} CC="${CC}
> ${CFLAGS} ${LDFLAGS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}"
> V=1'
> > -EXTRA_OEMAKE_class-cross = 'ARCH=${TARGET_ARCH} CC="${CC} ${CFLAGS}
> ${LDFLAGS}" V=1'
> > +EXTRA_OEMAKE_class-cross = 'ARCH=${ARCH} HOSTCC="${CC} ${CFLAGS}
> ${LDFLAGS}" V=0'
> 
> Since we're messing with this, U-Boot's build system doesn't take ARCH.
> It's one of the variables that you pick in Kconfig, not set so that
> arch/$(ARCH)/Kconfig is sourced.  We should drop that.
> 
> 
> You can't. Try dropping it...

I've never ever built U-Boot with ARCH=, so, what's going on in OE land?

-- 
Tom


signature.asc
Description: Digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] u-boot-fw-utils: Fix cross and target builds

[Otavio Salvador]

Em 19 de set de 2017 8:26 AM, "Tom Rini"  escreveu:

On Tue, Sep 19, 2017 at 02:40:58AM -0300, Otavio Salvador wrote:
>  - The environment tools target has change to envtools;
>  - The HOSTCC variable must be used to set CC for cross;
>  - The ARCH variable must be set for cross;
>
> Signed-off-by: Otavio Salvador 
> ---
>
>  meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> index c2e8f0fb84..21ab5b3e6d 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> @@ -5,13 +5,13 @@ DEPENDS = "mtd-utils"
>
>  INSANE_SKIP_${PN} = "already-stripped"
>  EXTRA_OEMAKE_class-target = 'CROSS_COMPILE=${TARGET_PREFIX} CC="${CC}
${CFLAGS} ${LDFLAGS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}"
V=1'
> -EXTRA_OEMAKE_class-cross = 'ARCH=${TARGET_ARCH} CC="${CC} ${CFLAGS}
${LDFLAGS}" V=1'
> +EXTRA_OEMAKE_class-cross = 'ARCH=${ARCH} HOSTCC="${CC} ${CFLAGS}
${LDFLAGS}" V=0'

Since we're messing with this, U-Boot's build system doesn't take ARCH.
It's one of the variables that you pick in Kconfig, not set so that
arch/$(ARCH)/Kconfig is sourced.  We should drop that.


You can't. Try dropping it...

And the
changelog doesn't say you're going from V=1 to V=0.


I sent v2 just after.


--
Tom

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] u-boot-fw-utils: Fix cross and target builds

[Tom Rini]

On Tue, Sep 19, 2017 at 02:40:58AM -0300, Otavio Salvador wrote:
>  - The environment tools target has change to envtools;
>  - The HOSTCC variable must be used to set CC for cross;
>  - The ARCH variable must be set for cross;
> 
> Signed-off-by: Otavio Salvador 
> ---
> 
>  meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb 
> b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> index c2e8f0fb84..21ab5b3e6d 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
> @@ -5,13 +5,13 @@ DEPENDS = "mtd-utils"
>  
>  INSANE_SKIP_${PN} = "already-stripped"
>  EXTRA_OEMAKE_class-target = 'CROSS_COMPILE=${TARGET_PREFIX} CC="${CC} 
> ${CFLAGS} ${LDFLAGS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" 
> V=1'
> -EXTRA_OEMAKE_class-cross = 'ARCH=${TARGET_ARCH} CC="${CC} ${CFLAGS} 
> ${LDFLAGS}" V=1'
> +EXTRA_OEMAKE_class-cross = 'ARCH=${ARCH} HOSTCC="${CC} ${CFLAGS} ${LDFLAGS}" 
> V=0'

Since we're messing with this, U-Boot's build system doesn't take ARCH.
It's one of the variables that you pick in Kconfig, not set so that
arch/$(ARCH)/Kconfig is sourced.  We should drop that.  And the
changelog doesn't say you're going from V=1 to V=0.

-- 
Tom


signature.asc
Description: Digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] u-boot-fw-utils: Fix cross and target builds

[Otavio Salvador]

 - The environment tools target has change to envtools;
 - The HOSTCC variable must be used to set CC for cross;
 - The ARCH variable must be set for cross;

Signed-off-by: Otavio Salvador 
---

 meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb 
b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
index c2e8f0fb84..21ab5b3e6d 100644
--- a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
+++ b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.09.bb
@@ -5,13 +5,13 @@ DEPENDS = "mtd-utils"
 
 INSANE_SKIP_${PN} = "already-stripped"
 EXTRA_OEMAKE_class-target = 'CROSS_COMPILE=${TARGET_PREFIX} CC="${CC} 
${CFLAGS} ${LDFLAGS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" V=1'
-EXTRA_OEMAKE_class-cross = 'ARCH=${TARGET_ARCH} CC="${CC} ${CFLAGS} 
${LDFLAGS}" V=1'
+EXTRA_OEMAKE_class-cross = 'ARCH=${ARCH} HOSTCC="${CC} ${CFLAGS} ${LDFLAGS}" 
V=0'
 
-inherit uboot-config
+inherit kernel-arch uboot-config
 
 do_compile () {
oe_runmake ${UBOOT_MACHINE}
-   oe_runmake env
+   oe_runmake envtools
 }
 
 do_install () {
-- 
2.14.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core