Re: [OE-core] [PATCH] webkitgtk: Enable building for ARC architecture
On Mon, Jan 14, 2019 at 12:45 PM Alexey Brodkin wrote: > > Hi Khem, > > > -Original Message- > > From: Khem Raj [mailto:raj.k...@gmail.com] > > Sent: Friday, January 11, 2019 6:32 PM > > To: Alexey Brodkin > > Cc: Patches and discussions about the oe-core layer > > ; > > Richard Purdie ; Ross Burton > > ; linux-snps- > > a...@lists.infradead.org; Alexander Kanavin ; > > Hongxu Jia > > > > Subject: Re: [PATCH] webkitgtk: Enable building for ARC architecture > > > > On Fri, Jan 11, 2019 at 4:50 AM Alexey Brodkin > > wrote: > > > > > > For that we need 2 things: > > > 1. Disable JIT in JS as it's not supported for ARC. > > > > > > 2. Compile with "-mlong-calls" so relocations with > > > offsets larger than 25 bits are used, otherwise > > > linker fails to link final binaries. > > > > > > Signed-off-by: Alexey Brodkin > > > Cc: Alexander Kanavin > > > Cc: Hongxu Jia > > > --- > > > meta/recipes-sato/webkit/webkitgtk_2.22.5.bb | 7 +++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb b/meta/recipes- > > sato/webkit/webkitgtk_2.22.5.bb > > > index fc56822f7a..56f69c7a30 100644 > > > --- a/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb > > > +++ b/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb > > > @@ -69,6 +69,13 @@ EXTRA_OECMAKE = " \ > > > EXTRA_OECMAKE_append_x86 = " -DUSE_GSTREAMER_GL=OFF " > > > EXTRA_OECMAKE_append_x86-x32 = " -DUSE_GSTREAMER_GL=OFF " > > > > > > +# Javascript JIT is not supported on ARC > > > +EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF " > > > +# By default 25-bit "medium" calls are used on ARC > > > +# which is not enough for binaries larger than 32 MiB > > > +CFLAGS_append_arc = " -mlong-calls" > > > +CXXFLAGS_append_arc = " -mlong-calls" > > > > perhaps adding to CPPFLAGS is going to be enough for both c/c++ cases > > Just tried that (only CPPFLAGS_append_arc = " -mlong-calls") and > I don't see "-mlong-calls" used during compilation at all > (I'm looking at > .../oe/build/tmp-glibc/work/archs-oe-linux/webkitgtk/2.22.5-r0/temp/log.do_compile). > > So I may guess webkitgtk doesn't copy CPPFLAGS to CFLAGS and CXXFLAGS. > yes its possible. Thanks for additional verifications > -Alexey -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] webkitgtk: Enable building for ARC architecture
Hi Khem, > -Original Message- > From: Khem Raj [mailto:raj.k...@gmail.com] > Sent: Friday, January 11, 2019 6:32 PM > To: Alexey Brodkin > Cc: Patches and discussions about the oe-core layer > ; > Richard Purdie ; Ross Burton > ; linux-snps- > a...@lists.infradead.org; Alexander Kanavin ; Hongxu > Jia > > Subject: Re: [PATCH] webkitgtk: Enable building for ARC architecture > > On Fri, Jan 11, 2019 at 4:50 AM Alexey Brodkin > wrote: > > > > For that we need 2 things: > > 1. Disable JIT in JS as it's not supported for ARC. > > > > 2. Compile with "-mlong-calls" so relocations with > > offsets larger than 25 bits are used, otherwise > > linker fails to link final binaries. > > > > Signed-off-by: Alexey Brodkin > > Cc: Alexander Kanavin > > Cc: Hongxu Jia > > --- > > meta/recipes-sato/webkit/webkitgtk_2.22.5.bb | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb b/meta/recipes- > sato/webkit/webkitgtk_2.22.5.bb > > index fc56822f7a..56f69c7a30 100644 > > --- a/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb > > +++ b/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb > > @@ -69,6 +69,13 @@ EXTRA_OECMAKE = " \ > > EXTRA_OECMAKE_append_x86 = " -DUSE_GSTREAMER_GL=OFF " > > EXTRA_OECMAKE_append_x86-x32 = " -DUSE_GSTREAMER_GL=OFF " > > > > +# Javascript JIT is not supported on ARC > > +EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF " > > +# By default 25-bit "medium" calls are used on ARC > > +# which is not enough for binaries larger than 32 MiB > > +CFLAGS_append_arc = " -mlong-calls" > > +CXXFLAGS_append_arc = " -mlong-calls" > > perhaps adding to CPPFLAGS is going to be enough for both c/c++ cases Just tried that (only CPPFLAGS_append_arc = " -mlong-calls") and I don't see "-mlong-calls" used during compilation at all (I'm looking at .../oe/build/tmp-glibc/work/archs-oe-linux/webkitgtk/2.22.5-r0/temp/log.do_compile). So I may guess webkitgtk doesn't copy CPPFLAGS to CFLAGS and CXXFLAGS. -Alexey -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] webkitgtk: Enable building for ARC architecture
On Fri, Jan 11, 2019 at 4:50 AM Alexey Brodkin wrote: > > For that we need 2 things: > 1. Disable JIT in JS as it's not supported for ARC. > > 2. Compile with "-mlong-calls" so relocations with > offsets larger than 25 bits are used, otherwise > linker fails to link final binaries. > > Signed-off-by: Alexey Brodkin > Cc: Alexander Kanavin > Cc: Hongxu Jia > --- > meta/recipes-sato/webkit/webkitgtk_2.22.5.bb | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb > b/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb > index fc56822f7a..56f69c7a30 100644 > --- a/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb > +++ b/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb > @@ -69,6 +69,13 @@ EXTRA_OECMAKE = " \ > EXTRA_OECMAKE_append_x86 = " -DUSE_GSTREAMER_GL=OFF " > EXTRA_OECMAKE_append_x86-x32 = " -DUSE_GSTREAMER_GL=OFF " > > +# Javascript JIT is not supported on ARC > +EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF " > +# By default 25-bit "medium" calls are used on ARC > +# which is not enough for binaries larger than 32 MiB > +CFLAGS_append_arc = " -mlong-calls" > +CXXFLAGS_append_arc = " -mlong-calls" perhaps adding to CPPFLAGS is going to be enough for both c/c++ cases > + > # Javascript JIT is not supported on powerpc > EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF " > EXTRA_OECMAKE_append_powerpc64 = " -DENABLE_JIT=OFF " > -- > 2.16.2 > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] webkitgtk: Enable building for ARC architecture
For that we need 2 things: 1. Disable JIT in JS as it's not supported for ARC. 2. Compile with "-mlong-calls" so relocations with offsets larger than 25 bits are used, otherwise linker fails to link final binaries. Signed-off-by: Alexey Brodkin Cc: Alexander Kanavin Cc: Hongxu Jia --- meta/recipes-sato/webkit/webkitgtk_2.22.5.bb | 7 +++ 1 file changed, 7 insertions(+) diff --git a/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb b/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb index fc56822f7a..56f69c7a30 100644 --- a/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +++ b/meta/recipes-sato/webkit/webkitgtk_2.22.5.bb @@ -69,6 +69,13 @@ EXTRA_OECMAKE = " \ EXTRA_OECMAKE_append_x86 = " -DUSE_GSTREAMER_GL=OFF " EXTRA_OECMAKE_append_x86-x32 = " -DUSE_GSTREAMER_GL=OFF " +# Javascript JIT is not supported on ARC +EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF " +# By default 25-bit "medium" calls are used on ARC +# which is not enough for binaries larger than 32 MiB +CFLAGS_append_arc = " -mlong-calls" +CXXFLAGS_append_arc = " -mlong-calls" + # Javascript JIT is not supported on powerpc EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF " EXTRA_OECMAKE_append_powerpc64 = " -DENABLE_JIT=OFF " -- 2.16.2 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
