Re: [OE-core] [PATCH 0/1] base/license.bbclass: handle multiple INCOMPATIBLE_LICENSEs
On Mon, Nov 19, 2012 at 8:37 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Fri, 2012-11-16 at 11:09 -0800, Andy Ross wrote: On 11/01/2012 11:02 AM, Andy Ross wrote: We hit a problem trying to exclude L/GPLv3 recipes where INCOMPATIBLE_LICENSE could only match exactly one license. The older wildcard syntax had been broken by a more recent SPDX change (specifying a string without a SPDXLICENSEMAP entry could crash), so *GPLv3 wouldn't work. Ping I'd like Beth to comment on this patch and she was out last week. I'm not 100% if she is back this week :/. Sorry about the absence (ELCE/Vacation/Thanksgiving had me out for a while). This patch needs a rebase and a minor bit of whitespace work. I've done some work to make it apply to the current master head and tested it out and it does improve the utility of INCOMPATIBLE_LICENSE quite a bit. I was able to not-create an image with: INCOMPATIBLE_LICENSE += *BSD* INCOMPATIBLE_LICENSE += *GPL* Obviously this would fail, however this does end up excluding all *GPL* and *BSD* licenses. If it's ok with you, Andy, I'll just submit my modifications to your patch. -b Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- Elizabeth Flanagan Yocto Project Build and Release ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/1] base/license.bbclass: handle multiple INCOMPATIBLE_LICENSEs
On 11/28/2012 03:14 PM, Flanagan, Elizabeth wrote: This patch needs a rebase and a minor bit of whitespace work. I've done some work to make it apply to the current master head and tested it out and it does improve the utility of INCOMPATIBLE_LICENSE quite a bit. Hm... AFAICT the content of the patch still seems to apply cleanly with git am on a just-pulled poky (don't have an oe-core tree on this machine) master HEAD. Am I looking at a wrong branch? If it's ok with you, Andy, I'll just submit my modifications to your patch. Fine with me. Andy ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/1] base/license.bbclass: handle multiple INCOMPATIBLE_LICENSEs
On Wed, Nov 28, 2012 at 3:19 PM, Andy Ross andy.r...@windriver.com wrote: On 11/28/2012 03:14 PM, Flanagan, Elizabeth wrote: This patch needs a rebase and a minor bit of whitespace work. I've done some work to make it apply to the current master head and tested it out and it does improve the utility of INCOMPATIBLE_LICENSE quite a bit. Hm... AFAICT the content of the patch still seems to apply cleanly with git am on a just-pulled poky (don't have an oe-core tree on this machine) master HEAD. Am I looking at a wrong branch? Let me recheck. It wasn't applying clean for me but it may be on my end. -b If it's ok with you, Andy, I'll just submit my modifications to your patch. Fine with me. Andy -- Elizabeth Flanagan Yocto Project Build and Release ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/1] base/license.bbclass: handle multiple INCOMPATIBLE_LICENSEs
On Fri, 2012-11-16 at 11:09 -0800, Andy Ross wrote: On 11/01/2012 11:02 AM, Andy Ross wrote: We hit a problem trying to exclude L/GPLv3 recipes where INCOMPATIBLE_LICENSE could only match exactly one license. The older wildcard syntax had been broken by a more recent SPDX change (specifying a string without a SPDXLICENSEMAP entry could crash), so *GPLv3 wouldn't work. Ping I'd like Beth to comment on this patch and she was out last week. I'm not 100% if she is back this week :/. Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/1] base/license.bbclass: handle multiple INCOMPATIBLE_LICENSEs
On 11/01/2012 11:02 AM, Andy Ross wrote: We hit a problem trying to exclude L/GPLv3 recipes where INCOMPATIBLE_LICENSE could only match exactly one license. The older wildcard syntax had been broken by a more recent SPDX change (specifying a string without a SPDXLICENSEMAP entry could crash), so *GPLv3 wouldn't work. Ping ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH 0/1] base/license.bbclass: handle multiple INCOMPATIBLE_LICENSEs
We hit a problem trying to exclude L/GPLv3 recipes where
INCOMPATIBLE_LICENSE could only match exactly one license. The older
wildcard syntax had been broken by a more recent SPDX change
(specifying a string without a SPDXLICENSEMAP entry could crash), so
*GPLv3 wouldn't work.
This fixes that, and extends INCOMPATIBLE_LICENSE to handle a
whitespace-separated list of license strings to exclude (e.g GPLv3
LGPLv3). This is compatible with existing usage because the LICENSE
parsing is already done on whitespace: a pre-existing
INCOMPATIBLE_LICENSE value with whitespace could not have matched
anything in practice.
All other behavior should be unaffected. Note specifically that the
LGPLv2_WHITELIST_${license} variables are used as whitelists for all
licenses (i.e. identically to WHITELIST_... and
HOSTTOOLS_WHITELIST_...). That sounds wrong, but seems to have been
the preexisting behavior. Ideas?
Andy
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
