Re: [OE-core] [PATCH 07/23] libepoxy: enable native/nativesdk variants
On Mon, 14 Jan 2019 at 16:50, Peter Kjellerstedt
wrote:
> Shouldn't this only be done for native/nativesdk? I.e.:
>
> do_install_append_class-native() {
> chrpath --delete ${D}${libdir}/*.so
> }
>
> do_install_append_class-nativesdk() {
> chrpath --delete ${D}${libdir}/*.so
> }
>
> (I also changed the indentation to tabs as I believe that is still
> the official OE-Core standard for shell code in recipes.)
Thanks, I have fixed this now. I'll resend the patchset.
Alex
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 07/23] libepoxy: enable native/nativesdk variants
> -Original Message-
> From: openembedded-core-boun...@lists.openembedded.org core-boun...@lists.openembedded.org> On Behalf Of Alexander Kanavin
> Sent: den 14 januari 2019 16:03
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 07/23] libepoxy: enable native/nativesdk
> variants
>
> libepoxy is a requirement of virglrenderer. Note that we strip
> RPATH from the library, as this allows fall-through to the host
> GL implementation, instead of attempting (and failing) to use
> mesa-native.
>
> Signed-off-by: Alexander Kanavin
> ---
> meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb
> b/meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb
> index 92f644c039d..45995325d2c 100644
> --- a/meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb
> +++ b/meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb
> @@ -14,9 +14,21 @@ UPSTREAM_CHECK_URI =
> "https://github.com/anholt/libepoxy/releases;
> inherit meson pkgconfig distro_features_check
>
> REQUIRED_DISTRO_FEATURES = "opengl"
> +REQUIRED_DISTRO_FEATURES_class-native = ""
> +REQUIRED_DISTRO_FEATURES_class-nativesdk = ""
>
> PACKAGECONFIG[egl] = "-Degl=yes, -Degl=no, virtual/egl"
> PACKAGECONFIG[x11] = "-Dglx=yes, -Dglx=no, virtual/libx11 virtual/libgl"
> PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)} egl"
>
> EXTRA_OEMESON += "-Dtests=false"
> +
> +PACKAGECONFIG_class-native = "egl"
> +PACKAGECONFIG_class-nativesdk = "egl"
> +
> +BBCLASSEXTEND = "native nativesdk"
> +
> +# This will ensure that dlopen will attempt only GL libraries provided by
> host
> +do_install_append () {
> +chrpath --delete ${D}${libdir}/*.so
> +}
Shouldn't this only be done for native/nativesdk? I.e.:
do_install_append_class-native() {
chrpath --delete ${D}${libdir}/*.so
}
do_install_append_class-nativesdk() {
chrpath --delete ${D}${libdir}/*.so
}
(I also changed the indentation to tabs as I believe that is still
the official OE-Core standard for shell code in recipes.)
> --
> 2.17.1
//Peter
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 07/23] libepoxy: enable native/nativesdk variants
libepoxy is a requirement of virglrenderer. Note that we strip
RPATH from the library, as this allows fall-through to the host
GL implementation, instead of attempting (and failing) to use
mesa-native.
Signed-off-by: Alexander Kanavin
---
meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb | 12
1 file changed, 12 insertions(+)
diff --git a/meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb
b/meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb
index 92f644c039d..45995325d2c 100644
--- a/meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb
+++ b/meta/recipes-graphics/libepoxy/libepoxy_1.5.3.bb
@@ -14,9 +14,21 @@ UPSTREAM_CHECK_URI =
"https://github.com/anholt/libepoxy/releases;
inherit meson pkgconfig distro_features_check
REQUIRED_DISTRO_FEATURES = "opengl"
+REQUIRED_DISTRO_FEATURES_class-native = ""
+REQUIRED_DISTRO_FEATURES_class-nativesdk = ""
PACKAGECONFIG[egl] = "-Degl=yes, -Degl=no, virtual/egl"
PACKAGECONFIG[x11] = "-Dglx=yes, -Dglx=no, virtual/libx11 virtual/libgl"
PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)} egl"
EXTRA_OEMESON += "-Dtests=false"
+
+PACKAGECONFIG_class-native = "egl"
+PACKAGECONFIG_class-nativesdk = "egl"
+
+BBCLASSEXTEND = "native nativesdk"
+
+# This will ensure that dlopen will attempt only GL libraries provided by host
+do_install_append () {
+chrpath --delete ${D}${libdir}/*.so
+}
--
2.17.1
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
