Re: [OE-core] [PATCH 1/1] e2fsprogs: 1.42.9 -> 1.43-WIP
> Op 15 jan. 2016, om 03:05 heeft Robert Yanghet > volgende geschreven: > > Upgrade to 1.43-WIP to make "mke2fs -d" support xattr, so that the layer > which requires xattr such as meta-selinux can populate images easily. > > > * Add --enable-libblkid to EXTRA_OECONF since libblkid is not created by > default. *ahem* commit fb8e776ea91c39d586b46400ad30aeea8dead1c4 Author: Richard Purdie Date: Sat Aug 25 16:45:33 2012 +0100 e2fsprogs: Fully remove/disable blkid We've removed libblkid from e2fsprogs as it was being provided by util-linux. The blkid binary is also provided there and providing it within e2fsprogs too, linked against a different and potentially incompatible library we're likely asking for trouble. It also leads to inconsistencies in the native sysroot since we don't consistently get one given provider of blkid (but always the liblibid from util-linux). To clean this up, fully remove/disable the blkid binary and package. Signed-off-by: Richard Purdie And the do_install in the recipe: # We use blkid from util-linux now so remove from here rm -f ${D}${base_libdir}/libblkid* rm -rf ${D}${includedir}/blkid rm -f ${D}${base_libdir}/pkgconfig/blkid.pc rm -f ${D}${base_sbindir}/blkid rm -f ${D}${base_sbindir}/fsck rm -f ${D}${base_sbindir}/findfs -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/1] e2fsprogs: 1.42.9 -> 1.43-WIP
On 01/18/2016 03:31 PM, Patrick Ohly wrote: On Fri, 2016-01-15 at 11:15 +, Richard Purdie wrote: On Thu, 2016-01-14 at 18:05 -0800, Robert Yang wrote: Upgrade to 1.43-WIP to make "mke2fs -d" support xattr, so that the layer which requires xattr such as meta-selinux can populate images easily. * Remove the following patches since they are alredy in the source. 0001-e2fsprogs-fix-cross-compilation-problem.patch 0001-libext2fs-fix-potential-buffer-overflow-in-closefs.patch 0001-mke2fs-add-the-ability-to-copy-files-from-a-given-di.patch 0002-misc-create_inode.c-copy-files-recursively.patch 0003-misc-create_inode.c-create-special-file.patch 0004-misc-create_inode.c-create-symlink.patch 0005-misc-create_inode.c-copy-regular-file.patch 0006-misc-create_inode.c-create-directory.patch 0007-misc-create_inode.c-set-owner-mode-time-for-the-inod.patch 0008-mke2fs.c-add-an-option-d-root-directory.patch 0009-misc-create_inode.c-handle-hardlinks.patch 0010-debugfs-use-the-functions-in-misc-create_inode.c.patch 0011-mke2fs.8.in-update-the-manual-for-the-d-option.patch 0012-Fix-musl-build-failures.patch CVE-2015-0247.patch copy-in-create-hardlinks-with-the-correct-directory-.patch fix-icache.patch misc-mke2fs.c-return-error-when-failed-to-populate-fs.patch * Remove cache_inode.patch since it is not needed any more * Updated mkdir.patch and ptest.patch * Add --enable-libblkid to EXTRA_OECONF since libblkid is not created by default. * Time of core-image-sato-sdk do_rootfs: - Before upgrade real3m18.508s user7m42.088s sys 1m1.984s - After upgrade real3m21.552s user7m38.496s sys 1m0.644s The are nearly the same * The "fsck -fn" shows the image is OK, and also can boot. [YOCTO #8622] Signed-off-by: Robert Yang[...] -SRC_URI[md5sum] = "3f8e41e63b432ba114b33f58674563f7" -SRC_URI[sha256sum] = "2f92ac06e92fa00f2ada3ee67dad012d74d685537527ad1241d82f2d041f2802" +SRCREV = "0f26747167cc9d82df849b0aad387bf824f04544" +PV = "1.43-WIP+git${SRCPV}" What happens when 1.43 is released? 1.43 < 1.43-WIP so we'd have to bump PE. Can we just call this 1.42+1.43-git${SRCPV}? However, that is not a more recent version than the one that was in OE-core before: $ dpkg --compare-versions 1.42+1.43 gt 1.42.9 && echo greater || echo less less As a result, the version upgrade (which is in OE-core master now) became a downgrade as far as distros with stable package feeds are concerned, didn't it? The version for OE-core could have been: 1.42.9+1.43-git${SRCPV} However, I've had a "1.42.9+git${SRCPV}" in meta-intel-iot-security for a while now, and 1.42.9+1.43-git${SRCPV} is considered older than that because of the embedded 1.43. While I understand that external layers should not be something that OE-core needs to be concerned about too much, some consistency still helps. I believe the "1.42.9+git${SRCPV}" string goes back to Ross, so I'd assume that it is not too unusual. Can we perhaps use "1.42.9+git ${SRCPV}" also in OE-core? Then if I'm not mistaken, the magic behind ${SRCPV} will ensure that the final version number will be higher. Maybe use 1.42.13+git${SRCPV} ? Since 1.42.13 is the lastest 1.42 version. // Robert -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/1] e2fsprogs: 1.42.9 -> 1.43-WIP
On Mon, 2016-01-18 at 15:58 +0800, Robert Yang wrote: > > On 01/18/2016 03:31 PM, Patrick Ohly wrote: > > I believe the "1.42.9+git${SRCPV}" string goes back to Ross, so I'd > > assume that it is not too unusual. Can we perhaps use "1.42.9+git > > ${SRCPV}" also in OE-core? Then if I'm not mistaken, the magic behind > > ${SRCPV} will ensure that the final version number will be higher. > > Maybe use 1.42.13+git${SRCPV} ? Since 1.42.13 is the lastest 1.42 version. That would also work. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/1] e2fsprogs: 1.42.9 -> 1.43-WIP
On Fri, 2016-01-15 at 11:15 +, Richard Purdie wrote: > On Thu, 2016-01-14 at 18:05 -0800, Robert Yang wrote: > > Upgrade to 1.43-WIP to make "mke2fs -d" support xattr, so that the > > layer > > which requires xattr such as meta-selinux can populate images easily. > > > > * Remove the following patches since they are alredy in the source. > > 0001-e2fsprogs-fix-cross-compilation-problem.patch > > 0001-libext2fs-fix-potential-buffer-overflow-in-closefs.patch > > 0001-mke2fs-add-the-ability-to-copy-files-from-a-given-di.patch > > 0002-misc-create_inode.c-copy-files-recursively.patch > > 0003-misc-create_inode.c-create-special-file.patch > > 0004-misc-create_inode.c-create-symlink.patch > > 0005-misc-create_inode.c-copy-regular-file.patch > > 0006-misc-create_inode.c-create-directory.patch > > 0007-misc-create_inode.c-set-owner-mode-time-for-the-inod.patch > > 0008-mke2fs.c-add-an-option-d-root-directory.patch > > 0009-misc-create_inode.c-handle-hardlinks.patch > > 0010-debugfs-use-the-functions-in-misc-create_inode.c.patch > > 0011-mke2fs.8.in-update-the-manual-for-the-d-option.patch > > 0012-Fix-musl-build-failures.patch > > CVE-2015-0247.patch > > copy-in-create-hardlinks-with-the-correct-directory-.patch > > fix-icache.patch > > misc-mke2fs.c-return-error-when-failed-to-populate-fs.patch > > > > * Remove cache_inode.patch since it is not needed any more > > > > * Updated mkdir.patch and ptest.patch > > > > * Add --enable-libblkid to EXTRA_OECONF since libblkid is not created > > by > > default. > > > > * Time of core-image-sato-sdk do_rootfs: > > - Before upgrade > > real3m18.508s > > user7m42.088s > > sys 1m1.984s > > > > - After upgrade > > real3m21.552s > > user7m38.496s > > sys 1m0.644s > > > >The are nearly the same > > > > * The "fsck -fn" shows the image is OK, and also can boot. > > > > [YOCTO #8622] > > > > Signed-off-by: Robert Yang> [...] > > > -SRC_URI[md5sum] = "3f8e41e63b432ba114b33f58674563f7" > > -SRC_URI[sha256sum] = > > "2f92ac06e92fa00f2ada3ee67dad012d74d685537527ad1241d82f2d041f2802" > > +SRCREV = "0f26747167cc9d82df849b0aad387bf824f04544" > > +PV = "1.43-WIP+git${SRCPV}" > > What happens when 1.43 is released? 1.43 < 1.43-WIP so we'd have to > bump PE. > > Can we just call this 1.42+1.43-git${SRCPV}? However, that is not a more recent version than the one that was in OE-core before: $ dpkg --compare-versions 1.42+1.43 gt 1.42.9 && echo greater || echo less less As a result, the version upgrade (which is in OE-core master now) became a downgrade as far as distros with stable package feeds are concerned, didn't it? The version for OE-core could have been: 1.42.9+1.43-git${SRCPV} However, I've had a "1.42.9+git${SRCPV}" in meta-intel-iot-security for a while now, and 1.42.9+1.43-git${SRCPV} is considered older than that because of the embedded 1.43. While I understand that external layers should not be something that OE-core needs to be concerned about too much, some consistency still helps. I believe the "1.42.9+git${SRCPV}" string goes back to Ross, so I'd assume that it is not too unusual. Can we perhaps use "1.42.9+git ${SRCPV}" also in OE-core? Then if I'm not mistaken, the magic behind ${SRCPV} will ensure that the final version number will be higher. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/1] e2fsprogs: 1.42.9 -> 1.43-WIP
On 15 January 2016 at 11:15, Richard Purdie < richard.pur...@linuxfoundation.org> wrote: > Can we just call this 1.42+1.43-git${SRCPV}? > I've a branch somewhere which added test cases for each package manager to exercise the ~ codepaths in the package managers (where 1.42 < 1.43~git < 1.43) with "interesting" conclusions: * dpkg works just fine * opkg's version compare logic is reimplemented three times, differently, and the tool for comparing versions from the shell is one of those implementations, at best returns inverted results, and at worse is non-deterministic. * rpm has no way to compare versions from the shell Something else to chip away at during this cycle I guess. Maybe in 2.2 we'll be able to confidently use ~ in versions! Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/1] e2fsprogs: 1.42.9 -> 1.43-WIP
On Thu, 2016-01-14 at 18:05 -0800, Robert Yang wrote: > Upgrade to 1.43-WIP to make "mke2fs -d" support xattr, so that the > layer > which requires xattr such as meta-selinux can populate images easily. > > * Remove the following patches since they are alredy in the source. > 0001-e2fsprogs-fix-cross-compilation-problem.patch > 0001-libext2fs-fix-potential-buffer-overflow-in-closefs.patch > 0001-mke2fs-add-the-ability-to-copy-files-from-a-given-di.patch > 0002-misc-create_inode.c-copy-files-recursively.patch > 0003-misc-create_inode.c-create-special-file.patch > 0004-misc-create_inode.c-create-symlink.patch > 0005-misc-create_inode.c-copy-regular-file.patch > 0006-misc-create_inode.c-create-directory.patch > 0007-misc-create_inode.c-set-owner-mode-time-for-the-inod.patch > 0008-mke2fs.c-add-an-option-d-root-directory.patch > 0009-misc-create_inode.c-handle-hardlinks.patch > 0010-debugfs-use-the-functions-in-misc-create_inode.c.patch > 0011-mke2fs.8.in-update-the-manual-for-the-d-option.patch > 0012-Fix-musl-build-failures.patch > CVE-2015-0247.patch > copy-in-create-hardlinks-with-the-correct-directory-.patch > fix-icache.patch > misc-mke2fs.c-return-error-when-failed-to-populate-fs.patch > > * Remove cache_inode.patch since it is not needed any more > > * Updated mkdir.patch and ptest.patch > > * Add --enable-libblkid to EXTRA_OECONF since libblkid is not created > by > default. > > * Time of core-image-sato-sdk do_rootfs: > - Before upgrade > real3m18.508s > user7m42.088s > sys 1m1.984s > > - After upgrade > real3m21.552s > user7m38.496s > sys 1m0.644s > >The are nearly the same > > * The "fsck -fn" shows the image is OK, and also can boot. > > [YOCTO #8622] > > Signed-off-by: Robert Yang[...] > -SRC_URI[md5sum] = "3f8e41e63b432ba114b33f58674563f7" > -SRC_URI[sha256sum] = > "2f92ac06e92fa00f2ada3ee67dad012d74d685537527ad1241d82f2d041f2802" > +SRCREV = "0f26747167cc9d82df849b0aad387bf824f04544" > +PV = "1.43-WIP+git${SRCPV}" What happens when 1.43 is released? 1.43 < 1.43-WIP so we'd have to bump PE. Can we just call this 1.42+1.43-git${SRCPV}? I agree with moving to this btw, I just don't like the idea of "WIP" in the version string and we need to keep upgrade paths in mind. Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/1] e2fsprogs: 1.42.9 -> 1.43-WIP
On 01/15/2016 07:15 PM, Richard Purdie wrote: On Thu, 2016-01-14 at 18:05 -0800, Robert Yang wrote: Upgrade to 1.43-WIP to make "mke2fs -d" support xattr, so that the layer which requires xattr such as meta-selinux can populate images easily. * Remove the following patches since they are alredy in the source. 0001-e2fsprogs-fix-cross-compilation-problem.patch 0001-libext2fs-fix-potential-buffer-overflow-in-closefs.patch 0001-mke2fs-add-the-ability-to-copy-files-from-a-given-di.patch 0002-misc-create_inode.c-copy-files-recursively.patch 0003-misc-create_inode.c-create-special-file.patch 0004-misc-create_inode.c-create-symlink.patch 0005-misc-create_inode.c-copy-regular-file.patch 0006-misc-create_inode.c-create-directory.patch 0007-misc-create_inode.c-set-owner-mode-time-for-the-inod.patch 0008-mke2fs.c-add-an-option-d-root-directory.patch 0009-misc-create_inode.c-handle-hardlinks.patch 0010-debugfs-use-the-functions-in-misc-create_inode.c.patch 0011-mke2fs.8.in-update-the-manual-for-the-d-option.patch 0012-Fix-musl-build-failures.patch CVE-2015-0247.patch copy-in-create-hardlinks-with-the-correct-directory-.patch fix-icache.patch misc-mke2fs.c-return-error-when-failed-to-populate-fs.patch * Remove cache_inode.patch since it is not needed any more * Updated mkdir.patch and ptest.patch * Add --enable-libblkid to EXTRA_OECONF since libblkid is not created by default. * Time of core-image-sato-sdk do_rootfs: - Before upgrade real3m18.508s user7m42.088s sys 1m1.984s - After upgrade real3m21.552s user7m38.496s sys 1m0.644s The are nearly the same * The "fsck -fn" shows the image is OK, and also can boot. [YOCTO #8622] Signed-off-by: Robert Yang[...] -SRC_URI[md5sum] = "3f8e41e63b432ba114b33f58674563f7" -SRC_URI[sha256sum] = "2f92ac06e92fa00f2ada3ee67dad012d74d685537527ad1241d82f2d041f2802" +SRCREV = "0f26747167cc9d82df849b0aad387bf824f04544" +PV = "1.43-WIP+git${SRCPV}" What happens when 1.43 is released? 1.43 < 1.43-WIP so we'd have to bump PE. Can we just call this 1.42+1.43-git${SRCPV}? Thanks, good idea, updated in the repo: git://git.openembedded.org/openembedded-core-contrib rbt/e2fsprogs http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/e2fsprogs Robert Yang (1): e2fsprogs: 1.42.9 -> 1.43 (master) * Changes: - Use PV = "1.42+1.43-git${SRCPV}" Another thing is that, though we use "1.42+1.43-git${SRCPV}", the rpm name is e2fsprogs-1.42+1.43+git0+0f26747167-r0.aarch64.rpm, note, no "-" in PV, the same to ipk. // Robert I agree with moving to this btw, I just don't like the idea of "WIP" in the version string and we need to keep upgrade paths in mind. Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 1/1] e2fsprogs: 1.42.9 -> 1.43-WIP
Upgrade to 1.43-WIP to make "mke2fs -d" support xattr, so that the layer which requires xattr such as meta-selinux can populate images easily. * Remove the following patches since they are alredy in the source. 0001-e2fsprogs-fix-cross-compilation-problem.patch 0001-libext2fs-fix-potential-buffer-overflow-in-closefs.patch 0001-mke2fs-add-the-ability-to-copy-files-from-a-given-di.patch 0002-misc-create_inode.c-copy-files-recursively.patch 0003-misc-create_inode.c-create-special-file.patch 0004-misc-create_inode.c-create-symlink.patch 0005-misc-create_inode.c-copy-regular-file.patch 0006-misc-create_inode.c-create-directory.patch 0007-misc-create_inode.c-set-owner-mode-time-for-the-inod.patch 0008-mke2fs.c-add-an-option-d-root-directory.patch 0009-misc-create_inode.c-handle-hardlinks.patch 0010-debugfs-use-the-functions-in-misc-create_inode.c.patch 0011-mke2fs.8.in-update-the-manual-for-the-d-option.patch 0012-Fix-musl-build-failures.patch CVE-2015-0247.patch copy-in-create-hardlinks-with-the-correct-directory-.patch fix-icache.patch misc-mke2fs.c-return-error-when-failed-to-populate-fs.patch * Remove cache_inode.patch since it is not needed any more * Updated mkdir.patch and ptest.patch * Add --enable-libblkid to EXTRA_OECONF since libblkid is not created by default. * Time of core-image-sato-sdk do_rootfs: - Before upgrade real3m18.508s user7m42.088s sys 1m1.984s - After upgrade real3m21.552s user7m38.496s sys 1m0.644s The are nearly the same * The "fsck -fn" shows the image is OK, and also can boot. [YOCTO #8622] Signed-off-by: Robert Yang--- meta/recipes-devtools/e2fsprogs/e2fsprogs.inc |8 +- ...1-e2fsprogs-fix-cross-compilation-problem.patch | 55 --- ...-fix-potential-buffer-overflow-in-closefs.patch | 59 --- ...the-ability-to-copy-files-from-a-given-di.patch | 98 ...isc-create_inode.c-copy-files-recursively.patch | 135 -- ...3-misc-create_inode.c-create-special-file.patch | 103 .../0004-misc-create_inode.c-create-symlink.patch | 63 --- ...005-misc-create_inode.c-copy-regular-file.patch | 224 - ...0006-misc-create_inode.c-create-directory.patch | 62 --- ..._inode.c-set-owner-mode-time-for-the-inod.patch | 81 ...8-mke2fs.c-add-an-option-d-root-directory.patch | 168 --- ...0009-misc-create_inode.c-handle-hardlinks.patch | 210 - ...-use-the-functions-in-misc-create_inode.c.patch | 496 ...s.8.in-update-the-manual-for-the-d-option.patch | 43 -- .../e2fsprogs/0012-Fix-musl-build-failures.patch | 54 --- .../e2fsprogs/e2fsprogs/CVE-2015-0247.patch| 58 --- .../e2fsprogs/e2fsprogs/cache_inode.patch | 52 -- ...ate-hardlinks-with-the-correct-directory-.patch | 81 .../e2fsprogs/e2fsprogs/fix-icache.patch | 65 --- ...c-return-error-when-failed-to-populate-fs.patch | 37 -- .../e2fsprogs/e2fsprogs/mkdir.patch| 32 +- .../e2fsprogs/e2fsprogs/ptest.patch| 35 +- .../{e2fsprogs_1.42.9.bb => e2fsprogs_git.bb} | 44 +- 23 files changed, 43 insertions(+), 2220 deletions(-) delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0001-e2fsprogs-fix-cross-compilation-problem.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0001-libext2fs-fix-potential-buffer-overflow-in-closefs.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0001-mke2fs-add-the-ability-to-copy-files-from-a-given-di.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0002-misc-create_inode.c-copy-files-recursively.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0003-misc-create_inode.c-create-special-file.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0004-misc-create_inode.c-create-symlink.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0005-misc-create_inode.c-copy-regular-file.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0006-misc-create_inode.c-create-directory.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0007-misc-create_inode.c-set-owner-mode-time-for-the-inod.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0008-mke2fs.c-add-an-option-d-root-directory.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0009-misc-create_inode.c-handle-hardlinks.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0010-debugfs-use-the-functions-in-misc-create_inode.c.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0011-mke2fs.8.in-update-the-manual-for-the-d-option.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0012-Fix-musl-build-failures.patch delete mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/CVE-2015-0247.patch delete mode 100644