Re: [OE-core] [PATCH 1/1] tar: set acpaths to avoid Argument list too long error

2015-03-12 Thread Richard Purdie
On Thu, 2015-03-12 at 12:16 +, Burton, Ross wrote:
 On 12 March 2015 at 06:14, Robert Yang liezhi.y...@windriver.com
 wrote:
 +acpaths = -I ./m4

 Why does this only happen on tar?  Why is it safe to pass just -I ./m4
 when the detected list that you're overriding is effectively -I ./m4
 -I ./tests?

 Would it be better to just make all include paths relative to ${S}
 when generating the acpaths?

We tried that. Subconfigures break:

http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/classes/autotools.bbclass?id=3c58f92d46e32c40b80575f14e0f6f66c9920c66

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/1] tar: set acpaths to avoid Argument list too long error

2015-03-12 Thread Burton, Ross
On 12 March 2015 at 06:14, Robert Yang liezhi.y...@windriver.com wrote:

 +acpaths = -I ./m4


Why does this only happen on tar?  Why is it safe to pass just -I ./m4 when
the detected list that you're overriding is effectively -I ./m4 -I ./tests?

Would it be better to just make all include paths relative to ${S} when
generating the acpaths?

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/1] tar: set acpaths to avoid Argument list too long error

2015-03-12 Thread Robert Yang



On 03/12/2015 08:16 PM, Burton, Ross wrote:


On 12 March 2015 at 06:14, Robert Yang liezhi.y...@windriver.com
mailto:liezhi.y...@windriver.com wrote:

+acpaths = -I ./m4


Why does this only happen on tar?  Why is it safe to pass just -I ./m4 when the
detected list that you're overriding is effectively -I ./m4 -I ./tests?


Not only tar has this problem, but also other recipes such as coreutils,
because they have many 4 files, but we have fixed that others bfore,
for example:

commit 238e9b54e228b850434f7d503870e86cfb12b775
Author: Robert Yang liezhi.y...@windriver.com
Date:   Sun Sep 15 09:13:12 2013 +

coreutils: set acpaths to avoid Argument list too long error


Now I tested the build in the deep directory again, only found tar
failed, and Chong had made a patch for it.

If we don't set 'acpaths = -I ./m4', then it would use the absolute path,
which would be too long, here is the related code in autotools.bbclass
for acpaths:

acpaths = default
[snip]
ACLOCAL=aclocal --system-acdir=${ACLOCALDIR}/
if [ x${acpaths} = xdefault ]; then
acpaths=
for i in `find ${S} -maxdepth 2 -name \*.m4|grep -v 'aclocal.m4'| \
grep -v 'acinclude.m4' | grep -v 'aclocal-copy' | sed -e 
's,\(.*/\).*$,\1,'|sort -u`; do

acpaths=$acpaths -I $i
done
else
acpaths=${acpaths}
fi

I think it's safe to set acpaths = -I ./m4 as we had done for coreutils.

// Robert



Would it be better to just make all include paths relative to ${S} when
generating the acpaths?

Ross

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH 1/1] tar: set acpaths to avoid Argument list too long error

2015-03-12 Thread Robert Yang
From: Chong Lu chong...@windriver.com

There would be an error when the TMPDIR is long/deep, for example when
len(TMPDIR) = 410 while our supported longest value is 410:

aclocal: error: cannot open xxx
autoreconf: aclocal failed with exit status: 1
ERROR: autoreconf execution failed.

Let aclocal use the relative path for the m4 file rather than the
absolute would fix the problem.

[YOCTO #6138]

Signed-off-by: Chong Lu chong...@windriver.com
Signed-off-by: Robert Yang liezhi.y...@windriver.com
---
 meta/recipes-extended/tar/tar.inc |6 ++
 1 file changed, 6 insertions(+)

diff --git a/meta/recipes-extended/tar/tar.inc 
b/meta/recipes-extended/tar/tar.inc
index fb5db78..de2ed31 100644
--- a/meta/recipes-extended/tar/tar.inc
+++ b/meta/recipes-extended/tar/tar.inc
@@ -10,6 +10,12 @@ inherit autotools gettext texinfo
 
 EXTRA_OECONF += DEFAULT_RMT_DIR=${base_sbindir}
 
+# Let aclocal use the relative path for the m4 file rather than the
+# absolute since tar has a lot of m4 files, otherwise there might
+# be an Argument list too long error when it is built in a long/deep
+# directory.
+acpaths = -I ./m4
+
 EXTRAINSTALL = do_install_extra
 EXTRAINSTALL_class-nativesdk = 
 
-- 
1.7.9.5

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/1] tar: set acpaths to avoid Argument list too long error

2014-05-15 Thread Chong Lu

ping

On 04/09/2014 05:44 PM, Chong Lu wrote:

There would be an error when the TMPDIR is long/deep, for example when
len(TMPDIR) = 410 while our supported longest value is 410:

 aclocal: error: cannot open xxx
 autoreconf: aclocal failed with exit status: 1
 ERROR: autoreconf execution failed.

Let aclocal use the relative path for the m4 file rather than the
absolute would fix the problem.

[YOCTO #6138]

Signed-off-by: Chong Lu chong...@windriver.com
---
  meta/recipes-extended/tar/tar.inc | 6 ++
  1 file changed, 6 insertions(+)

diff --git a/meta/recipes-extended/tar/tar.inc 
b/meta/recipes-extended/tar/tar.inc
index 30a1373..75c3518 100644
--- a/meta/recipes-extended/tar/tar.inc
+++ b/meta/recipes-extended/tar/tar.inc
@@ -10,6 +10,12 @@ inherit autotools gettext
  
  EXTRA_OECONF += DEFAULT_RMT_DIR=${base_sbindir}
  
+# Let aclocal use the relative path for the m4 file rather than the

+# absolute since tar has a lot of m4 files, otherwise there might
+# be an Argument list too long error when it is built in a long/deep
+# directory.
+acpaths = -I ./m4
+
  EXTRAINSTALL = do_install_extra
  EXTRAINSTALL_class-nativesdk = 
  


--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/1] tar: set acpaths to avoid Argument list too long error

2014-04-13 Thread Chong Lu

ping

On 04/09/2014 05:44 PM, Chong Lu wrote:

There would be an error when the TMPDIR is long/deep, for example when
len(TMPDIR) = 410 while our supported longest value is 410:

 aclocal: error: cannot open xxx
 autoreconf: aclocal failed with exit status: 1
 ERROR: autoreconf execution failed.

Let aclocal use the relative path for the m4 file rather than the
absolute would fix the problem.

[YOCTO #6138]

Signed-off-by: Chong Lu chong...@windriver.com
---
  meta/recipes-extended/tar/tar.inc | 6 ++
  1 file changed, 6 insertions(+)

diff --git a/meta/recipes-extended/tar/tar.inc 
b/meta/recipes-extended/tar/tar.inc
index 30a1373..75c3518 100644
--- a/meta/recipes-extended/tar/tar.inc
+++ b/meta/recipes-extended/tar/tar.inc
@@ -10,6 +10,12 @@ inherit autotools gettext
  
  EXTRA_OECONF += DEFAULT_RMT_DIR=${base_sbindir}
  
+# Let aclocal use the relative path for the m4 file rather than the

+# absolute since tar has a lot of m4 files, otherwise there might
+# be an Argument list too long error when it is built in a long/deep
+# directory.
+acpaths = -I ./m4
+
  EXTRAINSTALL = do_install_extra
  EXTRAINSTALL_class-nativesdk = 
  


--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH 1/1] tar: set acpaths to avoid Argument list too long error

2014-04-09 Thread Chong Lu
There would be an error when the TMPDIR is long/deep, for example when
len(TMPDIR) = 410 while our supported longest value is 410:

aclocal: error: cannot open xxx
autoreconf: aclocal failed with exit status: 1
ERROR: autoreconf execution failed.

Let aclocal use the relative path for the m4 file rather than the
absolute would fix the problem.

[YOCTO #6138]

Signed-off-by: Chong Lu chong...@windriver.com
---
 meta/recipes-extended/tar/tar.inc | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/meta/recipes-extended/tar/tar.inc 
b/meta/recipes-extended/tar/tar.inc
index 30a1373..75c3518 100644
--- a/meta/recipes-extended/tar/tar.inc
+++ b/meta/recipes-extended/tar/tar.inc
@@ -10,6 +10,12 @@ inherit autotools gettext
 
 EXTRA_OECONF += DEFAULT_RMT_DIR=${base_sbindir}
 
+# Let aclocal use the relative path for the m4 file rather than the
+# absolute since tar has a lot of m4 files, otherwise there might
+# be an Argument list too long error when it is built in a long/deep
+# directory.
+acpaths = -I ./m4
+
 EXTRAINSTALL = do_install_extra
 EXTRAINSTALL_class-nativesdk = 
 
-- 
1.8.1.2

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core