Re: [OE-core] [PATCH 1/3] toolchain-shar-extract.sh: add a space in the end

2015-08-16 Thread Robert Yang


On 08/15/2015 09:23 AM, Randy MacLeod wrote:

Nit pick on logs...

In the short log:
s/add a space in the end/
  /Add a space after asking a question/

On 2015-08-13 03:37 AM, Robert Yang wrote:

For a clear look when input.

This is a sentence fragment. It will read better if you repeat yourself:

Add a space at the end of a line when asking a question.
This makes it easier to read.


Thanks, I will update it.

// Robert



../Randy


[YOCTO #8089]

Signed-off-by: Robert Yang liezhi.y...@windriver.com
---
  meta/files/toolchain-shar-extract.sh |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/files/toolchain-shar-extract.sh
b/meta/files/toolchain-shar-extract.sh
index 0a33ee8..3a50991 100644
--- a/meta/files/toolchain-shar-extract.sh
+++ b/meta/files/toolchain-shar-extract.sh
@@ -92,11 +92,11 @@ fi

  if [ -e $target_sdk_dir/environment-setup-@REAL_MULTIMACH_TARGET_SYS@ ]; 
then
  echo The directory \$target_sdk_dir\ already contains a SDK for this
architecture.
-printf If you continue, existing files will be overwritten! Proceed[y/N]?
+printf If you continue, existing files will be overwritten! Proceed[y/N]? 


  default_answer=n
  else
-printf You are about to install the SDK to \$target_sdk_dir\.
Proceed[Y/n]?
+printf You are about to install the SDK to \$target_sdk_dir\.
Proceed[Y/n]? 

  default_answer=y
  fi





--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/3] toolchain-shar-extract.sh: add a space in the end

2015-08-14 Thread Randy MacLeod

Nit pick on logs...

In the short log:
s/add a space in the end/
 /Add a space after asking a question/

On 2015-08-13 03:37 AM, Robert Yang wrote:

For a clear look when input.

This is a sentence fragment. It will read better if you repeat yourself:

Add a space at the end of a line when asking a question.
This makes it easier to read.

../Randy


[YOCTO #8089]

Signed-off-by: Robert Yang liezhi.y...@windriver.com
---
  meta/files/toolchain-shar-extract.sh |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/files/toolchain-shar-extract.sh 
b/meta/files/toolchain-shar-extract.sh
index 0a33ee8..3a50991 100644
--- a/meta/files/toolchain-shar-extract.sh
+++ b/meta/files/toolchain-shar-extract.sh
@@ -92,11 +92,11 @@ fi

  if [ -e $target_sdk_dir/environment-setup-@REAL_MULTIMACH_TARGET_SYS@ ]; 
then
echo The directory \$target_sdk_dir\ already contains a SDK for this 
architecture.
-   printf If you continue, existing files will be overwritten! 
Proceed[y/N]?
+   printf If you continue, existing files will be overwritten! Proceed[y/N]? 


default_answer=n
  else
-   printf You are about to install the SDK to \$target_sdk_dir\. 
Proceed[Y/n]?
+   printf You are about to install the SDK to \$target_sdk_dir\. 
Proceed[Y/n]? 

default_answer=y
  fi




--
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH 1/3] toolchain-shar-extract.sh: add a space in the end

2015-08-13 Thread Robert Yang
For a clear look when input.

[YOCTO #8089]

Signed-off-by: Robert Yang liezhi.y...@windriver.com
---
 meta/files/toolchain-shar-extract.sh |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/files/toolchain-shar-extract.sh 
b/meta/files/toolchain-shar-extract.sh
index 0a33ee8..3a50991 100644
--- a/meta/files/toolchain-shar-extract.sh
+++ b/meta/files/toolchain-shar-extract.sh
@@ -92,11 +92,11 @@ fi
 
 if [ -e $target_sdk_dir/environment-setup-@REAL_MULTIMACH_TARGET_SYS@ ]; then
echo The directory \$target_sdk_dir\ already contains a SDK for this 
architecture.
-   printf If you continue, existing files will be overwritten! 
Proceed[y/N]?
+   printf If you continue, existing files will be overwritten! 
Proceed[y/N]? 
 
default_answer=n
 else
-   printf You are about to install the SDK to \$target_sdk_dir\. 
Proceed[Y/n]?
+   printf You are about to install the SDK to \$target_sdk_dir\. 
Proceed[Y/n]? 
 
default_answer=y
 fi
-- 
1.7.9.5

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core