Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-30 Thread Andrei Gherzan 
This commit made pulseaudio unbuildable for builds with no GPLv3 packages.

Andrei


On Wed, Oct 24, 2012 at 7:37 PM, Ross Burton ross.bur...@intel.com wrote:

 Add explicit build-dependency on GConf as currently it's an implicit
 dependency
 and so vunerable to races at build time.

 Signed-off-by: Ross Burton ross.bur...@intel.com
 ---
  meta/recipes-multimedia/pulseaudio/pulseaudio.inc|2 +-
  meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

 diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
 b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
 index 463777d..ab70c7e 100644
 --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
 +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
 @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM =
 file://GPL;md5=4325afd396febcb659c36b49533135d4 \
  DEPENDS = libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool
 \
 ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11
 libxtst libice libsm libxcb gtk+', '', d)}
  # optional
 -DEPENDS += udev alsa-lib glib-2.0 dbus \
 +DEPENDS += udev alsa-lib glib-2.0 dbus gconf \
 ${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '',
 d)}

  SRC_URI = 
 http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
 diff --git 
 a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bbb/meta/recipes-multimedia/pulseaudio/
 pulseaudio_2.1.bb
 index a10b953..d25b424 100644
 --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
 +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
 @@ -1,6 +1,6 @@
  require pulseaudio.inc

 -PR = r7
 +PR = r8

  DEPENDS += libjson gdbm speex libxml-parser-perl-native

 --
 1.7.10


 ___
 Openembedded-core mailing list
 Openembedded-core@lists.openembedded.org
 http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-30 Thread Burton, Ross 
On 30 October 2012 09:59, Andrei Gherzan and...@gherzan.ro wrote:
 This commit made pulseaudio unbuildable for builds with no GPLv3 packages.

What causes gconf to not build without GPLv3?

Ross

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-30 Thread Andrei Gherzan 
On Tue, Oct 30, 2012 at 12:02 PM, Burton, Ross ross.bur...@intel.comwrote:

 On 30 October 2012 09:59, Andrei Gherzan and...@gherzan.ro wrote:
  This commit made pulseaudio unbuildable for builds with no GPLv3
 packages.

 What causes gconf to not build without GPLv3?


pulseaudio depends on gconf (because of that racing issues). Now, gconf
inherits gnomebase which adds to gconf's DEPENDS gnome-common package which
is GPLv3. So this is the chain.

ag
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-30 Thread Burton, Ross 
On 30 October 2012 10:10, Andrei Gherzan and...@gherzan.ro wrote:
 What causes gconf to not build without GPLv3?

 pulseaudio depends on gconf (because of that racing issues). Now, gconf
 inherits gnomebase which adds to gconf's DEPENDS gnome-common package which
 is GPLv3. So this is the chain.

Oh joy, one of those instances where GPLv3 isn't actually a problem.

gnome-common is some scripts and tools used at configure time, so
there isn't any linkage, so there isn't any GPLv3 in the images, so
there isn't a problem.

The question is how do we express this?

Ross

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-30 Thread Andrei Gherzan 
On Tue, Oct 30, 2012 at 12:19 PM, Burton, Ross ross.bur...@intel.comwrote:

 On 30 October 2012 10:10, Andrei Gherzan and...@gherzan.ro wrote:
  What causes gconf to not build without GPLv3?
 
  pulseaudio depends on gconf (because of that racing issues). Now, gconf
  inherits gnomebase which adds to gconf's DEPENDS gnome-common package
 which
  is GPLv3. So this is the chain.

 Oh joy, one of those instances where GPLv3 isn't actually a problem.

 gnome-common is some scripts and tools used at configure time, so
 there isn't any linkage, so there isn't any GPLv3 in the images, so
 there isn't a problem.

 The question is how do we express this?


Should it be whitelisted?
ag
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-30 Thread Tomas Frydrych 
On 30/10/12 10:31, Andrei Gherzan wrote:
 gnome-common is some scripts and tools used at configure time, so
 there isn't any linkage, so there isn't any GPLv3 in the images, so
 there isn't a problem.

 The question is how do we express this?


 Should it be whitelisted?

The problem with whitelisting is that if the usage changes from the
assumptions the whitelisting was originally made on, this will not
automatically remove the whitelisting -- if whitlisting is the solution
here, it needs to be left to the Yocto users to do it locally based on
their own review of the situation.

I think to handle this scenario properly, you would need two sets of
license controls, one for 'build tools' and one for 'things that ship'.

Tomas

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-30 Thread Burton, Ross 
On 30 October 2012 10:31, Andrei Gherzan and...@gherzan.ro wrote:
 Oh joy, one of those instances where GPLv3 isn't actually a problem.

 gnome-common is some scripts and tools used at configure time, so
 there isn't any linkage, so there isn't any GPLv3 in the images, so
 there isn't a problem.

 The question is how do we express this?

 Should it be whitelisted?

So I did some digging.  The file in git that is explicitly v3 only
appeared in 3.6, so I considered reverting to 3.5.5 before it
appeared.  Then I noticed that we're still shipping gnome-common 2.28
from 2009, which doesn't have any v3 code in (to be honest it barely
has any license at all, but it's definitely not v3.  I've pinged
upstream.

The v3 license in the metadata came from:

commit 8a2b4e2a5e85f4937e72f03e579b1aaa264074a1
Author: Zhai Edwin edwin.z...@intel.com
Date:   Thu Jul 1 15:35:11 2010 +0800

gnome-common: Fix the metadata

Signed-off-by: Zhai Edwin edwin.z...@intel.com

diff --git a/meta/packages/gnome/gnome-common_2.20.0.bb
b/meta/packages/gnome/gnome-common_2.20.0.bb
index 075ac14..c2eae72 100644
--- a/meta/packages/gnome/gnome-common_2.20.0.bb
+++ b/meta/packages/gnome/gnome-common_2.20.0.bb
@@ -1,7 +1,11 @@
-LICENSE = GPL
+DESCRIPTION = Common macros for building GNOME applications
+HOMEPAGE = http://www.gnome.org/;
+BUGTRACKER = https://bugzilla.gnome.org/;
+
+LICENSE = GPLv3

Looks like a misguided attempt at fixing a warning from not specifying
what version of GPL was in use.  Traditionally the bulk of GNOME is
LGPLv2.1

But following the dependencies, gnomebase adds DEPENDS=gnome-common.
Shouldn't that be gnome-common-native?  It won't make much difference
to the structure of the sysroot as it's allarch already, but it makes
it clear that in this instance it's a build dependency only.

(patch coming)

Ross

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-30 Thread Koen Kooi 

Op 30 okt. 2012, om 12:00 heeft Burton, Ross ross.bur...@intel.com het 
volgende geschreven:

 On 30 October 2012 10:31, Andrei Gherzan and...@gherzan.ro wrote:
 Oh joy, one of those instances where GPLv3 isn't actually a problem.
 
 gnome-common is some scripts and tools used at configure time, so
 there isn't any linkage, so there isn't any GPLv3 in the images, so
 there isn't a problem.
 
 The question is how do we express this?
 
 Should it be whitelisted?
 
 So I did some digging.  The file in git that is explicitly v3 only
 appeared in 3.6, so I considered reverting to 3.5.5 before it
 appeared.  Then I noticed that we're still shipping gnome-common 2.28
 from 2009, which doesn't have any v3 code in (to be honest it barely
 has any license at all, but it's definitely not v3.  I've pinged
 upstream.
 
 The v3 license in the metadata came from:
 
 commit 8a2b4e2a5e85f4937e72f03e579b1aaa264074a1
 Author: Zhai Edwin edwin.z...@intel.com
 Date:   Thu Jul 1 15:35:11 2010 +0800
 
gnome-common: Fix the metadata
 
Signed-off-by: Zhai Edwin edwin.z...@intel.com
 
 diff --git a/meta/packages/gnome/gnome-common_2.20.0.bb
 b/meta/packages/gnome/gnome-common_2.20.0.bb
 index 075ac14..c2eae72 100644
 --- a/meta/packages/gnome/gnome-common_2.20.0.bb
 +++ b/meta/packages/gnome/gnome-common_2.20.0.bb
 @@ -1,7 +1,11 @@
 -LICENSE = GPL
 +DESCRIPTION = Common macros for building GNOME applications
 +HOMEPAGE = http://www.gnome.org/;
 +BUGTRACKER = https://bugzilla.gnome.org/;
 +
 +LICENSE = GPLv3
 
 Looks like a misguided attempt at fixing a warning from not specifying
 what version of GPL was in use.  Traditionally the bulk of GNOME is
 LGPLv2.1
 
 But following the dependencies, gnomebase adds DEPENDS=gnome-common.
 Shouldn't that be gnome-common-native?  

No, it checks for the files in the target sysroot. I can't say it that's a bug 
or not, though.

regards,

Koen
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-27 Thread Saul Wold 

On 10/24/2012 09:37 AM, Ross Burton wrote:

Add explicit build-dependency on GConf as currently it's an implicit dependency
and so vunerable to races at build time.

Signed-off-by: Ross Burton ross.bur...@intel.com
---
  meta/recipes-multimedia/pulseaudio/pulseaudio.inc|2 +-
  meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc 
b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 463777d..ab70c7e 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = 
file://GPL;md5=4325afd396febcb659c36b49533135d4 \
  DEPENDS = libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool \
 ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxtst 
libice libsm libxcb gtk+', '', d)}
  # optional
-DEPENDS += udev alsa-lib glib-2.0 dbus \
+DEPENDS += udev alsa-lib glib-2.0 dbus gconf \
 ${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}

  SRC_URI = 
http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb 
b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
index a10b953..d25b424 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
@@ -1,6 +1,6 @@
  require pulseaudio.inc

-PR = r7
+PR = r8

  DEPENDS += libjson gdbm speex libxml-parser-perl-native




Merged this full set to OE-Core

Thanks
Sau!


___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

[OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-24 Thread Ross Burton 
Add explicit build-dependency on GConf as currently it's an implicit dependency
and so vunerable to races at build time.

Signed-off-by: Ross Burton ross.bur...@intel.com
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc|2 +-
 meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc 
b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 463777d..ab70c7e 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = 
file://GPL;md5=4325afd396febcb659c36b49533135d4 \
 DEPENDS = libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool \
${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxtst 
libice libsm libxcb gtk+', '', d)}
 # optional
-DEPENDS += udev alsa-lib glib-2.0 dbus \
+DEPENDS += udev alsa-lib glib-2.0 dbus gconf \
${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}
 
 SRC_URI = 
http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb 
b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
index a10b953..d25b424 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
@@ -1,6 +1,6 @@
 require pulseaudio.inc
 
-PR = r7
+PR = r8
 
 DEPENDS += libjson gdbm speex libxml-parser-perl-native
 
-- 
1.7.10


___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-24 Thread Martin Jansa 
On Wed, Oct 24, 2012 at 05:37:33PM +0100, Ross Burton wrote:
 Add explicit build-dependency on GConf as currently it's an implicit 
 dependency
 and so vunerable to races at build time.

Isn't better to inherit gconf or the issue I had today with foxtrotgps
does not apply here?

 Signed-off-by: Ross Burton ross.bur...@intel.com
 ---
  meta/recipes-multimedia/pulseaudio/pulseaudio.inc|2 +-
  meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc 
 b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
 index 463777d..ab70c7e 100644
 --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
 +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
 @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = 
 file://GPL;md5=4325afd396febcb659c36b49533135d4 \
  DEPENDS = libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool \
 ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 
 libxtst libice libsm libxcb gtk+', '', d)}
  # optional
 -DEPENDS += udev alsa-lib glib-2.0 dbus \
 +DEPENDS += udev alsa-lib glib-2.0 dbus gconf \
 ${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', 
 d)}
  
  SRC_URI = 
 http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
 diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb 
 b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
 index a10b953..d25b424 100644
 --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
 +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
 @@ -1,6 +1,6 @@
  require pulseaudio.inc
  
 -PR = r7
 +PR = r8
  
  DEPENDS += libjson gdbm speex libxml-parser-perl-native
  
 -- 
 1.7.10
 
 
 ___
 Openembedded-core mailing list
 Openembedded-core@lists.openembedded.org
 http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com


signature.asc
Description: Digital signature
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/4] pulseaudio: add GConf dependency

2012-10-24 Thread Burton, Ross 
On 24 October 2012 19:09, Martin Jansa martin.ja...@gmail.com wrote:
 On Wed, Oct 24, 2012 at 05:37:33PM +0100, Ross Burton wrote:
 Add explicit build-dependency on GConf as currently it's an implicit 
 dependency
 and so vunerable to races at build time.

 Isn't better to inherit gconf or the issue I had today with foxtrotgps
 does not apply here?

This just links to gconf, no schemas.

Ross

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core