Re: [OE-core] [PATCH 2/2] oeqa/runexported: Removed DEPLOY_DIR as mandatory.

[Christopher Larson]

On Wed, Sep 23, 2015 at 2:02 AM, Lucian Musat 
wrote:

> We don't need DEPLOY_DIR for every runtime test so there is no
> need for it to be mandatory.
>
> Signed-off-by: Lucian Musat 
> ---
>  meta/lib/oeqa/runexported.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/runexported.py b/meta/lib/oeqa/runexported.py
> index 96442b1..7d68965 100755
> --- a/meta/lib/oeqa/runexported.py
> +++ b/meta/lib/oeqa/runexported.py
> @@ -112,7 +112,7 @@ def main():
>  d["DEPLOY_DIR"] = options.deploy_dir
>  else:
>  if not os.path.isdir(d["DEPLOY_DIR"]):
> -raise Exception("The path to DEPLOY_DIR does not exists: %s"
> % d["DEPLOY_DIR"])
> +print "WARNING: The path to DEPLOY_DIR does not exist: %s" %
> d["DEPLOY_DIR"]
>

First, we generally use loggers / the bb messaging commands instead of
print. Assuming that's not appropriate here for some reason, at least use
the print function, not the print command, to make the python more forward
portable. The command no longer works in future versions of python.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] oeqa/runexported: Removed DEPLOY_DIR as mandatory.

[Musat, George L]

From: kerg...@gmail.com [mailto:kerg...@gmail.com] On Behalf Of Christopher 
Larson
Sent: Wednesday, September 23, 2015 6:12 PM
To: Musat, George L
Cc: Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH 2/2] oeqa/runexported: Removed DEPLOY_DIR as 
mandatory.

Sorry, didn’t know that. Cannot use bb here because the test export system is 
outside the bitbake environment. Will send v2 of the patch with the print 
function.

On Wed, Sep 23, 2015 at 2:02 AM, Lucian Musat 
<george.l.mu...@intel.com<mailto:george.l.mu...@intel.com>> wrote:
We don't need DEPLOY_DIR for every runtime test so there is no
need for it to be mandatory.

Signed-off-by: Lucian Musat 
<george.l.mu...@intel.com<mailto:george.l.mu...@intel.com>>
---
 meta/lib/oeqa/runexported.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/runexported.py b/meta/lib/oeqa/runexported.py
index 96442b1..7d68965 100755
--- a/meta/lib/oeqa/runexported.py
+++ b/meta/lib/oeqa/runexported.py
@@ -112,7 +112,7 @@ def main():
 d["DEPLOY_DIR"] = options.deploy_dir
 else:
 if not os.path.isdir(d["DEPLOY_DIR"]):
-raise Exception("The path to DEPLOY_DIR does not exists: %s" % 
d["DEPLOY_DIR"])
+print "WARNING: The path to DEPLOY_DIR does not exist: %s" % 
d["DEPLOY_DIR"]

First, we generally use loggers / the bb messaging commands instead of print. 
Assuming that's not appropriate here for some reason, at least use the print 
function, not the print command, to make the python more forward portable. The 
command no longer works in future versions of python.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 2/2] oeqa/runexported: Removed DEPLOY_DIR as mandatory.

[Lucian Musat]

We don't need DEPLOY_DIR for every runtime test so there is no
need for it to be mandatory.

Signed-off-by: Lucian Musat 
---
 meta/lib/oeqa/runexported.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/runexported.py b/meta/lib/oeqa/runexported.py
index 96442b1..7d68965 100755
--- a/meta/lib/oeqa/runexported.py
+++ b/meta/lib/oeqa/runexported.py
@@ -112,7 +112,7 @@ def main():
 d["DEPLOY_DIR"] = options.deploy_dir
 else:
 if not os.path.isdir(d["DEPLOY_DIR"]):
-raise Exception("The path to DEPLOY_DIR does not exists: %s" % 
d["DEPLOY_DIR"])
+print "WARNING: The path to DEPLOY_DIR does not exist: %s" % 
d["DEPLOY_DIR"]
 
 
 target = FakeTarget(d)
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core