Re: [OE-core] [PATCH 2/2] sysklogd.inc: Check for package-management in IMAGE_FEATURES

2011-06-10 Thread Koen Kooi 

Op 10 jun 2011, om 02:57 heeft Khem Raj het volgende geschreven:

 ONLINE_PACKAGE_MANAGEMENT does not exist on oe-core
 
 Signed-off-by: Khem Raj raj.k...@gmail.com
 ---
 meta/recipes-extended/sysklogd/sysklogd.inc |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/meta/recipes-extended/sysklogd/sysklogd.inc 
 b/meta/recipes-extended/sysklogd/sysklogd.inc
 index f2b1c15..f6a56ec 100644
 --- a/meta/recipes-extended/sysklogd/sysklogd.inc
 +++ b/meta/recipes-extended/sysklogd/sysklogd.inc
 @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = 
 file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
 # syslog initscript is handled explicitly because order of
 # update-rc.d and update-alternatives is important (see below)
 DEPENDS_append =  update-rc.d update-rc.d-native
 -RDEPENDS_${PN}_append =  ${@base_conditional(ONLINE_PACKAGE_MANAGEMENT, 
 none, , update-rc.d, d)}
 +RDEPENDS_${PN}_append =  ${@oe.utils.contains(IMAGE_FEATURES, 
 package-management, update-rc.d, , d)}

You can't do IMAGE_FEATURES in RDEPENDS, consider what happens when I build 2 
images, one with package-management and one without. Phils changes to catch 
update-rc.d usage in the image* classes should be enough to fix this.

regards,

Koen
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] sysklogd.inc: Check for package-management in IMAGE_FEATURES

2011-06-10 Thread Phil Blundell 
On Thu, 2011-06-09 at 17:57 -0700, Khem Raj wrote:
 -RDEPENDS_${PN}_append =  ${@base_conditional(ONLINE_PACKAGE_MANAGEMENT, 
 none, , update-rc.d, d)}
 +RDEPENDS_${PN}_append =  ${@oe.utils.contains(IMAGE_FEATURES, 
 package-management, update-rc.d, , d)}

This sort of thing shouldn't be necessary in oe-core.  See previous
discussions between me and Richard as to why IMAGE_FEATURES is not the
right thing, and code in package_ipk.bbclass which ought to be taking
care of it.  If you're using a different package manager then it should
be fairly straightforward to adapt that logic to suit.

You're right though the the reference to O_P_M is clearly wrong and
should be removed.  I'm not quite sure how that got in there in the
first place; must have been some oversight during patch review I guess.

p.



___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core