Re: [OE-core] [PATCH 3/5] default-distrovars.inc: add vfat to DISTRO_FEATURES
Sorry but certainly no. It’s already hard enough to make ptests pass with just
the one standard configuration tested by the autobuilder. I still have a
handful of components with cryptic failures left to fix, so if you can help
with valgrind, mdadm or lttng failures I’d appreciate that.
If you want parted test suite to handle things gracefully when vfat is absent,
work with parted upstream to make it happen.
Alex
> On 23 Jan 2020, at 21.15, André Draszik wrote:
>
> Hi,
>
>> On Thu, 2020-01-23 at 18:34 +0100, Alexander Kanavin wrote:
>> This is beneficial for parted ptests in particular, as
>> they expect vfat functionality to work.
>
> Could you also update the parted ptests to skip or delete those
> tests that depend on vfat, please? I.e. when the DISTRO_FEATURE
> is not enabled.
>
> For the benefit of those people that don't need / want vfat, but
> still want to ensure that parted works by running the ptests.
>
> Is that feasible?
>
>
> Cheers,
> Andre'
>
>>
>> Signed-off-by: Alexander Kanavin
>> ---
>> meta/conf/distro/include/default-distrovars.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/conf/distro/include/default-distrovars.inc
>> b/meta/conf/distro/include/default-distrovars.inc
>> index 10d86cf7b17..433d4b6651d 100644
>> --- a/meta/conf/distro/include/default-distrovars.inc
>> +++ b/meta/conf/distro/include/default-distrovars.inc
>> @@ -10,7 +10,7 @@ LOCALE_UTF8_ONLY ?= "0"
>> LOCALE_UTF8_IS_DEFAULT ?= "1"
>> LOCALE_UTF8_IS_DEFAULT_class-nativesdk = "0"
>>
>> -DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth ext2 ipv4 ipv6
>> largefile pcmcia usbgadget usbhost wifi xattr nfs
>> zeroconf pci 3g nfc x11"
>> +DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth ext2 ipv4 ipv6
>> largefile pcmcia usbgadget usbhost wifi xattr nfs
>> zeroconf pci 3g nfc x11 vfat"
>> DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT}"
>> IMAGE_FEATURES ?= ""
>>
>> --
>> 2.17.1
>>
>
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 3/5] default-distrovars.inc: add vfat to DISTRO_FEATURES
Hi,
On Thu, 2020-01-23 at 18:34 +0100, Alexander Kanavin wrote:
> This is beneficial for parted ptests in particular, as
> they expect vfat functionality to work.
Could you also update the parted ptests to skip or delete those
tests that depend on vfat, please? I.e. when the DISTRO_FEATURE
is not enabled.
For the benefit of those people that don't need / want vfat, but
still want to ensure that parted works by running the ptests.
Is that feasible?
Cheers,
Andre'
>
> Signed-off-by: Alexander Kanavin
> ---
> meta/conf/distro/include/default-distrovars.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/distro/include/default-distrovars.inc
> b/meta/conf/distro/include/default-distrovars.inc
> index 10d86cf7b17..433d4b6651d 100644
> --- a/meta/conf/distro/include/default-distrovars.inc
> +++ b/meta/conf/distro/include/default-distrovars.inc
> @@ -10,7 +10,7 @@ LOCALE_UTF8_ONLY ?= "0"
> LOCALE_UTF8_IS_DEFAULT ?= "1"
> LOCALE_UTF8_IS_DEFAULT_class-nativesdk = "0"
>
> -DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth ext2 ipv4 ipv6 largefile
> pcmcia usbgadget usbhost wifi xattr nfs
> zeroconf pci 3g nfc x11"
> +DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth ext2 ipv4 ipv6 largefile
> pcmcia usbgadget usbhost wifi xattr nfs
> zeroconf pci 3g nfc x11 vfat"
> DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT}"
> IMAGE_FEATURES ?= ""
>
> --
> 2.17.1
>
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 3/5] default-distrovars.inc: add vfat to DISTRO_FEATURES
This is beneficial for parted ptests in particular, as
they expect vfat functionality to work.
Signed-off-by: Alexander Kanavin
---
meta/conf/distro/include/default-distrovars.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/conf/distro/include/default-distrovars.inc
b/meta/conf/distro/include/default-distrovars.inc
index 10d86cf7b17..433d4b6651d 100644
--- a/meta/conf/distro/include/default-distrovars.inc
+++ b/meta/conf/distro/include/default-distrovars.inc
@@ -10,7 +10,7 @@ LOCALE_UTF8_ONLY ?= "0"
LOCALE_UTF8_IS_DEFAULT ?= "1"
LOCALE_UTF8_IS_DEFAULT_class-nativesdk = "0"
-DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth ext2 ipv4 ipv6 largefile
pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11"
+DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth ext2 ipv4 ipv6 largefile
pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat"
DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT}"
IMAGE_FEATURES ?= ""
--
2.17.1
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
