[OE-core] [PATCH 6/6] perf: drop the rdep on man
From: Christopher Larson It's not common practice to make -doc rdep on man when man pages are included, and doing so prevents the recipe from building for non-gplv3 Signed-off-by: Christopher Larson --- meta/recipes-kernel/perf/perf.bb | 1 - 1 file changed, 1 deletion(-) diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb index 51f5597eb92..5e710f61834 100644 --- a/meta/recipes-kernel/perf/perf.bb +++ b/meta/recipes-kernel/perf/perf.bb @@ -239,7 +239,6 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" RDEPENDS_${PN} += "elfutils bash" -RDEPENDS_${PN}-doc += "man" RDEPENDS_${PN}-archive =+ "bash" RDEPENDS_${PN}-python =+ "bash python python-modules ${@bb.utils.contains('PACKAGECONFIG', 'audit', 'audit-python', '', d)}" RDEPENDS_${PN}-perl =+ "bash perl perl-modules" -- 2.11.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 6/6] perf: drop the rdep on man
On Fri, 2018-06-22 at 02:07 +0500, Christopher Larson wrote: > From: Christopher Larson > > It's not common practice to make -doc rdep on man when man pages are > included, and doing so prevents the recipe from building for non- > gplv3 > > Signed-off-by: Christopher Larson > --- > meta/recipes-kernel/perf/perf.bb | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes- > kernel/perf/perf.bb > index 51f5597eb92..5e710f61834 100644 > --- a/meta/recipes-kernel/perf/perf.bb > +++ b/meta/recipes-kernel/perf/perf.bb > @@ -239,7 +239,6 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" > PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" > > RDEPENDS_${PN} += "elfutils bash" > -RDEPENDS_${PN}-doc += "man" > RDEPENDS_${PN}-archive =+ "bash" > RDEPENDS_${PN}-python =+ "bash python python-modules ${@bb.utils.con > tains('PACKAGECONFIG', 'audit', 'audit-python', '', d)}" > RDEPENDS_${PN}-perl =+ "bash perl perl-modules" We're certainly not consistent but: http://git.yoctoproject.org/cgit.cgi/poky/tree/meta/classes/manpages.bbclass#n13 RDEPENDS_${MAN_PKG} += "${@bb.utils.contains('PACKAGECONFIG', 'manpages', 'man-db', '', d)}" man-db is gplv2 too... Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 6/6] perf: drop the rdep on man
On Fri, Jun 22, 2018 at 12:36 AM Richard Purdie < richard.pur...@linuxfoundation.org> wrote: > On Fri, 2018-06-22 at 02:07 +0500, Christopher Larson wrote: > > From: Christopher Larson > > > > It's not common practice to make -doc rdep on man when man pages are > > included, and doing so prevents the recipe from building for non- > > gplv3 > > > > Signed-off-by: Christopher Larson > > --- > > meta/recipes-kernel/perf/perf.bb | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes- > > kernel/perf/perf.bb > > index 51f5597eb92..5e710f61834 100644 > > --- a/meta/recipes-kernel/perf/perf.bb > > +++ b/meta/recipes-kernel/perf/perf.bb > > @@ -239,7 +239,6 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" > > PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" > > > > RDEPENDS_${PN} += "elfutils bash" > > -RDEPENDS_${PN}-doc += "man" > > RDEPENDS_${PN}-archive =+ "bash" > > RDEPENDS_${PN}-python =+ "bash python python-modules ${@bb.utils.con > > tains('PACKAGECONFIG', 'audit', 'audit-python', '', d)}" > > RDEPENDS_${PN}-perl =+ "bash perl perl-modules" > > We're certainly not consistent but: > > > http://git.yoctoproject.org/cgit.cgi/poky/tree/meta/classes/manpages.bbclass#n13 > > RDEPENDS_${MAN_PKG} += "${@bb.utils.contains('PACKAGECONFIG', 'manpages', > 'man-db', '', d)}" > > man-db is gplv2 too... > Ah, well spotted, I didn't know about that one. If that's the case, I'll drop this patch and rework both it and manpages.bbclass to make the rdep conditional on license compatibility. Thanks! -- Christopher Larson kergoth at gmail dot com Founder - BitBake, OpenEmbedded, OpenZaurus Senior Software Engineer, Mentor Graphics -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core