Re: [OE-core] [PATCH V2 1/4] pam_systemd: Include missing.h for secure_getenv

2019-05-29 Thread Richard Purdie 
On Mon, 2019-05-27 at 09:45 -0700, Khem Raj wrote:
> ping^1 for the whole series ..

The maintainers entry disappeared in the second version of the patch
and the series is generally confused in my inbox.

I also have doubts about whether the elfutils changes give functional
binaries which are useful on musl systems.

Could you resend the series please?

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH V2 1/4] pam_systemd: Include missing.h for secure_getenv

2019-05-27 Thread Khem Raj 
ping^1 for the whole series ..

On Wed, May 22, 2019 at 4:40 PM Khem Raj  wrote:
>
> 'secure_getenv' api is not uniformly implemented across all C libraries
> therefore its good to include missing.h so it can use the alternative
> implementation where its not awvailable
>
> Fixes
> ../git/src/login/pam_systemd.c:344:13: error: implicit declaration of 
> function 'secure_getenv' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
> v = secure_getenv(key);
>
> Signed-off-by: Khem Raj 
> ---
> v2: Rebased
>
>  ...missing.h-check-for-missing-strndupa.patch | 71 +++
>  1 file changed, 10 insertions(+), 61 deletions(-)
>
> diff --git 
> a/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
>  
> b/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
> index a2e25a97df..df1043b27d 100644
> --- 
> a/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
> +++ 
> b/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
> @@ -43,8 +43,6 @@ Signed-off-by: Andrej Valek 
>   src/udev/udev-rules.c  |  1 +
>   29 files changed, 40 insertions(+)
>
> -diff --git a/meson.build b/meson.build
> -index 79195c9..80d9564 100644
>  --- a/meson.build
>  +++ b/meson.build
>  @@ -572,6 +572,7 @@ foreach ident : [
> @@ -55,8 +53,6 @@ index 79195c9..80d9564 100644
>   ]
>
>   have = cc.has_function(ident[0], prefix : ident[1], args : 
> '-D_GNU_SOURCE')
> -diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c
> -index dfd6805..c2b2ace 100644
>  --- a/src/backlight/backlight.c
>  +++ b/src/backlight/backlight.c
>  @@ -17,6 +17,7 @@
> @@ -67,8 +63,6 @@ index dfd6805..c2b2ace 100644
>
>   static int find_pci_or_platform_parent(sd_device *device, sd_device **ret) {
>   const char *subsystem, *sysname, *value;
> -diff --git a/src/basic/env-util.c b/src/basic/env-util.c
> -index fd449dc..e2b0722 100644
>  --- a/src/basic/env-util.c
>  +++ b/src/basic/env-util.c
>  @@ -16,6 +16,7 @@
> @@ -79,8 +73,6 @@ index fd449dc..e2b0722 100644
>
>   #define VALID_CHARS_ENV_NAME\
>   DIGITS LETTERS  \
> -diff --git a/src/basic/missing_stdlib.h b/src/basic/missing_stdlib.h
> -index 188a8d4..1e16ec2 100644
>  --- a/src/basic/missing_stdlib.h
>  +++ b/src/basic/missing_stdlib.h
>  @@ -11,3 +11,15 @@
> @@ -99,8 +91,6 @@ index 188a8d4..1e16ec2 100644
>  +(char *)memcpy(__new, __old, __len); \
>  +  })
>  +#endif
> -diff --git a/src/basic/mkdir.c b/src/basic/mkdir.c
> -index 6b82eab..51c6b78 100644
>  --- a/src/basic/mkdir.c
>  +++ b/src/basic/mkdir.c
>  @@ -14,6 +14,7 @@
> @@ -111,8 +101,6 @@ index 6b82eab..51c6b78 100644
>
>   int mkdir_safe_internal(const char *path, mode_t mode, uid_t uid, gid_t 
> gid, MkdirFlags flags, mkdir_func_t _mkdir) {
>   struct stat st;
> -diff --git a/src/basic/parse-util.c b/src/basic/parse-util.c
> -index 87724af..d9c53bc 100644
>  --- a/src/basic/parse-util.c
>  +++ b/src/basic/parse-util.c
>  @@ -19,6 +19,7 @@
> @@ -123,8 +111,6 @@ index 87724af..d9c53bc 100644
>
>   int parse_boolean(const char *v) {
>   if (!v)
> -diff --git a/src/basic/proc-cmdline.c b/src/basic/proc-cmdline.c
> -index 1670001..b51feaa 100644
>  --- a/src/basic/proc-cmdline.c
>  +++ b/src/basic/proc-cmdline.c
>  @@ -15,6 +15,7 @@
> @@ -135,8 +121,6 @@ index 1670001..b51feaa 100644
>
>   int proc_cmdline(char **ret) {
>   const char *e;
> -diff --git a/src/basic/procfs-util.c b/src/basic/procfs-util.c
> -index 7aaf95b..42ce53d 100644
>  --- a/src/basic/procfs-util.c
>  +++ b/src/basic/procfs-util.c
>  @@ -11,6 +11,7 @@
> @@ -147,8 +131,6 @@ index 7aaf95b..42ce53d 100644
>
>   int procfs_tasks_get_limit(uint64_t *ret) {
>   _cleanup_free_ char *value = NULL;
> -diff --git a/src/basic/time-util.c b/src/basic/time-util.c
> -index daf952b..374b97f 100644
>  --- a/src/basic/time-util.c
>  +++ b/src/basic/time-util.c
>  @@ -28,6 +28,7 @@
> @@ -159,8 +141,6 @@ index daf952b..374b97f 100644
>
>   static clockid_t map_clock_id(clockid_t c) {
>
> -diff --git a/src/core/dbus-cgroup.c b/src/core/dbus-cgroup.c
> -index 4615aea..bc1364f 100644
>  --- a/src/core/dbus-cgroup.c
>  +++ b/src/core/dbus-cgroup.c
>  @@ -15,6 +15,7 @@
> @@ -171,8 +151,6 @@ index 4615aea..bc1364f 100644
>
>   static BUS_DEFINE_PROPERTY_GET_ENUM(property_get_cgroup_device_policy, 
> cgroup_device_policy, CGroupDevicePolicy);
>
> -diff --git a/src/core/dbus-util.c b/src/core/dbus-util.c
> -index f4fbb72..0a1e3b5 100644
>  --- a/src/core/dbus-util.c
>  +++ b/src/core/dbus-util.c
>  @@ -7,6 +7,7 @@
> @@ -183,8 +161,6 @@ index f4fbb72..0a1e3b5 100644
>
>   int bus_property_get_triggered_unit(
>   sd_bus *bus,
> -diff --git a/src/core/kmod-setup.c b/src/core/kmod-setup.c
> -index a91cfeb..a459610 100644
>  --- a/src/core/kmod-setup.c
>  +++ b/src/core/kmod-setup.c
>

[OE-core] [PATCH V2 1/4] pam_systemd: Include missing.h for secure_getenv

2019-05-22 Thread Khem Raj 
'secure_getenv' api is not uniformly implemented across all C libraries
therefore its good to include missing.h so it can use the alternative
implementation where its not awvailable

Fixes
../git/src/login/pam_systemd.c:344:13: error: implicit declaration of function 
'secure_getenv' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
v = secure_getenv(key);

Signed-off-by: Khem Raj 
---
v2: Rebased

 ...missing.h-check-for-missing-strndupa.patch | 71 +++
 1 file changed, 10 insertions(+), 61 deletions(-)

diff --git 
a/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
 
b/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
index a2e25a97df..df1043b27d 100644
--- 
a/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
+++ 
b/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
@@ -43,8 +43,6 @@ Signed-off-by: Andrej Valek 
  src/udev/udev-rules.c  |  1 +
  29 files changed, 40 insertions(+)
 
-diff --git a/meson.build b/meson.build
-index 79195c9..80d9564 100644
 --- a/meson.build
 +++ b/meson.build
 @@ -572,6 +572,7 @@ foreach ident : [
@@ -55,8 +53,6 @@ index 79195c9..80d9564 100644
  ]
  
  have = cc.has_function(ident[0], prefix : ident[1], args : 
'-D_GNU_SOURCE')
-diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c
-index dfd6805..c2b2ace 100644
 --- a/src/backlight/backlight.c
 +++ b/src/backlight/backlight.c
 @@ -17,6 +17,7 @@
@@ -67,8 +63,6 @@ index dfd6805..c2b2ace 100644
  
  static int find_pci_or_platform_parent(sd_device *device, sd_device **ret) {
  const char *subsystem, *sysname, *value;
-diff --git a/src/basic/env-util.c b/src/basic/env-util.c
-index fd449dc..e2b0722 100644
 --- a/src/basic/env-util.c
 +++ b/src/basic/env-util.c
 @@ -16,6 +16,7 @@
@@ -79,8 +73,6 @@ index fd449dc..e2b0722 100644
  
  #define VALID_CHARS_ENV_NAME\
  DIGITS LETTERS  \
-diff --git a/src/basic/missing_stdlib.h b/src/basic/missing_stdlib.h
-index 188a8d4..1e16ec2 100644
 --- a/src/basic/missing_stdlib.h
 +++ b/src/basic/missing_stdlib.h
 @@ -11,3 +11,15 @@
@@ -99,8 +91,6 @@ index 188a8d4..1e16ec2 100644
 +(char *)memcpy(__new, __old, __len); \
 +  })
 +#endif
-diff --git a/src/basic/mkdir.c b/src/basic/mkdir.c
-index 6b82eab..51c6b78 100644
 --- a/src/basic/mkdir.c
 +++ b/src/basic/mkdir.c
 @@ -14,6 +14,7 @@
@@ -111,8 +101,6 @@ index 6b82eab..51c6b78 100644
  
  int mkdir_safe_internal(const char *path, mode_t mode, uid_t uid, gid_t gid, 
MkdirFlags flags, mkdir_func_t _mkdir) {
  struct stat st;
-diff --git a/src/basic/parse-util.c b/src/basic/parse-util.c
-index 87724af..d9c53bc 100644
 --- a/src/basic/parse-util.c
 +++ b/src/basic/parse-util.c
 @@ -19,6 +19,7 @@
@@ -123,8 +111,6 @@ index 87724af..d9c53bc 100644
  
  int parse_boolean(const char *v) {
  if (!v)
-diff --git a/src/basic/proc-cmdline.c b/src/basic/proc-cmdline.c
-index 1670001..b51feaa 100644
 --- a/src/basic/proc-cmdline.c
 +++ b/src/basic/proc-cmdline.c
 @@ -15,6 +15,7 @@
@@ -135,8 +121,6 @@ index 1670001..b51feaa 100644
  
  int proc_cmdline(char **ret) {
  const char *e;
-diff --git a/src/basic/procfs-util.c b/src/basic/procfs-util.c
-index 7aaf95b..42ce53d 100644
 --- a/src/basic/procfs-util.c
 +++ b/src/basic/procfs-util.c
 @@ -11,6 +11,7 @@
@@ -147,8 +131,6 @@ index 7aaf95b..42ce53d 100644
  
  int procfs_tasks_get_limit(uint64_t *ret) {
  _cleanup_free_ char *value = NULL;
-diff --git a/src/basic/time-util.c b/src/basic/time-util.c
-index daf952b..374b97f 100644
 --- a/src/basic/time-util.c
 +++ b/src/basic/time-util.c
 @@ -28,6 +28,7 @@
@@ -159,8 +141,6 @@ index daf952b..374b97f 100644
  
  static clockid_t map_clock_id(clockid_t c) {
  
-diff --git a/src/core/dbus-cgroup.c b/src/core/dbus-cgroup.c
-index 4615aea..bc1364f 100644
 --- a/src/core/dbus-cgroup.c
 +++ b/src/core/dbus-cgroup.c
 @@ -15,6 +15,7 @@
@@ -171,8 +151,6 @@ index 4615aea..bc1364f 100644
  
  static BUS_DEFINE_PROPERTY_GET_ENUM(property_get_cgroup_device_policy, 
cgroup_device_policy, CGroupDevicePolicy);
  
-diff --git a/src/core/dbus-util.c b/src/core/dbus-util.c
-index f4fbb72..0a1e3b5 100644
 --- a/src/core/dbus-util.c
 +++ b/src/core/dbus-util.c
 @@ -7,6 +7,7 @@
@@ -183,8 +161,6 @@ index f4fbb72..0a1e3b5 100644
  
  int bus_property_get_triggered_unit(
  sd_bus *bus,
-diff --git a/src/core/kmod-setup.c b/src/core/kmod-setup.c
-index a91cfeb..a459610 100644
 --- a/src/core/kmod-setup.c
 +++ b/src/core/kmod-setup.c
 @@ -11,6 +11,7 @@
@@ -195,8 +171,6 @@ index a91cfeb..a459610 100644
  
  #if HAVE_KMOD
  #include 
-diff --git a/src/core/service.c b/src/core/service.c
-index 0289990..0e725b5 100644
 --- a/src/core/service.c
 +++ b/src/core/service.c
 @@ -42,6 +42,7 @@
@@ -207,8 +181,6 @@ index 0289990..0e725b5 100644