Re: [OE-core] [PATCH v2] kernel-fitimage: support RISC-V

2019-04-23 Thread Michael Scott 


On 4/23/19 2:37 AM, Richard Purdie wrote:

On Fri, 2019-04-19 at 10:41 -0700, Michael Scott wrote:

On 4/12/19 9:56 PM, Michael Scott wrote:

Support RISC-V kernel image, using the "Image" target.

This change allows RISC-V support for fitImage via the following
flow: OpenSBI -> u-boot (as payload) -> Linux kernel (as fitImage
with ramdisk and dtb).

This was tested using QEMU RISC-V 64-bit.

Signed-off-by: Michael Scott 
---
   meta/classes/kernel-fitimage.bbclass | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel-fitimage.bbclass
b/meta/classes/kernel-fitimage.bbclass
index 2517d75746..09abedff8e 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -8,7 +8,7 @@ python __anonymous () {
   d.setVar("DEPENDS", depends)
   
   uarch = d.getVar("UBOOT_ARCH")

-if uarch == "arm64":
+if uarch == "arm64" or uarch == "riscv":

I didn't see any response to this v2 patch.  Is this approach
acceptible?  RISC-V should not attempt to use zImage for fitImage as
it now stands.

I think the v1 patch was merged. I'd take a patch to tweak the code to
the v2 version as it is slightly neater but its not essential.

Cheers,

Richard
Thank you for pointing out that v1 got merged.  I didn't realize there 
isn't a notification for when patches are merged and wasn't watching the 
warrior branches.  I'll submit the tweak patch later this week.


- Mike




--
Michael Scott
Embedded Software Engineer at Foundries.io
"microPlatforms™ for Connected Products"
E: m...@foundries.io
W: https://www.foundries.io

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v2] kernel-fitimage: support RISC-V

2019-04-23 Thread Richard Purdie 
On Fri, 2019-04-19 at 10:41 -0700, Michael Scott wrote:
> On 4/12/19 9:56 PM, Michael Scott wrote:
> > Support RISC-V kernel image, using the "Image" target.
> > 
> > This change allows RISC-V support for fitImage via the following
> > flow: OpenSBI -> u-boot (as payload) -> Linux kernel (as fitImage
> > with ramdisk and dtb).
> > 
> > This was tested using QEMU RISC-V 64-bit.
> > 
> > Signed-off-by: Michael Scott 
> > ---
> >   meta/classes/kernel-fitimage.bbclass | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/kernel-fitimage.bbclass
> > b/meta/classes/kernel-fitimage.bbclass
> > index 2517d75746..09abedff8e 100644
> > --- a/meta/classes/kernel-fitimage.bbclass
> > +++ b/meta/classes/kernel-fitimage.bbclass
> > @@ -8,7 +8,7 @@ python __anonymous () {
> >   d.setVar("DEPENDS", depends)
> >   
> >   uarch = d.getVar("UBOOT_ARCH")
> > -if uarch == "arm64":
> > +if uarch == "arm64" or uarch == "riscv":
> 
> I didn't see any response to this v2 patch.  Is this approach 
> acceptible?  RISC-V should not attempt to use zImage for fitImage as
> it now stands.

I think the v1 patch was merged. I'd take a patch to tweak the code to
the v2 version as it is slightly neater but its not essential.

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v2] kernel-fitimage: support RISC-V

2019-04-19 Thread Michael Scott 


On 4/12/19 9:56 PM, Michael Scott wrote:

Support RISC-V kernel image, using the "Image" target.

This change allows RISC-V support for fitImage via the following
flow: OpenSBI -> u-boot (as payload) -> Linux kernel (as fitImage
with ramdisk and dtb).

This was tested using QEMU RISC-V 64-bit.

Signed-off-by: Michael Scott 
---
  meta/classes/kernel-fitimage.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel-fitimage.bbclass 
b/meta/classes/kernel-fitimage.bbclass
index 2517d75746..09abedff8e 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -8,7 +8,7 @@ python __anonymous () {
  d.setVar("DEPENDS", depends)
  
  uarch = d.getVar("UBOOT_ARCH")

-if uarch == "arm64":
+if uarch == "arm64" or uarch == "riscv":


I didn't see any response to this v2 patch.  Is this approach 
acceptible?  RISC-V should not attempt to use zImage for fitImage as it 
now stands.



  replacementtype = "Image"
  elif uarch == "mips":
  replacementtype = "vmlinuz.bin"


--
Michael Scott
Embedded Software Engineer at Foundries.io
"microPlatforms™ for Connected Products"
E: m...@foundries.io
W: https://www.foundries.io

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v2] kernel-fitimage: support RISC-V

2019-04-12 Thread Michael Scott 
Support RISC-V kernel image, using the "Image" target.

This change allows RISC-V support for fitImage via the following
flow: OpenSBI -> u-boot (as payload) -> Linux kernel (as fitImage
with ramdisk and dtb).

This was tested using QEMU RISC-V 64-bit.

Signed-off-by: Michael Scott 
---
 meta/classes/kernel-fitimage.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel-fitimage.bbclass 
b/meta/classes/kernel-fitimage.bbclass
index 2517d75746..09abedff8e 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -8,7 +8,7 @@ python __anonymous () {
 d.setVar("DEPENDS", depends)
 
 uarch = d.getVar("UBOOT_ARCH")
-if uarch == "arm64":
+if uarch == "arm64" or uarch == "riscv":
 replacementtype = "Image"
 elif uarch == "mips":
 replacementtype = "vmlinuz.bin"
-- 
2.21.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core