Re: [OE-core] [PATCH v2] ltp: Remove admin_tools test

2019-01-29 Thread He Zhe



On 1/28/19 10:09 PM, Richard Purdie wrote:
> On Mon, 2019-01-14 at 18:47 -0800, He Zhe wrote:
>> admin_tools test group has been removed from upstream. Backport to
>> fix the
>> following failures.
>>
>> at_deny01 1 TFAIL : ltpapicmd.c:188: At denyed user to execute test
>> job
>> at_allow01 1 TFAIL : ltpapicmd.c:188: At did not allow user to
>> execute job
>>
>> Signed-off-by: He Zhe 
>> ---
>> v2: Add missing SOB and upstream status.
> Rather than add the huge patch could we upgrade please?
>
> I believe Petr sent a patch but it had some issues so perhaps you could
> help fix those?

OK. I'll go check what I can help.

Zhe

>
> Cheers,
>
> Richard
>
>

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH v2] ltp: Remove admin_tools test

2019-01-28 Thread Richard Purdie
On Mon, 2019-01-14 at 18:47 -0800, He Zhe wrote:
> admin_tools test group has been removed from upstream. Backport to
> fix the
> following failures.
> 
> at_deny01 1 TFAIL : ltpapicmd.c:188: At denyed user to execute test
> job
> at_allow01 1 TFAIL : ltpapicmd.c:188: At did not allow user to
> execute job
> 
> Signed-off-by: He Zhe 
> ---
> v2: Add missing SOB and upstream status.

Rather than add the huge patch could we upgrade please?

I believe Petr sent a patch but it had some issues so perhaps you could
help fix those?

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH v2] ltp: Remove admin_tools test

2019-01-28 Thread He Zhe
Kindly ping.

Zhe

On 1/15/19 10:47 AM, He Zhe wrote:
> admin_tools test group has been removed from upstream. Backport to fix the
> following failures.
>
> at_deny01 1 TFAIL : ltpapicmd.c:188: At denyed user to execute test job
> at_allow01 1 TFAIL : ltpapicmd.c:188: At did not allow user to execute job
>
> Signed-off-by: He Zhe 
> ---
> v2: Add missing SOB and upstream status.
>
>  .../ltp/ltp/0001-Remove-admin_tools-test.patch | 3042 
> 
>  meta/recipes-extended/ltp/ltp_20180926.bb  |1 +
>  2 files changed, 3043 insertions(+)
>  create mode 100644 
> meta/recipes-extended/ltp/ltp/0001-Remove-admin_tools-test.patch
>
> diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-admin_tools-test.patch 
> b/meta/recipes-extended/ltp/ltp/0001-Remove-admin_tools-test.patch
> new file mode 100644
> index 00..2fc5be82a1
> --- /dev/null
> +++ b/meta/recipes-extended/ltp/ltp/0001-Remove-admin_tools-test.patch
> @@ -0,0 +1,3042 @@
> +From 0fc9b8624bea8acfdb408bf5ff4916b1453e3daa Mon Sep 17 00:00:00 2001
> +From: Petr Vorel 
> +Date: Thu, 27 Sep 2018 16:57:20 +0200
> +Subject: [PATCH] Remove admin_tools test
> +
> +Removing cron, at, su related tests as they don't really fit into
> +"kernel testing", it'd be better to have them in some "LTP userspace"
> +project.
> +ACL are considered as "kernel tests", but it would be easier to write
> +something from scratch, thus remove them as well.
> +
> +Signed-off-by: Petr Vorel 
> +Acked-by: Xiao Yang 
> +Acked-by: Jan Stancek 
> +Acked-by: Cyril Hrubis  +
> +Upstream-Status: Backport 
> [https://github.com/linux-test-project/ltp/commit/0fc9b8624bea8acfdb408bf5ff4916b1453e3daa]
> +
> +Signed-off-by: He Zhe 
> +
> +---
> + runtest/admin_tools |   9 -
> + runtest/commands|   1 -
> + scenario_groups/default |   1 -
> + testcases/commands/.gitignore   |   1 -
> + testcases/commands/at/Makefile  |  31 --
> + testcases/commands/at/at_allow01| 188 -
> + testcases/commands/at/at_deny01 | 195 --
> + testcases/commands/cron/00_Descriptions.txt |   4 -
> + testcases/commands/cron/Makefile|  29 --
> + testcases/commands/cron/README.tests|  25 --
> + testcases/commands/cron/cron02  |  80 
> + testcases/commands/cron/cron03  |  83 
> + testcases/commands/cron/cron_allow01| 202 --
> + testcases/commands/cron/cron_deny01 | 192 --
> + testcases/commands/cron/cron_dirs_check.c   |  44 ---
> + testcases/commands/cron/cron_dirs_checks01  |  46 ---
> + testcases/commands/cron/cron_illegal_cron_lines |  39 --
> + testcases/commands/cron/cron_neg_tests.sh   | 141 ---
> + testcases/commands/cron/cron_pos_tests.sh   | 118 --
> + testcases/commands/cron/cron_tests.sh   | 276 --
> + testcases/commands/su/Makefile  |  31 --
> + testcases/commands/su/su01  | 181 -
> + testcases/commands/su/su01_s1   | 486 
> 
> + testcases/commands/su/su_set_passwd |  14 -
> + testcases/kernel/fs/acls/.gitignore |   2 -
> + testcases/kernel/fs/acls/Makefile   |  40 --
> + testcases/kernel/fs/acls/acl_file_test.c|  73 
> + testcases/kernel/fs/acls/acl_link_test.c|  56 ---
> + testcases/kernel/fs/acls/acl_test01 | 186 -
> + 29 files changed, 2774 deletions(-)
> + delete mode 100644 runtest/admin_tools
> + delete mode 100644 testcases/commands/at/Makefile
> + delete mode 100755 testcases/commands/at/at_allow01
> + delete mode 100755 testcases/commands/at/at_deny01
> + delete mode 100644 testcases/commands/cron/00_Descriptions.txt
> + delete mode 100644 testcases/commands/cron/Makefile
> + delete mode 100644 testcases/commands/cron/README.tests
> + delete mode 100755 testcases/commands/cron/cron02
> + delete mode 100755 testcases/commands/cron/cron03
> + delete mode 100755 testcases/commands/cron/cron_allow01
> + delete mode 100755 testcases/commands/cron/cron_deny01
> + delete mode 100644 testcases/commands/cron/cron_dirs_check.c
> + delete mode 100755 testcases/commands/cron/cron_dirs_checks01
> + delete mode 100644 testcases/commands/cron/cron_illegal_cron_lines
> + delete mode 100755 testcases/commands/cron/cron_neg_tests.sh
> + delete mode 100755 testcases/commands/cron/cron_pos_tests.sh
> + delete mode 100644 testcases/commands/cron/cron_tests.sh
> + delete mode 100644 testcases/commands/su/Makefile
> + delete mode 100755 testcases/commands/su/su01
> + delete mode 100755 testcases/commands/su/su01_s1
> + delete mode 100755 testcases/commands/su/su_set_passwd
> + delete mode 100644 testcases/kernel/fs/acls/.gitignore
> + delete mode 100644 testcases/kernel/fs/acls/Makefile
> + delete mode 100644 

[OE-core] [PATCH v2] ltp: Remove admin_tools test

2019-01-14 Thread He Zhe
admin_tools test group has been removed from upstream. Backport to fix the
following failures.

at_deny01 1 TFAIL : ltpapicmd.c:188: At denyed user to execute test job
at_allow01 1 TFAIL : ltpapicmd.c:188: At did not allow user to execute job

Signed-off-by: He Zhe 
---
v2: Add missing SOB and upstream status.

 .../ltp/ltp/0001-Remove-admin_tools-test.patch | 3042 
 meta/recipes-extended/ltp/ltp_20180926.bb  |1 +
 2 files changed, 3043 insertions(+)
 create mode 100644 
meta/recipes-extended/ltp/ltp/0001-Remove-admin_tools-test.patch

diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-admin_tools-test.patch 
b/meta/recipes-extended/ltp/ltp/0001-Remove-admin_tools-test.patch
new file mode 100644
index 00..2fc5be82a1
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/0001-Remove-admin_tools-test.patch
@@ -0,0 +1,3042 @@
+From 0fc9b8624bea8acfdb408bf5ff4916b1453e3daa Mon Sep 17 00:00:00 2001
+From: Petr Vorel 
+Date: Thu, 27 Sep 2018 16:57:20 +0200
+Subject: [PATCH] Remove admin_tools test
+
+Removing cron, at, su related tests as they don't really fit into
+"kernel testing", it'd be better to have them in some "LTP userspace"
+project.
+ACL are considered as "kernel tests", but it would be easier to write
+something from scratch, thus remove them as well.
+
+Signed-off-by: Petr Vorel 
+Acked-by: Xiao Yang 
+Acked-by: Jan Stancek 
+Acked-by: Cyril Hrubis https://github.com/linux-test-project/ltp/commit/0fc9b8624bea8acfdb408bf5ff4916b1453e3daa]
+
+Signed-off-by: He Zhe 
+
+---
+ runtest/admin_tools |   9 -
+ runtest/commands|   1 -
+ scenario_groups/default |   1 -
+ testcases/commands/.gitignore   |   1 -
+ testcases/commands/at/Makefile  |  31 --
+ testcases/commands/at/at_allow01| 188 -
+ testcases/commands/at/at_deny01 | 195 --
+ testcases/commands/cron/00_Descriptions.txt |   4 -
+ testcases/commands/cron/Makefile|  29 --
+ testcases/commands/cron/README.tests|  25 --
+ testcases/commands/cron/cron02  |  80 
+ testcases/commands/cron/cron03  |  83 
+ testcases/commands/cron/cron_allow01| 202 --
+ testcases/commands/cron/cron_deny01 | 192 --
+ testcases/commands/cron/cron_dirs_check.c   |  44 ---
+ testcases/commands/cron/cron_dirs_checks01  |  46 ---
+ testcases/commands/cron/cron_illegal_cron_lines |  39 --
+ testcases/commands/cron/cron_neg_tests.sh   | 141 ---
+ testcases/commands/cron/cron_pos_tests.sh   | 118 --
+ testcases/commands/cron/cron_tests.sh   | 276 --
+ testcases/commands/su/Makefile  |  31 --
+ testcases/commands/su/su01  | 181 -
+ testcases/commands/su/su01_s1   | 486 
+ testcases/commands/su/su_set_passwd |  14 -
+ testcases/kernel/fs/acls/.gitignore |   2 -
+ testcases/kernel/fs/acls/Makefile   |  40 --
+ testcases/kernel/fs/acls/acl_file_test.c|  73 
+ testcases/kernel/fs/acls/acl_link_test.c|  56 ---
+ testcases/kernel/fs/acls/acl_test01 | 186 -
+ 29 files changed, 2774 deletions(-)
+ delete mode 100644 runtest/admin_tools
+ delete mode 100644 testcases/commands/at/Makefile
+ delete mode 100755 testcases/commands/at/at_allow01
+ delete mode 100755 testcases/commands/at/at_deny01
+ delete mode 100644 testcases/commands/cron/00_Descriptions.txt
+ delete mode 100644 testcases/commands/cron/Makefile
+ delete mode 100644 testcases/commands/cron/README.tests
+ delete mode 100755 testcases/commands/cron/cron02
+ delete mode 100755 testcases/commands/cron/cron03
+ delete mode 100755 testcases/commands/cron/cron_allow01
+ delete mode 100755 testcases/commands/cron/cron_deny01
+ delete mode 100644 testcases/commands/cron/cron_dirs_check.c
+ delete mode 100755 testcases/commands/cron/cron_dirs_checks01
+ delete mode 100644 testcases/commands/cron/cron_illegal_cron_lines
+ delete mode 100755 testcases/commands/cron/cron_neg_tests.sh
+ delete mode 100755 testcases/commands/cron/cron_pos_tests.sh
+ delete mode 100644 testcases/commands/cron/cron_tests.sh
+ delete mode 100644 testcases/commands/su/Makefile
+ delete mode 100755 testcases/commands/su/su01
+ delete mode 100755 testcases/commands/su/su01_s1
+ delete mode 100755 testcases/commands/su/su_set_passwd
+ delete mode 100644 testcases/kernel/fs/acls/.gitignore
+ delete mode 100644 testcases/kernel/fs/acls/Makefile
+ delete mode 100644 testcases/kernel/fs/acls/acl_file_test.c
+ delete mode 100644 testcases/kernel/fs/acls/acl_link_test.c
+ delete mode 100755 testcases/kernel/fs/acls/acl_test01
+
+diff --git a/runtest/admin_tools b/runtest/admin_tools
+deleted file mode 100644
+index 0a46468c8..0
+---