Re: [OE-core] [PATCH v2 0/1] kexec-tools: Upgrade to 2.0.14

2016-12-28 Thread He Zhe 


On 12/28/2016 08:15 PM, Alexander Kanavin wrote:
> On 12/27/2016 08:43 AM, zhe...@windriver.com wrote:
>> From: He Zhe 
>>
>> Remove kexec-aarch64.patch since it has been merged upstream
>> Remove kexec-x32.patch since it has been reverted upstream
>> Backport patches for kdump arm64 from:
>> https://git.linaro.org/people/takahiro.akashi/kexec-tools.git
>>
>> v1 to v2: Remove redundant tarball link in SRC_URI
>
> None of my comments are addressed in this new version of the patch. 
> Specifically:
>
> > Remove kexec-aarch64.patch since it has been merged upstream
> > Remove kexec-x32.patch since it has been reverted upstream
>
> You should also remove the actual files, not just drop them from the recipe.
>
> > Backport patches for kdump arm64 from:
> > https://git.linaro.org/people/takahiro.akashi/kexec-tools.git
>
> If the patches are coming from a different repository, they are not a 
> backport. Change the upstream-status to 'pending' please, or 'submitted 
> (link)' if they have been submitted upstream.
>
> >  meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb|  37 
> >  meta/recipes-kernel/kexec/kexec-tools_2.0.14.bb|  44 +
>
> Please use git's rename detection when submitting patches, so we can see what 
> is the difference between the two files.
>

Thank you for your careful review. Sorry for missing your comments for v1 since 
I just filter mails specifically sent to me...
I'll send v3 soon.

Thanks,
Zhe

>
> Alex
>
>

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v2 0/1] kexec-tools: Upgrade to 2.0.14

2016-12-28 Thread Alexander Kanavin 

On 12/27/2016 08:43 AM, zhe...@windriver.com wrote:

From: He Zhe 

Remove kexec-aarch64.patch since it has been merged upstream
Remove kexec-x32.patch since it has been reverted upstream
Backport patches for kdump arm64 from:
https://git.linaro.org/people/takahiro.akashi/kexec-tools.git

v1 to v2: Remove redundant tarball link in SRC_URI


None of my comments are addressed in this new version of the patch. 
Specifically:


> Remove kexec-aarch64.patch since it has been merged upstream
> Remove kexec-x32.patch since it has been reverted upstream

You should also remove the actual files, not just drop them from the recipe.

> Backport patches for kdump arm64 from:
> https://git.linaro.org/people/takahiro.akashi/kexec-tools.git

If the patches are coming from a different repository, they are not a 
backport. Change the upstream-status to 'pending' please, or 'submitted 
(link)' if they have been submitted upstream.


>  meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb|  37 
>  meta/recipes-kernel/kexec/kexec-tools_2.0.14.bb|  44 +

Please use git's rename detection when submitting patches, so we can see 
what is the difference between the two files.



Alex

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v2 0/1] kexec-tools: Upgrade to 2.0.14

2016-12-26 Thread zhe.he 
From: He Zhe 

Remove kexec-aarch64.patch since it has been merged upstream
Remove kexec-x32.patch since it has been reverted upstream
Backport patches for kdump arm64 from:
https://git.linaro.org/people/takahiro.akashi/kexec-tools.git

v1 to v2: Remove redundant tarball link in SRC_URI

He Zhe (1):
  kexec-tools: Upgrade to 2.0.14

 ...nd-the-semantics-of-kexec_iomem_for_each_.patch |  78 
 ...eneralize-and-rename-get_kernel_stext_sym.patch | 194 
 ...0003-arm64-identify-PHYS_OFFSET-correctly.patch |  76 
 .../0004-arm64-kdump-identify-memory-regions.patch | 202 +
 ...5-arm64-kdump-add-elf-core-header-segment.patch | 191 +++
 ...6-arm64-kdump-set-up-kernel-image-segment.patch | 137 ++
 .../0007-arm64-kdump-set-up-other-segments.patch   |  35 
 ...-add-DT-properties-to-crash-dump-kernel-s.patch | 150 +++
 ...-kdump-Add-support-for-binary-image-files.patch |  52 ++
 meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb|  37 
 meta/recipes-kernel/kexec/kexec-tools_2.0.14.bb|  44 +
 11 files changed, 1159 insertions(+), 37 deletions(-)
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0001-kexec-exntend-the-semantics-of-kexec_iomem_for_each_.patch
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0002-kexec-generalize-and-rename-get_kernel_stext_sym.patch
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0003-arm64-identify-PHYS_OFFSET-correctly.patch
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0004-arm64-kdump-identify-memory-regions.patch
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0005-arm64-kdump-add-elf-core-header-segment.patch
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0006-arm64-kdump-set-up-kernel-image-segment.patch
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0007-arm64-kdump-set-up-other-segments.patch
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0008-arm64-kdump-add-DT-properties-to-crash-dump-kernel-s.patch
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0009-arm64-kdump-Add-support-for-binary-image-files.patch
 delete mode 100644 meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb
 create mode 100644 meta/recipes-kernel/kexec/kexec-tools_2.0.14.bb

-- 
2.8.3

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core