Re: [OE-core] [PATCH v2 2/2] lttng-tools: add lttng-modules to ptest dependencies

2019-05-25 Thread Richard Purdie
On Wed, 2019-05-22 at 22:21 +, Jonathan Rajotte wrote:
> The lttng-tools project is essentially a "tracer" controller, the tests
> depends heavily on lttng-ust and lttng-modules presence.
> 
> Signed-off-by: Jonathan Rajotte 
> ---
>  meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb 
> b/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
> index f1bb7224f3..7e80bb45d1 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = 
> "file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \
>  
>  DEPENDS = "liburcu popt libxml2 util-linux"
>  RDEPENDS_${PN} = "libgcc"
> -RDEPENDS_${PN}-ptest += "make perl bash gawk ${PN} babeltrace procps 
> perl-module-overloading coreutils util-linux kmod"
> +RDEPENDS_${PN}-ptest += "make perl bash gawk ${PN} babeltrace procps 
> perl-module-overloading coreutils util-linux kmod lttng-modules"
>  RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-utils"
>  RDEPENDS_${PN}-ptest_append_libc-musl = " musl-utils"
>  # babelstats.pl wants getopt-long

Thanks for these patches, this will help a lot.

This patch threw up some issues in testing since kernel modules are
machine specific and this then means lttng-tools should become machine
specfic too (which is a bad idea and not necessary).

I've sent out an additional patch which resolved that, not as neatly as
I'd like as I had to special case lttng-modules in the mutilib code.

It gets this merged though as I'd like to stop seeing those timeouts
once and for all!

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v2 2/2] lttng-tools: add lttng-modules to ptest dependencies

2019-05-22 Thread Jonathan Rajotte
The lttng-tools project is essentially a "tracer" controller, the tests
depends heavily on lttng-ust and lttng-modules presence.

Signed-off-by: Jonathan Rajotte 
---
 meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb 
b/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
index f1bb7224f3..7e80bb45d1 100644
--- a/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
+++ b/meta/recipes-kernel/lttng/lttng-tools_2.10.6.bb
@@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = 
"file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \
 
 DEPENDS = "liburcu popt libxml2 util-linux"
 RDEPENDS_${PN} = "libgcc"
-RDEPENDS_${PN}-ptest += "make perl bash gawk ${PN} babeltrace procps 
perl-module-overloading coreutils util-linux kmod"
+RDEPENDS_${PN}-ptest += "make perl bash gawk ${PN} babeltrace procps 
perl-module-overloading coreutils util-linux kmod lttng-modules"
 RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-utils"
 RDEPENDS_${PN}-ptest_append_libc-musl = " musl-utils"
 # babelstats.pl wants getopt-long
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core