Re: [OE-core] [PATCH v3 1/2] dbus: add user sessions support

[Tanu Kaskinen]

On Mon, 2015-09-14 at 12:41 +0200, Andrew Shadura wrote:
> ---
>  meta/recipes-core/dbus/dbus_1.10.0.bb | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/dbus/dbus_1.10.0.bb 
> b/meta/recipes-core/dbus/dbus_1.10.0.bb
> index 31cbef0..e099f4b 100644
> --- a/meta/recipes-core/dbus/dbus_1.10.0.bb
> +++ b/meta/recipes-core/dbus/dbus_1.10.0.bb
> @@ -68,7 +68,9 @@ FILES_${PN} = "${bindir}/dbus-daemon* \
> ${datadir}/dbus-1/session.conf \
> ${datadir}/dbus-1/system.d \
> ${datadir}/dbus-1/system.conf \
> -   ${systemd_unitdir}/system/"
> +   ${systemd_system_unitdir} \
> +   ${systemd_user_unitdir} \
> +"
>  FILES_${PN}-lib = "${libdir}/lib*.so.*"
>  RRECOMMENDS_${PN}-lib = "${PN}"
>  FILES_${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-glib-tool 
> ${bindir}/dbus-test-tool"
> @@ -105,6 +107,7 @@ PACKAGECONFIG_class-nativesdk = ""
>  PACKAGECONFIG[systemd] = 
> "--with-systemdsystemunitdir=${systemd_unitdir}/system/,--without-systemdsystemunitdir"
>  PACKAGECONFIG[x11] = "--with-x --enable-x11-autolaunch,--without-x 
> --disable-x11-autolaunch, virtual/libx11 libsm"
>  PACKAGECONFIG[apparmor] = "--enable-apparmor,--disable-apparmor,libapparmor"
> +PACKAGECONFIG[user-session] = "--enable-user-session,--disable-user-session"

I think user-session should be enabled by default when systemd is in
DISTRO_FEATURES. Some services, e.g. PulseAudio, can fully enable their
systemd integration only if dbus is compiled with --enable-user
-session.

-- 
Tanu
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v3 1/2] dbus: add user sessions support

[Pau Espin Pedrol]

Hi,

I agree with Tanu. +1 enabling for user-session by default if systemd is
used.

Pau Espin Pedrol
mail/jabber: pespin.s...@gmail.com
http://blog.espeweb.net

2015-09-15 13:36 GMT+02:00 Tanu Kaskinen :

> On Mon, 2015-09-14 at 12:41 +0200, Andrew Shadura wrote:
> > ---
> >  meta/recipes-core/dbus/dbus_1.10.0.bb | 5 -
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/dbus/dbus_1.10.0.bb
> b/meta/recipes-core/dbus/dbus_1.10.0.bb
> > index 31cbef0..e099f4b 100644
> > --- a/meta/recipes-core/dbus/dbus_1.10.0.bb
> > +++ b/meta/recipes-core/dbus/dbus_1.10.0.bb
> > @@ -68,7 +68,9 @@ FILES_${PN} = "${bindir}/dbus-daemon* \
> > ${datadir}/dbus-1/session.conf \
> > ${datadir}/dbus-1/system.d \
> > ${datadir}/dbus-1/system.conf \
> > -   ${systemd_unitdir}/system/"
> > +   ${systemd_system_unitdir} \
> > +   ${systemd_user_unitdir} \
> > +"
> >  FILES_${PN}-lib = "${libdir}/lib*.so.*"
> >  RRECOMMENDS_${PN}-lib = "${PN}"
> >  FILES_${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-glib-tool
> ${bindir}/dbus-test-tool"
> > @@ -105,6 +107,7 @@ PACKAGECONFIG_class-nativesdk = ""
> >  PACKAGECONFIG[systemd] =
> "--with-systemdsystemunitdir=${systemd_unitdir}/system/,--without-systemdsystemunitdir"
> >  PACKAGECONFIG[x11] = "--with-x --enable-x11-autolaunch,--without-x
> --disable-x11-autolaunch, virtual/libx11 libsm"
> >  PACKAGECONFIG[apparmor] =
> "--enable-apparmor,--disable-apparmor,libapparmor"
> > +PACKAGECONFIG[user-session] =
> "--enable-user-session,--disable-user-session"
>
> I think user-session should be enabled by default when systemd is in
> DISTRO_FEATURES. Some services, e.g. PulseAudio, can fully enable their
> systemd integration only if dbus is compiled with --enable-user
> -session.
>
> --
> Tanu
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v3 1/2] dbus: add user sessions support

[Tanu Kaskinen]

On Tue, 2015-09-15 at 14:53 +0200, Andrew Shadura wrote:
> On 15/09/15 13:36, Tanu Kaskinen wrote:
> > I think user-session should be enabled by default when systemd is in
> > DISTRO_FEATURES. Some services, e.g. PulseAudio, can fully enable their
> > systemd integration only if dbus is compiled with --enable-user
> > -session.
> 
> I think so too, but I think it's worth a separate patch, right?

I think this patch could already have it "right", but I don't really
mind either way.

-- 
Tanu
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v3 1/2] dbus: add user sessions support

[Andrew Shadura]

On 15/09/15 13:36, Tanu Kaskinen wrote:
> I think user-session should be enabled by default when systemd is in
> DISTRO_FEATURES. Some services, e.g. PulseAudio, can fully enable their
> systemd integration only if dbus is compiled with --enable-user
> -session.

I think so too, but I think it's worth a separate patch, right?

-- 
Cheers,
  Andrew



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v3 1/2] dbus: add user sessions support

[Andrew Shadura]

---
 meta/recipes-core/dbus/dbus_1.10.0.bb | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/dbus/dbus_1.10.0.bb 
b/meta/recipes-core/dbus/dbus_1.10.0.bb
index 31cbef0..e099f4b 100644
--- a/meta/recipes-core/dbus/dbus_1.10.0.bb
+++ b/meta/recipes-core/dbus/dbus_1.10.0.bb
@@ -68,7 +68,9 @@ FILES_${PN} = "${bindir}/dbus-daemon* \
${datadir}/dbus-1/session.conf \
${datadir}/dbus-1/system.d \
${datadir}/dbus-1/system.conf \
-   ${systemd_unitdir}/system/"
+   ${systemd_system_unitdir} \
+   ${systemd_user_unitdir} \
+"
 FILES_${PN}-lib = "${libdir}/lib*.so.*"
 RRECOMMENDS_${PN}-lib = "${PN}"
 FILES_${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-glib-tool 
${bindir}/dbus-test-tool"
@@ -105,6 +107,7 @@ PACKAGECONFIG_class-nativesdk = ""
 PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_unitdir}/system/,--without-systemdsystemunitdir"
 PACKAGECONFIG[x11] = "--with-x --enable-x11-autolaunch,--without-x 
--disable-x11-autolaunch, virtual/libx11 libsm"
 PACKAGECONFIG[apparmor] = "--enable-apparmor,--disable-apparmor,libapparmor"
+PACKAGECONFIG[user-session] = "--enable-user-session,--disable-user-session"
 
 do_install() {
autotools_do_install
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core