Re: [OE-core] [PATCHv3 0/6] recipetool/devtool/oe-selftest: pull from BBPATH
On Sat, 2015-07-25 at 12:18 -0700, Christopher Larson wrote: On Sat, Jul 25, 2015 at 9:09 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: however when I apply this and your other series, the autobuilder oe-selftest does this: https://autobuilder.yoctoproject.org/main/builders/nightly-oe-selftest/builds/92/steps/Running%20oe-selftest/logs/stdio which is substantially worse. I can't immediately see what the issue is but the two runs above pretty much bisect this down to the patch series. I'm therefore reluctant to merge these until we can figure out what is going on... Given that both failures have nothing to do with devtool, recipetool, or oe-selftest and are simply bitbake build failures as called by tests, I don’t really see how these could have anything to do with that, but understood. FWIW, the issue is that you use the xxx:do_unpack syntax in one of the tests. This breaks toaster.bbclass and once its broken, it stays broken as its doing a split(:) on data in a file it never cleans up if the function fails. I've taken a fix which should avoid these issues. Will rerun a build with that applied (and various other fixes) and hopefully we can then get things merged. Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCHv3 0/6] recipetool/devtool/oe-selftest: pull from BBPATH
On Mon, Jul 27, 2015 at 5:16 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Sat, 2015-07-25 at 12:18 -0700, Christopher Larson wrote: On Sat, Jul 25, 2015 at 9:09 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: however when I apply this and your other series, the autobuilder oe-selftest does this: https://autobuilder.yoctoproject.org/main/builders/nightly-oe-selftest/builds/92/steps/Running%20oe-selftest/logs/stdio which is substantially worse. I can't immediately see what the issue is but the two runs above pretty much bisect this down to the patch series. I'm therefore reluctant to merge these until we can figure out what is going on... Given that both failures have nothing to do with devtool, recipetool, or oe-selftest and are simply bitbake build failures as called by tests, I don’t really see how these could have anything to do with that, but understood. FWIW, the issue is that you use the xxx:do_unpack syntax in one of the tests. This breaks toaster.bbclass and once its broken, it stays broken as its doing a split(:) on data in a file it never cleans up if the function fails. I've taken a fix which should avoid these issues. Will rerun a build with that applied (and various other fixes) and hopefully we can then get things merged. Ah! That explains it. Thanks. Obviously I could have used -c, but I’m a fan of the new syntax, it gives some nice flexibility :) -- Christopher Larson kergoth at gmail dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCHv3 0/6] recipetool/devtool/oe-selftest: pull from BBPATH
On Thu, 2015-07-23 at 12:57 -0700, Christopher Larson wrote: From: Christopher Larson chris_lar...@mentor.com Ensures that recipetool and devtool pull plugins from layers, and oe-selftest will pull tests from layers. Unrelated to that, also prevents a traceback on parsing failure, and adds a tiny feature to appendsrc to facilitate reuse by other sub-commands. [v3 Update] Fixed the commit message for `devtool: also load plugins from BBPATH` to match the implementation. Split up `recipetool: also load plugins from BBPATH` into two commits with clear commit messages. [v2 Update] `devtool: also load plugins from BBPATH` was fixed, so it no longer breaks the devtool selftests. I know there are some issues with oe-selftest on the autobuilder at the moment, specifically master results in things like: https://autobuilder.yoctoproject.org/main/builders/nightly-oe-selftest/builds/93 however when I apply this and your other series, the autobuilder oe-selftest does this: https://autobuilder.yoctoproject.org/main/builders/nightly-oe-selftest/builds/92/steps/Running%20oe-selftest/logs/stdio which is substantially worse. I can't immediately see what the issue is but the two runs above pretty much bisect this down to the patch series. I'm therefore reluctant to merge these until we can figure out what is going on... Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCHv3 0/6] recipetool/devtool/oe-selftest: pull from BBPATH
On Sat, Jul 25, 2015 at 9:09 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Thu, 2015-07-23 at 12:57 -0700, Christopher Larson wrote: From: Christopher Larson chris_lar...@mentor.com Ensures that recipetool and devtool pull plugins from layers, and oe-selftest will pull tests from layers. Unrelated to that, also prevents a traceback on parsing failure, and adds a tiny feature to appendsrc to facilitate reuse by other sub-commands. [v3 Update] Fixed the commit message for `devtool: also load plugins from BBPATH` to match the implementation. Split up `recipetool: also load plugins from BBPATH` into two commits with clear commit messages. [v2 Update] `devtool: also load plugins from BBPATH` was fixed, so it no longer breaks the devtool selftests. I know there are some issues with oe-selftest on the autobuilder at the moment, specifically master results in things like: https://autobuilder.yoctoproject.org/main/builders/nightly-oe-selftest/builds/93 however when I apply this and your other series, the autobuilder oe-selftest does this: https://autobuilder.yoctoproject.org/main/builders/nightly-oe-selftest/builds/92/steps/Running%20oe-selftest/logs/stdio which is substantially worse. I can't immediately see what the issue is but the two runs above pretty much bisect this down to the patch series. I'm therefore reluctant to merge these until we can figure out what is going on... Given that both failures have nothing to do with devtool, recipetool, or oe-selftest and are simply bitbake build failures as called by tests, I don’t really see how these could have anything to do with that, but understood. -- Christopher Larson kergoth at gmail dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCHv3 0/6] recipetool/devtool/oe-selftest: pull from BBPATH
On Thursday 23 July 2015 12:57:55 Christopher Larson wrote: From: Christopher Larson chris_lar...@mentor.com Ensures that recipetool and devtool pull plugins from layers, and oe-selftest will pull tests from layers. Unrelated to that, also prevents a traceback on parsing failure, and adds a tiny feature to appendsrc to facilitate reuse by other sub-commands. [v3 Update] Fixed the commit message for `devtool: also load plugins from BBPATH` to match the implementation. Split up `recipetool: also load plugins from BBPATH` into two commits with clear commit messages. Looks good, thanks! Acked-by: Paul Eggleton paul.eggle...@linux.intel.com Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCHv3 0/6] recipetool/devtool/oe-selftest: pull from BBPATH
From: Christopher Larson chris_lar...@mentor.com Ensures that recipetool and devtool pull plugins from layers, and oe-selftest will pull tests from layers. Unrelated to that, also prevents a traceback on parsing failure, and adds a tiny feature to appendsrc to facilitate reuse by other sub-commands. [v3 Update] Fixed the commit message for `devtool: also load plugins from BBPATH` to match the implementation. Split up `recipetool: also load plugins from BBPATH` into two commits with clear commit messages. [v2 Update] `devtool: also load plugins from BBPATH` was fixed, so it no longer breaks the devtool selftests. The following changes since commit 3143920c541b55b543b9dcc12b18af4e0e4b7ae1: linux-libc-headers: update to 4.1 (2015-07-23 08:47:52 +0100) are available in the git repository at: g...@github.com:kergoth/openembedded-core yocto-bug-7625 for you to fetch changes up to 6ac90ef048adff65b6dce1e4102156ccb365964a: oe-selftest: add libdirs from BBPATH to sys.path (2015-07-23 07:59:18 -0700) Christopher Larson (7): recipetool: catch BBHandledException from parsing recipetool.append: add extralines arg to appendsrc recipetool: also load plugins from BBPATH recipetool: parse global args early devtool: also load plugins from BBPATH oe-selftest: obey oeqa.selftest.__path__ oe-selftest: add libdirs from BBPATH to sys.path scripts/devtool | 57 +--- scripts/lib/devtool/__init__.py | 4 +-- scripts/lib/recipetool/append.py | 4 +-- scripts/oe-selftest | 18 + scripts/recipetool | 57 +--- 5 files changed, 89 insertions(+), 51 deletions(-) -- 2.2.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
