Re: [OE-core] [dunfell][master][PATCH] kernel.bbclass: Fix Module.symvers support

[Bruce Ashfield]

On Thu, Jul 2, 2020 at 2:14 PM Bruce Ashfield via
lists.openembedded.org
 wrote:
>
> On Fri, Jun 26, 2020 at 1:47 AM  wrote:
> >
> > From: Lili Li 
> >
> > Starting from v5.8-rc1 commit 269a535ca931 (modpost: generate
> > vmlinux.symvers and reuse it for the second modpost"), kernel will
> > generate new vmlinux.symvers instead of dumping all the vmlinux symbols
> > into Module.symvers in the first pass.
> >
> > Error log:
> > 'run.do_shared_workdir.16614' failed with exit code 1:
> > DEBUG: cp: cannot stat 'Module.symvers': No such file or directory
> >
> > This change will check the file Module.symvers existence before copying it.
>
> This doesn't actually fix the problem where we still want
> Module.symvers, it just ignores copying it to the shared directory.
> But it will be created ones modules are built.
>
> We either need a 2nd copy task, or we need to move the
> do_shared_workdir until after modules are built. I'm looking into
> which makes more sense.

As it turns out (and as you probably already knew), we do that 2nd
copy already so it will make it to the shared workdir.

So I retract my comment, and we are good.

Cheers,

Bruce

>
> Bruce
>
> >
> > Signed-off-by: Lili Li 
> > ---
> >  meta/classes/kernel.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> > index 20a0135fc979..a1219f315620 100644
> > --- a/meta/classes/kernel.bbclass
> > +++ b/meta/classes/kernel.bbclass
> > @@ -463,7 +463,7 @@ do_shared_workdir () {
> >
> > # Copy files required for module builds
> > cp System.map $kerneldir/System.map-${KERNEL_VERSION}
> > -   cp Module.symvers $kerneldir/
> > +   [ -e Module.symvers ] && cp Module.symvers $kerneldir/
> > cp .config $kerneldir/
> > mkdir -p $kerneldir/include/config
> > cp include/config/kernel.release 
> > $kerneldir/include/config/kernel.release
> > --
> > 2.26.2
> >
> >
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
> 



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140237): 
https://lists.openembedded.org/g/openembedded-core/message/140237
Mute This Topic: https://lists.openembedded.org/mt/75119073/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [dunfell][master][PATCH] kernel.bbclass: Fix Module.symvers support

[Bruce Ashfield]

On Fri, Jun 26, 2020 at 1:47 AM  wrote:
>
> From: Lili Li 
>
> Starting from v5.8-rc1 commit 269a535ca931 (modpost: generate
> vmlinux.symvers and reuse it for the second modpost"), kernel will
> generate new vmlinux.symvers instead of dumping all the vmlinux symbols
> into Module.symvers in the first pass.
>
> Error log:
> 'run.do_shared_workdir.16614' failed with exit code 1:
> DEBUG: cp: cannot stat 'Module.symvers': No such file or directory
>
> This change will check the file Module.symvers existence before copying it.

This doesn't actually fix the problem where we still want
Module.symvers, it just ignores copying it to the shared directory.
But it will be created ones modules are built.

We either need a 2nd copy task, or we need to move the
do_shared_workdir until after modules are built. I'm looking into
which makes more sense.

Bruce

>
> Signed-off-by: Lili Li 
> ---
>  meta/classes/kernel.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 20a0135fc979..a1219f315620 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -463,7 +463,7 @@ do_shared_workdir () {
>
> # Copy files required for module builds
> cp System.map $kerneldir/System.map-${KERNEL_VERSION}
> -   cp Module.symvers $kerneldir/
> +   [ -e Module.symvers ] && cp Module.symvers $kerneldir/
> cp .config $kerneldir/
> mkdir -p $kerneldir/include/config
> cp include/config/kernel.release 
> $kerneldir/include/config/kernel.release
> --
> 2.26.2
>
> 



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140234): 
https://lists.openembedded.org/g/openembedded-core/message/140234
Mute This Topic: https://lists.openembedded.org/mt/75119073/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [dunfell][master][PATCH] kernel.bbclass: Fix Module.symvers support

[lili . li]

From: Lili Li 

Starting from v5.8-rc1 commit 269a535ca931 (modpost: generate
vmlinux.symvers and reuse it for the second modpost"), kernel will
generate new vmlinux.symvers instead of dumping all the vmlinux symbols
into Module.symvers in the first pass.

Error log:
'run.do_shared_workdir.16614' failed with exit code 1:
DEBUG: cp: cannot stat 'Module.symvers': No such file or directory

This change will check the file Module.symvers existence before copying it.

Signed-off-by: Lili Li 
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 20a0135fc979..a1219f315620 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -463,7 +463,7 @@ do_shared_workdir () {
 
# Copy files required for module builds
cp System.map $kerneldir/System.map-${KERNEL_VERSION}
-   cp Module.symvers $kerneldir/
+   [ -e Module.symvers ] && cp Module.symvers $kerneldir/
cp .config $kerneldir/
mkdir -p $kerneldir/include/config
cp include/config/kernel.release 
$kerneldir/include/config/kernel.release
-- 
2.26.2

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#139976): 
https://lists.openembedded.org/g/openembedded-core/message/139976
Mute This Topic: https://lists.openembedded.org/mt/75119073/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-