Re: [OE-core] [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
No feelings were touched. I should have indeed explained why the SRC_URI
was changed.
I'll update the patch. Cheers.
On 02/06/18 23:35, Alexander Kanavin wrote:
I'm sorry for being terse. Reviewing patches before morning coffee is
not always a great idea.
When changing SRC_URI, you still need to explain in the commit message
what's wrong with the old URI and how the new URI was chosen.
Specifically here, alioth is not temporarily down, it has been
deliberately taken offline:
https://wiki.debian.org/Alioth
and the same wiki page lists salsa.debian.org as the successor. Any
debian-driven projects are likely to have been moved there, and so
that's the first place I had checked.
Alex
2018-06-02 16:35 GMT+03:00 Oleksandr Kravchuk
:
On 02/06/18 07:19, Alexander Kanavin wrote:
2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
:
SRC_URI =
"https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz;
+SRC_URI =
"https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz;
The correct new URI is
https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
ftp from google search results please.
Alex
It is not always easy to find "the new" official URI. I took the one that
was around for a long time, not "a random ftp from google search results".
I will fix and resend the patch.
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
I'm sorry for being terse. Reviewing patches before morning coffee is
not always a great idea.
When changing SRC_URI, you still need to explain in the commit message
what's wrong with the old URI and how the new URI was chosen.
Specifically here, alioth is not temporarily down, it has been
deliberately taken offline:
https://wiki.debian.org/Alioth
and the same wiki page lists salsa.debian.org as the successor. Any
debian-driven projects are likely to have been moved there, and so
that's the first place I had checked.
Alex
2018-06-02 16:35 GMT+03:00 Oleksandr Kravchuk
:
> On 02/06/18 07:19, Alexander Kanavin wrote:
>>
>> 2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
>> :
>>>
>>> SRC_URI =
>>> "https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz;
>>> +SRC_URI =
>>> "https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz;
>>
>> The correct new URI is
>> https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
>> ftp from google search results please.
>>
>> Alex
>
> It is not always easy to find "the new" official URI. I took the one that
> was around for a long time, not "a random ftp from google search results".
>
> I will fix and resend the patch.
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
On 02/06/18 07:19, Alexander Kanavin wrote:
2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
:
SRC_URI =
"https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz;
+SRC_URI =
"https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz;
The correct new URI is
https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
ftp from google search results please.
Alex
It is not always easy to find "the new" official URI. I took the one
that was around for a long time, not "a random ftp from google search
results".
I will fix and resend the patch.
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
:
> SRC_URI =
> "https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz;
> +SRC_URI =
> "https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz;
The correct new URI is
https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
ftp from google search results please.
Alex
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
Signed-off-by: Oleksandr Kravchuk
---
meta/recipes-support/iso-codes/iso-codes_3.77.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-support/iso-codes/iso-codes_3.77.bb
b/meta/recipes-support/iso-codes/iso-codes_3.77.bb
index bd613ac573..d899a7fa82 100644
--- a/meta/recipes-support/iso-codes/iso-codes_3.77.bb
+++ b/meta/recipes-support/iso-codes/iso-codes_3.77.bb
@@ -3,6 +3,7 @@ LICENSE = "LGPLv2.1"
LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
SRC_URI =
"https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz;
+SRC_URI =
"https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz;
SRC_URI[md5sum] = "9d0d06cfb4634428b300845edcd7140a"
SRC_URI[sha256sum] =
"21cd73a4c6f95d9474ebfcffd4e065223857720f24858e564f4409b19f7f0d90"
--
2.17.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
