Re: [OE-core] [morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp
On Thu, Feb 9, 2017 at 2:46 AM, Jussi Kukkonenwrote: > On 8 February 2017 at 22:06, George McCollister > wrote: >> >> Any chance we can get this applied to morty? > > > You should add [morty] tag to subject and CC the maintainer > (akuster...@gmail.com) to improve chances of this happening. I'm sure Armin > would also appreciate explicit confirmation that the patches apply to morty > branch. [morty] was in the subject but I didn't CC the maintainer. Now I know who the maintainer is. > > Before that some review though (sorry I missed this in Dec) ... it looks > like the "Add imp to importlib" commit only modified manifest.inc: this is a > generated file and your changes will be overwritten next time someone runs > the generator. You should modify > scripts/contrib/python/generate-manifest-3.5.py and run that to generate the > new manifest.inc file. Yes, I messed that up. Someone else fixed it in master here: http://git.openembedded.org/openembedded-core/commit/scripts/contrib/python/generate-manifest-3.5.py?id=bfe1d948ab034017622110c8365be7026e139fbf > > It would be nice if we did not store noth the source and the generated files > in git but that's how it's currently setup... I'll resend my two patches with the patch that fixes generate-manifest-3.5.py for morty. > > Jussi -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp
On 8 February 2017 at 22:06, George McCollister < george.mccollis...@gmail.com> wrote: > Any chance we can get this applied to morty? > You should add [morty] tag to subject and CC the maintainer ( akuster...@gmail.com) to improve chances of this happening. I'm sure Armin would also appreciate explicit confirmation that the patches apply to morty branch. Before that some review though (sorry I missed this in Dec) ... it looks like the "Add imp to importlib" commit only modified manifest.inc: this is a generated file and your changes will be overwritten next time someone runs the generator. You should modify scripts/contrib/python/ generate-manifest-3.5.py and run that to generate the new manifest.inc file. It would be nice if we did not store noth the source and the generated files in git but that's how it's currently setup... Jussi -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp
Any chance we can get this applied to morty? -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp
Add imp to python3-importlib. Make gdb-cross-canadian depend on nativesdk-python3-importlib when python is enabled. The following changes since commit c8d96b10ee3bc2eae0fd269d2564286fd0bc82ed: rm_work: Ensure we don't remove sigbasedata files (2016-11-16 10:34:34 +) are available in the git repository at: git://github.com/gmccollister/openembedded-core morty-gdb-cross-canadian https://github.com/gmccollister/openembedded-core/tree/morty-gdb-cross-canadian George McCollister (2): python-3.5-manifest: Add imp to importlib gdb-cross-canadian: Depend on nativesdk-python3-importlib meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++- meta/recipes-devtools/python/python-3.5-manifest.inc | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.9.3 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core