Re: [OE-core] qemu: backport patches to fix cves breaks qemu-system-native
On Wed, 2019-03-20 at 12:12 +, Alexey Brodkin wrote: > Hi Richard, > > [snip] > > > > > We're not seeing this on the autobuilder, is this gated by some > > > > non- > > > > default config option? > > > > > > Maybe. > > > > > > But if you grep by qemu sources you may notice that indeed > > > VENDOR_ERR_INV_NUM_SGE is not defined anywhere. So regardless of > > > my > > > setup > > > that looks like a valid and expected build failure. > > > > > > At least that was the case after I fetched OE-core changes this > > > morning. > > > > I don't doubt it, I'm just wondering why our testing didn't > > highlight > > it... > > Well that's indeed strange as this is host package and so shouldn't > have > anything target arch-specific. > > But do you build "qemu-system-native" by autobuilder? > Just a guess... We boot test qemu using it in many places, so yes, very much so. Hence why I'm wondering what happened... Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] qemu: backport patches to fix cves breaks qemu-system-native
Hi Richard, > -Original Message- > From: richard.pur...@linuxfoundation.org > Sent: Wednesday, March 20, 2019 3:04 PM > To: Alexey Brodkin ; Kai Kang > > Cc: Patches and discussions about the oe-core layer > > Subject: Re: qemu: backport patches to fix cves breaks qemu-system-native > > On Wed, 2019-03-20 at 07:42 +, Alexey Brodkin wrote: > > Hello Kai Kang, > > > > You recent changes in QEMU [1] lead to build failure: > > -->8- > > > > # bitbake qemu-system-native > > ... > > > .../build/tmp-glibc/work/x86_64-linux/qemu-system-native/3.1.0- > > > r0/qemu-3.1.0/hw/rdma/rdma_backend.c:316:42: error: > > > 'VENDOR_ERR_INV_NUM_SGE' undeclared (first use in this function) > > > comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, > > > ctx); > > > ^ > > -->8- > > > > > > That's obviously because of meta/recipes-devtools/qemu/qemu/0015-fix- > > CVE-2018-20124.patch. > > > > I'm wondering if you tried to build QEMU yourself? > > We're not seeing this on the autobuilder, is this gated by some non- > default config option? Maybe. But if you grep by qemu sources you may notice that indeed VENDOR_ERR_INV_NUM_SGE is not defined anywhere. So regardless of my setup that looks like a valid and expected build failure. At least that was the case after I fetched OE-core changes this morning. -Alexey -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] qemu: backport patches to fix cves breaks qemu-system-native
Hi Richard, [snip] > > > > > We're not seeing this on the autobuilder, is this gated by some > > > non- > > > default config option? > > > > Maybe. > > > > But if you grep by qemu sources you may notice that indeed > > VENDOR_ERR_INV_NUM_SGE is not defined anywhere. So regardless of my > > setup > > that looks like a valid and expected build failure. > > > > At least that was the case after I fetched OE-core changes this > > morning. > > I don't doubt it, I'm just wondering why our testing didn't highlight > it... Well that's indeed strange as this is host package and so shouldn't have anything target arch-specific. But do you build "qemu-system-native" by autobuilder? Just a guess... -Alexey -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] qemu: backport patches to fix cves breaks qemu-system-native
On Wed, 2019-03-20 at 12:07 +, Alexey Brodkin wrote: > Hi Richard, > > > -Original Message- > > From: richard.pur...@linuxfoundation.org < > > richard.pur...@linuxfoundation.org> > > Sent: Wednesday, March 20, 2019 3:04 PM > > To: Alexey Brodkin ; Kai Kang < > > kai.k...@windriver.com> > > Cc: Patches and discussions about the oe-core layer < > > openembedded-core@lists.openembedded.org> > > Subject: Re: qemu: backport patches to fix cves breaks qemu-system- > > native > > > > On Wed, 2019-03-20 at 07:42 +, Alexey Brodkin wrote: > > > Hello Kai Kang, > > > > > > You recent changes in QEMU [1] lead to build failure: > > > -->8- > > > > > > > > > # bitbake qemu-system-native > > > ... > > > > .../build/tmp-glibc/work/x86_64-linux/qemu-system-native/3.1.0- > > > > r0/qemu-3.1.0/hw/rdma/rdma_backend.c:316:42: error: > > > > 'VENDOR_ERR_INV_NUM_SGE' undeclared (first use in this > > > > function) > > > > comp_handler(IBV_WC_GENERAL_ERR, > > > > VENDOR_ERR_INV_NUM_SGE, > > > > ctx); > > > > ^ > > > -->8- > > > > > > > > > > > > That's obviously because of meta/recipes-devtools/qemu/qemu/0015- > > > fix- > > > CVE-2018-20124.patch. > > > > > > I'm wondering if you tried to build QEMU yourself? > > > > We're not seeing this on the autobuilder, is this gated by some > > non- > > default config option? > > Maybe. > > But if you grep by qemu sources you may notice that indeed > VENDOR_ERR_INV_NUM_SGE is not defined anywhere. So regardless of my > setup > that looks like a valid and expected build failure. > > At least that was the case after I fetched OE-core changes this > morning. I don't doubt it, I'm just wondering why our testing didn't highlight it... Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] qemu: backport patches to fix cves breaks qemu-system-native
On Wed, 2019-03-20 at 07:42 +, Alexey Brodkin wrote: > Hello Kai Kang, > > You recent changes in QEMU [1] lead to build failure: > -->8- > > # bitbake qemu-system-native > ... > > .../build/tmp-glibc/work/x86_64-linux/qemu-system-native/3.1.0- > > r0/qemu-3.1.0/hw/rdma/rdma_backend.c:316:42: error: > > 'VENDOR_ERR_INV_NUM_SGE' undeclared (first use in this function) > > comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, > > ctx); > > ^ > -->8- > > > That's obviously because of meta/recipes-devtools/qemu/qemu/0015-fix- > CVE-2018-20124.patch. > > I'm wondering if you tried to build QEMU yourself? We're not seeing this on the autobuilder, is this gated by some non- default config option? Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] qemu: backport patches to fix cves breaks qemu-system-native
On 2019/3/20 下午3:42, Alexey Brodkin wrote: Hello Kai Kang, You recent changes in QEMU [1] lead to build failure: -->8- # bitbake qemu-system-native ... | .../build/tmp-glibc/work/x86_64-linux/qemu-system-native/3.1.0-r0/qemu-3.1.0/hw/rdma/rdma_backend.c:316:42: error: 'VENDOR_ERR_INV_NUM_SGE' undeclared (first use in this function) | comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx); | ^ -->8- That's obviously because of meta/recipes-devtools/qemu/qemu/0015-fix-CVE-2018-20124.patch. I'm wondering if you tried to build QEMU yourself? My fault. qemu & qemu-native has been verified but qemu-system-native not. I'll send fix ASAP. Regards, Kai [1] https://github.com/openembedded/openembedded-core/commit/489ece1aa90d8f76b4c1f009d837f82e38e11ba9 -Alexey -- Kai Kang -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] qemu: backport patches to fix cves breaks qemu-system-native
Hello Kai Kang, You recent changes in QEMU [1] lead to build failure: -->8- # bitbake qemu-system-native ... | .../build/tmp-glibc/work/x86_64-linux/qemu-system-native/3.1.0-r0/qemu-3.1.0/hw/rdma/rdma_backend.c:316:42: error: 'VENDOR_ERR_INV_NUM_SGE' undeclared (first use in this function) | comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx); | ^ -->8- That's obviously because of meta/recipes-devtools/qemu/qemu/0015-fix-CVE-2018-20124.patch. I'm wondering if you tried to build QEMU yourself? [1] https://github.com/openembedded/openembedded-core/commit/489ece1aa90d8f76b4c1f009d837f82e38e11ba9 -Alexey -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core