Re: [OE-core] [PATCH] qemu: add gettext to DEPENDS
This is not a correct fix. We have a gettext bbclass for a reason.
On Fri, May 11, 2018 at 9:35 AM, Chris Patterson wrote:
> From: Chris Patterson
>
> Otherwise QEMU build may fail with missing `msgfmt` command.
>
> | make -C po install
> | GEN bg.mo
> | GEN tr.mo
> | GEN de_DE.mo
> | /bin/sh: msgfmt: command not found
> | /bin/sh: msgfmt: command not found
>
> Signed-off-by: Chris Patterson
> ---
> meta/recipes-devtools/qemu/qemu.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/qemu/qemu.inc
> b/meta/recipes-devtools/qemu/qemu.inc
> index dc73df8..ba1b9b2 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -1,7 +1,7 @@
> SUMMARY = "Fast open source processor emulator"
> HOMEPAGE = "http://qemu.org";
> LICENSE = "GPLv2 & LGPLv2.1"
> -DEPENDS = "glib-2.0 zlib pixman"
> +DEPENDS = "glib-2.0 zlib pixman gettext"
> RDEPENDS_${PN}_class-target += "bash"
>
> require qemu-targets.inc
> --
> 2.1.4
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] qemu: add gettext to DEPENDS
On Fri, May 11, 2018 at 3:10 PM, Christopher Larson wrote: > This is not a correct fix. We have a gettext bbclass for a reason. > I did look at that prior to doing this. It was my initial approach, but inheriting gettext causes qemu build to fail when it modifies the EXTRA_OECONF options with the nls flag (that qemu doesn't process). There are quite a few other recipes using gettext-native in their DEPENDS, and the reason for one over the other isn't quite clear. In the other thread (v2), Khem requested it only be added conditionally if the gtk packageconfig flag is enabled. Do you think it would be appropriate to check packageconfig flag, then conditionally inherit, then resolve (scrub) the unsupported configure flags? Or modify the class such that modifying the OECONF is prevented to begin with? Cheers! -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] qemu: add gettext to DEPENDS
On Fri, May 11, 2018 at 05:21:09PM -0400, Chris Patterson wrote: > On Fri, May 11, 2018 at 3:10 PM, Christopher Larson wrote: > > This is not a correct fix. We have a gettext bbclass for a reason. > > > > I did look at that prior to doing this. It was my initial approach, > but inheriting gettext causes qemu build to fail when it modifies the > EXTRA_OECONF options with the nls flag (that qemu doesn't process). > There are quite a few other recipes using gettext-native in their > DEPENDS, and the reason for one over the other isn't quite clear. > > In the other thread (v2), Khem requested it only be added > conditionally if the gtk packageconfig flag is enabled. Do you think > it would be appropriate to check packageconfig flag, then > conditionally inherit, then resolve (scrub) the unsupported configure > flags? Or modify the class such that modifying the OECONF is prevented > to begin with? Are you using gtk PACKAGECONFIG for qemu-native (or nativesdk-qemu)? Last time I've tried I've found that there are many things missing to make it usable, see last few commits at: http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/qemu I haven't tried gtk(3) for target build, it probably works better there. -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com signature.asc Description: Digital signature -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] qemu: add gettext to DEPENDS
On Fri, May 11, 2018 at 5:32 PM, Martin Jansa wrote: > On Fri, May 11, 2018 at 05:21:09PM -0400, Chris Patterson wrote: >> On Fri, May 11, 2018 at 3:10 PM, Christopher Larson >> wrote: >> > This is not a correct fix. We have a gettext bbclass for a reason. >> > >> >> I did look at that prior to doing this. It was my initial approach, >> but inheriting gettext causes qemu build to fail when it modifies the >> EXTRA_OECONF options with the nls flag (that qemu doesn't process). >> There are quite a few other recipes using gettext-native in their >> DEPENDS, and the reason for one over the other isn't quite clear. >> >> In the other thread (v2), Khem requested it only be added >> conditionally if the gtk packageconfig flag is enabled. Do you think >> it would be appropriate to check packageconfig flag, then >> conditionally inherit, then resolve (scrub) the unsupported configure >> flags? Or modify the class such that modifying the OECONF is prevented >> to begin with? > > Are you using gtk PACKAGECONFIG for qemu-native (or nativesdk-qemu)? > Last time I've tried I've found that there are many things missing to > make it usable, see last few commits at: > http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/qemu > > I haven't tried gtk(3) for target build, it probably works better there. > I was looking to use it in my image (non-native). Thank you for the info! -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
