Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Jussi Kukkonen]

On 3 April 2017 at 14:00, Choong, Yin Thong 
wrote:
>
> Hi,
> Once I change to github.com below error pop out. Seem like it miss align
with the patch compare with github.com logrotate source. Both package seem
got miss align on the version. When I compare yoctoproject logrotate.c and
github logrotate.c it has big different (as attached), there even got
different parameter count on some API function


Ross's  suggestion of asking the maintainer is good but I'll note that
there does not seem to be any difference in the actual source files: you're
maybe looking at a different version.

The patching error is a result of the top level source directory name
changing. This could be worked around with
  S = "${WORKDIR}/logrotate-r3-9-1"

Jussi
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Burton, Ross]

On 3 April 2017 at 12:00, Choong, Yin Thong 
wrote:

> https://downloads.yoctoproject.org/mirror/sources/logrotate-3.9.1.tar.gz
>
> https://github.com/logrotate/logrotate/archive/r3-9-1.tar.gz
>
>
Annoyingly the /archive/ links on github are generated on demand by 'git
archive' so only contain the exact contents of the git archive and will not
be identical to the tarballs.

As the maintainer has been uploading generated tarballs for new releases
(3.9.2, etc) it's probably work asking him if he'd be willing to upload the
older tarballs too.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Choong, Yin Thong]

Hi,
Once I change to github.com below error pop out. Seem like it miss align with 
the patch compare with github.com logrotate source. Both package seem got miss 
align on the version. When I compare yoctoproject logrotate.c and github 
logrotate.c it has big different (as attached), there even got different 
parameter count on some API function. Let’s stick with yoctoproject.org/mirror 
1st ? Or I check back the github to get for suitable version? Then I may need 
to rename bbrecipe filename base on the github version? Suggestion?

https://downloads.yoctoproject.org/mirror/sources/logrotate-3.9.1.tar.gz
https://github.com/logrotate/logrotate/archive/r3-9-1.tar.gz

ERROR: logrotate-3.9.1-r0 do_patch: Command Error: 'quilt --quiltrc 
/home/yinthong/rebeccapoky/build/tmp/work/i586-poky-linux/logrotate/3.9.1-r0/recipe-sysroot-native/etc/quiltrc
 push' exited with 0  Output:
Applying patch act-as-mv-when-rotate.patch
can't find file to patch at input line 20
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--
|From 68f29ab490cf987aa34b5f4caf1784b58a021308 Mon Sep 17 00:00:00 2001
|From: Robert Yang <liezhi.y...@windriver.com>
|Date: Tue, 17 Feb 2015 21:08:07 -0800
|Subject: [PATCH] Act as the "mv" command when rotate log
|
|Act as the "mv" command when rotate log, first rename, if failed, then
|read and write.
|
|Upstream-Status: Pending
|
|Signed-off-by: Robert Yang <liezhi.y...@windriver.com>
|---
| logrotate.c |   71 +--
| 1 file changed, 59 insertions(+), 12 deletions(-)
|
|diff --git a/logrotate.c b/logrotate.c
|index d3deb6a..cf8bf2c 100644
|--- a/logrotate.c
|+++ b/logrotate.c
--
No file to patch.  Skipping patch.
6 out of 6 hunks ignored
Patch act-as-mv-when-rotate.patch does not apply (enforce with -f)
ERROR: logrotate-3.9.1-r0 do_patch: Function failed: patch_do_patch
ERROR: Logfile of failure stored in: 
/home/yinthong/rebeccapoky/build/tmp/work/i586-poky-linux/logrotate/3.9.1-r0/temp/log.do_patch.130676
ERROR: Task 
(/home/yinthong/rebeccapoky/meta/recipes-extended/logrotate/logrotate_3.9.1.bb:do_patch)
 failed with exit code '1'

Thanks and Regards
Choong YinThong

From: Burton, Ross [mailto:ross.bur...@intel.com]
Sent: Monday, April 3, 2017 5:17 PM
To: Kukkonen, Jussi <jussi.kukko...@intel.com>
Cc: Choong, Yin Thong <yin.thong.cho...@intel.com>; Patches and discussions 
about the oe-core layer <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI 
with yoctoproject.org source


On 3 April 2017 at 09:30, Jussi Kukkonen 
<jussi.kukko...@intel.com<mailto:jussi.kukko...@intel.com>> wrote:
This is true, there's not that much in the repo itself to create trust. The 
major show of trust is here though: 
http://pkgs.fedoraproject.org/cgit/rpms/logrotate.git/commit/?id=9cb55142e51b82085d6c3136448c1f441454e351
Fedora/Red Hat themselves changed to use this repo when the fedorahosted repos 
were EOL'd (see also Red Hat folks working on the github issues in January).

So logrotate was originally hosted on Fedora infrastructure that is then shut 
down, a github repository appears and Fedora fetch from that github repository. 
 Also the commit in the github repository to change the README from 
fedorahosted to github 
(https://github.com/logrotate/logrotate/commit/09c4fa8bc6cf2c01bad24d33c3ea69371030c014)
 was committed by a Red Hat employee (https://github.com/kdudka).

Whilst there are many official-looking forks on github that are just Some Guy, 
this is clearly the new canonical home.

Ross


1styocto_2ndgithub_logrotate.diff
Description: 1styocto_2ndgithub_logrotate.diff
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Burton, Ross]

On 3 April 2017 at 09:30, Jussi Kukkonen  wrote:

> This is true, there's not that much in the repo itself to create trust.
> The major show of trust is here though: http://pkgs.fedoraproject.org/
> cgit/rpms/logrotate.git/commit/?id=9cb55142e51b82085d6c3136448c1f
> 441454e351
> Fedora/Red Hat themselves changed to use this repo when the fedorahosted
> repos were EOL'd (see also Red Hat folks working on the github issues in
> January).
>

So logrotate was originally hosted on Fedora infrastructure that is then
shut down, a github repository appears and Fedora fetch from that github
repository.  Also the commit in the github repository to change the README
from fedorahosted to github (
https://github.com/logrotate/logrotate/commit/09c4fa8bc6cf2c01bad24d33c3ea69371030c014)
was committed by a Red Hat employee (https://github.com/kdudka).

Whilst there are many official-looking forks on github that are just Some
Guy, this is clearly the new canonical home.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Alexander Kanavin]

On 04/03/2017 11:30 AM, Jussi Kukkonen wrote:


This is true, there's not that much in the repo itself to create trust.
The major show of trust is here though:
http://pkgs.fedoraproject.org/cgit/rpms/logrotate.git/commit/?id=9cb55142e51b82085d6c3136448c1f441454e351
Fedora/Red Hat themselves changed to use this repo when the fedorahosted
repos were EOL'd (see also Red Hat folks working on the github issues in
January).

If the release tarballs have been re-generated and the hashes no longer
match, I'd still prefer modifying the recipe to use github (after
manually diffing to make sure they are the same source release of
course) but I can understand a differing viewpoint in this case.

It would be good to mention the issue in the commit message, whichever
way this is solved.


If github is not trustworthy, I'd say taking the tarball from Debian 
should be good enough. Same applies to chkconfig - we just shouldn't 
self-host these things, as that guarantees support headaches.



Alex

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Jussi Kukkonen]

On 3 April 2017 at 10:53, Choong, Yin Thong 
wrote:

> Hi,
>
> The link seem like create by an individual, no a company or group.
> Therefore, we decide to drop this link and go for yoctoproject.org/mirror.
>

This is true, there's not that much in the repo itself to create trust. The
major show of trust is here though:
http://pkgs.fedoraproject.org/cgit/rpms/logrotate.git/commit/?id=9cb55142e51b82085d6c3136448c1f441454e351
Fedora/Red Hat themselves changed to use this repo when the fedorahosted
repos were EOL'd (see also Red Hat folks working on the github issues in
January).

If the release tarballs have been re-generated and the hashes no longer
match, I'd still prefer modifying the recipe to use github (after manually
diffing to make sure they are the same source release of course) but I can
understand a differing viewpoint in this case.

It would be good to mention the issue in the commit message, whichever way
this is solved.

Thanks,
  Jussi
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Choong, Yin Thong]

Hi,
The link seem like create by an individual, no a company or group. Therefore, 
we decide to drop this link and go for yoctoproject.org/mirror.

Thanks and Regards
Choong YinThong

From: Jussi Kukkonen [mailto:jussi.kukko...@intel.com]
Sent: Monday, April 3, 2017 3:46 PM
To: Choong, Yin Thong <yin.thong.cho...@intel.com>
Cc: Patches and discussions about the oe-core layer 
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI 
with yoctoproject.org source



On 3 April 2017 at 05:51, 
<yin.thong.cho...@intel.com<mailto:yin.thong.cho...@intel.com>> wrote:
>
> From: Choong YinThong 
> <yin.thong.cho...@intel.com<mailto:yin.thong.cho...@intel.com>>
>
> fedorahosted.org<http://fedorahosted.org> was retired on March 1st, 2017. 
> This is to
> update the SRC_URI to point to 
> yoctoproject.org/mirror<http://yoctoproject.org/mirror>.

Hi,

Is there a reason not to use https://github.com/logrotate/logrotate ?

Same question applies to the selftest patch as well.

Thanks,
  Jussi

>
>
> [YOCTO #11226]
>
> Signed-off-by: Choong YinThong 
> <yin.thong.cho...@intel.com<mailto:yin.thong.cho...@intel.com>>
> ---
>  
> meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb> 
> | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git 
> a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb>
>  
> b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb>
> index 9c2dfe0..386c01b 100644
> --- 
> a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb>
> +++ 
> b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb<http://logrotate_3.9.1.bb>
> @@ -1,6 +1,6 @@
>  SUMMARY = "Rotates, compresses, removes and mails system log files"
>  SECTION = "console/utils"
> -HOMEPAGE = "https://fedorahosted.org/logrotate/;
> +HOMEPAGE = "http://downloads.yoctoproject.org;
>  LICENSE = "GPLv2"
>
>  # TODO: logrotate 3.8.8 adds autotools/automake support, update recipe to 
> use it.
> @@ -10,7 +10,7 @@ DEPENDS="coreutils popt"
>
>  LIC_FILES_CHKSUM = 
> "file://COPYING;md5=18810669f13b87348459e611d31ab760"
>
> -SRC_URI = 
> "https://fedorahosted.org/releases/l/o/logrotate/logrotate-${PV}.tar.gz<https://fedorahosted.org/releases/l/o/logrotate/logrotate-$%7bPV%7d.tar.gz>
>  \
> +SRC_URI = 
> "http://downloads.yoctoproject.org/mirror/sources/logrotate-${PV}.tar.gz<http://downloads.yoctoproject.org/mirror/sources/logrotate-$%7bPV%7d.tar.gz>
>  \
> file://act-as-mv-when-rotate.patch \
> file://update-the-manual.patch \
> file://disable-check-different-filesystems.patch \
> --
> 2.7.4
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Jussi Kukkonen]

On 3 April 2017 at 05:51,  wrote:
>
> From: Choong YinThong 
>
> fedorahosted.org was retired on March 1st, 2017. This is to
> update the SRC_URI to point to yoctoproject.org/mirror.

Hi,

Is there a reason not to use https://github.com/logrotate/logrotate ?

Same question applies to the selftest patch as well.

Thanks,
  Jussi

>
>
> [YOCTO #11226]
>
> Signed-off-by: Choong YinThong 
> ---
>  meta/recipes-extended/logrotate/logrotate_3.9.1.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> index 9c2dfe0..386c01b 100644
> --- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> +++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> @@ -1,6 +1,6 @@
>  SUMMARY = "Rotates, compresses, removes and mails system log files"
>  SECTION = "console/utils"
> -HOMEPAGE = "https://fedorahosted.org/logrotate/;
> +HOMEPAGE = "http://downloads.yoctoproject.org;
>  LICENSE = "GPLv2"
>
>  # TODO: logrotate 3.8.8 adds autotools/automake support, update recipe
to use it.
> @@ -10,7 +10,7 @@ DEPENDS="coreutils popt"
>
>  LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
>
> -SRC_URI = "
https://fedorahosted.org/releases/l/o/logrotate/logrotate-${PV}.tar.gz \
> +SRC_URI = "
http://downloads.yoctoproject.org/mirror/sources/logrotate-${PV}.tar.gz \
> file://act-as-mv-when-rotate.patch \
> file://update-the-manual.patch \
> file://disable-check-different-filesystems.patch \
> --
> 2.7.4
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core