Re: [OE-core] [PATCH v2 11/13] selftest: sstatetests: skip methods in case of poky-tiny or opengl is missing

[Leonardo Sandoval]

On 12/13/2016 09:25 AM, Burton, Ross wrote:
On 24 November 2016 at 20:58, 
> wrote:


diff --git a/meta/lib/oeqa/selftest/sstatetests.py
b/meta/lib/oeqa/selftest/sstatetests.py
index 6642539..8ea3932 100644
--- a/meta/lib/oeqa/selftest/sstatetests.py
+++ b/meta/lib/oeqa/selftest/sstatetests.py
@@ -42,20 +42,36 @@ class SStateTests(SStateBase):
 @testcase(975)
 def test_sstate_creation_distro_specific_pass(self):
 targetarch = get_bb_var('TUNE_ARCH')
-self.run_test_sstate_creation(['binutils-cross-'+
targetarch, 'binutils-native'], distro_specific=True,
distro_nonspecific=False, temp_sstate_location=True)
+# Execute the test in all distros expect poky-tiny where
glibc-initial is not provided
+targets = ['binutils-cross-'+ targetarch, 'binutils-native']
+if self.distro == 'poky-tiny':
+self.skipTest('Distro %s does not support building
the following targets %s' % (self.distro, ','.join(targets)))
+self.run_test_sstate_creation(targets,
distro_specific=True, distro_nonspecific=False,
temp_sstate_location=True)


Sounds like it would be easier to just remove glibc-initial from that 
list, and either remove it entirely or replace it with a virtual name 
that both glibc and musl provide.

Ok


@@ -228,6 +255,8 @@ class SStateTests(SStateBase):
 build machines and running a builds, override the
variables calling uname()
 manually and check using bitbake -S.
 """
+if self.distro == 'poky-tiny':
+self.skipTest('core-image-sato not buildable for
poky-tiny')

 topdir = get_bb_var('TOPDIR')
 targetvendor = get_bb_var('TARGET_VENDOR')


For all of these tests that just do bitbake -S core-image-sato, if 
world works then that is more flexible and more comprehensive.




Agree. Sending v3 soon.



Ross


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v2 11/13] selftest: sstatetests: skip methods in case of poky-tiny or opengl is missing

[Burton, Ross]

On 24 November 2016 at 20:58, 
wrote:

> diff --git a/meta/lib/oeqa/selftest/sstatetests.py
> b/meta/lib/oeqa/selftest/sstatetests.py
> index 6642539..8ea3932 100644
> --- a/meta/lib/oeqa/selftest/sstatetests.py
> +++ b/meta/lib/oeqa/selftest/sstatetests.py
> @@ -42,20 +42,36 @@ class SStateTests(SStateBase):
>  @testcase(975)
>  def test_sstate_creation_distro_specific_pass(self):
>  targetarch = get_bb_var('TUNE_ARCH')
> -self.run_test_sstate_creation(['binutils-cross-'+ targetarch,
> 'binutils-native'], distro_specific=True, distro_nonspecific=False,
> temp_sstate_location=True)
> +# Execute the test in all distros expect poky-tiny where
> glibc-initial is not provided
> +targets = ['binutils-cross-'+ targetarch, 'binutils-native']
> +if self.distro == 'poky-tiny':
> +self.skipTest('Distro %s does not support building the
> following targets %s' % (self.distro, ','.join(targets)))
> +self.run_test_sstate_creation(targets, distro_specific=True,
> distro_nonspecific=False, temp_sstate_location=True)
>

Sounds like it would be easier to just remove glibc-initial from that list,
and either remove it entirely or replace it with a virtual name that both
glibc and musl provide.


> @@ -228,6 +255,8 @@ class SStateTests(SStateBase):
>  build machines and running a builds, override the variables
> calling uname()
>  manually and check using bitbake -S.
>  """
> +if self.distro == 'poky-tiny':
> +self.skipTest('core-image-sato not buildable for poky-tiny')
>
>  topdir = get_bb_var('TOPDIR')
>  targetvendor = get_bb_var('TARGET_VENDOR')
>

For all of these tests that just do bitbake -S core-image-sato, if world
works then that is more flexible and more comprehensive.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core