Re: [OE-core] [master][PATCH] perl: reorder tar arguments in do_install_ptest()

[Renato Caldas]

2016-05-30 22:49 GMT+01:00 Aníbal Limón :
> Thanks for sending the patch, only a little comment the [master] prefix
> isn't required.

I know, I meant to type "krogoth".. noticed the error shortly after
sending it :)

>
> alimon
>
> On 05/30/2016 04:45 PM, Renato Caldas wrote:
>> On some distributions tar requires the FILE argument to be the last, and
>> the existing order was causing the subsequent --exclude options to be 
>> dropped.
>>
>> Fixes [YOCTO #9673].
>>
>> Signed-off-by: Renato Caldas 
>> ---
>>  meta/recipes-devtools/perl/perl-ptest.inc | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/perl/perl-ptest.inc 
>> b/meta/recipes-devtools/perl/perl-ptest.inc
>> index 948ea7c..66c5355 100644
>> --- a/meta/recipes-devtools/perl/perl-ptest.inc
>> +++ b/meta/recipes-devtools/perl/perl-ptest.inc
>> @@ -7,8 +7,8 @@ do_install_ptest () {
>>   mkdir -p ${D}${PTEST_PATH}
>>   sed -e "s:\/opt:\/usr:" -i Porting/add-package.pl
>>   sed -e "s:\/local\/gnu\/:\/:" -i hints/cxux.sh
>> - tar -cf - * --exclude \*.o --exclude libperl.so --exclude Makefile 
>> --exclude makefile --exclude hostperl \
>> - --exclude miniperl --exclude generate_uudmap --exclude patches 
>> | ( cd ${D}${PTEST_PATH} && tar -xf - )
>> + tar -cf - --exclude \*.o --exclude libperl.so --exclude Makefile 
>> --exclude makefile --exclude hostperl \
>> + --exclude miniperl --exclude generate_uudmap --exclude patches 
>> * | ( cd ${D}${PTEST_PATH} && tar -xf - )
>>
>>   sed -i -e "s,${D},,g" \
>>  -e "s,--sysroot=${STAGING_DIR_HOST},,g" \
>>
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [master][PATCH] perl: reorder tar arguments in do_install_ptest()

[Aníbal Limón]

Thanks for sending the patch, only a little comment the [master] prefix
isn't required.

alimon

On 05/30/2016 04:45 PM, Renato Caldas wrote:
> On some distributions tar requires the FILE argument to be the last, and
> the existing order was causing the subsequent --exclude options to be dropped.
> 
> Fixes [YOCTO #9673].
> 
> Signed-off-by: Renato Caldas 
> ---
>  meta/recipes-devtools/perl/perl-ptest.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/perl/perl-ptest.inc 
> b/meta/recipes-devtools/perl/perl-ptest.inc
> index 948ea7c..66c5355 100644
> --- a/meta/recipes-devtools/perl/perl-ptest.inc
> +++ b/meta/recipes-devtools/perl/perl-ptest.inc
> @@ -7,8 +7,8 @@ do_install_ptest () {
>   mkdir -p ${D}${PTEST_PATH}
>   sed -e "s:\/opt:\/usr:" -i Porting/add-package.pl
>   sed -e "s:\/local\/gnu\/:\/:" -i hints/cxux.sh
> - tar -cf - * --exclude \*.o --exclude libperl.so --exclude Makefile 
> --exclude makefile --exclude hostperl \
> - --exclude miniperl --exclude generate_uudmap --exclude patches 
> | ( cd ${D}${PTEST_PATH} && tar -xf - )
> + tar -cf - --exclude \*.o --exclude libperl.so --exclude Makefile 
> --exclude makefile --exclude hostperl \
> + --exclude miniperl --exclude generate_uudmap --exclude patches 
> * | ( cd ${D}${PTEST_PATH} && tar -xf - )
>  
>   sed -i -e "s,${D},,g" \
>  -e "s,--sysroot=${STAGING_DIR_HOST},,g" \
> 



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core