Re: [OE-core] [poky][PATCH 1/6] gstreamer1.0-plugins-bad: Enable gldeinterlace on OpenGL ES
On Mon, Jul 4, 2016 at 7:46 AM, Yuqing Zhuwrote: > ++ > ++#if GST_GL_HAVE_OPENGL > ++ if (USING_OPENGL (context)) { > ++gl->MatrixMode (GL_PROJECTION); > ++gl->LoadIdentity (); > ++ } > ++#endif > + yes, I know , a bit late in the game.. but this patch breaks when -bad is built with 'opengl' support in PACKAGECONFIG. In the original upstream commit at [1] the .h file defines the USING_OPENGL macro, but that piece of code was not backported properly in OE and it leaves USING_OPENGL as an undefined symbol.. This is now a morty issue.. i will try to cook up a patch for it later today. [1] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=0cfb0890ce9a20f096a0a9c9f23b656f436794c6 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [poky][PATCH 1/6] gstreamer1.0-plugins-bad: Enable gldeinterlace on OpenGL ES
Hi Ross, Thanks for your feedback. Yes, it is backported from 1.9.1, I will update the Upstream-Status and resend the patch. B.R. Carol From: Burton, Ross [mailto:ross.bur...@intel.com] Sent: Monday, July 04, 2016 6:19 PM To: Yuqing Zhu <carol@nxp.com> Cc: OE-core <openembedded-core@lists.openembedded.org> Subject: Re: [OE-core] [poky][PATCH 1/6] gstreamer1.0-plugins-bad: Enable gldeinterlace on OpenGL ES On 4 July 2016 at 06:46, Yuqing Zhu <carol@nxp.com<mailto:carol@nxp.com>> wrote: +Upstream-Status: Pending + +https://bugzilla.gnome.org/show_bug.cgi?id=764873 U-S says Pending, bug says fixed. Is this a backport of a change that actually landed upstream? I don't really agree with OE-Core carrying new API and features in a core component like GStreamer that are not backported. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [poky][PATCH 1/6] gstreamer1.0-plugins-bad: Enable gldeinterlace on OpenGL ES
On 4 July 2016 at 06:46, Yuqing Zhuwrote: > +Upstream-Status: Pending > + > +https://bugzilla.gnome.org/show_bug.cgi?id=764873 > U-S says Pending, bug says fixed. Is this a backport of a change that actually landed upstream? I don't really agree with OE-Core carrying new API and features in a core component like GStreamer that are not backported. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core