Re: [oe] meta-openembedded patch flow

2018-05-23 Thread Andrea Galbusera
On Thu, May 24, 2018 at 4:58 AM, Khem Raj  wrote:
> On Wed, May 23, 2018 at 9:26 PM, Andre McCurdy  wrote:
>> On Tue, May 22, 2018 at 4:20 PM, Khem Raj  wrote:
>>> Hi All,
>>>
>>> I am writing this to just paraphrase the patch flight process that is
>>> in place more or less
>>> and I am going to follow.
>>>
>>> We have patchwork instance where all patches from mailing list are captured
>>>
>>> https://patchwork.openembedded.org/project/oe/patches/
>>>
>>> I am going to watch this and cherry pick patches from patchwork into
>>> master-next branch
>>
>> New patches currently seem to be going into
>> meta-openembedded-contrib/kraj/master.
>>
>
> Yes, currently, I am trying to get the jenkins builds going, and until
> then I have been
> staging them into contrib kraj/master, so it can be run though my home
> based CI loop.
>
>> Is that the branch you mean when you say "master-next"?
>>
>
> Once I get the jenkins job straightened out, then it will start using
> this branch

Is the CI jobs configuration available somewhere? I need to setup a
company CI infrastructure and it'd be nice to dig into already working
setups.

>>> master-next then will be run through CI loop on my own system as well as on
>>>
>>> http://jenkins.nas-admin.org/
>>>
>>> tasks - oe_world_qemuarm oe_world_qemuarm64 oe_world_qemux86 
>>> oe_world_qemux86-64
>>>
>>> For layer maintainers
>>>
>>> Please review and provide your ACK/NACK based upon your own testing
>>> and judgement. If
>>> you want to rely on the jenkins jobs above thats fine too. If you want
>>> to test your bundle separately
>>> and send a separate approved patchlist via a pull thats fine too.
>>> Usually we do not give explicit
>>> ACKs and provide feedback if a patch needs to be changed. It would be
>>> good if you start providing
>>> ACKs if you think patch is good to signal. If a patch is not
>>> ACKED/NACKED and its passing the
>>> jenkins builds, I will assume you are OK with the patch for master.
>>>
>>> Submitters, please watch the patchwork for progress on your submission
>>> Hopefully patchwork will reflect the current state
>>> more accurately, if its stuck in same state for a long time (1+ weeks
>>> ) send the pings to maintainers.
>>> you can also check master-next branch if its still there and not
>>> dropped then its in queue for merge
>>>
>>> Since we all have limited resources and time, I would invite all of
>>> you to test master-next for machines/distros you are interested in
>>> (keep in mind master-next will get rebased) and provide
>>> feedback/review so we can include it in decision
>>> to accept the patch, any help will be appreciated.
>>>
>>> If you have suggestions, feel free to share here
>>>
>>> Thanks
>>> -Khem
>>> --
>>> ___
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] meta-openembedded patch flow

2018-05-23 Thread Khem Raj
On Wed, May 23, 2018 at 9:26 PM, Andre McCurdy  wrote:
> On Tue, May 22, 2018 at 4:20 PM, Khem Raj  wrote:
>> Hi All,
>>
>> I am writing this to just paraphrase the patch flight process that is
>> in place more or less
>> and I am going to follow.
>>
>> We have patchwork instance where all patches from mailing list are captured
>>
>> https://patchwork.openembedded.org/project/oe/patches/
>>
>> I am going to watch this and cherry pick patches from patchwork into
>> master-next branch
>
> New patches currently seem to be going into
> meta-openembedded-contrib/kraj/master.
>

Yes, currently, I am trying to get the jenkins builds going, and until
then I have been
staging them into contrib kraj/master, so it can be run though my home
based CI loop.

> Is that the branch you mean when you say "master-next"?
>

Once I get the jenkins job straightened out, then it will start using
this branch

>> master-next then will be run through CI loop on my own system as well as on
>>
>> http://jenkins.nas-admin.org/
>>
>> tasks - oe_world_qemuarm oe_world_qemuarm64 oe_world_qemux86 
>> oe_world_qemux86-64
>>
>> For layer maintainers
>>
>> Please review and provide your ACK/NACK based upon your own testing
>> and judgement. If
>> you want to rely on the jenkins jobs above thats fine too. If you want
>> to test your bundle separately
>> and send a separate approved patchlist via a pull thats fine too.
>> Usually we do not give explicit
>> ACKs and provide feedback if a patch needs to be changed. It would be
>> good if you start providing
>> ACKs if you think patch is good to signal. If a patch is not
>> ACKED/NACKED and its passing the
>> jenkins builds, I will assume you are OK with the patch for master.
>>
>> Submitters, please watch the patchwork for progress on your submission
>> Hopefully patchwork will reflect the current state
>> more accurately, if its stuck in same state for a long time (1+ weeks
>> ) send the pings to maintainers.
>> you can also check master-next branch if its still there and not
>> dropped then its in queue for merge
>>
>> Since we all have limited resources and time, I would invite all of
>> you to test master-next for machines/distros you are interested in
>> (keep in mind master-next will get rebased) and provide
>> feedback/review so we can include it in decision
>> to accept the patch, any help will be appreciated.
>>
>> If you have suggestions, feel free to share here
>>
>> Thanks
>> -Khem
>> --
>> ___
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] meta-openembedded patch flow

2018-05-23 Thread Andre McCurdy
On Tue, May 22, 2018 at 4:20 PM, Khem Raj  wrote:
> Hi All,
>
> I am writing this to just paraphrase the patch flight process that is
> in place more or less
> and I am going to follow.
>
> We have patchwork instance where all patches from mailing list are captured
>
> https://patchwork.openembedded.org/project/oe/patches/
>
> I am going to watch this and cherry pick patches from patchwork into
> master-next branch

New patches currently seem to be going into
meta-openembedded-contrib/kraj/master.

Is that the branch you mean when you say "master-next"?

> master-next then will be run through CI loop on my own system as well as on
>
> http://jenkins.nas-admin.org/
>
> tasks - oe_world_qemuarm oe_world_qemuarm64 oe_world_qemux86 
> oe_world_qemux86-64
>
> For layer maintainers
>
> Please review and provide your ACK/NACK based upon your own testing
> and judgement. If
> you want to rely on the jenkins jobs above thats fine too. If you want
> to test your bundle separately
> and send a separate approved patchlist via a pull thats fine too.
> Usually we do not give explicit
> ACKs and provide feedback if a patch needs to be changed. It would be
> good if you start providing
> ACKs if you think patch is good to signal. If a patch is not
> ACKED/NACKED and its passing the
> jenkins builds, I will assume you are OK with the patch for master.
>
> Submitters, please watch the patchwork for progress on your submission
> Hopefully patchwork will reflect the current state
> more accurately, if its stuck in same state for a long time (1+ weeks
> ) send the pings to maintainers.
> you can also check master-next branch if its still there and not
> dropped then its in queue for merge
>
> Since we all have limited resources and time, I would invite all of
> you to test master-next for machines/distros you are interested in
> (keep in mind master-next will get rebased) and provide
> feedback/review so we can include it in decision
> to accept the patch, any help will be appreciated.
>
> If you have suggestions, feel free to share here
>
> Thanks
> -Khem
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [PATCH] redis: Update to 4.0.8

2018-05-23 Thread Khem Raj
On Wed, May 23, 2018 at 9:03 PM, Alistair Francis  wrote:
> On Wed, May 23, 2018 at 5:37 PM, Khem Raj  wrote:
>> On Wed, May 23, 2018 at 5:58 PM, Alistair Francis
>>  wrote:
>>> Update redis to the latest 4.0.8 release. This also involves updating
>>> the redis.conf while maintaining some OE specific config options.
>>>
>>
>> fails on mips
>>
>> | networking.o: In function `createClient':
>> | /usr/src/debug/redis/4.0.8-r0/redis-4.0.8/src/networking.c:93:
>> undefined reference to `__atomic_fetch_add_8'
>> | collect2: error: ld returned 1 exit status
>> | make[1]: *** [redis-server] Error 1
>> | make[1]: *** Waiting for unfinished jobs
>> | make[1]: Leaving directory
>> `/mnt/jenkins/workspace/OpenEmbedded/build/tmp/work/mips32r2-bec-linux/redis/4.0.8-r0/redis-4.0.8/src'
>> | make: *** [all] Error 2
>> | ERROR: oe_runmake failed
>
> This seems like a limitation in Redis:
> https://github.com/antirez/redis/issues/4282
>
> I see two options:
>  1. Try and add pthread support to Redis for MIPS and then maintain that
>  2. Move the other platforms forward to 4.0.x and keep MIPS at the old
> 3.x version or remove Redis for MIPS
>
> Thoughts?
>

does this work ?

https://github.com/patrikx3/lede-redis/blob/master/redis/patches/010-redis.patch

> Alistair
>
>>
>>
>>
>>> Signed-off-by: Alistair Francis 
>>> ---
>>>  ...Makefile-to-add-symbols-to-staticlib.patch |  19 -
>>>  .../hiredis-use-default-CC-if-it-is-set.patch |  12 +-
>>>  .../redis/redis/oe-use-libc-malloc.patch  |  10 +-
>>>  .../recipes-extended/redis/redis/redis.conf   | 974 --
>>>  .../redis/{redis_3.0.2.bb => redis_4.0.8.bb}  |   5 +-
>>>  5 files changed, 882 insertions(+), 138 deletions(-)
>>>  delete mode 100644 
>>> meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
>>>  rename meta-oe/recipes-extended/redis/{redis_3.0.2.bb => redis_4.0.8.bb} 
>>> (89%)
>>>
>>> diff --git 
>>> a/meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
>>>  
>>> b/meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
>>> deleted file mode 100644
>>> index 2b3b58793..0
>>> --- 
>>> a/meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
>>> +++ /dev/null
>>> @@ -1,19 +0,0 @@
>>>  redis-3.0.2/deps/hiredis/Makefile.orig 2016-05-06 
>>> 19:36:26.179003036 -0700
>>> -+++ redis-3.0.2/deps/hiredis/Makefile  2016-05-06 19:40:15.341340736 -0700
>>> -@@ -25,7 +25,7 @@
>>> -
>>> - # Fallback to gcc when $CC is not in $PATH.
>>> - CC?=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || 
>>> echo gcc')
>>> --OPTIMIZATION?=-O3
>>> -+OPTIMIZATION?=-O2
>>> - WARNINGS=-Wall -W -Wstrict-prototypes -Wwrite-strings
>>> - DEBUG?= -g -ggdb
>>> - REAL_CFLAGS=$(OPTIMIZATION) -fPIC $(CFLAGS) $(WARNINGS) $(DEBUG) $(ARCH)
>>> -@@ -68,6 +68,7 @@
>>> -
>>> - $(STLIBNAME): $(OBJ)
>>> -   $(STLIB_MAKE_CMD) $(OBJ)
>>> -+  $(RANLIB) $@
>>> -
>>> - dynamic: $(DYLIBNAME)
>>> - static: $(STLIBNAME)
>>> diff --git 
>>> a/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
>>>  
>>> b/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
>>> index f9f1c0dbd..421f306de 100644
>>> --- 
>>> a/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
>>> +++ 
>>> b/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
>>> @@ -8,23 +8,23 @@ as CC has spaces in it, just skip it if one was already 
>>> passed in.
>>>
>>>  Signed-off-by: Venture Research 
>>>
>>> -Update to work with 3.0.x
>>> -Signed-off-by: Armin Kuster 
>>> +Update to work with 4.0.8
>>> +Signed-off-by: Alistair Francis 
>>>
>>>  ---
>>>   deps/hiredis/Makefile | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> -Index: deps/hiredis/Makefile
>>> -===
>>> +diff --git a/deps/hiredis/Makefile b/deps/hiredis/Makefile
>>> +index 9a4de836..271c06ba 100644
>>>  --- a/deps/hiredis/Makefile
>>>  +++ b/deps/hiredis/Makefile
>>> -@@ -24,7 +24,7 @@ endef
>>> +@@ -36,7 +36,7 @@ endef
>>>   export REDIS_TEST_CONFIG
>>>
>>>   # Fallback to gcc when $CC is not in $PATH.
>>>  -CC:=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || 
>>> echo gcc')
>>>  +CC?=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || 
>>> echo gcc')
>>> + CXX:=$(shell sh -c 'type $(CXX) >/dev/null 2>/dev/null && echo $(CXX) || 
>>> echo g++')
>>>   OPTIMIZATION?=-O3
>>>   WARNINGS=-Wall -W -Wstrict-prototypes -Wwrite-strings
>>> - DEBUG?= -g -ggdb
>>> diff --git a/meta-oe/recipes-extended/redis/redis/oe-use-libc-malloc.patch 
>>> 

Re: [oe] [PATCH] redis: Update to 4.0.8

2018-05-23 Thread Khem Raj
On Wed, May 23, 2018 at 5:58 PM, Alistair Francis
 wrote:
> Update redis to the latest 4.0.8 release. This also involves updating
> the redis.conf while maintaining some OE specific config options.
>

fails on mips

| networking.o: In function `createClient':
| /usr/src/debug/redis/4.0.8-r0/redis-4.0.8/src/networking.c:93:
undefined reference to `__atomic_fetch_add_8'
| collect2: error: ld returned 1 exit status
| make[1]: *** [redis-server] Error 1
| make[1]: *** Waiting for unfinished jobs
| make[1]: Leaving directory
`/mnt/jenkins/workspace/OpenEmbedded/build/tmp/work/mips32r2-bec-linux/redis/4.0.8-r0/redis-4.0.8/src'
| make: *** [all] Error 2
| ERROR: oe_runmake failed



> Signed-off-by: Alistair Francis 
> ---
>  ...Makefile-to-add-symbols-to-staticlib.patch |  19 -
>  .../hiredis-use-default-CC-if-it-is-set.patch |  12 +-
>  .../redis/redis/oe-use-libc-malloc.patch  |  10 +-
>  .../recipes-extended/redis/redis/redis.conf   | 974 --
>  .../redis/{redis_3.0.2.bb => redis_4.0.8.bb}  |   5 +-
>  5 files changed, 882 insertions(+), 138 deletions(-)
>  delete mode 100644 
> meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
>  rename meta-oe/recipes-extended/redis/{redis_3.0.2.bb => redis_4.0.8.bb} 
> (89%)
>
> diff --git 
> a/meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
>  
> b/meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
> deleted file mode 100644
> index 2b3b58793..0
> --- 
> a/meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
> +++ /dev/null
> @@ -1,19 +0,0 @@
>  redis-3.0.2/deps/hiredis/Makefile.orig 2016-05-06 19:36:26.179003036 
> -0700
> -+++ redis-3.0.2/deps/hiredis/Makefile  2016-05-06 19:40:15.341340736 -0700
> -@@ -25,7 +25,7 @@
> -
> - # Fallback to gcc when $CC is not in $PATH.
> - CC?=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || echo 
> gcc')
> --OPTIMIZATION?=-O3
> -+OPTIMIZATION?=-O2
> - WARNINGS=-Wall -W -Wstrict-prototypes -Wwrite-strings
> - DEBUG?= -g -ggdb
> - REAL_CFLAGS=$(OPTIMIZATION) -fPIC $(CFLAGS) $(WARNINGS) $(DEBUG) $(ARCH)
> -@@ -68,6 +68,7 @@
> -
> - $(STLIBNAME): $(OBJ)
> -   $(STLIB_MAKE_CMD) $(OBJ)
> -+  $(RANLIB) $@
> -
> - dynamic: $(DYLIBNAME)
> - static: $(STLIBNAME)
> diff --git 
> a/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
>  
> b/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
> index f9f1c0dbd..421f306de 100644
> --- 
> a/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
> +++ 
> b/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
> @@ -8,23 +8,23 @@ as CC has spaces in it, just skip it if one was already 
> passed in.
>
>  Signed-off-by: Venture Research 
>
> -Update to work with 3.0.x
> -Signed-off-by: Armin Kuster 
> +Update to work with 4.0.8
> +Signed-off-by: Alistair Francis 
>
>  ---
>   deps/hiredis/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> -Index: deps/hiredis/Makefile
> -===
> +diff --git a/deps/hiredis/Makefile b/deps/hiredis/Makefile
> +index 9a4de836..271c06ba 100644
>  --- a/deps/hiredis/Makefile
>  +++ b/deps/hiredis/Makefile
> -@@ -24,7 +24,7 @@ endef
> +@@ -36,7 +36,7 @@ endef
>   export REDIS_TEST_CONFIG
>
>   # Fallback to gcc when $CC is not in $PATH.
>  -CC:=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || echo 
> gcc')
>  +CC?=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || echo 
> gcc')
> + CXX:=$(shell sh -c 'type $(CXX) >/dev/null 2>/dev/null && echo $(CXX) || 
> echo g++')
>   OPTIMIZATION?=-O3
>   WARNINGS=-Wall -W -Wstrict-prototypes -Wwrite-strings
> - DEBUG?= -g -ggdb
> diff --git a/meta-oe/recipes-extended/redis/redis/oe-use-libc-malloc.patch 
> b/meta-oe/recipes-extended/redis/redis/oe-use-libc-malloc.patch
> index b768a7749..6745f3d0e 100644
> --- a/meta-oe/recipes-extended/redis/redis/oe-use-libc-malloc.patch
> +++ b/meta-oe/recipes-extended/redis/redis/oe-use-libc-malloc.patch
> @@ -11,15 +11,15 @@ jemalloc wasn't building correctly.
>
>  Signed-off-by: Venture Research 
>
> -Update to work with 3.0.x
> -Signed-off-by: Armin Kuster 
> +Update to work with 4.0.8
> +Signed-off-by: Alistair Francis 
>
>  ---
>   src/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> -Index: src/Makefile
> -===
> +diff --git a/src/Makefile b/src/Makefile
> +index 86e0b3fe..a810180b 100644
>  --- a/src/Makefile
>  +++ b/src/Makefile
>  @@ -13,7 +13,8 @@
> @@ -29,6 +29,6 

[oe] [meta-oe][PATCH 1/2] libgpiod: update to 1.1

2018-05-23 Thread Martin Hundebøll
Add native dependency on autoconf-archive as it is now used by the
libgpiod autotools.

Signed-off-by: Martin Hundebøll 
---
 meta-oe/recipes-support/libgpiod/libgpiod_1.0.1.bb | 4 
 meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb   | 6 ++
 2 files changed, 6 insertions(+), 4 deletions(-)
 delete mode 100644 meta-oe/recipes-support/libgpiod/libgpiod_1.0.1.bb
 create mode 100644 meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb

diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.0.1.bb 
b/meta-oe/recipes-support/libgpiod/libgpiod_1.0.1.bb
deleted file mode 100644
index 51499fd72..0
--- a/meta-oe/recipes-support/libgpiod/libgpiod_1.0.1.bb
+++ /dev/null
@@ -1,4 +0,0 @@
-require libgpiod.inc
-
-SRC_URI[md5sum] = "2ca0c3eb17d69e367b6f6a109ca86e41"
-SRC_URI[sha256sum] = 
"972924195367f5fb045c023d65340c4b7dfc8764499516be446553865208dedc"
diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb 
b/meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb
new file mode 100644
index 0..c2e11ad38
--- /dev/null
+++ b/meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb
@@ -0,0 +1,6 @@
+require libgpiod.inc
+
+DEPENDS += "autoconf-archive-native"
+
+SRC_URI[md5sum] = "80237a047a9d653a14c5d71e5ce9d641"
+SRC_URI[sha256sum] = 
"9758466468a7ef3f5e30c182c1303abef6241e665cda4d82a64328a7474838c1"
-- 
2.17.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH 2/2] libgpiod: add packageconfig for python bindings

2018-05-23 Thread Martin Hundebøll
Signed-off-by: Martin Hundebøll 
---
 meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb | 8 
 1 file changed, 8 insertions(+)

diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb 
b/meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb
index c2e11ad38..1bda8bc3a 100644
--- a/meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb
+++ b/meta-oe/recipes-support/libgpiod/libgpiod_1.1.bb
@@ -4,3 +4,11 @@ DEPENDS += "autoconf-archive-native"
 
 SRC_URI[md5sum] = "80237a047a9d653a14c5d71e5ce9d641"
 SRC_URI[sha256sum] = 
"9758466468a7ef3f5e30c182c1303abef6241e665cda4d82a64328a7474838c1"
+
+PACKAGECONFIG[python3] = 
"--enable-bindings-python,--disable-bindings-python,python3,python3-core"
+inherit ${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3native', '', 
d)}
+
+PACKAGES =+ "${PN}-python"
+FILES_${PN}-python = "${PYTHON_SITEPACKAGES_DIR}"
+RRECOMMENDS_PYTHON = "${@bb.utils.contains('PACKAGECONFIG', 'python3', 
'${PN}-python', '',d)}"
+RRECOMMENDS_${PN} += "${RRECOMMENDS_PYTHON}"
-- 
2.17.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-multimedia][PATCH 3/3] libmusicbrainz: Set CMAKE_EXE_LINKER_FLAGS to build linker flags

2018-05-23 Thread Khem Raj
Some older compilers do not support security flags like -fstack-protector=strong
and if we do not set this then it will use the target flags to pass here
which will fail with gcc < 5.x, especially a problem building distros with
security flags on host with 4.x gcc e.g. ubuntu 14.04

Signed-off-by: Khem Raj 
---
 .../recipes-multimedia/musicbrainz/libmusicbrainz_git.bb  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb 
b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
index 16e52134bd..ca9d94a19c 100644
--- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
+++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
@@ -22,10 +22,12 @@ do_configure_prepend() {
 git clean -dfx -e /.pc/ -e /patches/ .
 mkdir build-native
 cd build-native
-cmake -DCMAKE_C_FLAGS=${BUILD_CFLAGS} \
+LDFLAGS="${BUILD_LDFLAGS}" \
+  cmake -DCMAKE_C_FLAGS=${BUILD_CFLAGS} \
   -DCMAKE_C_COMPILER=${BUILD_CC} \
   -DCMAKE_CXX_FLAGS=${BUILD_CXXFLAGS} \
   -DCMAKE_CXX_COMPILER=${BUILD_CXX} \
+  -DCMAKE_EXE_LINKER_FLAGS=${BUILD_LDFLAGS} \
   ..
 make make-c-interface
 cd ..
-- 
2.17.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH 1/3] procmail: Use build ldflags when invoking native compile/link

2018-05-23 Thread Khem Raj
Some older compilers do not support security flags like -fstack-protector=strong
and if we do not set this then it will use the target flags to pass here
which will fail with gcc < 5.x, especially a problem building distros with
security flags on host with 4.x gcc e.g. ubuntu 14.04

Signed-off-by: Khem Raj 
---
 meta-oe/recipes-support/procmail/procmail_3.22.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/procmail/procmail_3.22.bb 
b/meta-oe/recipes-support/procmail/procmail_3.22.bb
index aa474ceb14..6160733b3d 100644
--- a/meta-oe/recipes-support/procmail/procmail_3.22.bb
+++ b/meta-oe/recipes-support/procmail/procmail_3.22.bb
@@ -29,7 +29,7 @@ do_configure() {
 export CFLAGS="${BUILD_CFLAGS}"
 export AR="${BUILD_AR}"
 export AS="${BUILD_AS}"
-make TARGET_CFLAGS="$TARGET_CFLAGS -D_LARGEFILE_SOURCE 
-D_FILE_OFFSET_BITS=64" LDFLAGS0="${LDFLAGS}" autoconf.h
+make TARGET_CFLAGS="$TARGET_CFLAGS -D_LARGEFILE_SOURCE 
-D_FILE_OFFSET_BITS=64" LDFLAGS0="${BUILD_LDFLAGS}" autoconf.h
 }
 
 do_compile() {
-- 
2.17.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH 2/3] cpprest: Fix build with clang

2018-05-23 Thread Khem Raj
Signed-off-by: Khem Raj 
---
 .../0001-Fix-a-build-problem-on-Clang.patch   | 28 +++
 .../0002-Define-virtual-destructor.patch  | 28 +++
 .../recipes-support/cpprest/cpprest_2.10.2.bb |  8 --
 3 files changed, 61 insertions(+), 3 deletions(-)
 create mode 100644 
meta-oe/recipes-support/cpprest/cpprest-2.10.2/0001-Fix-a-build-problem-on-Clang.patch
 create mode 100644 
meta-oe/recipes-support/cpprest/cpprest-2.10.2/0002-Define-virtual-destructor.patch

diff --git 
a/meta-oe/recipes-support/cpprest/cpprest-2.10.2/0001-Fix-a-build-problem-on-Clang.patch
 
b/meta-oe/recipes-support/cpprest/cpprest-2.10.2/0001-Fix-a-build-problem-on-Clang.patch
new file mode 100644
index 00..dc6b9dfcab
--- /dev/null
+++ 
b/meta-oe/recipes-support/cpprest/cpprest-2.10.2/0001-Fix-a-build-problem-on-Clang.patch
@@ -0,0 +1,28 @@
+From 0c07931f77aa9df2da065b633ae66faad5a570ec Mon Sep 17 00:00:00 2001
+From: Wu Yongwei 
+Date: Tue, 10 Apr 2018 11:29:12 +0800
+Subject: [PATCH] Fix a build problem on Clang.
+
+AND_CAPTURE_MEMBER_FUNCTION_POINTERS workaround had a check for GCC,
+but did not exclude Clang.  Clang has a fake GCC version of 4.2, thus
+caused problems.
+
+Upstream-Status: Backport [https://github.com/Microsoft/cpprestsdk/pull/732]
+Signed-off-by: Khem Raj 
+---
+ Release/src/http/client/http_client_asio.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Release/src/http/client/http_client_asio.cpp 
b/Release/src/http/client/http_client_asio.cpp
+index 4ba3e085..fca4bb5b 100644
+--- a/Release/src/http/client/http_client_asio.cpp
 b/Release/src/http/client/http_client_asio.cpp
+@@ -47,7 +47,7 @@
+ #include 
+ #include 
+ 
+-#if defined(__GNUC__)
++#if defined(__GNUC__) && !defined(__clang__)
+ 
+ #if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8)
+ #define AND_CAPTURE_MEMBER_FUNCTION_POINTERS
diff --git 
a/meta-oe/recipes-support/cpprest/cpprest-2.10.2/0002-Define-virtual-destructor.patch
 
b/meta-oe/recipes-support/cpprest/cpprest-2.10.2/0002-Define-virtual-destructor.patch
new file mode 100644
index 00..34cbe66974
--- /dev/null
+++ 
b/meta-oe/recipes-support/cpprest/cpprest-2.10.2/0002-Define-virtual-destructor.patch
@@ -0,0 +1,28 @@
+From 816d183eb0fe9ab4607cb049b4b792f8df84d5fe Mon Sep 17 00:00:00 2001
+From: Khem Raj 
+Date: Tue, 22 May 2018 22:17:43 -0700
+Subject: [PATCH] Define virtual destructor
+
+Fixes
+error: destructor called on non-final 'pplx::details::linux_scheduler' that 
has virtual functions but non-virtual destructor 
[-Werror,-Wdelete-non-virtual-dtor]
+__data_.second().~_Tp();
+
+Upstream-Status: Pending [https://github.com/Microsoft/cpprestsdk/issues/747]
+
+Signed-off-by: Khem Raj 
+---
+ Release/include/pplx/pplxlinux.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/Release/include/pplx/pplxlinux.h 
b/Release/include/pplx/pplxlinux.h
+index 6aa1ba35..f3f8d70d 100644
+--- a/Release/include/pplx/pplxlinux.h
 b/Release/include/pplx/pplxlinux.h
+@@ -240,6 +240,7 @@ namespace platform
+ {
+ public:
+ _PPLXIMP virtual void schedule( TaskProc_t proc, _In_ void* param);
++virtual ~linux_scheduler() {}
+ };
+ 
+ } // namespace details
diff --git a/meta-oe/recipes-support/cpprest/cpprest_2.10.2.bb 
b/meta-oe/recipes-support/cpprest/cpprest_2.10.2.bb
index 2ba6fc66cc..1dbe093bee 100644
--- a/meta-oe/recipes-support/cpprest/cpprest_2.10.2.bb
+++ b/meta-oe/recipes-support/cpprest/cpprest_2.10.2.bb
@@ -5,9 +5,11 @@ LICENSE = "MIT"
 LIC_FILES_CHKSUM = 
"file://${S}/../license.txt;md5=a2e15b954769218ff912468eecd6a02f"
 DEPENDS = "openssl websocketpp zlib boost"
 
-SRC_URI = 
"git://github.com/Microsoft/cpprestsdk.git;protocol=https;branch=master"
-
-SRC_URI += "file://fix-cmake-install.patch"
+SRC_URI = 
"git://github.com/Microsoft/cpprestsdk.git;protocol=https;branch=master \
+   file://fix-cmake-install.patch \
+   file://0001-Fix-a-build-problem-on-Clang.patch;patchdir=.. \
+   file://0002-Define-virtual-destructor.patch;patchdir=.. \
+   "
 
 # tag 2.10.2
 SRCREV= "fea848e2a77563cf2a6f28f8eab396fd6e787fbf"
-- 
2.17.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [PATCH] redis: Update to 4.0.8

2018-05-23 Thread Alistair Francis
Update redis to the latest 4.0.8 release. This also involves updating
the redis.conf while maintaining some OE specific config options.

Signed-off-by: Alistair Francis 
---
 ...Makefile-to-add-symbols-to-staticlib.patch |  19 -
 .../hiredis-use-default-CC-if-it-is-set.patch |  12 +-
 .../redis/redis/oe-use-libc-malloc.patch  |  10 +-
 .../recipes-extended/redis/redis/redis.conf   | 974 --
 .../redis/{redis_3.0.2.bb => redis_4.0.8.bb}  |   5 +-
 5 files changed, 882 insertions(+), 138 deletions(-)
 delete mode 100644 
meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
 rename meta-oe/recipes-extended/redis/{redis_3.0.2.bb => redis_4.0.8.bb} (89%)

diff --git 
a/meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
 
b/meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
deleted file mode 100644
index 2b3b58793..0
--- 
a/meta-oe/recipes-extended/redis/redis/hiredis-update-Makefile-to-add-symbols-to-staticlib.patch
+++ /dev/null
@@ -1,19 +0,0 @@
 redis-3.0.2/deps/hiredis/Makefile.orig 2016-05-06 19:36:26.179003036 
-0700
-+++ redis-3.0.2/deps/hiredis/Makefile  2016-05-06 19:40:15.341340736 -0700
-@@ -25,7 +25,7 @@
- 
- # Fallback to gcc when $CC is not in $PATH.
- CC?=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || echo 
gcc')
--OPTIMIZATION?=-O3
-+OPTIMIZATION?=-O2
- WARNINGS=-Wall -W -Wstrict-prototypes -Wwrite-strings
- DEBUG?= -g -ggdb
- REAL_CFLAGS=$(OPTIMIZATION) -fPIC $(CFLAGS) $(WARNINGS) $(DEBUG) $(ARCH)
-@@ -68,6 +68,7 @@
- 
- $(STLIBNAME): $(OBJ)
-   $(STLIB_MAKE_CMD) $(OBJ)
-+  $(RANLIB) $@
- 
- dynamic: $(DYLIBNAME)
- static: $(STLIBNAME)
diff --git 
a/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
 
b/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
index f9f1c0dbd..421f306de 100644
--- 
a/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
+++ 
b/meta-oe/recipes-extended/redis/redis/hiredis-use-default-CC-if-it-is-set.patch
@@ -8,23 +8,23 @@ as CC has spaces in it, just skip it if one was already 
passed in.
 
 Signed-off-by: Venture Research 
 
-Update to work with 3.0.x
-Signed-off-by: Armin Kuster 
+Update to work with 4.0.8
+Signed-off-by: Alistair Francis 
 
 ---
  deps/hiredis/Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
-Index: deps/hiredis/Makefile
-===
+diff --git a/deps/hiredis/Makefile b/deps/hiredis/Makefile
+index 9a4de836..271c06ba 100644
 --- a/deps/hiredis/Makefile
 +++ b/deps/hiredis/Makefile
-@@ -24,7 +24,7 @@ endef
+@@ -36,7 +36,7 @@ endef
  export REDIS_TEST_CONFIG
  
  # Fallback to gcc when $CC is not in $PATH.
 -CC:=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || echo 
gcc')
 +CC?=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || echo 
gcc')
+ CXX:=$(shell sh -c 'type $(CXX) >/dev/null 2>/dev/null && echo $(CXX) || echo 
g++')
  OPTIMIZATION?=-O3
  WARNINGS=-Wall -W -Wstrict-prototypes -Wwrite-strings
- DEBUG?= -g -ggdb
diff --git a/meta-oe/recipes-extended/redis/redis/oe-use-libc-malloc.patch 
b/meta-oe/recipes-extended/redis/redis/oe-use-libc-malloc.patch
index b768a7749..6745f3d0e 100644
--- a/meta-oe/recipes-extended/redis/redis/oe-use-libc-malloc.patch
+++ b/meta-oe/recipes-extended/redis/redis/oe-use-libc-malloc.patch
@@ -11,15 +11,15 @@ jemalloc wasn't building correctly.
 
 Signed-off-by: Venture Research 
 
-Update to work with 3.0.x
-Signed-off-by: Armin Kuster 
+Update to work with 4.0.8
+Signed-off-by: Alistair Francis 
 
 ---
  src/Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
-Index: src/Makefile
-===
+diff --git a/src/Makefile b/src/Makefile
+index 86e0b3fe..a810180b 100644
 --- a/src/Makefile
 +++ b/src/Makefile
 @@ -13,7 +13,8 @@
@@ -29,6 +29,6 @@ Index: src/Makefile
 -uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
 +# use fake uname option to force use of generic libc
 +uname_S := "USE_LIBC_MALLOC"
+ uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo not')
  OPTIMIZATION?=-O2
  DEPENDENCY_TARGETS=hiredis linenoise lua
- 
diff --git a/meta-oe/recipes-extended/redis/redis/redis.conf 
b/meta-oe/recipes-extended/redis/redis/redis.conf
index ab024ad85..75037d6dc 100644
--- a/meta-oe/recipes-extended/redis/redis/redis.conf
+++ b/meta-oe/recipes-extended/redis/redis/redis.conf
@@ -1,4 +1,9 @@
-# Redis configuration file example
+# Redis configuration file example.
+#
+# Note that in order to read the configuration file, Redis must be
+# started with the file path as first argument:
+#
+# 

[oe] [meta-oe][PATCH] opencv: Work around deprecated ffmpeg functions

2018-05-23 Thread Jason Wessel
The ffmpeg no longer makes use of the AVFMT_RAWPICTURE format, but
opencv still has code in it for dealing with this type of exported
format.  For now it is easier to work around it and allow the code to
compile and it will just not get used.  A future version of OpenCV
will remove the AVFMT_RAWPICTURE handler.

Signed-off-by: Jason Wessel 
---
 ...-work-around-deprecated-ffmpeg-RAW-functi.patch | 33 ++
 meta-oe/recipes-support/opencv/opencv_3.3.bb   |  1 +
 2 files changed, 34 insertions(+)
 create mode 100644 
meta-oe/recipes-support/opencv/opencv/0001-Temporarliy-work-around-deprecated-ffmpeg-RAW-functi.patch

diff --git 
a/meta-oe/recipes-support/opencv/opencv/0001-Temporarliy-work-around-deprecated-ffmpeg-RAW-functi.patch
 
b/meta-oe/recipes-support/opencv/opencv/0001-Temporarliy-work-around-deprecated-ffmpeg-RAW-functi.patch
new file mode 100644
index 0..63cb7f943
--- /dev/null
+++ 
b/meta-oe/recipes-support/opencv/opencv/0001-Temporarliy-work-around-deprecated-ffmpeg-RAW-functi.patch
@@ -0,0 +1,33 @@
+From 7d31f41d2a6759e244983504ce855fc32916b97a Mon Sep 17 00:00:00 2001
+From: Jason Wessel 
+Date: Wed, 9 May 2018 13:33:59 -0700
+Subject: [PATCH] Temporarliy work around deprecated ffmpeg RAW function
+ compile failure until next uprev
+
+Signed-off-by: Jason Wessel 
+---
+ modules/videoio/src/cap_ffmpeg_impl.hpp | 8 
+ 1 file changed, 8 insertions(+)
+
+diff --git a/modules/videoio/src/cap_ffmpeg_impl.hpp 
b/modules/videoio/src/cap_ffmpeg_impl.hpp
+index 5a9b10f075..97c6b74b07 100644
+--- a/modules/videoio/src/cap_ffmpeg_impl.hpp
 b/modules/videoio/src/cap_ffmpeg_impl.hpp
+@@ -667,6 +667,14 @@ struct ImplMutex::Impl
+ 
+ #endif
+ 
++/* NOTE This is deprecated in ffmpeg and the code should be removed */
++#ifndef AVFMT_RAWPICTURE
++#define AVFMT_RAWPICTURE  0x0020
++#endif /* AVFMT_RAWPICTURE */
++#ifndef CODEC_FLAG_GLOBAL_HEADER
++#define CODEC_FLAG_GLOBAL_HEADER  AV_CODEC_FLAG_GLOBAL_HEADER
++#endif
++
+ void ImplMutex::init()
+ {
+ impl = new Impl();
+-- 
+2.11.0
+
diff --git a/meta-oe/recipes-support/opencv/opencv_3.3.bb 
b/meta-oe/recipes-support/opencv/opencv_3.3.bb
index ca62de7c8..b697f44d1 100644
--- a/meta-oe/recipes-support/opencv/opencv_3.3.bb
+++ b/meta-oe/recipes-support/opencv/opencv_3.3.bb
@@ -60,6 +60,7 @@ SRC_URI = "git://github.com/opencv/opencv.git;name=opencv \
 file://javagen.patch \
 file://protobuf.patch \
 file://already-exists.patch \
+file://0001-Temporarliy-work-around-deprecated-ffmpeg-RAW-functi.patch \
 "
 PV = "3.3+git${SRCPV}"
 
-- 
2.11.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-initramfs][PATCH v2] ubi-utils-klibc: update from v. 1.5.2 to 2.0.2

2018-05-23 Thread Andrea Adami
Update to new version and drop accepted patches.
Use autotools and packageconfig (for xattrs).

Signed-off-by: Andrea Adami 
---
 .../0001-Makefile-build-ubi-utils-only.patch   |  87 --
 .../0002-common.mk-for-klibc-CC-is-klcc.patch  |  27 --
 ...bubi.c-add-klibc-specific-fixes-for-ioctl.patch |  76 -
 ...patibility-to-dietlibc-klibc-musl-libc-af.patch |  88 --
 ...-more-workarounds-for-klibc-compatibility.patch |  52 
 ...rser-remove-unused-function-needing-float.patch |  85 --
 ...ls-common.c-convert-to-integer-arithmetic.patch |  64 
 ...ubiformat.c-convert-to-integer-arithmetic.patch |  44 ---
 ...arnings-about-implicit-non-const-casting-.patch |  48 ---
 ...h-fix-klibc-build-when-using-glibc-toolch.patch |  40 +++
 ...doing-preprocessor-magic-just-output-off_.patch | 326 +
 .../0003-Makefile.am-only-build-ubi-utils.patch|  34 +++
 ...s-common.h-no-features.h-for-klibc-builds.patch |  38 +++
 .../0005-common.h-replace-getline-with-fgets.patch |  56 
 ...ils-klibc_1.5.2.bb => ubi-utils-klibc_2.0.2.bb} |  27 +-
 15 files changed, 508 insertions(+), 584 deletions(-)
 delete mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0001-Makefile-build-ubi-utils-only.patch
 delete mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0002-common.mk-for-klibc-CC-is-klcc.patch
 delete mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0003-libubi.c-add-klibc-specific-fixes-for-ioctl.patch
 delete mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0004-Restore-compatibility-to-dietlibc-klibc-musl-libc-af.patch
 delete mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0005-common.h-more-workarounds-for-klibc-compatibility.patch
 delete mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0006-libiniparser-remove-unused-function-needing-float.patch
 delete mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0007-mtd-utils-common.c-convert-to-integer-arithmetic.patch
 delete mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0008-ubi-utils-ubiformat.c-convert-to-integer-arithmetic.patch
 delete mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0009-Eliminate-warnings-about-implicit-non-const-casting-.patch
 create mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-2.0.2/0001-libmissing.h-fix-klibc-build-when-using-glibc-toolch.patch
 create mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-2.0.2/0002-Instead-of-doing-preprocessor-magic-just-output-off_.patch
 create mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-2.0.2/0003-Makefile.am-only-build-ubi-utils.patch
 create mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-2.0.2/0004-mtd-utils-common.h-no-features.h-for-klibc-builds.patch
 create mode 100644 
meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-2.0.2/0005-common.h-replace-getline-with-fgets.patch
 rename meta-initramfs/recipes-devtools/mtd/{ubi-utils-klibc_1.5.2.bb => 
ubi-utils-klibc_2.0.2.bb} (64%)

diff --git 
a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0001-Makefile-build-ubi-utils-only.patch
 
b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0001-Makefile-build-ubi-utils-only.patch
deleted file mode 100644
index 6ac2cca..000
--- 
a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc-1.5.2/0001-Makefile-build-ubi-utils-only.patch
+++ /dev/null
@@ -1,87 +0,0 @@
-From 1c989e4c36d0bf76ab444f984bc73b98eeacd03f Mon Sep 17 00:00:00 2001
-From: Andrea Adami 
-Date: Sun, 29 Jun 2014 00:32:29 +0200
-Subject: [PATCH 1/9] Makefile: build ubi-utils only
-
-We build all the static ubi-utils but actually only ubiattach is needed in
-a minimalistic initramfs for the mount of ubi volumes.
-
-More fixes are needed in order to build the full mtd-utils.
-The first issue is:
-
-| mkfs.jffs2.c:64:20: fatal error: libgen.h: No such file or directory
-|  #include 
-
-Removing the include then the second error is:
-
-| mkfs.jffs2.c:1570:22: error: '_SC_PAGESIZE' undeclared
-| (first use in this function)
-|   page_size = sysconf(_SC_PAGESIZE);
-
-Upstream-Status: Inappropriate [embedded specific]
-
-Signed-off-by: Andrea Adami 

- Makefile | 26 ++
- 1 file changed, 2 insertions(+), 24 deletions(-)
-
-diff --git a/Makefile b/Makefile
-index 3ce8587..8b79f71 100644
 a/Makefile
-+++ b/Makefile
-@@ -16,28 +16,11 @@ endif
- 
- TESTS = tests
- 
--MTD_BINS = \
--  ftl_format flash_erase nanddump doc_loadbios \
--  ftl_check mkfs.jffs2 flash_lock flash_unlock \
--  flash_otp_info flash_otp_dump flash_otp_lock flash_otp_write \
--  mtd_debug flashcp nandwrite nandtest mtdpart \
--  jffs2dump \
--  nftldump nftl_format docfdisk \
--  rfddump rfdformat \
--  serve_image recv_image \

Re: [oe] [meta-java][PATCH] openjdk-8: update aarch64 version to 8u162b12

2018-05-23 Thread André Draszik
On Wed, 2018-05-23 at 12:37 +0100, André Draszik wrote:
> It looks like the files have changed, as the checksums for this 162b12
> update aren't right anymore...
> 
> Starting to look into this, I wonder if the URLs used by the OpenJDK-8
> recipes are actually meant to be stable? The URL pattern is
> 
> http://hg.openjdk.java.net/${OPENJDK_ARCH_PORT}/${OPENJDK_HG_U}/archive/${
> OPENJDK_FILE}
> 
> Considering 'archive' in the URL, and considering you can download an
> archive of tip if you want to, and the fact that the server doesn't send
> the
> size in bytes of the file - are these created on demand, and can thusly
> change due to timestamps? (Similar to the github archive problems we're
> having).
> 
> On the other hand, the previous checksums for the 161b15 release are still
> valid.
> 
> I'd suggest to switch the OpenJDK-8 recipes to fetching from hg://
> directly,
> rather than using those archive URLs?
> 
> So, are those archives meant to be returning the same file forever? Any
> thoughts?

Luckily, I still had my originally downloaded file lying somewhere :-) So,
the only difference seems to be a file called '.hg_archival.txt' (all
timestamps for all files / directories within both new and old archives are
the same, even for the .hg_archival.txt file)

When I downloaded originally, it contained:

repo: cfeea66a3fa8ca3686a7cfa2d0ce8ab0169f168d
node: 917454da25c1735c001ad84fae01c61e0dac0f07
branch: default
latesttag: aarch64-jdk8u161-b15
latesttagdistance: 1

Whereas when I download now, it contains:

repo: cfeea66a3fa8ca3686a7cfa2d0ce8ab0169f168d
node: f8e58f4c29aecbadcd7f1ee0e28a4ab8c8a7e3b1
branch: default
tag: aarch64-jdk8u171-b10


Any thoughts why a snapshot of an older tag (162b12) would suddenly start to
reference a newer tag (171b10). And why does the snapshot of the even older
tag 161b15 still doesn't reference the 171b10 tag, even when downloaded
anew? I don't know enough about mercurial to make sense out of that...


Cheers,
Andre'

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-java][PATCH] openjdk-8: update aarch64 version to 8u162b12

2018-05-23 Thread André Draszik
It looks like the files have changed, as the checksums for this 162b12
update aren't right anymore...

Starting to look into this, I wonder if the URLs used by the OpenJDK-8
recipes are actually meant to be stable? The URL pattern is

http://hg.openjdk.java.net/${OPENJDK_ARCH_PORT}/${OPENJDK_HG_U}/archive/${OPENJDK_FILE}

Considering 'archive' in the URL, and considering you can download an
archive of tip if you want to, and the fact that the server doesn't send the
size in bytes of the file - are these created on demand, and can thusly
change due to timestamps? (Similar to the github archive problems we're
having).

On the other hand, the previous checksums for the 161b15 release are still
valid.

I'd suggest to switch the OpenJDK-8 recipes to fetching from hg:// directly,
rather than using those archive URLs?

So, are those archives meant to be returning the same file forever? Any
thoughts?


Cheers,
Andre'

On Wed, 2018-04-25 at 16:07 +0100, André Draszik wrote:
> From: André Draszik 
> 
> Signed-off-by: André Draszik 
> ---
>  recipes-core/openjdk/openjdk-8-release-161b15.inc  | 33 ---
> ---
>  .../openjdk/openjdk-8-release-162b12-aarch64.inc   | 33
> ++
>  recipes-core/openjdk/openjdk-8_16xbyy.bb   |  5 ++--
>  recipes-core/openjdk/openjre-8_16xbyy.bb   |  5 ++--
>  4 files changed, 39 insertions(+), 37 deletions(-)
>  delete mode 100644 recipes-core/openjdk/openjdk-8-release-161b15.inc
>  create mode 100644 recipes-core/openjdk/openjdk-8-release-162b12-
> aarch64.inc
> 
> diff --git a/recipes-core/openjdk/openjdk-8-release-161b15.inc b/recipes-
> core/openjdk/openjdk-8-release-161b15.inc
> deleted file mode 100644
> index 0a4434c..000
> --- a/recipes-core/openjdk/openjdk-8-release-161b15.inc
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -require openjdk-8-release-16xbyy.inc
> -
> -CORBA_CHANGESET_aarch64 = "f73da600c483"
> -SRC_URI[corba.md5sum] = "bf884b82fcc6de466946fcb87d24ebf3"
> -SRC_URI[corba.sha256sum] =
> "ebf73d96185fc05e502088ae89a8d6494c3971dd220458deeff3876f72396b6c"
> -
> -HOTSPOT_CHANGESET_aarch64 = "a600839824fa"
> -SRC_URI[hotspot.md5sum] = "20c88ba26f8f45a2769f4edf32afd593"
> -SRC_URI[hotspot.sha256sum] =
> "6d0d1b9c2df3392ad6e21ca3eae39d06b50632a4a419da3d4363248943ea8b97"
> -
> -JAXP_CHANGESET_aarch64 = "b1e2af899046"
> -SRC_URI[jaxp.md5sum] = "219582b26d7de2973b75f4329b53ec7d"
> -SRC_URI[jaxp.sha256sum] =
> "907cc4dfb01a3a2a6d74dfa90fa6fcb5b3df55600f41ba44dcdc94b47e85a382"
> -
> -JAXWS_CHANGESET_aarch64 = "0002ed323fe5"
> -SRC_URI[jaxws.md5sum] = "44935b81e3405fcaef675d5d08c2149e"
> -SRC_URI[jaxws.sha256sum] =
> "0d1d52f1cf254a643ece1bd6cd8628fae1a4d56e8b59388cc9ad73b3caf151a1"
> -
> -JDK_CHANGESET_aarch64 = "c2ba2ed87d18"
> -SRC_URI[jdk.md5sum] = "f4c0393a157dcb8b90ee7c7d80cbdfbf"
> -SRC_URI[jdk.sha256sum] =
> "c84a17451b47242f9d96bf431011607afc3776f285a6ad9a60190fba2d434c49"
> -
> -LANGTOOLS_CHANGESET_aarch64 = "cdb217c578cb"
> -SRC_URI[langtools.md5sum] = "608cf07781259d916d1663d6a5ced26d"
> -SRC_URI[langtools.sha256sum] =
> "ad28e75bfaba1b64fdd02ea316db3ba3cba68007f90c5fa2be2418ce8bc0074d"
> -
> -NASHORN_CHANGESET_aarch64 = "505d0eb2fafe"
> -SRC_URI[nashorn.md5sum] = "be981a6c55f9e602ff129fed65505a8c"
> -SRC_URI[nashorn.sha256sum] =
> "14419ccd773e1db83b600d05aca3cbac9f24be77abda9a132d12305d8821d6d7"
> -
> -OPENJDK_CHANGESET_aarch64 = "917454da25c1"
> -SRC_URI[openjdk.md5sum] = "1e4b3eca032742b7448731f9b8fcb426"
> -SRC_URI[openjdk.sha256sum] =
> "1e17e2d8384a7b808a89b982e7c09c4feb8598b7a66b93697bfb8759c1005974"
> diff --git a/recipes-core/openjdk/openjdk-8-release-162b12-aarch64.inc
> b/recipes-core/openjdk/openjdk-8-release-162b12-aarch64.inc
> new file mode 100644
> index 000..ed3e957
> --- /dev/null
> +++ b/recipes-core/openjdk/openjdk-8-release-162b12-aarch64.inc
> @@ -0,0 +1,33 @@
> +require openjdk-8-release-16xbyy.inc
> +
> +CORBA_CHANGESET_aarch64 = "2c6daa746022"
> +SRC_URI[corba.md5sum] = "2ca2413f1e6eaeb49b1c138c5cafcb30"
> +SRC_URI[corba.sha256sum] =
> "3ffcd358e45b4af5a62d9ac1c8abea2e33a9d25b34096084bc77349d846cf4f4"
> +
> +HOTSPOT_CHANGESET_aarch64 = "b08b1e9e2963"
> +SRC_URI[hotspot.md5sum] = "bb632eba37ad0f54e0535c1e0ae3440c"
> +SRC_URI[hotspot.sha256sum] =
> "fcf8369ff8871dbee81de7a15432b625dd2c6dcfe43d2dd5194d9273de0fdbfc"
> +
> +JAXP_CHANGESET_aarch64 = "413640f7312d"
> +SRC_URI[jaxp.md5sum] = "3232a514db9b7ed2ffbc9ebd69acb4fd"
> +SRC_URI[jaxp.sha256sum] =
> "05ed49cea8559bcbd2ef285c8cfcb0b2026aefb1178ec531f9c72e3918c97a9c"
> +
> +JAXWS_CHANGESET_aarch64 = "8b27752a1bbe"
> +SRC_URI[jaxws.md5sum] = "6688b2d40a0c1d5edff1f5594b6ac7a0"
> +SRC_URI[jaxws.sha256sum] =
> "c818df20d14411af78654cb53cd7f87b1c5b42ed0158775869571a42f75f3c84"
> +
> +JDK_CHANGESET_aarch64 = "9944f808c91d"
> +SRC_URI[jdk.md5sum] = "77b1caebd3d9b89af6ee8d57958334f8"
> +SRC_URI[jdk.sha256sum] =
> "d401a0611c90b52d08424d427cb43e81234dda46645a02d90531dbcbb9976b80"
> +
> +LANGTOOLS_CHANGESET_aarch64 

[oe] [meta-oe][PATCH] turbostat: add the recipe of turbostat to meta-oe

2018-05-23 Thread Hongzhi.Song
It is an efficient and necessary tool to reflect the status of X86
processors. Turbostat reports processor topology, frequency, idle
power-state statistics, temperature and power on X86 processors.

Signed-off-by: Hongzhi.Song 
---
 recipes-kernel/turbostat/turbostat_3.4.bb | 58 +++
 1 file changed, 58 insertions(+)
 create mode 100644 recipes-kernel/turbostat/turbostat_3.4.bb

diff --git a/recipes-kernel/turbostat/turbostat_3.4.bb 
b/recipes-kernel/turbostat/turbostat_3.4.bb
new file mode 100644
index 000..13c53aa
--- /dev/null
+++ b/recipes-kernel/turbostat/turbostat_3.4.bb
@@ -0,0 +1,58 @@
+#
+# Copyright (C) 2013 Wind River Systems, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 as
+# published by the Free Software Foundation.
+#
+SUMMARY = "Frequency and Idle power monitoring tools for Linux"
+
+DESCRIPTION = "The turbostat tool allows you to determine the actual \
+processor frequency and idle power saving state residency on supported \
+processors."
+
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
+
+COMPATIBLE_HOST = '(x86_64.*|i.86.*)-linux'
+COMPATIBLE_HOST_libc-musl_class-target = "null"
+
+DEPENDS = "virtual/kernel"
+
+do_fetch[noexec] = "1"
+do_unpack[noexec] = "1"
+do_patch[noexec] = "1"
+
+# This looks in S, so we better make sure there's
+# something in the directory.
+#
+do_populate_lic[depends] = "${PN}:do_configure"
+
+
+EXTRA_OEMAKE = '\
+CC="${CC}" \
+   'CFLAGS=-Wall -I${STAGING_KERNEL_DIR}/arch/x86/include/uapi 
${LDFLAGS}' \
+   '
+
+# If we build under STAGING_KERNEL_DIR, source will not be put
+# into the dbg rpm.  STAGING_KERNEL_DIR will exist by the time
+# do_configure() is invoked so we can safely copy from it.
+#
+do_configure_prepend() {
+   mkdir -p ${S}
+   cp -r ${STAGING_KERNEL_DIR}/arch/x86/include/asm/msr-index.h ${S}
+   cp -r ${STAGING_KERNEL_DIR}/arch/x86/include/asm/intel-family.h ${S}
+   cp -r ${STAGING_KERNEL_DIR}/tools/power/x86/turbostat/* ${S}
+   cp -r ${STAGING_KERNEL_DIR}/COPYING ${S}
+}
+
+do_compile() {
+   sed -i 's#MSRHEADER#"msr-index.h"#' turbostat.c
+   sed -i 's#INTEL_FAMILY_HEADER#"intel-family.h"#' turbostat.c
+   sed -i 's#\$(CC) \$(CFLAGS) \$< -o \$(BUILD_OUTPUT)/\$@#\$(CC) 
\$(CFLAGS) \$(LDFLAGS) \$< -o \$(BUILD_OUTPUT)/\$@#' Makefile
+   oe_runmake STAGING_KERNEL_DIR=${STAGING_KERNEL_DIR}
+}
+
+do_install() {
+   oe_runmake DESTDIR="${D}" install
+}
-- 
2.11.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH v2] pam-plugin-ldapdb: add recipe

2018-05-23 Thread Richard Leitner

On 05/23/2018 10:54 AM, Martin Jansa wrote:
> Don't use github archives which are regenerated from time to time with 
> different checksums (read older discussions for more details).

What should we use instead?
git clone?
My comments on that from the last patch version:

> Why should we change to git clones instead of archives? What's the advantage?

.. ok that's clear with the "different checksums" statement

> IMHO it only causes more traffic and uses more disk space.
> Furthermore if we rely on tags these may be changed without our notice...
> And if they are unsigned (like here) we also don't know if something got 
> modified unintentionally...
> Or should we use revision hashes?

If these points were already settled please give me a pointer to that 
discussion.

thanks & regards;Richard.L
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH v2] pam-plugin-ldapdb: add recipe

2018-05-23 Thread Martin Jansa
Don't use github archives which are regenerated from time to time with
different checksums (read older discussions for more details).

On Wed, May 23, 2018 at 10:42 AM Richard Leitner <
richard.leit...@skidata.com> wrote:

> Add recipe for version 1.3 of pam-plugin-ldapdb, a PAM module for
> directly binding a user DN to an LDAP server.
>
> Signed-off-by: Richard Leitner 
> ---
> Changes v2:
>   + assign DEPENDS (instead of appending to it)
>   + add downloadfilename to SRC_URI
>   + append to FILES (instead of assigning it)
> ---
>  .../recipes-extended/pam/pam-plugin-ldapdb_1.3.bb  | 23
> ++
>  1 file changed, 23 insertions(+)
>  create mode 100644 meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
>
> diff --git a/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
> b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
> new file mode 100644
> index 0..c59a259fc
> --- /dev/null
> +++ b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
> @@ -0,0 +1,23 @@
> +SUMMARY = "PAM searchless LDAP authentication module"
> +HOMEPAGE = "https://github.com/rmbreak/pam_ldapdb;
> +BUGTRACKER = "https://github.com/rmbreak/pam_ldapdb/issues;
> +SECTION = "libs"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=41ab94182d94be9bb35e2a8b933f1e7d"
> +
> +DEPENDS = "libpam openldap"
> +
> +inherit distro_features_check
> +REQUIRED_DISTRO_FEATURES = "pam"
> +
> +SRC_URI = "
> https://github.com/rmbreak/pam_ldapdb/archive/v${PV}.tar.gz;downloadfilename=${BP}.tar.gz
> "
> +SRC_URI[md5sum] = "2dd4f1370fcfe995ee0ad09611109b87"
> +SRC_URI[sha256sum] =
> "8ed92b36523556bb5d9bf3eb33a1035e46041d4be767c8d62136930c0ca0e45b"
> +
> +S = "${WORKDIR}/pam_ldapdb-${PV}"
> +
> +do_install () {
> +oe_runmake install DESTDIR=${D} PAMDIR=${base_libdir}/security
> +}
> +
> +FILES_${PN} += "${base_libdir}/security/pam_ldapdb.so"
> --
> 2.11.0
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH v2] pam-plugin-ldapdb: add recipe

2018-05-23 Thread Richard Leitner
Add recipe for version 1.3 of pam-plugin-ldapdb, a PAM module for
directly binding a user DN to an LDAP server.

Signed-off-by: Richard Leitner 
---
Changes v2:
  + assign DEPENDS (instead of appending to it)
  + add downloadfilename to SRC_URI
  + append to FILES (instead of assigning it)
---
 .../recipes-extended/pam/pam-plugin-ldapdb_1.3.bb  | 23 ++
 1 file changed, 23 insertions(+)
 create mode 100644 meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb

diff --git a/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb 
b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
new file mode 100644
index 0..c59a259fc
--- /dev/null
+++ b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
@@ -0,0 +1,23 @@
+SUMMARY = "PAM searchless LDAP authentication module"
+HOMEPAGE = "https://github.com/rmbreak/pam_ldapdb;
+BUGTRACKER = "https://github.com/rmbreak/pam_ldapdb/issues;
+SECTION = "libs"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=41ab94182d94be9bb35e2a8b933f1e7d"
+
+DEPENDS = "libpam openldap"
+
+inherit distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
+
+SRC_URI = 
"https://github.com/rmbreak/pam_ldapdb/archive/v${PV}.tar.gz;downloadfilename=${BP}.tar.gz;
+SRC_URI[md5sum] = "2dd4f1370fcfe995ee0ad09611109b87"
+SRC_URI[sha256sum] = 
"8ed92b36523556bb5d9bf3eb33a1035e46041d4be767c8d62136930c0ca0e45b"
+
+S = "${WORKDIR}/pam_ldapdb-${PV}"
+
+do_install () {
+oe_runmake install DESTDIR=${D} PAMDIR=${base_libdir}/security
+}
+
+FILES_${PN} += "${base_libdir}/security/pam_ldapdb.so"
-- 
2.11.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH] pam-plugin-ldapdb: add recipe

2018-05-23 Thread Richard Leitner


On 05/22/2018 08:09 PM, Khem Raj wrote:
> On Tue, May 22, 2018 at 7:10 AM, Richard Leitner
>  wrote:
>> Add recipe for version 1.3 of pam-plugin-ldapdb, a PAM module for
>> directly binding a user DN to an LDAP server.
>>
>> Signed-off-by: Richard Leitner 
>> ---
>>  .../recipes-extended/pam/pam-plugin-ldapdb_1.3.bb  | 23 
>> ++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
>>
>> diff --git a/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb 
>> b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
>> new file mode 100644
>> index 0..a68d1999f
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
>> @@ -0,0 +1,23 @@
>> +SUMMARY = "PAM searchless LDAP authentication module"
>> +HOMEPAGE = "https://github.com/rmbreak/pam_ldapdb;
>> +BUGTRACKER = "https://github.com/rmbreak/pam_ldapdb/issues;
>> +SECTION = "libs"
>> +LICENSE = "MIT"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=41ab94182d94be9bb35e2a8b933f1e7d"
>> +
>> +DEPENDS += "libpam openldap"
>> +
>> +inherit distro_features_check
>> +REQUIRED_DISTRO_FEATURES = "pam"
>> +
>> +SRC_URI = "https://github.com/rmbreak/pam_ldapdb/archive/v${PV}.tar.gz;
>> +SRC_URI[md5sum] = "2dd4f1370fcfe995ee0ad09611109b87"
>> +SRC_URI[sha256sum] = 
>> "8ed92b36523556bb5d9bf3eb33a1035e46041d4be767c8d62136930c0ca0e45b"
>> +
>> +S = "${WORKDIR}/pam_ldapdb-${PV}"
>> +
>> +do_install () {
>> +oe_runmake install DESTDIR=${D} PAMDIR=${base_libdir}/security
>> +}
> 
> Perhaps using EXTRA_OEMAKE += " PAMDIR=${base_libdir}/security"
> would mean do dont need to define custom do_install()

nope. sadly not. Without the custom do_install nothing gets installed and 
therefore
we get no package...

> 
>> +
>> +FILES_${PN} = "${base_libdir}/security/pam_ldapdb.so"

regards;Richard.L
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH] pam-plugin-ldapdb: add recipe

2018-05-23 Thread Richard Leitner
Hi Andre,
thank you for your feedback. Please find my comments below.

On 05/23/2018 02:51 AM, Andre McCurdy wrote:
> On Tue, May 22, 2018 at 4:10 AM, Richard Leitner
>  wrote:
>> Add recipe for version 1.3 of pam-plugin-ldapdb, a PAM module for
>> directly binding a user DN to an LDAP server.
>>
>> Signed-off-by: Richard Leitner 
>> ---
>>  .../recipes-extended/pam/pam-plugin-ldapdb_1.3.bb  | 23 
>> ++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
>>
>> diff --git a/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb 
>> b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
>> new file mode 100644
>> index 0..a68d1999f
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/pam/pam-plugin-ldapdb_1.3.bb
>> @@ -0,0 +1,23 @@
>> +SUMMARY = "PAM searchless LDAP authentication module"
>> +HOMEPAGE = "https://github.com/rmbreak/pam_ldapdb;
>> +BUGTRACKER = "https://github.com/rmbreak/pam_ldapdb/issues;
>> +SECTION = "libs"
>> +LICENSE = "MIT"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=41ab94182d94be9bb35e2a8b933f1e7d"
>> +
>> +DEPENDS += "libpam openldap"
> 
> The usual convention is to assign to DEPENDS with = rather than +=

Ok. Thanks for that hint. I'll change that in v2.

> 
>> +inherit distro_features_check
>> +REQUIRED_DISTRO_FEATURES = "pam"
>> +
>> +SRC_URI = "https://github.com/rmbreak/pam_ldapdb/archive/v${PV}.tar.gz;
> 
> To give the local file a meaningful file name, you can have bitbake
> rename it as part of the download process by adding
> ";downloadfilename=${BP}.tar.gz" to the end of SRC_URI.

Thank you. That makes sense. I'll add it in v2.

> 
> Note however that there have recently been a series of patches merged
> to meta-oe which updated recipes to build from git clones rather than
> github tar file archives, so you may want to consider doing that in
> this recipe too.

Why should we change to git clones instead of archives? What's the advantage?

IMHO it only causes more traffic and uses more disk space.
Furthermore if we rely on tags these may be changed without our notice...
And if they are unsigned (like here) we also don't know if something got 
modified unintentionally...
Or should we use revision hashes?

> 
>> +SRC_URI[md5sum] = "2dd4f1370fcfe995ee0ad09611109b87"
>> +SRC_URI[sha256sum] = 
>> "8ed92b36523556bb5d9bf3eb33a1035e46041d4be767c8d62136930c0ca0e45b"
>> +
>> +S = "${WORKDIR}/pam_ldapdb-${PV}"
>> +
>> +do_install () {
>> +oe_runmake install DESTDIR=${D} PAMDIR=${base_libdir}/security
>> +}
>> +
>> +FILES_${PN} = "${base_libdir}/security/pam_ldapdb.so"
> 
> It's conventional to add to the default packaging rules rather than
> over-ride them, ie use += here rather than =
> 

Ok. Thanks.

regards;Richard.L
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel