Re: [oe] [PATCH] linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM

2011-06-30 Thread Khem Raj 

On 06/29/2011 09:51 PM, Joel A Fernandes wrote:

Signed-off-by: Joel A Fernandesagnel.j...@gmail.com
---
  ...agle-cleaned-up-board-revision-conditions.patch |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
 
b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
index 513a101..fb91cb6 100644
--- 
a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
+++ 
b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
omap3_beagle_i2c_init();

  - if (cpu_is_omap3630()) {
-+  if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB)
-+  (omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++  if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++  (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
gpio_buttons[0].gpio = 4;
}



while the patch seems good it does not follow the submission guidelines.

___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [oe] [PATCH] linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM

2011-06-30 Thread Paul Menzel 
Am Donnerstag, den 30.06.2011, 01:13 -0700 schrieb Khem Raj:
 On 06/29/2011 09:51 PM, Joel A Fernandes wrote:
  Signed-off-by: Joel A Fernandesagnel.j...@gmail.com
  ---
...agle-cleaned-up-board-revision-conditions.patch |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
 
  diff --git 
  a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
   
  b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
  index 513a101..fb91cb6 100644
  --- 
  a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
  +++ 
  b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
  @@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
  omap3_beagle_i2c_init();
 
- if (cpu_is_omap3630()) {
  -+  if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB)
  -+  (omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
  ++  if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
  ++  (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
  gpio_buttons[0].gpio = 4;
  }
 
 
 while the patch seems good it does not follow the submission guidelines.

Please read the following policies [1] in the Wiki [2][3][4].


Thanks,

Paul


[1] http://openembedded.org/index.php/Category:Policy
[2] http://openembedded.org/index.php/Commit_Patch_Message_Guidelines
[3] http://openembedded.org/index.php/Commit_Policy
[4] http://openembedded.org/index.php/Commit_log_example


signature.asc
Description: This is a digitally signed message part
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

[oe] [PATCH] linux-omap-psp-2.6.32 kernel: Fixed User-button GPIO to correct value for -xM

2011-06-29 Thread Joel A Fernandes 
Signed-off-by: Joel A Fernandes agnel.j...@gmail.com
---
 ...agle-cleaned-up-board-revision-conditions.patch |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
 
b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
index 513a101..fb91cb6 100644
--- 
a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
+++ 
b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
omap3_beagle_i2c_init();
  
 -  if (cpu_is_omap3630()) {
-+  if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB) 
-+  (omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++  if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++  (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
gpio_buttons[0].gpio = 4;
}
  
-- 
1.7.1


___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel