Re: [oe] [PATCH] ti-dmai: Fixes for Display and Capture.

2011-06-25 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 25-06-11 03:14, Joel A Fernandes wrote:
 These patches fix issues with display and capture in ti-dmai that cause it to 
 break with recent kernels.

Thanks, I applied your patch, but one of them might need an update later on:

 +From 5e59be7d0d5d3d90e9bbc5d1bb5829ad8482fbf0 Mon Sep 17 00:00:00 2001
 +From: Joel A Fernandes agnel.j...@gmail.com
 +Date: Fri, 24 Jun 2011 17:04:10 -0500
 +Subject: [PATCH 4/4] DMAI: Use the correct capture device node.
 +
 +Signed-off-by: Joel A Fernandes agnel.j...@gmail.com
 +---
 + linux/Capture.c |2 +-
 + 1 files changed, 1 insertions(+), 1 deletions(-)
 +
 +diff --git a/packages/ti/sdo/dmai/linux/Capture.c 
 b/packages/ti/sdo/dmai/linux/Capture.c
 +index e7a081e..a2614e7 100644
 +--- a/packages/ti/sdo/dmai/linux/Capture.c
  b/packages/ti/sdo/dmai/linux/Capture.c
 +@@ -120,7 +120,7 @@ const Capture_Attrs Capture_Attrs_OMAP3530_DEFAULT = {
 + -1,
 + -1,
 + -1,
 +-/dev/video0,
 ++/dev/video2,
 + FALSE,
 + VideoStd_AUTO,
 + -1,

This is still dependant in which order modules get loaded, so like with
the output patch it would be better to iterate over

/sys/class/video4linux/video*/name

And look for the usual suspects (e.g. OMAP3 ISP CCDC output on omap3).
I'm not sure how well that works on other platforms, which I why this
patch went in as is :)

regards,

Koen
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOBZJyMkyGM64RGpERAgcGAKCGQ/R8hzFpOLaeMQYmvsKEvu2wWACeL70H
ipxR1rKruT7mLTJtpSdKHLU=
=Q0F8
-END PGP SIGNATURE-


___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


[oe] [PATCH] ti-dmai: Fixes for Display and Capture.

2011-06-24 Thread Joel A Fernandes
These patches fix issues with display and capture in ti-dmai that cause it to 
break with recent kernels.

Signed-off-by: Joel A Fernandes agnel.j...@gmail.com
---
 recipes/ti/ti-dmai.inc |4 +
 ...display-Set-the-default-Display-Output-to.patch |   26 +
 ...o-detect-V4L2-display-device-node-to-open.patch |  109 
 ...e-display-rotation-to-avoid-problems-due-.patch |   29 +
 ...-DMAI-Use-the-correct-capture-device-node.patch |   26 +
 5 files changed, 194 insertions(+), 0 deletions(-)
 create mode 100644 
recipes/ti/ti-dmai/beagle/0001-DMAI-video_display-Set-the-default-Display-Output-to.patch
 create mode 100644 
recipes/ti/ti-dmai/beagle/0002-DMAI-Auto-detect-V4L2-display-device-node-to-open.patch
 create mode 100644 
recipes/ti/ti-dmai/beagle/0003-DMAI-Disable-display-rotation-to-avoid-problems-due-.patch
 create mode 100644 
recipes/ti/ti-dmai/beagle/0004-DMAI-Use-the-correct-capture-device-node.patch

diff --git a/recipes/ti/ti-dmai.inc b/recipes/ti/ti-dmai.inc
index c3a0f71..a5a11a1 100644
--- a/recipes/ti/ti-dmai.inc
+++ b/recipes/ti/ti-dmai.inc
@@ -27,6 +27,10 @@ SRC_URI = 
svn://gforge.ti.com/svn/dmai/;module=${DMAIBRANCH};proto=https;user=a
file://loadmodules-ti-dmai-ol138_al.sh \
file://doxygen_templates.tar.gz \
 file://arago-tdox \
+
file://beagle/0001-DMAI-video_display-Set-the-default-Display-Output-to.patch \
+
file://beagle/0002-DMAI-Auto-detect-V4L2-display-device-node-to-open.patch \
+
file://beagle/0003-DMAI-Disable-display-rotation-to-avoid-problems-due-.patch \
+
file://beagle/0004-DMAI-Use-the-correct-capture-device-node.patch \

 
 DEPENDS = virtual/kernel alsa-lib ti-framework-components ti-codec-engine 
ti-xdctools
diff --git 
a/recipes/ti/ti-dmai/beagle/0001-DMAI-video_display-Set-the-default-Display-Output-to.patch
 
b/recipes/ti/ti-dmai/beagle/0001-DMAI-video_display-Set-the-default-Display-Output-to.patch
new file mode 100644
index 000..fce8272
--- /dev/null
+++ 
b/recipes/ti/ti-dmai/beagle/0001-DMAI-video_display-Set-the-default-Display-Output-to.patch
@@ -0,0 +1,26 @@
+From c584fc4593fc95c24facc8521a8a1180a0bc7b13 Mon Sep 17 00:00:00 2001
+From: Joel joel@chase-ubuntu.(none)
+Date: Mon, 20 Jun 2011 16:59:54 -0500
+Subject: [PATCH 1/4] DMAI video_display: Set the default Display Output to DVI.
+
+Signed-off-by: Joel A Fernandes agnel.j...@gmail.com
+---
+ apps/video_display/linux/main.c |2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+packages/ti/sdo/dmai
+diff --git a/packages/ti/sdo/dmai/apps/video_display/linux/main.c 
b/packages/ti/sdo/dmai/apps/video_display/linux/main.c
+index 15182b7..496d19c 100644
+--- a/packages/ti/sdo/dmai/apps/video_display/linux/main.c
 b/packages/ti/sdo/dmai/apps/video_display/linux/main.c
+@@ -45,7 +45,7 @@
+ #include ../appMain.h
+ 
+ /* Default arguments for app */
+-#define DEFAULT_ARGS { 1000, FALSE, FALSE, VideoStd_D1_NTSC, 
Display_Output_COMPOSITE }
++#define DEFAULT_ARGS { 1000, FALSE, FALSE, VideoStd_D1_NTSC, 
Display_Output_DVI }
+ 
+ /*
+  * Argument IDs for long options. They must not conflict with ASCII values,
+-- 
+1.7.0.4
+
diff --git 
a/recipes/ti/ti-dmai/beagle/0002-DMAI-Auto-detect-V4L2-display-device-node-to-open.patch
 
b/recipes/ti/ti-dmai/beagle/0002-DMAI-Auto-detect-V4L2-display-device-node-to-open.patch
new file mode 100644
index 000..77882f4
--- /dev/null
+++ 
b/recipes/ti/ti-dmai/beagle/0002-DMAI-Auto-detect-V4L2-display-device-node-to-open.patch
@@ -0,0 +1,109 @@
+From 39d909ea1040b86968adf0d62475955bd07f96a8 Mon Sep 17 00:00:00 2001
+From: Joel A Fernandes agnel.j...@gmail.com
+Date: Tue, 21 Jun 2011 15:33:14 -0500
+Subject: [PATCH 2/4] DMAI: Auto-detect V4L2 display device node to open.
+
+Changes in display device node names in the kernel break DMAI.
+This autodetects the device node name to avoid such breakages in the future.
+
+Signed-off-by: Joel A Fernandes agnel.j...@gmail.com
+---
+ linux/Display.c   |2 +-
+ linux/omap3530/Display_v4l2.c |   40 
+ 2 files changed, 41 insertions(+), 1 deletions(-)
+
+diff --git a/packages/ti/sdo/dmai/linux/Display.c 
b/packages/ti/sdo/dmai/linux/Display.c
+index bf0db2e..578ab8a 100644
+--- a/packages/ti/sdo/dmai/linux/Display.c
 b/packages/ti/sdo/dmai/linux/Display.c
+@@ -197,7 +197,7 @@ const Display_Attrs Display_Attrs_O3530_VID_DEFAULT = {
+ Display_Std_V4L2,
+ VideoStd_VGA,
+ Display_Output_LCD,
+-/dev/video1,
++,   // V4L2 device nodes are auto detected
+ 0,
+ ColorSpace_UYVY,
+ -1,
+diff --git a/packages/ti/sdo/dmai/linux/omap3530/Display_v4l2.c 
b/packages/ti/sdo/dmai/linux/omap3530/Display_v4l2.c
+index 8cd891c..61f15bb 100644
+--- a/packages/ti/sdo/dmai/linux/omap3530/Display_v4l2.c
 b/packages/ti/sdo/dmai/linux/omap3530/Display_v4l2.c
+@@ -35,6 +35,7 @@
+