Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism

2015-11-12 Thread Julien Brianceau (jbriance) 
I've added -j in http://patches.openembedded.org/patch/100133/, because 
chromium recipe wasn't fair to other recipes.
For instance, if bitbake is processing 8 compile tasks (incl. chromium) in 
parallel on a 24 cores machine, 7 recipes will
be compiled with -j${BB_NUMBER_THREADS} whereas chromium will use something 
like -j24

Just out of my curiosity, what "${PARALLEL_MAKE}" brings compared to 
"-j${BB_NUMBER_THREADS}" ?


-Original Message-
From: openembedded-devel-boun...@lists.openembedded.org 
[mailto:openembedded-devel-boun...@lists.openembedded.org] On Behalf Of Zoltan 
Kuscsik
Sent: jeudi 12 novembre 2015 07:08
To: openembedded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control 
build parallelism

Fair enough.

Z

On 11 November 2015 at 08:22, Andre McCurdy <armccu...@gmail.com> wrote:

> On Tue, Nov 10, 2015 at 9:48 PM, Zoltan Kuscsik
> <zoltan.kusc...@linaro.org> wrote:
> > Hi,
> >
> > isn't ninja picking up the number of cores separately? I'm not sure why
> > this is needed.
>
> Without any -j option, ninja will default to "-j (logical_cores + 2)".
>
> The PARALLEL_MAKE value configured in OE isn't just about maximising
> parallelism though (although that's it's common usage), it's also
> useful to limit parallelism and reduce the load on the CPU. If
> PARALLEL_MAKE isn't passed to ninja builds then they will always fully
> load the CPU.
>
> > Z
> >
> > On 11 November 2015 at 05:48, Andre McCurdy <armccu...@gmail.com> wrote:
> >
> >> Signed-off-by: Andre McCurdy <armccu...@gmail.com>
> >> ---
> >>  recipes-browser/chromium/cef3_280796.bb | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/recipes-browser/chromium/cef3_280796.bb
> >> b/recipes-browser/chromium/cef3_280796.bb
> >> index d827b8e..6872e5b 100644
> >> --- a/recipes-browser/chromium/cef3_280796.bb
> >> +++ b/recipes-browser/chromium/cef3_280796.bb
> >> @@ -60,5 +60,5 @@ do_qa_configure() {
> >>  }
> >>
> >>  do_compile() {
> >> -ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS}
> cefsimple
> >> +ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple
> >>  }
> >> --
> >> 1.9.1
> >>
> >> --
> >> ___
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>
> >
> >
> >
> > --
> > Zoltan Kuscsik
> >
> > Senior Software Developer, Linaro Digital Home Group
> > email: zoltan.kusc...@linaro.org
> > IRC: zoli_ on irc.linaro.org
> > --
> > ___
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



-- 
Zoltan Kuscsik

Senior Software Developer, Linaro Digital Home Group
email: zoltan.kusc...@linaro.org
IRC: zoli_ on irc.linaro.org
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism

2015-11-12 Thread Andreas Müller 
On Thu, Nov 12, 2015 at 10:26 AM, Julien Brianceau (jbriance)
 wrote:
> I've added -j in http://patches.openembedded.org/patch/100133/, because 
> chromium recipe wasn't fair to other recipes.
> For instance, if bitbake is processing 8 compile tasks (incl. chromium) in 
> parallel on a 24 cores machine, 7 recipes will
> be compiled with -j${BB_NUMBER_THREADS} whereas chromium will use something 
> like -j24
>
> Just out of my curiosity, what "${PARALLEL_MAKE}" brings compared to 
> "-j${BB_NUMBER_THREADS}" ?

BB_NUMBER_THREADS -> max bitbake tasks run at the same time
PARALLEL_MAKE -> make tasks (gcc) at the same time

Andrease
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism

2015-11-12 Thread Julien Brianceau (jbriance) 
That makes sense, thanks for the clarification.

-Original Message-
From: openembedded-devel-boun...@lists.openembedded.org 
[mailto:openembedded-devel-boun...@lists.openembedded.org] On Behalf Of Andreas 
Müller
Sent: jeudi 12 novembre 2015 10:34
To: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control 
build parallelism

On Thu, Nov 12, 2015 at 10:26 AM, Julien Brianceau (jbriance)
<jbria...@cisco.com> wrote:
> I've added -j in http://patches.openembedded.org/patch/100133/, because 
> chromium recipe wasn't fair to other recipes.
> For instance, if bitbake is processing 8 compile tasks (incl. chromium) in 
> parallel on a 24 cores machine, 7 recipes will
> be compiled with -j${BB_NUMBER_THREADS} whereas chromium will use something 
> like -j24
>
> Just out of my curiosity, what "${PARALLEL_MAKE}" brings compared to 
> "-j${BB_NUMBER_THREADS}" ?

BB_NUMBER_THREADS -> max bitbake tasks run at the same time
PARALLEL_MAKE -> make tasks (gcc) at the same time

Andrease
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism

2015-11-11 Thread Zoltan Kuscsik 
Fair enough.

Z

On 11 November 2015 at 08:22, Andre McCurdy  wrote:

> On Tue, Nov 10, 2015 at 9:48 PM, Zoltan Kuscsik
>  wrote:
> > Hi,
> >
> > isn't ninja picking up the number of cores separately? I'm not sure why
> > this is needed.
>
> Without any -j option, ninja will default to "-j (logical_cores + 2)".
>
> The PARALLEL_MAKE value configured in OE isn't just about maximising
> parallelism though (although that's it's common usage), it's also
> useful to limit parallelism and reduce the load on the CPU. If
> PARALLEL_MAKE isn't passed to ninja builds then they will always fully
> load the CPU.
>
> > Z
> >
> > On 11 November 2015 at 05:48, Andre McCurdy  wrote:
> >
> >> Signed-off-by: Andre McCurdy 
> >> ---
> >>  recipes-browser/chromium/cef3_280796.bb | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/recipes-browser/chromium/cef3_280796.bb
> >> b/recipes-browser/chromium/cef3_280796.bb
> >> index d827b8e..6872e5b 100644
> >> --- a/recipes-browser/chromium/cef3_280796.bb
> >> +++ b/recipes-browser/chromium/cef3_280796.bb
> >> @@ -60,5 +60,5 @@ do_qa_configure() {
> >>  }
> >>
> >>  do_compile() {
> >> -ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS}
> cefsimple
> >> +ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple
> >>  }
> >> --
> >> 1.9.1
> >>
> >> --
> >> ___
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>
> >
> >
> >
> > --
> > Zoltan Kuscsik
> >
> > Senior Software Developer, Linaro Digital Home Group
> > email: zoltan.kusc...@linaro.org
> > IRC: zoli_ on irc.linaro.org
> > --
> > ___
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



-- 
Zoltan Kuscsik

Senior Software Developer, Linaro Digital Home Group
email: zoltan.kusc...@linaro.org
IRC: zoli_ on irc.linaro.org
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism

2015-11-10 Thread Andre McCurdy 
On Tue, Nov 10, 2015 at 9:48 PM, Zoltan Kuscsik
 wrote:
> Hi,
>
> isn't ninja picking up the number of cores separately? I'm not sure why
> this is needed.

Without any -j option, ninja will default to "-j (logical_cores + 2)".

The PARALLEL_MAKE value configured in OE isn't just about maximising
parallelism though (although that's it's common usage), it's also
useful to limit parallelism and reduce the load on the CPU. If
PARALLEL_MAKE isn't passed to ninja builds then they will always fully
load the CPU.

> Z
>
> On 11 November 2015 at 05:48, Andre McCurdy  wrote:
>
>> Signed-off-by: Andre McCurdy 
>> ---
>>  recipes-browser/chromium/cef3_280796.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-browser/chromium/cef3_280796.bb
>> b/recipes-browser/chromium/cef3_280796.bb
>> index d827b8e..6872e5b 100644
>> --- a/recipes-browser/chromium/cef3_280796.bb
>> +++ b/recipes-browser/chromium/cef3_280796.bb
>> @@ -60,5 +60,5 @@ do_qa_configure() {
>>  }
>>
>>  do_compile() {
>> -ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple
>> +ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple
>>  }
>> --
>> 1.9.1
>>
>> --
>> ___
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>
>
>
> --
> Zoltan Kuscsik
>
> Senior Software Developer, Linaro Digital Home Group
> email: zoltan.kusc...@linaro.org
> IRC: zoli_ on irc.linaro.org
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism

2015-11-10 Thread Khem Raj 
On Tue, Nov 10, 2015 at 9:48 PM, Zoltan Kuscsik
 wrote:
> Hi,
>
> isn't ninja picking up the number of cores separately? I'm not sure why
> this is needed.
>

thats another issue. This one atleast improves the current usage a nit.

>
> Z
>
> On 11 November 2015 at 05:48, Andre McCurdy  wrote:
>
>> Signed-off-by: Andre McCurdy 
>> ---
>>  recipes-browser/chromium/cef3_280796.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-browser/chromium/cef3_280796.bb
>> b/recipes-browser/chromium/cef3_280796.bb
>> index d827b8e..6872e5b 100644
>> --- a/recipes-browser/chromium/cef3_280796.bb
>> +++ b/recipes-browser/chromium/cef3_280796.bb
>> @@ -60,5 +60,5 @@ do_qa_configure() {
>>  }
>>
>>  do_compile() {
>> -ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple
>> +ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple
>>  }
>> --
>> 1.9.1
>>
>> --
>> ___
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>
>
>
> --
> Zoltan Kuscsik
>
> Senior Software Developer, Linaro Digital Home Group
> email: zoltan.kusc...@linaro.org
> IRC: zoli_ on irc.linaro.org
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism

2015-11-10 Thread Andre McCurdy 
Signed-off-by: Andre McCurdy 
---
 recipes-browser/chromium/cef3_280796.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-browser/chromium/cef3_280796.bb 
b/recipes-browser/chromium/cef3_280796.bb
index d827b8e..6872e5b 100644
--- a/recipes-browser/chromium/cef3_280796.bb
+++ b/recipes-browser/chromium/cef3_280796.bb
@@ -60,5 +60,5 @@ do_qa_configure() {
 }
 
 do_compile() {
-ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple
+ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple
 }
-- 
1.9.1

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism

2015-11-10 Thread Khem Raj 
On Tue, Nov 10, 2015 at 8:48 PM, Andre McCurdy  wrote:
> Signed-off-by: Andre McCurdy 
> ---
>  recipes-browser/chromium/cef3_280796.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-browser/chromium/cef3_280796.bb 
> b/recipes-browser/chromium/cef3_280796.bb
> index d827b8e..6872e5b 100644
> --- a/recipes-browser/chromium/cef3_280796.bb
> +++ b/recipes-browser/chromium/cef3_280796.bb
> @@ -60,5 +60,5 @@ do_qa_configure() {
>  }
>
>  do_compile() {
> -ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple
> +ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple
>  }

this is ok

> --
> 1.9.1
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-browser][PATCH 1/2] cef3: use PARALLEL_MAKE to control build parallelism

2015-11-10 Thread Zoltan Kuscsik 
Hi,

isn't ninja picking up the number of cores separately? I'm not sure why
this is needed.


Z

On 11 November 2015 at 05:48, Andre McCurdy  wrote:

> Signed-off-by: Andre McCurdy 
> ---
>  recipes-browser/chromium/cef3_280796.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-browser/chromium/cef3_280796.bb
> b/recipes-browser/chromium/cef3_280796.bb
> index d827b8e..6872e5b 100644
> --- a/recipes-browser/chromium/cef3_280796.bb
> +++ b/recipes-browser/chromium/cef3_280796.bb
> @@ -60,5 +60,5 @@ do_qa_configure() {
>  }
>
>  do_compile() {
> -ninja -C out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS} cefsimple
> +ninja -C out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} cefsimple
>  }
> --
> 1.9.1
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



-- 
Zoltan Kuscsik

Senior Software Developer, Linaro Digital Home Group
email: zoltan.kusc...@linaro.org
IRC: zoli_ on irc.linaro.org
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel