Re: [oe] [meta-oe][PATCH] wavpack: add PACKAGECONFIG for shared and enable it by default

2023-12-22 Thread Martin Jansa
Sorry, ignore this one.

Something is still wrong, sent too soon (after do_compile finished), but
later there was:

ERROR: gstreamer1.0-plugins-good-1.22.7-r0 do_package_qa: QA Issue:
gstreamer1.0-plugins-good-wavpack rdepends on wavpack-dev [dev-deps]

so it's packaged incorrectly, because now it built unversioned .so:

tmp-glibc/work/cortexa57-oe-linux/wavpack/5.1.0-old/image/usr/lib/:
total 1528
drwxr-xr-x 3 martin martin   4096 Dec 22 14:27 ./
drwxr-xr-x 6 martin martin   4096 Dec 22 14:27 ../
-rw-r--r-- 2 martin martin 988636 Dec 22 14:27 libwavpack.a
lrwxrwxrwx 1 martin martin 19 Dec 22 14:27 libwavpack.so ->
libwavpack.so.1.2.0*
lrwxrwxrwx 1 martin martin 19 Dec 22 14:27 libwavpack.so.1 ->
libwavpack.so.1.2.0*
-rwxr-xr-x 1 martin martin 601320 Dec 22 14:27 libwavpack.so.1.2.0*
drwxr-xr-x 2 martin martin   4096 Dec 22 14:27 pkgconfig/

tmp-glibc/work/cortexa57-oe-linux/wavpack/5.6.0-shared/image/usr/lib/:
total 616
drwxr-xr-x 4 martin martin   4096 Dec 22 14:45 ./
drwxr-xr-x 6 martin martin   4096 Dec 22 14:45 ../
drwxr-xr-x 3 martin martin   4096 Dec 22 14:45 cmake/
-rwxr-xr-x 1 martin martin 608120 Dec 22 14:45 libwavpack.so*
drwxr-xr-x 2 martin martin   4096 Dec 22 14:45 pkgconfig/

will send v2 later

On Fri, Dec 22, 2023 at 2:46 PM Martin Jansa via lists.openembedded.org
 wrote:

> * fixes gstreamer1.0-plugins-good build with wavpack enabled:
>   PACKAGECONFIG:append:pn-gstreamer1.0-plugins-good = " wavpack"
>
> * 5.1.0 built shared libs by default, 5.6.0 build with CMake doesn't,
> causing:
>   http://errors.yoctoproject.org/Errors/Details/748247/
>
> TOPDIR/tmp-glibc/work/cortexa57-oe-linux/gstreamer1.0-plugins-good/1.22.7/recipe-sysroot-native/usr/bin/aarch64-oe-linux/../../libexec/aarch64-oe-linux/gcc/aarch64-oe-linux/13.2.0/ld:
> TOPDIR/tmp-glibc/work/cortexa57-oe-linux/gstreamer1.0-plugins-good/1.22.7/recipe-sysroot/usr/lib/libwavpack.a(read_words.c.o):
> relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `bitset' which may
> bind externally can not be used when making a shared object; recompile with
> -fPIC
> /usr/src/debug/wavpack/5.6.0/src/read_words.c:592:(.text+0xb88): dangerous
> relocation: unsupported relocation
> collect2: error: ld returned 1 exit status
>
> Signed-off-by: Martin Jansa 
> ---
>  meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
> b/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
> index ebbc59dde8..1011cd4c03 100644
> --- a/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
> +++ b/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
> @@ -9,3 +9,6 @@ SRCREV = "e03e8e29dc618e08e7baba9636e57ba1254874ce"
>  S = "${WORKDIR}/git"
>
>  inherit cmake pkgconfig
> +
> +PACKAGECONFIG = "shared"
> +PACKAGECONFIG[shared] = "-DBUILD_SHARED_LIBS=ON,-DBUILD_SHARED_LIBS=OFF,,"
> --
> 2.43.0
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#107749): 
https://lists.openembedded.org/g/openembedded-devel/message/107749
Mute This Topic: https://lists.openembedded.org/mt/103318396/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH] wavpack: add PACKAGECONFIG for shared and enable it by default

2023-12-22 Thread Martin Jansa
* fixes gstreamer1.0-plugins-good build with wavpack enabled:
  PACKAGECONFIG:append:pn-gstreamer1.0-plugins-good = " wavpack"

* 5.1.0 built shared libs by default, 5.6.0 build with CMake doesn't, causing:
  http://errors.yoctoproject.org/Errors/Details/748247/

TOPDIR/tmp-glibc/work/cortexa57-oe-linux/gstreamer1.0-plugins-good/1.22.7/recipe-sysroot-native/usr/bin/aarch64-oe-linux/../../libexec/aarch64-oe-linux/gcc/aarch64-oe-linux/13.2.0/ld:
 
TOPDIR/tmp-glibc/work/cortexa57-oe-linux/gstreamer1.0-plugins-good/1.22.7/recipe-sysroot/usr/lib/libwavpack.a(read_words.c.o):
 relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `bitset' which may bind 
externally can not be used when making a shared object; recompile with -fPIC
/usr/src/debug/wavpack/5.6.0/src/read_words.c:592:(.text+0xb88): dangerous 
relocation: unsupported relocation
collect2: error: ld returned 1 exit status

Signed-off-by: Martin Jansa 
---
 meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb 
b/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
index ebbc59dde8..1011cd4c03 100644
--- a/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
+++ b/meta-oe/recipes-multimedia/wavpack/wavpack_5.6.0.bb
@@ -9,3 +9,6 @@ SRCREV = "e03e8e29dc618e08e7baba9636e57ba1254874ce"
 S = "${WORKDIR}/git"
 
 inherit cmake pkgconfig
+
+PACKAGECONFIG = "shared"
+PACKAGECONFIG[shared] = "-DBUILD_SHARED_LIBS=ON,-DBUILD_SHARED_LIBS=OFF,,"
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#107748): 
https://lists.openembedded.org/g/openembedded-devel/message/107748
Mute This Topic: https://lists.openembedded.org/mt/103318396/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-