Re: [oe] [meta-python2][PATCH] python-beautifulsoup4: fix target RDEPENDS
On Mon, Jan 20, 2020 at 2:29 AM André Draszik wrote: > On Sun, 2020-01-19 at 15:24 -0800, Tim Orling wrote: > > * target has run-time dependencies on: > > - python-html > > - python-logging > > Any reason -native doesn't depend on those? These are part of the package splitting OE does for python. They are normally part of a full python installation in distros that don’t care about space. For python-native environment, there is no package splitting and these would not exist as -native variants. > > > > Unexpectedly, class-target += override is wiping out > > RDEPENDS_${PN}, so explicitly add the rest of the > > run-time dependencies (python-html5lib, python-lxml, > > python-soupsieve). > > This is expected, you should instead do: > > RDEPENDS_${PN}_append_class-target = "\ > ${PYTHON_PN}-html \ > ${PYTHON_PN}-logging" > Facepalm. I had tried it with append after class-target, which clearly doesn’t work and my brain was getting tired. I’ll clean it up today. Thank you for the catch. So as to avoid duplication and having to maintain two distinct lists. > > Cheers, > Andre' > > > > > > Signed-off-by: Tim Orling > > --- > > recipes-devtools/python/python-beautifulsoup4_4.8.1.bb | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb > b/recipes-devtools/python/python- > > beautifulsoup4_4.8.1.bb > > index 86482714..8ac9c8c5 100644 > > --- a/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb > > +++ b/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb > > @@ -19,4 +19,14 @@ RDEPENDS_${PN} = "\ > > ${PYTHON_PN}-soupsieve \ > > > > +# class override, which is not > > +# inheriting from above (FIXME?) > > +RDEPENDS_${PN}_class-target += "\ > > +${PYTHON_PN}-html \ > > +${PYTHON_PN}-html5lib \ > > +${PYTHON_PN}-logging \ > > +${PYTHON_PN}-lxml \ > > +${PYTHON_PN}-soupsieve \ > > +" > > + > > BBCLASSEXTEND = "native nativesdk" > > -- > > 2.25.0 > > > > -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-python2][PATCH] python-beautifulsoup4: fix target RDEPENDS
On Sun, 2020-01-19 at 15:24 -0800, Tim Orling wrote: > * target has run-time dependencies on: > - python-html > - python-logging Any reason -native doesn't depend on those? > Unexpectedly, class-target += override is wiping out > RDEPENDS_${PN}, so explicitly add the rest of the > run-time dependencies (python-html5lib, python-lxml, > python-soupsieve). This is expected, you should instead do: RDEPENDS_${PN}_append_class-target = "\ ${PYTHON_PN}-html \ ${PYTHON_PN}-logging" So as to avoid duplication and having to maintain two distinct lists. Cheers, Andre' > > Signed-off-by: Tim Orling > --- > recipes-devtools/python/python-beautifulsoup4_4.8.1.bb | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb > b/recipes-devtools/python/python- > beautifulsoup4_4.8.1.bb > index 86482714..8ac9c8c5 100644 > --- a/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb > +++ b/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb > @@ -19,4 +19,14 @@ RDEPENDS_${PN} = "\ > ${PYTHON_PN}-soupsieve \ > > +# class override, which is not > +# inheriting from above (FIXME?) > +RDEPENDS_${PN}_class-target += "\ > +${PYTHON_PN}-html \ > +${PYTHON_PN}-html5lib \ > +${PYTHON_PN}-logging \ > +${PYTHON_PN}-lxml \ > +${PYTHON_PN}-soupsieve \ > +" > + > BBCLASSEXTEND = "native nativesdk" > -- > 2.25.0 > -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
[oe] [meta-python2][PATCH] python-beautifulsoup4: fix target RDEPENDS
* target has run-time dependencies on: - python-html - python-logging Unexpectedly, class-target += override is wiping out RDEPENDS_${PN}, so explicitly add the rest of the run-time dependencies (python-html5lib, python-lxml, python-soupsieve). Signed-off-by: Tim Orling --- recipes-devtools/python/python-beautifulsoup4_4.8.1.bb | 10 ++ 1 file changed, 10 insertions(+) diff --git a/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb b/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb index 86482714..8ac9c8c5 100644 --- a/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb +++ b/recipes-devtools/python/python-beautifulsoup4_4.8.1.bb @@ -19,4 +19,14 @@ RDEPENDS_${PN} = "\ ${PYTHON_PN}-soupsieve \ " +# class override, which is not +# inheriting from above (FIXME?) +RDEPENDS_${PN}_class-target += "\ +${PYTHON_PN}-html \ +${PYTHON_PN}-html5lib \ +${PYTHON_PN}-logging \ +${PYTHON_PN}-lxml \ +${PYTHON_PN}-soupsieve \ +" + BBCLASSEXTEND = "native nativesdk" -- 2.25.0 -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel