[oe] [meta-xfce] task-xfce-base: add thunar-volman
This fixes:
ERROR: There is a comment on line 34 of file
/OE/tentacle/sources/meta-openembedded/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
(#thunar-volman \) which is in the middle of a multiline expression.
Bitbake used to ignore these but no longer does so, please fix your metadata as
errors are likely as a result of this change.
Signed-off-by: Koen Kooi
---
meta-xfce/recipes-xfce/tasks/task-xfce-base.bb |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
b/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
index 8a87203..7589f6d 100644
--- a/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
+++ b/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "All packages required for a base installation of
XFCE"
SECTION = "x11/wm"
LICENSE = "MIT"
LIC_FILES_CHKSUM =
"file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58"
-PR = "r0"
+PR = "r1"
inherit task
@@ -31,5 +31,5 @@ RDEPENDS_${PN} = " \
xfce4-settings \
xfce-terminal \
thunar \
-#thunar-volman \
+thunar-volman \
"
--
1.6.6.1
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [meta-xfce] task-xfce-base: add thunar-volman
On Thursday, September 01, 2011 09:44:51 AM you wrote:
> This fixes:
>
> ERROR: There is a comment on line 34 of file
> /OE/tentacle/sources/meta-openembedded/meta-xfce/recipes-xfce/tasks/task-x
> fce-base.bb (#thunar-volman \) which is in the middle of a multiline
> expression. Bitbake used to ignore these but no longer does so, please fix
> your metadata as errors are likely as a result of this change.
>
> Signed-off-by: Koen Kooi
> ---
> meta-xfce/recipes-xfce/tasks/task-xfce-base.bb |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
> b/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb index 8a87203..7589f6d
> 100644
> --- a/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
> +++ b/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "All packages required for a base
> installation of XFCE" SECTION = "x11/wm"
> LICENSE = "MIT"
> LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58" -PR =
> "r0"
> +PR = "r1"
>
> inherit task
>
> @@ -31,5 +31,5 @@ RDEPENDS_${PN} = " \
> xfce4-settings \
> xfce-terminal \
> thunar \
> -#thunar-volman \
> +thunar-volman \
> "
Acked-by: Andreas Müller
By the way: what is the automated / correct workflow to
* apply a patch ( wget from patchwork & 'git am'? )
* generate 'acked by' / 'tested by' / .. messages
Andreas
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [meta-xfce] task-xfce-base: add thunar-volman
Op 1 sep. 2011, om 19:06 heeft Andreas Müller het volgende geschreven:
> On Thursday, September 01, 2011 09:44:51 AM you wrote:
>> This fixes:
>>
>> ERROR: There is a comment on line 34 of file
>> /OE/tentacle/sources/meta-openembedded/meta-xfce/recipes-xfce/tasks/task-x
>> fce-base.bb (#thunar-volman \) which is in the middle of a multiline
>> expression. Bitbake used to ignore these but no longer does so, please fix
>> your metadata as errors are likely as a result of this change.
>>
>> Signed-off-by: Koen Kooi
>> ---
>> meta-xfce/recipes-xfce/tasks/task-xfce-base.bb |4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
>> b/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb index 8a87203..7589f6d
>> 100644
>> --- a/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
>> +++ b/meta-xfce/recipes-xfce/tasks/task-xfce-base.bb
>> @@ -2,7 +2,7 @@ DESCRIPTION = "All packages required for a base
>> installation of XFCE" SECTION = "x11/wm"
>> LICENSE = "MIT"
>> LIC_FILES_CHKSUM =
>> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58" -PR =
>> "r0"
>> +PR = "r1"
>>
>> inherit task
>>
>> @@ -31,5 +31,5 @@ RDEPENDS_${PN} = " \
>> xfce4-settings \
>> xfce-terminal \
>> thunar \
>> -#thunar-volman \
>> +thunar-volman \
>> "
> Acked-by: Andreas Müller
>
> By the way: what is the automated / correct workflow to
>
> * apply a patch ( wget from patchwork & 'git am'? )
> * generate 'acked by' / 'tested by' / .. messages
What I do when applying a patch:
$ /OE/org.openembedded.dev/contrib/patchwork/pw-am.sh 10827
$ git show
$ git push
patchwork will have gathered all acked-by/signed-off-by from the followup
emails.
When replying to a patch I type up the acked-by stuff manually.
Not sure how correct and/or optimal this is, but this is how I do it :)
regards,
Koen
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
