Re: [oe] [PATCH] musicbrainz: Build with B=S

2014-03-08 Thread Tim Orling
I may have gone extra steps to get to the bottom of the build error, but my
solution is not even slightly pretty. If it works to just set $B=$S that is
simpler than my do_configure hack. Otherwise we'd have to look into a
change in cmake class which I doubt is justified--or further patch
libmusicbrainz.
KISS.

--Tim


On Wed, Mar 5, 2014 at 11:49 AM, Mike Looijmans mike.looijm...@topic.nlwrote:

 On 5-3-2014 19:08, Martin Jansa wrote:

 On Sat, Mar 01, 2014 at 06:54:47PM +0100, mike.looijm...@topic.nl wrote:

 From: Mike Looijmans milo-softw...@users.sourceforge.net

 This recipe doesn't work when B!=S, so force B=$S to fix the failure.

 Signed-off-by: Mike Looijmans milo-softw...@users.sourceforge.net

 What's the relation of this change to
 http://patchwork.openembedded.org/patch/67597/
 ?


 I suspect they both accomplish the same: Make the project compile again.
 Mine is the simplistic approach I guess - I did the least I could possible
 get away with... Theirs looks more like they actually understand what's
 going on

 Mike.



  ---
   .../musicbrainz/libmusicbrainz_git.bb  |3 +++
   1 file changed, 3 insertions(+)

 diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
 cbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
 cbrainz_git.bb
 index f6a8f53..4cc04b8 100644
 --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
 cbrainz_git.bb
 +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
 cbrainz_git.bb
 @@ -37,3 +37,6 @@ do_configure_prepend() {
 EXTRA_OECMAKE = -DLIB_INSTALL_DIR:PATH=${libdir} \
-DIMPORT_EXECUTABLES=build-native/ImportExecutables.
 cmake
 +
 +# out-of-tree building doesn't appear to work for this package.
 +B = ${S}
 --
 1.7.9.5

 ___
 Openembedded-devel mailing list
 Openembedded-devel@lists.openembedded.org
 http://lists.openembedded.org/mailman/listinfo/openembedded-devel



 --
 Mike Looijmans


 ___
 Openembedded-devel mailing list
 Openembedded-devel@lists.openembedded.org
 http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [PATCH] musicbrainz: Build with B=S

2014-03-05 Thread Martin Jansa
On Sat, Mar 01, 2014 at 06:54:47PM +0100, mike.looijm...@topic.nl wrote:
 From: Mike Looijmans milo-softw...@users.sourceforge.net
 
 This recipe doesn't work when B!=S, so force B=$S to fix the failure.
 
 Signed-off-by: Mike Looijmans milo-softw...@users.sourceforge.net

What's the relation of this change to
http://patchwork.openembedded.org/patch/67597/
?

 ---
  .../musicbrainz/libmusicbrainz_git.bb  |3 +++
  1 file changed, 3 insertions(+)
 
 diff --git 
 a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb 
 b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
 index f6a8f53..4cc04b8 100644
 --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
 +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
 @@ -37,3 +37,6 @@ do_configure_prepend() {
  
  EXTRA_OECMAKE = -DLIB_INSTALL_DIR:PATH=${libdir} \
   -DIMPORT_EXECUTABLES=build-native/ImportExecutables.cmake
 +
 +# out-of-tree building doesn't appear to work for this package.
 +B = ${S}
 -- 
 1.7.9.5
 
 ___
 Openembedded-devel mailing list
 Openembedded-devel@lists.openembedded.org
 http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com


signature.asc
Description: Digital signature
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel