Re: [oe] [PATCH] neon: add the recipe from oe-core

[Alexander Kanavin]

On 11/23/2017 02:06 PM, Martin Jansa wrote:

https://www.openembedded.org/wiki/Styleguide#Format_Guidelines


Alright. I resent the patch, as I don't want to start a style war, but 
(as discussed previously) I will resist any attempts to enforce 
indentation in oe-core. We need to prioritize what we spend our time on 
ruthlessly, considering the project is constantly under-staffed.


Alex
--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [PATCH] neon: add the recipe from oe-core

[Martin Jansa]

https://www.openembedded.org/wiki/Styleguide#Format_Guidelines

On Thu, Nov 23, 2017 at 10:46 AM, Alexander Kanavin <
alexander.kana...@linux.intel.com> wrote:

> On 11/22/2017 07:47 PM, Martin Jansa wrote:
>
>> +do_compile_append() {
>>> +   oe_runmake -C test
>>>
>>
>> Use 4 spaces for indentation instead of tabs.
>>
>
> Please explain why.
>
> Alex
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [PATCH] neon: add the recipe from oe-core

[Alexander Kanavin]

On 11/22/2017 07:47 PM, Martin Jansa wrote:

+do_compile_append() {
+   oe_runmake -C test


Use 4 spaces for indentation instead of tabs.


Please explain why.

Alex
--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [PATCH] neon: add the recipe from oe-core

[Martin Jansa]

On Wed, Nov 22, 2017 at 06:30:30PM +0200, Alexander Kanavin wrote:
> It is still required by libmusicbrainz, but is no longer needed
> by oe-core. Switch the upstream to debian as webdav.org is down.
> 
> Signed-off-by: Alexander Kanavin 
> ---
>  meta-oe/recipes-support/neon/neon/pkgconfig.patch | 15 +
>  meta-oe/recipes-support/neon/neon_0.30.2.bb   | 38 
> +++
>  2 files changed, 53 insertions(+)
>  create mode 100644 meta-oe/recipes-support/neon/neon/pkgconfig.patch
>  create mode 100644 meta-oe/recipes-support/neon/neon_0.30.2.bb
> 
> diff --git a/meta-oe/recipes-support/neon/neon/pkgconfig.patch 
> b/meta-oe/recipes-support/neon/neon/pkgconfig.patch
> new file mode 100644
> index 0..239dba8e2
> --- /dev/null
> +++ b/meta-oe/recipes-support/neon/neon/pkgconfig.patch
> @@ -0,0 +1,15 @@
> +Upstream-Status: Inappropriate [configuration]
> +
> +---
> + neon.pc.in |2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +--- neon-0.30.1.orig/neon.pc.in
>  neon-0.30.1/neon.pc.in
> +@@ -7,5 +7,5 @@ Name: neon
> + Description: HTTP/WebDAV client library
> + Version: @NEON_VERSION@
> + Libs: -L${libdir} -lneon @NEON_PC_LIBS@
> +-Libs.private: @NEON_LIBS@
> ++Libs.private: -L${libdir} -lz -lgcrypt -lgpg-error -lexpat -lgnutls
> + Cflags: -I${includedir}/neon @NEON_CFLAGS@
> diff --git a/meta-oe/recipes-support/neon/neon_0.30.2.bb 
> b/meta-oe/recipes-support/neon/neon_0.30.2.bb
> new file mode 100644
> index 0..12a2e0b37
> --- /dev/null
> +++ b/meta-oe/recipes-support/neon/neon_0.30.2.bb
> @@ -0,0 +1,38 @@
> +SUMMARY = "An HTTP and WebDAV client library with a C interface"
> +HOMEPAGE = "http://www.webdav.org/neon/;
> +SECTION = "libs"
> +LICENSE = "LGPLv2+"
> +LIC_FILES_CHKSUM = 
> "file://src/COPYING.LIB;md5=f30a9716ef3762e3467a2f62bf790f0a \
> +
> file://src/ne_utils.h;beginline=1;endline=20;md5=2caca609538eddaa6f6adf120a218037"
> +
> +SRC_URI = "${DEBIAN_MIRROR}/main/n/neon27/neon27_${PV}.orig.tar.gz \
> +   file://pkgconfig.patch \
> +  "
> +
> +SRC_URI[md5sum] = "e28d77bf14032d7f5046b3930704ef41"
> +SRC_URI[sha256sum] = 
> "db0bd8cdec329b48f53a6f00199c92d5ba40b0f015b153718d1b15d3d967fbca"
> +
> +inherit autotools binconfig-disabled lib_package pkgconfig
> +
> +# Enable gnutls or openssl, not both
> +PACKAGECONFIG ?= "expat gnutls libproxy webdav zlib"
> +PACKAGECONFIG_class-native = "expat gnutls webdav zlib"
> +
> +PACKAGECONFIG[expat] = "--with-expat,--without-expat,expat"
> +PACKAGECONFIG[gnutls] = "--with-ssl=gnutls,,gnutls"
> +PACKAGECONFIG[gssapi] = "--with-gssapi,--without-gssapi,krb5"
> +PACKAGECONFIG[libproxy] = "--with-libproxy,--without-libproxy,libproxy"
> +PACKAGECONFIG[libxml2] = "--with-libxml2,--without-libxml2,libxml2"
> +PACKAGECONFIG[openssl] = "--with-ssl=openssl,,openssl"
> +PACKAGECONFIG[webdav] = "--enable-webdav,--disable-webdav,"
> +PACKAGECONFIG[zlib] = "--with-zlib,--without-zlib,zlib"
> +
> +EXTRA_OECONF += "--enable-shared"
> +
> +do_compile_append() {
> + oe_runmake -C test

Use 4 spaces for indentation instead of tabs.

> +}
> +
> +BINCONFIG = "${bindir}/neon-config"
> +
> +BBCLASSEXTEND = "native"
> -- 
> 2.15.0
> 
> -- 
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com


signature.asc
Description: Digital signature
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel