Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On 11/14/19 9:20 AM, Leon Anavi wrote: > Add a recipe for surf, a simple web browser based on WebKit2/GTK+. shouldn't this go into the meta-webserver layer ? > > Signed-off-by: Leon Anavi > --- > .../0001-config.mk-Fix-compiler-and-linker.patch | 36 > ++ > meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 ++ > 2 files changed, 66 insertions(+) > create mode 100644 > meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb > > diff --git > a/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > new file mode 100644 > index 000..a3e33ea > --- /dev/null > +++ > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > @@ -0,0 +1,36 @@ > +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 00:00:00 2001 > +From: Leon Anavi > +Date: Thu, 14 Nov 2019 14:28:39 + > +Subject: [PATCH] config.mk: Fix compiler and linker > + > +Do not set explicitly compiler and linker. > + > +Signed-off-by: Leon Anavi > +--- > + config.mk | 6 +++--- > + 1 file changed, 3 insertions(+), 3 deletions(-) > + > +diff --git a/config.mk b/config.mk > +index df6e812..bf07406 100644 > +--- a/config.mk > b/config.mk > +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 webkit2gtk-4.0` > + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0` > + > + # includes and libs > +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC} > +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0 > ++INCS = ${GTKINC} > ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0 > + > + # flags > + CPPFLAGS = -DVERSION=\"${VERSION}\" -DWEBEXTDIR=\"${LIBPREFIX}\" > -D_DEFAULT_SOURCE > +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS} > + #LDFLAGS = ${LIBS} > + > + # compiler and linker > +-CC = cc > ++#CC = cc > +-- > +2.7.4 > + > diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb > b/meta-oe/recipes-graphics/surf/surf_2.0.bb > new file mode 100644 > index 000..98d3b23 > --- /dev/null > +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb > @@ -0,0 +1,30 @@ > +SUMMARY = "Simple web browser" > +DESCRIPTION = "Simple open source web browser based on WebKit2/GTK" > +HOMEPAGE = "https://surf.suckless.org/"; > +SECTION = "x11/graphics" > +LICENSE = "MIT" > +LIC_FILES_CHKSUM = "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa" > + > +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" > + > +REQUIRED_DISTRO_FEATURES = "x11" > + > +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \ > + file://0001-config.mk-Fix-compiler-and-linker.patch \ > +" > +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65" > + > +S = "${WORKDIR}/git" > + > +inherit pkgconfig > + > +TARGET_CC_ARCH += "${LDFLAGS}" > + > +do_install () { > + install -d ${D}${bindir} > + install -m 0644 ${S}/surf ${D}${bindir} > + chmod +x ${D}${bindir}/surf > +} > + > +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > +INHIBIT_PACKAGE_STRIP = "1" -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On Thu, Nov 14, 2019 at 10:53 AM akuster808 wrote: > > > > On 11/14/19 9:20 AM, Leon Anavi wrote: > > Add a recipe for surf, a simple web browser based on WebKit2/GTK+. > > shouldn't this go into the meta-webserver layer ? perhaps but its the browser > > > > Signed-off-by: Leon Anavi > > --- > > .../0001-config.mk-Fix-compiler-and-linker.patch | 36 > > ++ > > meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 ++ > > 2 files changed, 66 insertions(+) > > create mode 100644 > > meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb > > > > diff --git > > a/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > > > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > new file mode 100644 > > index 000..a3e33ea > > --- /dev/null > > +++ > > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > @@ -0,0 +1,36 @@ > > +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 00:00:00 2001 > > +From: Leon Anavi > > +Date: Thu, 14 Nov 2019 14:28:39 + > > +Subject: [PATCH] config.mk: Fix compiler and linker > > + > > +Do not set explicitly compiler and linker. > > + > > +Signed-off-by: Leon Anavi > > +--- > > + config.mk | 6 +++--- > > + 1 file changed, 3 insertions(+), 3 deletions(-) > > + > > +diff --git a/config.mk b/config.mk > > +index df6e812..bf07406 100644 > > +--- a/config.mk > > b/config.mk > > +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 webkit2gtk-4.0` > > + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0` > > + > > + # includes and libs > > +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC} > > +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0 > > ++INCS = ${GTKINC} > > ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0 > > + > > + # flags > > + CPPFLAGS = -DVERSION=\"${VERSION}\" -DWEBEXTDIR=\"${LIBPREFIX}\" > > -D_DEFAULT_SOURCE > > +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS} > > + #LDFLAGS = ${LIBS} > > + > > + # compiler and linker > > +-CC = cc > > ++#CC = cc > > +-- > > +2.7.4 > > + > > diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb > > b/meta-oe/recipes-graphics/surf/surf_2.0.bb > > new file mode 100644 > > index 000..98d3b23 > > --- /dev/null > > +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb > > @@ -0,0 +1,30 @@ > > +SUMMARY = "Simple web browser" > > +DESCRIPTION = "Simple open source web browser based on WebKit2/GTK" > > +HOMEPAGE = "https://surf.suckless.org/"; > > +SECTION = "x11/graphics" > > +LICENSE = "MIT" > > +LIC_FILES_CHKSUM = "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa" > > + > > +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" > > + > > +REQUIRED_DISTRO_FEATURES = "x11" > > + > > +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \ > > + file://0001-config.mk-Fix-compiler-and-linker.patch \ > > +" > > +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65" > > + > > +S = "${WORKDIR}/git" > > + > > +inherit pkgconfig > > + > > +TARGET_CC_ARCH += "${LDFLAGS}" > > + > > +do_install () { > > + install -d ${D}${bindir} > > + install -m 0644 ${S}/surf ${D}${bindir} > > + chmod +x ${D}${bindir}/surf > > +} > > + > > +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > > +INHIBIT_PACKAGE_STRIP = "1" > > -- > ___ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
Hi Armin, Khem, On 14.11.19 г. 21:10 ч., Khem Raj wrote: On Thu, Nov 14, 2019 at 10:53 AM akuster808 wrote: On 11/14/19 9:20 AM, Leon Anavi wrote: Add a recipe for surf, a simple web browser based on WebKit2/GTK+. shouldn't this go into the meta-webserver layer ? perhaps but its the browser I will be happy to move it to a more appropriate location. Where should this recipe go? I have been thinking a lot before submitting the patch and I decided to add it to recipes-graphics and set SECTION to "x11/graphics" because it is a web browser with GUI. The other web browser, links, is in meta-oe/recipes-support. Best regards, Leon Signed-off-by: Leon Anavi --- .../0001-config.mk-Fix-compiler-and-linker.patch | 36 ++ meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 ++ 2 files changed, 66 insertions(+) create mode 100644 meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb diff --git a/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch new file mode 100644 index 000..a3e33ea --- /dev/null +++ b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch @@ -0,0 +1,36 @@ +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 00:00:00 2001 +From: Leon Anavi +Date: Thu, 14 Nov 2019 14:28:39 + +Subject: [PATCH] config.mk: Fix compiler and linker + +Do not set explicitly compiler and linker. + +Signed-off-by: Leon Anavi +--- + config.mk | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/config.mk b/config.mk +index df6e812..bf07406 100644 +--- a/config.mk b/config.mk +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 webkit2gtk-4.0` + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0` + + # includes and libs +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC} +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0 ++INCS = ${GTKINC} ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0 + + # flags + CPPFLAGS = -DVERSION=\"${VERSION}\" -DWEBEXTDIR=\"${LIBPREFIX}\" -D_DEFAULT_SOURCE +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS} + #LDFLAGS = ${LIBS} + + # compiler and linker +-CC = cc ++#CC = cc +-- +2.7.4 + diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb b/meta-oe/recipes-graphics/surf/surf_2.0.bb new file mode 100644 index 000..98d3b23 --- /dev/null +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb @@ -0,0 +1,30 @@ +SUMMARY = "Simple web browser" +DESCRIPTION = "Simple open source web browser based on WebKit2/GTK" +HOMEPAGE = "https://surf.suckless.org/"; +SECTION = "x11/graphics" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa" + +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" + +REQUIRED_DISTRO_FEATURES = "x11" + +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \ + file://0001-config.mk-Fix-compiler-and-linker.patch \ +" +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65" + +S = "${WORKDIR}/git" + +inherit pkgconfig + +TARGET_CC_ARCH += "${LDFLAGS}" + +do_install () { + install -d ${D}${bindir} + install -m 0644 ${S}/surf ${D}${bindir} + chmod +x ${D}${bindir}/surf +} + +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" +INHIBIT_PACKAGE_STRIP = "1" -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Leon Anavi Software Engineer konsulko.com -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On 11/14/19 11:10 AM, Khem Raj wrote: > On Thu, Nov 14, 2019 at 10:53 AM akuster808 wrote: >> >> >> On 11/14/19 9:20 AM, Leon Anavi wrote: >>> Add a recipe for surf, a simple web browser based on WebKit2/GTK+. >> shouldn't this go into the meta-webserver layer ? > perhaps but its the browser hehe, your right.. > >>> Signed-off-by: Leon Anavi >>> --- >>> .../0001-config.mk-Fix-compiler-and-linker.patch | 36 >>> ++ >>> meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 ++ >>> 2 files changed, 66 insertions(+) >>> create mode 100644 >>> meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch >>> create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb >>> >>> diff --git >>> a/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch >>> >>> b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch >>> new file mode 100644 >>> index 000..a3e33ea >>> --- /dev/null >>> +++ >>> b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch >>> @@ -0,0 +1,36 @@ >>> +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 00:00:00 2001 >>> +From: Leon Anavi >>> +Date: Thu, 14 Nov 2019 14:28:39 + >>> +Subject: [PATCH] config.mk: Fix compiler and linker >>> + >>> +Do not set explicitly compiler and linker. >>> + >>> +Signed-off-by: Leon Anavi >>> +--- >>> + config.mk | 6 +++--- >>> + 1 file changed, 3 insertions(+), 3 deletions(-) >>> + >>> +diff --git a/config.mk b/config.mk >>> +index df6e812..bf07406 100644 >>> +--- a/config.mk >>> b/config.mk >>> +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 webkit2gtk-4.0` >>> + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0` >>> + >>> + # includes and libs >>> +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC} >>> +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0 >>> ++INCS = ${GTKINC} >>> ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0 >>> + >>> + # flags >>> + CPPFLAGS = -DVERSION=\"${VERSION}\" -DWEBEXTDIR=\"${LIBPREFIX}\" >>> -D_DEFAULT_SOURCE >>> +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS} >>> + #LDFLAGS = ${LIBS} >>> + >>> + # compiler and linker >>> +-CC = cc >>> ++#CC = cc >>> +-- >>> +2.7.4 >>> + >>> diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb >>> b/meta-oe/recipes-graphics/surf/surf_2.0.bb >>> new file mode 100644 >>> index 000..98d3b23 >>> --- /dev/null >>> +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb >>> @@ -0,0 +1,30 @@ >>> +SUMMARY = "Simple web browser" >>> +DESCRIPTION = "Simple open source web browser based on WebKit2/GTK" >>> +HOMEPAGE = "https://surf.suckless.org/"; >>> +SECTION = "x11/graphics" >>> +LICENSE = "MIT" >>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa" >>> + >>> +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" >>> + >>> +REQUIRED_DISTRO_FEATURES = "x11" >>> + >>> +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \ >>> + file://0001-config.mk-Fix-compiler-and-linker.patch \ >>> +" >>> +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65" >>> + >>> +S = "${WORKDIR}/git" >>> + >>> +inherit pkgconfig >>> + >>> +TARGET_CC_ARCH += "${LDFLAGS}" >>> + >>> +do_install () { >>> + install -d ${D}${bindir} >>> + install -m 0644 ${S}/surf ${D}${bindir} >>> + chmod +x ${D}${bindir}/surf >>> +} >>> + >>> +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" >>> +INHIBIT_PACKAGE_STRIP = "1" >> -- >> ___ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On Thu, Nov 14, 2019 at 10:04 AM Leon Anavi wrote: > > Add a recipe for surf, a simple web browser based on WebKit2/GTK+. > > Signed-off-by: Leon Anavi > --- > .../0001-config.mk-Fix-compiler-and-linker.patch | 36 > ++ > meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 ++ > 2 files changed, 66 insertions(+) > create mode 100644 > meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb > > diff --git > a/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > new file mode 100644 > index 000..a3e33ea > --- /dev/null > +++ > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > @@ -0,0 +1,36 @@ > +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 00:00:00 2001 > +From: Leon Anavi > +Date: Thu, 14 Nov 2019 14:28:39 + > +Subject: [PATCH] config.mk: Fix compiler and linker > + > +Do not set explicitly compiler and linker. > + > +Signed-off-by: Leon Anavi > +--- > + config.mk | 6 +++--- > + 1 file changed, 3 insertions(+), 3 deletions(-) > + > +diff --git a/config.mk b/config.mk > +index df6e812..bf07406 100644 > +--- a/config.mk > b/config.mk > +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 webkit2gtk-4.0` > + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0` > + > + # includes and libs > +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC} > +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0 > ++INCS = ${GTKINC} > ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0 > + > + # flags > + CPPFLAGS = -DVERSION=\"${VERSION}\" -DWEBEXTDIR=\"${LIBPREFIX}\" > -D_DEFAULT_SOURCE > +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS} > + #LDFLAGS = ${LIBS} > + > + # compiler and linker > +-CC = cc > ++#CC = cc > +-- > +2.7.4 > + > diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb > b/meta-oe/recipes-graphics/surf/surf_2.0.bb > new file mode 100644 > index 000..98d3b23 > --- /dev/null > +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb > @@ -0,0 +1,30 @@ > +SUMMARY = "Simple web browser" > +DESCRIPTION = "Simple open source web browser based on WebKit2/GTK" > +HOMEPAGE = "https://surf.suckless.org/"; > +SECTION = "x11/graphics" > +LICENSE = "MIT" > +LIC_FILES_CHKSUM = "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa" > + > +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" > + seems to have sstate issues in do_install see http://jenkins.nas-admin.org/job/oe_world_workspace-compare-signatures/846/console perhaps due to ./meta/recipes-graphics/x11-common/xserver-nodm-init_3.0.bb being in depends and this recipe is pinned per MACHINE via PACKAGE_ARCH = "${MACHINE_ARCH}" > +REQUIRED_DISTRO_FEATURES = "x11" > + > +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \ > + file://0001-config.mk-Fix-compiler-and-linker.patch \ > +" > +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65" > + > +S = "${WORKDIR}/git" > + > +inherit pkgconfig > + > +TARGET_CC_ARCH += "${LDFLAGS}" > + > +do_install () { > + install -d ${D}${bindir} > + install -m 0644 ${S}/surf ${D}${bindir} > + chmod +x ${D}${bindir}/surf > +} > + > +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > +INHIBIT_PACKAGE_STRIP = "1" > -- > 2.7.4 > > -- > ___ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
REQUIRED_DISTRO_FEATURES = "x11" doesn't do anything unless you inherit the distro_features_check.bbclass which I don't see in the recipe. On Thu, Nov 14, 2019 at 11:34 PM Khem Raj wrote: > On Thu, Nov 14, 2019 at 10:04 AM Leon Anavi > wrote: > > > > Add a recipe for surf, a simple web browser based on WebKit2/GTK+. > > > > Signed-off-by: Leon Anavi > > --- > > .../0001-config.mk-Fix-compiler-and-linker.patch | 36 > ++ > > meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 > ++ > > 2 files changed, 66 insertions(+) > > create mode 100644 > meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb > > > > diff --git > a/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > new file mode 100644 > > index 000..a3e33ea > > --- /dev/null > > +++ > b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > @@ -0,0 +1,36 @@ > > +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 00:00:00 2001 > > +From: Leon Anavi > > +Date: Thu, 14 Nov 2019 14:28:39 + > > +Subject: [PATCH] config.mk: Fix compiler and linker > > + > > +Do not set explicitly compiler and linker. > > + > > +Signed-off-by: Leon Anavi > > +--- > > + config.mk | 6 +++--- > > + 1 file changed, 3 insertions(+), 3 deletions(-) > > + > > +diff --git a/config.mk b/config.mk > > +index df6e812..bf07406 100644 > > +--- a/config.mk > > b/config.mk > > +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 webkit2gtk-4.0` > > + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0` > > + > > + # includes and libs > > +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC} > > +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0 > > ++INCS = ${GTKINC} > > ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0 > > + > > + # flags > > + CPPFLAGS = -DVERSION=\"${VERSION}\" -DWEBEXTDIR=\"${LIBPREFIX}\" > -D_DEFAULT_SOURCE > > +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS} > > + #LDFLAGS = ${LIBS} > > + > > + # compiler and linker > > +-CC = cc > > ++#CC = cc > > +-- > > +2.7.4 > > + > > diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb > b/meta-oe/recipes-graphics/surf/surf_2.0.bb > > new file mode 100644 > > index 000..98d3b23 > > --- /dev/null > > +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb > > @@ -0,0 +1,30 @@ > > +SUMMARY = "Simple web browser" > > +DESCRIPTION = "Simple open source web browser based on WebKit2/GTK" > > +HOMEPAGE = "https://surf.suckless.org/"; > > +SECTION = "x11/graphics" > > +LICENSE = "MIT" > > +LIC_FILES_CHKSUM = "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa" > > + > > +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" > > + > > seems to have sstate issues in do_install see > > http://jenkins.nas-admin.org/job/oe_world_workspace-compare-signatures/846/console > > perhaps due to ./meta/recipes-graphics/x11-common/xserver-nodm-init_3.0.bb > being in depends and > this recipe is pinned per MACHINE via PACKAGE_ARCH = "${MACHINE_ARCH}" > > > > +REQUIRED_DISTRO_FEATURES = "x11" > > + > > +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \ > > + file://0001-config.mk-Fix-compiler-and-linker.patch \ > > +" > > +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65" > > + > > +S = "${WORKDIR}/git" > > + > > +inherit pkgconfig > > + > > +TARGET_CC_ARCH += "${LDFLAGS}" > > + > > +do_install () { > > + install -d ${D}${bindir} > > + install -m 0644 ${S}/surf ${D}${bindir} > > + chmod +x ${D}${bindir}/surf > > +} > > + > > +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > > +INHIBIT_PACKAGE_STRIP = "1" > > -- > > 2.7.4 > > > > -- > > ___ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- > ___ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On 14/11/2019 17:20, Leon Anavi wrote: +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" Are you sure it *build* depends on the X init scripts? +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" +INHIBIT_PACKAGE_STRIP = "1" Why? Ross -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
Hi Ross, Martin, Khem, Thanks you for the feedback and for helping me. I've just submitted an updated version of the patch for a review. Now the recipe inherits distro_features_check. On 15.11.19 г. 1:22 ч., Ross Burton wrote: On 14/11/2019 17:20, Leon Anavi wrote: +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" Are you sure it *build* depends on the X init scripts? No, sorry, xserver-nodm-init is not a build dependency. I've removed it from the new version of the patch. +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" +INHIBIT_PACKAGE_STRIP = "1" Why? These two lines prevent already-stripped QA errors. I have tested the recipe on QEMU and Raspberry Pi 4. Thanks, Leon Ross -- Leon Anavi Software Engineer konsulko.com -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On Fri, Nov 15, 2019 at 5:30 AM Leon Anavi wrote: > Hi Ross, Martin, Khem, > > Thanks you for the feedback and for helping me. I've just submitted an > updated version of the patch for a review. Now the recipe inherits > distro_features_check. > > On 15.11.19 г. 1:22 ч., Ross Burton wrote: > > On 14/11/2019 17:20, Leon Anavi wrote: > >> +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" > > > > Are you sure it *build* depends on the X init scripts? > > > No, sorry, xserver-nodm-init is not a build dependency. I've removed it > from the new version of the patch. > >> +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > >> +INHIBIT_PACKAGE_STRIP = "1" > > > > Why? > These two lines prevent already-stripped QA errors. > At least we don’t want debug splitting to be disabled What errors do you see with this Enabled > I have tested the recipe on QEMU and Raspberry Pi 4. > > Thanks, Leon > > > > Ross > > > -- > Leon Anavi > Software Engineer > konsulko.com > > -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
meta-browser would be more appropriate. On 14.11.19 19:52, akuster808 wrote: On 11/14/19 9:20 AM, Leon Anavi wrote: Add a recipe for surf, a simple web browser based on WebKit2/GTK+. shouldn't this go into the meta-webserver layer ? Signed-off-by: Leon Anavi --- .../0001-config.mk-Fix-compiler-and-linker.patch | 36 ++ meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 ++ 2 files changed, 66 insertions(+) create mode 100644 meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb diff --git a/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch new file mode 100644 index 000..a3e33ea --- /dev/null +++ b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch @@ -0,0 +1,36 @@ +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 00:00:00 2001 +From: Leon Anavi +Date: Thu, 14 Nov 2019 14:28:39 + +Subject: [PATCH] config.mk: Fix compiler and linker + +Do not set explicitly compiler and linker. + +Signed-off-by: Leon Anavi +--- + config.mk | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/config.mk b/config.mk +index df6e812..bf07406 100644 +--- a/config.mk b/config.mk +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 webkit2gtk-4.0` + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0` + + # includes and libs +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC} +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0 ++INCS = ${GTKINC} ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0 + + # flags + CPPFLAGS = -DVERSION=\"${VERSION}\" -DWEBEXTDIR=\"${LIBPREFIX}\" -D_DEFAULT_SOURCE +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS} + #LDFLAGS = ${LIBS} + + # compiler and linker +-CC = cc ++#CC = cc +-- +2.7.4 + diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb b/meta-oe/recipes-graphics/surf/surf_2.0.bb new file mode 100644 index 000..98d3b23 --- /dev/null +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb @@ -0,0 +1,30 @@ +SUMMARY = "Simple web browser" +DESCRIPTION = "Simple open source web browser based on WebKit2/GTK" +HOMEPAGE = "https://surf.suckless.org/"; +SECTION = "x11/graphics" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa" + +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" + +REQUIRED_DISTRO_FEATURES = "x11" + +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \ + file://0001-config.mk-Fix-compiler-and-linker.patch \ +" +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65" + +S = "${WORKDIR}/git" + +inherit pkgconfig + +TARGET_CC_ARCH += "${LDFLAGS}" + +do_install () { + install -d ${D}${bindir} + install -m 0644 ${S}/surf ${D}${bindir} + chmod +x ${D}${bindir}/surf +} + +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" +INHIBIT_PACKAGE_STRIP = "1" -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On Fri, 2019-11-15 at 16:09 +0100, Carlos Rafael Giani wrote: > meta-browser would be more appropriate. I was contemplating that as well. but these layer has more chromium and firefox lineage > > On 14.11.19 19:52, akuster808 wrote: > > On 11/14/19 9:20 AM, Leon Anavi wrote: > > > Add a recipe for surf, a simple web browser based on > > > WebKit2/GTK+. > > shouldn't this go into the meta-webserver layer ? > > > Signed-off-by: Leon Anavi > > > --- > > > .../0001-config.mk-Fix-compiler-and-linker.patch | 36 > > > ++ > > > meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 > > > ++ > > > 2 files changed, 66 insertions(+) > > > create mode 100644 meta-oe/recipes-graphics/surf/surf/0001- > > > config.mk-Fix-compiler-and-linker.patch > > > create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb > > > > > > diff --git a/meta-oe/recipes-graphics/surf/surf/0001-config.mk- > > > Fix-compiler-and-linker.patch b/meta-oe/recipes- > > > graphics/surf/surf/0001-config.mk-Fix-compiler-and-linker.patch > > > new file mode 100644 > > > index 000..a3e33ea > > > --- /dev/null > > > +++ b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix- > > > compiler-and-linker.patch > > > @@ -0,0 +1,36 @@ > > > +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 > > > 00:00:00 2001 > > > +From: Leon Anavi > > > +Date: Thu, 14 Nov 2019 14:28:39 + > > > +Subject: [PATCH] config.mk: Fix compiler and linker > > > + > > > +Do not set explicitly compiler and linker. > > > + > > > +Signed-off-by: Leon Anavi > > > +--- > > > + config.mk | 6 +++--- > > > + 1 file changed, 3 insertions(+), 3 deletions(-) > > > + > > > +diff --git a/config.mk b/config.mk > > > +index df6e812..bf07406 100644 > > > +--- a/config.mk > > > b/config.mk > > > +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 > > > webkit2gtk-4.0` > > > + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0` > > > + > > > + # includes and libs > > > +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC} > > > +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0 > > > ++INCS = ${GTKINC} > > > ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0 > > > + > > > + # flags > > > + CPPFLAGS = -DVERSION=\"${VERSION}\" > > > -DWEBEXTDIR=\"${LIBPREFIX}\" -D_DEFAULT_SOURCE > > > +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS} > > > + #LDFLAGS = ${LIBS} > > > + > > > + # compiler and linker > > > +-CC = cc > > > ++#CC = cc > > > +-- > > > +2.7.4 > > > + > > > diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb b/meta- > > > oe/recipes-graphics/surf/surf_2.0.bb > > > new file mode 100644 > > > index 000..98d3b23 > > > --- /dev/null > > > +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb > > > @@ -0,0 +1,30 @@ > > > +SUMMARY = "Simple web browser" > > > +DESCRIPTION = "Simple open source web browser based on > > > WebKit2/GTK" > > > +HOMEPAGE = "https://surf.suckless.org/"; > > > +SECTION = "x11/graphics" > > > +LICENSE = "MIT" > > > +LIC_FILES_CHKSUM = > > > "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa" > > > + > > > +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" > > > + > > > +REQUIRED_DISTRO_FEATURES = "x11" > > > + > > > +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \ > > > + file://0001-config.mk-Fix-compiler-and-linker.patch \ > > > +" > > > +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65" > > > + > > > +S = "${WORKDIR}/git" > > > + > > > +inherit pkgconfig > > > + > > > +TARGET_CC_ARCH += "${LDFLAGS}" > > > + > > > +do_install () { > > > + install -d ${D}${bindir} > > > + install -m 0644 ${S}/surf ${D}${bindir} > > > + chmod +x ${D}${bindir}/surf > > > +} > > > + > > > +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > > > +INHIBIT_PACKAGE_STRIP = "1" -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On 15/11/2019 17:30, Khem Raj wrote: On Fri, 2019-11-15 at 16:09 +0100, Carlos Rafael Giani wrote: meta-browser would be more appropriate. I was contemplating that as well. but these layer has more chromium and firefox lineage But it's called meta-browser and not meta-firefox-and-chromium. :) Ross -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On 15/11/2019 13:30, Leon Anavi wrote: +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" +INHIBIT_PACKAGE_STRIP = "1" Why? These two lines prevent already-stripped QA errors. The correct fix is to stop the recipe from forcibly stripping, or tell it to include debug information in the first place. The default CFLAGS includes -g so the problem is normally the former unless CFLAGS is not being respected. Ross -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
On Fri, Nov 15, 2019 at 11:25 AM Ross Burton wrote: > > On 15/11/2019 17:30, Khem Raj wrote: > > On Fri, 2019-11-15 at 16:09 +0100, Carlos Rafael Giani wrote: > >> meta-browser would be more appropriate. > > > > I was contemplating that as well. but these layer has more chromium and > > firefox lineage > > But it's called meta-browser and not meta-firefox-and-chromium. :) > certainly, worth proposing there. > Ross > -- > ___ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-oe][PATCH] surf: Add simple web browser
Hi Khem, Ross, On 15.11.19 г. 22:49 ч., Khem Raj wrote: On Fri, Nov 15, 2019 at 11:25 AM Ross Burton wrote: On 15/11/2019 17:30, Khem Raj wrote: On Fri, 2019-11-15 at 16:09 +0100, Carlos Rafael Giani wrote: meta-browser would be more appropriate. I was contemplating that as well. but these layer has more chromium and firefox lineage But it's called meta-browser and not meta-firefox-and-chromium. :) certainly, worth proposing there. Layer meta-browser was on my radar before submitting the patch to meta-oe. I also thought that this layer is more about chromium and firefox. Links, another lightweight browser, is in meta-oe. In the mean time I've fixed the configurations so that surf recipe doesn't need INHIBIT_PACKAGE_DEBUG_SPLIT or INHIBIT_PACKAGE_STRIP anymore. Best regards, Leon Ross -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Leon Anavi Software Engineer konsulko.com -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel